)]}'
{"lib/cinder":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ecab609c5f0c91d5410f035db3f1af7009710349","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    if is_service_enabled c-vol \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":241,"context_line":"        local enabled_backends\u003d\"\""},{"line_number":242,"context_line":"        local default_type\u003d\"\""},{"line_number":243,"context_line":"        local be BE_NAME BE_TYPE"},{"line_number":244,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":245,"context_line":"            BE_TYPE\u003d${be%%:*}"},{"line_number":246,"context_line":"            BE_NAME\u003d${be##*:}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_08e97eaa","line":243,"updated":"2014-07-28 22:24:47.000000000","message":"why was everything else made lower-case but these two?","commit_id":"b3297256d7d3003a7e3a436fdfd0f58a52f48ec9"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"06cae2448c2a92ca9ec718577fa86786e76da1c4","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    if is_service_enabled c-vol \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":241,"context_line":"        local enabled_backends\u003d\"\""},{"line_number":242,"context_line":"        local default_type\u003d\"\""},{"line_number":243,"context_line":"        local be BE_NAME BE_TYPE"},{"line_number":244,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":245,"context_line":"            BE_TYPE\u003d${be%%:*}"},{"line_number":246,"context_line":"            BE_NAME\u003d${be##*:}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_5bfa5e77","line":243,"in_reply_to":"baada198_08e97eaa","updated":"2014-07-28 22:56:33.000000000","message":"uh, dang good question...I am going to say, uh, they are defined near the top of lib/cinder outside of a function so they can not be made local although declaring them local here masks the global values...uh, yeah.","commit_id":"b3297256d7d3003a7e3a436fdfd0f58a52f48ec9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"518009fc0c650a1f8be7f4f635ad1271a7d4f357","unresolved":false,"context_lines":[{"line_number":96,"context_line":"# Source the enabled backends"},{"line_number":97,"context_line":"if is_service_enabled c-vol \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":98,"context_line":"    for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":99,"context_line":"        be_type\u003d${be%%:*}"},{"line_number":100,"context_line":"        be_name\u003d${be##*:}"},{"line_number":101,"context_line":"        if [[ -r $CINDER_BACKENDS/${be_type} ]]; then"},{"line_number":102,"context_line":"            source $CINDER_BACKENDS/${be_type}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"baada198_821589e7","line":99,"updated":"2014-08-04 13:02:12.000000000","message":"these are properly global, so they should probably remain UPPER_CASE","commit_id":"247f82ca937e99cba24130f1865e587ce6142054"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"252a5f52f00842b0eb46e3be3fc68f70d4fa1c17","unresolved":false,"context_lines":[{"line_number":96,"context_line":"# Source the enabled backends"},{"line_number":97,"context_line":"if is_service_enabled c-vol \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":98,"context_line":"    for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":99,"context_line":"        be_type\u003d${be%%:*}"},{"line_number":100,"context_line":"        be_name\u003d${be##*:}"},{"line_number":101,"context_line":"        if [[ -r $CINDER_BACKENDS/${be_type} ]]; then"},{"line_number":102,"context_line":"            source $CINDER_BACKENDS/${be_type}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"baada198_4490abf3","line":99,"in_reply_to":"baada198_821589e7","updated":"2014-08-05 15:58:40.000000000","message":"They are global simply because they are used here outside of a function. Each use of this code pattern is intended for these vars to be considered local.  How about I throw in an unset here to reinforce the idea they are not meant to be referenced outside this loop?","commit_id":"247f82ca937e99cba24130f1865e587ce6142054"}]}