)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1d2e8cfeafc08e9cf8b2b52dc0e86625e2f08746","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omri Marcovitch \u003comrim@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-28 19:15:54 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support to Devstack to run with ML2 SR-IOV NIC Switch MD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following variables should be set in Devstack local.conf configuration file:"},{"line_number":10,"context_line":"        Q_PLUGIN\u003dml2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_d059d2fe","line":7,"updated":"2014-07-29 12:41:20.000000000","message":"Actually, you  add also support for agent","commit_id":"7e90722b4db12804f789e8089bd791acf7ef3f07"}],"lib/neutron_plugins/sriovnicswitch_agent":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1d2e8cfeafc08e9cf8b2b52dc0e86625e2f08746","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Neutron Mellanox agent"},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Save trace setting"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_10bd0a04","line":1,"updated":"2014-07-29 12:41:20.000000000","message":"It is not Mellanox Agent","commit_id":"7e90722b4db12804f789e8089bd791acf7ef3f07"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d17b25cdda51797a02f67cd8bb15edf7324cde63","unresolved":false,"context_lines":[{"line_number":10,"context_line":"}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"function neutron_plugin_configure_plugin_agent() {"},{"line_number":13,"context_line":"    if [[ -z \"$PHYSICAL_INTERFACE_MAPPINGS\" ]] \u0026\u0026 [[ -n \"$PHYSICAL_NETWORK\" ]] \u0026\u0026 [[ -n \"$PHYSICAL_INTERFACE\" ]]; then"},{"line_number":14,"context_line":"        PHYSICAL_INTERFACE_MAPPINGS\u003d$PHYSICAL_NETWORK:$PHYSICAL_INTERFACE"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"    if [[ -n \"$PHYSICAL_INTERFACE_MAPPINGS\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_088a5ebb","line":13,"updated":"2014-07-28 22:36:43.000000000","message":"some \u0027\\\u0027s would make more readable","commit_id":"7e90722b4db12804f789e8089bd791acf7ef3f07"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d17b25cdda51797a02f67cd8bb15edf7324cde63","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        PHYSICAL_INTERFACE_MAPPINGS\u003d$PHYSICAL_NETWORK:$PHYSICAL_INTERFACE"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"    if [[ -n \"$PHYSICAL_INTERFACE_MAPPINGS\" ]]; then"},{"line_number":17,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE sriov_nic physical_device_mappings $PHYSICAL_INTERFACE_MAPPINGS"},{"line_number":18,"context_line":"    fi"},{"line_number":19,"context_line":"    AGENT_BINARY\u003d\"$NEUTRON_BIN_DIR/neutron-mlnx-agent\""},{"line_number":20,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE agent rpc True"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_481b767f","line":17,"updated":"2014-07-28 22:36:43.000000000","message":"PHYSICAL_INTERFACE_MAPPINGS should be name-spaced?  it\u0027s only for this plugin?","commit_id":"7e90722b4db12804f789e8089bd791acf7ef3f07"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1d2e8cfeafc08e9cf8b2b52dc0e86625e2f08746","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    if [[ -n \"$PHYSICAL_INTERFACE_MAPPINGS\" ]]; then"},{"line_number":17,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE sriov_nic physical_device_mappings $PHYSICAL_INTERFACE_MAPPINGS"},{"line_number":18,"context_line":"    fi"},{"line_number":19,"context_line":"    AGENT_BINARY\u003d\"$NEUTRON_BIN_DIR/neutron-mlnx-agent\""},{"line_number":20,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE agent rpc True"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_7033a6c4","line":19,"updated":"2014-07-29 12:41:20.000000000","message":"Why this is mellanox agent?","commit_id":"7e90722b4db12804f789e8089bd791acf7ef3f07"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d17b25cdda51797a02f67cd8bb15edf7324cde63","unresolved":false,"context_lines":[{"line_number":23,"context_line":"function neutron_plugin_create_nova_conf() {"},{"line_number":24,"context_line":"    NOVA_VIF_DRIVER\u003d${NOVA_VIF_DRIVER:-\"nova.virt.libvirt.vif.LibvirtGenericVIFDriver\"}"},{"line_number":25,"context_line":"    iniset $NOVA_CONF DEFAULT security_group_api nova"},{"line_number":26,"context_line":"    iniset $NOVA_CONF DEFAULT pci_passthrough_whitelist $PCI_PASSTHROUGH_WHITELIST "},{"line_number":27,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE ml2_sriov agent_required True  "},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_4898d61a","line":26,"updated":"2014-07-28 22:36:43.000000000","message":"shouldn\u0027t this have a default value other than blank?\n\nalso, variables should be name-spaced?  they look pretty generic","commit_id":"7e90722b4db12804f789e8089bd791acf7ef3f07"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d17b25cdda51797a02f67cd8bb15edf7324cde63","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    NOVA_VIF_DRIVER\u003d${NOVA_VIF_DRIVER:-\"nova.virt.libvirt.vif.LibvirtGenericVIFDriver\"}"},{"line_number":25,"context_line":"    iniset $NOVA_CONF DEFAULT security_group_api nova"},{"line_number":26,"context_line":"    iniset $NOVA_CONF DEFAULT pci_passthrough_whitelist $PCI_PASSTHROUGH_WHITELIST "},{"line_number":27,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE ml2_sriov agent_required True  "},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"function neutron_plugin_configure_dhcp_agent() {"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_e88e0ad0","line":27,"updated":"2014-07-28 22:36:43.000000000","message":"please cleanup trailing whitespace","commit_id":"7e90722b4db12804f789e8089bd791acf7ef3f07"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"bab9f26a433a5bdd66398121af3a34149327d2c3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE sriov_nic physical_device_mappings $PHYSICAL_DEVICE_MAPPINGS"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    AGENT_BINARY\u003d\"$NEUTRON_BIN_DIR/neutron-sriov-nic-agent\""},{"line_number":22,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE ml2_sriov agent_required True"},{"line_number":23,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE agent rpc True"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_77baae0c","line":22,"updated":"2014-07-29 18:50:30.000000000","message":"I think \u0027agent_required\u0027 should be configurable","commit_id":"8e8080ed6785b8a8e307d84d6817540bb3707e35"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"bab9f26a433a5bdd66398121af3a34149327d2c3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"function neutron_plugin_create_nova_conf() {"},{"line_number":27,"context_line":"    NOVA_VIF_DRIVER\u003d${NOVA_VIF_DRIVER:-\"nova.virt.libvirt.vif.LibvirtGenericVIFDriver\"}"},{"line_number":28,"context_line":"    iniset $NOVA_CONF DEFAULT security_group_api nova"},{"line_number":29,"context_line":"    if [[ -z $PCI_PASSTHROUGH_WHITELIST  ]]; then"},{"line_number":30,"context_line":"        die $LINENO \"Please provide list of PCI devices available to VMs in your local.conf file.\\n"},{"line_number":31,"context_line":"                     For example: PCI_PASSTHROUGH_WHITELIST\u003d\u0027{\\\"address\\\":\\\"*:07:00.*\\\",\\\"physical_network\\\":\\\"default\\\"}\u0027\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_b770c6a8","line":28,"updated":"2014-07-29 18:50:30.000000000","message":"security_group_api should be neutron","commit_id":"8e8080ed6785b8a8e307d84d6817540bb3707e35"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"bab9f26a433a5bdd66398121af3a34149327d2c3","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"function neutron_plugin_setup_interface_driver() {"},{"line_number":45,"context_line":"    local conf_file\u003d$1"},{"line_number":46,"context_line":"    iniset $conf_file DEFAULT interface_driver neutron.agent.linux.interface.BridgeInterfaceDriver"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"function neutron_plugin_configure_debug_command() {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_b42d24b1","line":46,"updated":"2014-07-29 18:50:30.000000000","message":"You should use OVS Interface driver","commit_id":"8e8080ed6785b8a8e307d84d6817540bb3707e35"}]}