)]}'
{"id":"openstack%2Fdevstack~113377","triplet_id":"openstack%2Fdevstack~master~I927dafca8a2047d6c0fd3c74569ed2521f124547","project":"openstack/devstack","branch":"master","topic":"ironic_grenade","hashtags":[],"change_id":"I927dafca8a2047d6c0fd3c74569ed2521f124547","subject":"Centralize neutron config file argument generation","status":"MERGED","created":"2014-08-11 21:38:02.000000000","updated":"2014-08-25 21:59:51.000000000","submitted":"2014-08-25 21:59:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1510cd17a47d742703b2cd238ac5a09f7d6b8cf1","_number":113377,"virtual_id_number":113377,"owner":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2014-08-11 22:55:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":1,"date":"2014-08-12 03:55:53.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":2,"date":"2014-08-25 21:59:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-08-25 16:59:47.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2014-08-25 14:18:36.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-08-25 16:59:47.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-08-11 22:55:48.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-08-12 03:55:53.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-08-25 14:18:36.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-08-25 16:59:47.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-08-25 21:59:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4d068b460541a78e0bd15743730060f2d107778b","author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"date":"2014-08-11 21:38:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cebd385afedf8f1840caa7303fd1158c086aa98e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-11 21:38:07.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"4a1b6fd4688cd293f6017f65107d3b90be8488e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-11 21:45:29.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"3e71972c129cd5b78901b114b1df136688648215","author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"date":"2014-08-11 21:45:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5f490144363ff0fb4ec259468c7aeed7c69fcaf8","author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"date":"2014-08-11 22:35:07.000000000","message":"Topic changed from neutron_sanitize_config to ironic_grenade","accounts_in_message":[],"_revision_number":2},{"id":"8e2a6013a5af16e630e6646ff8c613c0d410f879","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2014-08-11 22:55:48.000000000","message":"Patch Set 2: Verified+1\n\n- check-tempest-neutron-vmware-nsx http://208.91.1.172/logs/neutron/113377/2/414814/ : SUCCESS in 36m 8s (98.68% avg)","accounts_in_message":[],"_revision_number":2},{"id":"22342739b981d52e0d5ac2971495c0756aa60192","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-08-12 03:55:53.000000000","message":"Patch Set 2: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/77/113377/2/21415/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2},{"id":"3d081c35f7a21597805d52a5fb66687190807b40","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-12 05:42:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/77/113377/2/check/check-tempest-dsvm-full/e33f0a4 : SUCCESS in 49m 41s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/77/113377/2/check/check-tempest-dsvm-postgres-full/b64299d : SUCCESS in 36m 49s\n- check-tempest-dsvm-neutron http://logs.openstack.org/77/113377/2/check/check-tempest-dsvm-neutron/788ca55 : SUCCESS in 47m 04s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/77/113377/2/check/check-tempest-dsvm-neutron-heat-slow/e728039 : SUCCESS in 19m 58s\n- check-grenade-dsvm http://logs.openstack.org/77/113377/2/check/check-grenade-dsvm/4361ab6 : SUCCESS in 37m 50s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/77/113377/2/check/gate-tempest-dsvm-large-ops/d350d18 : SUCCESS in 17m 58s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/77/113377/2/check/gate-tempest-dsvm-neutron-large-ops/b99ddb8 : SUCCESS in 19m 28s\n- gate-devstack-bashate http://logs.openstack.org/77/113377/2/check/gate-devstack-bashate/017c561 : SUCCESS in 33s\n- check-devstack-dsvm-cells http://logs.openstack.org/77/113377/2/check/check-devstack-dsvm-cells/2905240 : SUCCESS in 16m 12s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/77/113377/2/check/check-tempest-dsvm-neutron-full/fa8c324 : SUCCESS in 1h 04m 10s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/77/113377/2/check/check-grenade-dsvm-partial-ncpu/4a05a8f : SUCCESS in 38m 10s\n- check-neutron-dsvm-functional http://logs.openstack.org/77/113377/2/check/check-neutron-dsvm-functional/03b5bf7 : SUCCESS in 20m 00s\n- check-swift-dsvm-functional http://logs.openstack.org/77/113377/2/check/check-swift-dsvm-functional/2cb6591 : SUCCESS in 16m 21s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/77/113377/2/check/check-tempest-dsvm-ironic-nv/c9b3280 : SUCCESS in 37m 30s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/77/113377/2/check/check-tempest-dsvm-ironic-postgres-nv/e233356 : SUCCESS in 35m 36s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/77/113377/2/check/check-tempest-dsvm-virtual-ironic-nv/afe6464 : SUCCESS in 27m 42s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/77/113377/2/check/check-tempest-dsvm-f20/083f1b4 : SUCCESS in 1h 01m 50s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2a056cb5ad2a46cd33dbe50ee6f3be31d5dcd451","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-08-25 14:18:36.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d7d0b30953fa09daacf16f4484ae3193b68985a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-25 16:59:47.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"bb47562c573dc7d0d36501d2317ef01f90f8b27c","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-25 16:59:47.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"48f07d59ec764e203bb3d406a44b6d73e80945d8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-25 21:59:50.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded.\n\n- gate-tempest-dsvm-full http://logs.openstack.org/77/113377/2/gate/gate-tempest-dsvm-full/655203f : SUCCESS in 56m 27s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/77/113377/2/gate/gate-tempest-dsvm-postgres-full/4552888 : SUCCESS in 56m 01s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/77/113377/2/gate/gate-tempest-dsvm-neutron-full/646cca3 : SUCCESS in 1h 05m 59s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/77/113377/2/gate/gate-tempest-dsvm-neutron-heat-slow/96d3852 : SUCCESS in 23m 15s\n- gate-grenade-dsvm http://logs.openstack.org/77/113377/2/gate/gate-grenade-dsvm/45fc43b : SUCCESS in 44m 49s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/77/113377/2/gate/gate-tempest-dsvm-large-ops/8811351 : SUCCESS in 27m 08s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/77/113377/2/gate/gate-tempest-dsvm-neutron-large-ops/ab5caa7 : SUCCESS in 25m 43s\n- gate-devstack-bashate http://logs.openstack.org/77/113377/2/gate/gate-devstack-bashate/2cf0992 : SUCCESS in 20s\n- gate-devstack-dsvm-cells http://logs.openstack.org/77/113377/2/gate/gate-devstack-dsvm-cells/821a434 : SUCCESS in 16m 32s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/77/113377/2/gate/gate-grenade-dsvm-partial-ncpu/562df3e : SUCCESS in 36m 52s\n- gate-neutron-dsvm-functional http://logs.openstack.org/77/113377/2/gate/gate-neutron-dsvm-functional/76e7db3 : SUCCESS in 19m 54s\n- gate-swift-dsvm-functional http://logs.openstack.org/77/113377/2/gate/gate-swift-dsvm-functional/a196df0 : SUCCESS in 19m 42s","accounts_in_message":[],"_revision_number":2},{"id":"1510cd17a47d742703b2cd238ac5a09f7d6b8cf1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-25 21:59:51.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7614d21fe157a6b3a833d3eb278fb9267ef13e06","revisions":{"877734bce6c196395a1a4d1f3bf1a115c8a59a30":{"kind":"REWORK","_number":1,"created":"2014-08-11 21:38:02.000000000","uploader":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"ref":"refs/changes/77/113377/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/77/113377/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/113377/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/113377/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/113377/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/77/113377/1"}}},"commit":{"parents":[{"commit":"84744d8e38b9c729d4d9aef3638aefbab707ac37","subject":"Merge \"Adds support for Hyper-V image formats\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/84744d8e38b9c729d4d9aef3638aefbab707ac37"}]}],"author":{"name":"Adam Gandelman","email":"adamg@ubuntu.com","date":"2014-08-11 21:27:50.000000000","tz":-420},"committer":{"name":"Adam Gandelman","email":"adamg@ubuntu.com","date":"2014-08-11 21:27:50.000000000","tz":-420},"subject":"Centralize neutron config file argument generation","message":"Centralize neutron config file argument generation\n\nMoves dynamic generation of the --config-file list from local functions\nto global utility functions.  This breaks up the current non-obvious\ndependency between start_neutron_agents and _configure_neutron_l3_agent\nfor setting the correct arguments for the vpn agent.   This also similarly\nupdates generation of arguments for neutron-server and neutron-l3-agent to\nuse said functions.  Finally, this cleans lib/neutron up a bit and moves\nall default paths to config files and binaries out of local functions and\ninto the top-level, allowing external tools like Grenade to make use of the\nlibrary for starting Neutron services and agents currently.\n\nChange-Id: I927dafca8a2047d6c0fd3c74569ed2521f124547\nCloses-bug: #1355429.\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/877734bce6c196395a1a4d1f3bf1a115c8a59a30"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/877734bce6c196395a1a4d1f3bf1a115c8a59a30"}]},"branch":"refs/heads/master"},"7614d21fe157a6b3a833d3eb278fb9267ef13e06":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2014-08-11 21:45:29.000000000","uploader":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"ref":"refs/changes/77/113377/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/77/113377/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/113377/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/113377/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/113377/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/77/113377/2"}}},"commit":{"parents":[{"commit":"84744d8e38b9c729d4d9aef3638aefbab707ac37","subject":"Merge \"Adds support for Hyper-V image formats\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/84744d8e38b9c729d4d9aef3638aefbab707ac37"}]}],"author":{"name":"Adam Gandelman","email":"adamg@ubuntu.com","date":"2014-08-11 21:27:50.000000000","tz":-420},"committer":{"name":"Adam Gandelman","email":"adamg@ubuntu.com","date":"2014-08-11 21:45:22.000000000","tz":-420},"subject":"Centralize neutron config file argument generation","message":"Centralize neutron config file argument generation\n\nMoves dynamic generation of the --config-file list from local functions\nto global utility functions.  This breaks up the current non-obvious\ndependency between start_neutron_agents and _configure_neutron_l3_agent\nfor setting the correct arguments for the vpn agent.   This also similarly\nupdates generation of arguments for neutron-server and neutron-l3-agent to\nuse said functions.  Finally, this cleans lib/neutron up a bit and moves\nall default paths to config files and binaries out of local functions and\ninto the top-level, allowing external tools like Grenade to make use of the\nlibrary for starting Neutron services and agents currently.\n\nChange-Id: I927dafca8a2047d6c0fd3c74569ed2521f124547\nCloses-bug: #1355429\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7614d21fe157a6b3a833d3eb278fb9267ef13e06"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7614d21fe157a6b3a833d3eb278fb9267ef13e06"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}