)]}'
{"lib/ceilometer":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c792f45c2b72bbd6a351ec82ee190a1e69900646","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    # Wait for the collector to fully wake up and connect to the"},{"line_number":232,"context_line":"    # message bus before starting the compute agent. See bug #1355809"},{"line_number":233,"context_line":"    sleep 1"},{"line_number":234,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"},{"line_number":235,"context_line":"        screen_it ceilometer-acompute \"cd ; sg $LIBVIRT_GROUP \u0027ceilometer-agent-compute --config-file $CEILOMETER_CONF\u0027\""},{"line_number":236,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_4ccfffb2","line":233,"updated":"2014-08-12 19:41:57.000000000","message":"I\u0027d just like to confirm that there is no better way to do this than to sleep?","commit_id":"d06b640ce3cdb2c9e7dc489d50776fa233f7d3ac"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"73bd69d0555326a48855349c5ee61749fa932767","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    # Wait for the collector to fully wake up and connect to the"},{"line_number":232,"context_line":"    # message bus before starting the compute agent. See bug #1355809"},{"line_number":233,"context_line":"    sleep 1"},{"line_number":234,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"},{"line_number":235,"context_line":"        screen_it ceilometer-acompute \"cd ; sg $LIBVIRT_GROUP \u0027ceilometer-agent-compute --config-file $CEILOMETER_CONF\u0027\""},{"line_number":236,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_6ce2039e","line":233,"in_reply_to":"baada198_4ccfffb2","updated":"2014-08-12 19:57:39.000000000","message":"I\u0027ve run several tests, some with sleep and some without and they all pass. The sleep is there basically because a) I\u0027m paranoid and don\u0027t want to replace an invisible race condition with another one b) I\u0027m insufficiently ignorant about the startup process here to know if `screen_it` + the services being started is fully sequential.\n\nI think the sleep can probably be removed but if it is adding a bit of insurance and robustness it is not going to make a ton of difference in the already hugely slow process?\n\nI\u0027m not wed to it by any stretch, but see above :)","commit_id":"d06b640ce3cdb2c9e7dc489d50776fa233f7d3ac"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5fa090ddeb2c0f3ff3f4e867ae0492976b78aa6e","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    # Wait for the collector to fully wake up and connect to the"},{"line_number":232,"context_line":"    # message bus before starting the compute agent. See bug #1355809"},{"line_number":233,"context_line":"    sleep 1"},{"line_number":234,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"},{"line_number":235,"context_line":"        screen_it ceilometer-acompute \"cd ; sg $LIBVIRT_GROUP \u0027ceilometer-agent-compute --config-file $CEILOMETER_CONF\u0027\""},{"line_number":236,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_8d25915d","line":233,"in_reply_to":"baada198_6ce2039e","updated":"2014-08-12 20:46:09.000000000","message":"screen_it just runs the process; it doesn\u0027t know about connection status etc.\n\nI\u0027m just a bit negative on adding more magic sleeps.  If we don\u0027t need it, great; if we do, then can\u0027t we check log output or do a test call or something reliable?\n\nit sounds like we should remove it and fix the problem if it is required","commit_id":"d06b640ce3cdb2c9e7dc489d50776fa233f7d3ac"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e8f905b22a402c0af05950fef926158e575b3d98","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    # Wait for the collector to fully wake up and connect to the"},{"line_number":232,"context_line":"    # message bus before starting the compute agent. See bug #1355809"},{"line_number":233,"context_line":"    sleep 1"},{"line_number":234,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"},{"line_number":235,"context_line":"        screen_it ceilometer-acompute \"cd ; sg $LIBVIRT_GROUP \u0027ceilometer-agent-compute --config-file $CEILOMETER_CONF\u0027\""},{"line_number":236,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_ed28cd9a","line":233,"in_reply_to":"baada198_8d25915d","updated":"2014-08-12 20:59:44.000000000","message":"Done","commit_id":"d06b640ce3cdb2c9e7dc489d50776fa233f7d3ac"}]}