)]}'
{"lib/nova_plugins/functions-libvirt":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"632d3e0d7aecd1608a6397bece80298db1b88274","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    # don\u0027t care if it fails."},{"line_number":40,"context_line":"    if is_fedora; then"},{"line_number":41,"context_line":"        sudo service firewalld restart || true"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Configures the installed libvirt system so that is accessible by"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1abeadc6_eedc3577","side":"PARENT","line":42,"updated":"2014-08-18 09:08:05.000000000","message":"This shouldn\u0027t be removed - that scenario is still valid for people who have set the env var to request use of firewalld.","commit_id":"04a351133a5f4819df1a6474d5599900d55ae501"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"735dbc765eb8ae30f7ad2f2f5eb85a31736630e2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    # don\u0027t care if it fails."},{"line_number":40,"context_line":"    if is_fedora; then"},{"line_number":41,"context_line":"        sudo service firewalld restart || true"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Configures the installed libvirt system so that is accessible by"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1abeadc6_b9396043","side":"PARENT","line":42,"in_reply_to":"1abeadc6_eedc3577","updated":"2014-08-19 19:11:07.000000000","message":"Yup, restored with an is_package_installed() test added","commit_id":"04a351133a5f4819df1a6474d5599900d55ae501"}],"tools/fixup_stuff.sh":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"88863f75112a159653a7cfe60b481eddf8687312","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        sudo setenforce 0"},{"line_number":105,"context_line":"    fi"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    FORCE_F20_FIREWALLD\u003d$(trueorfalse False $FORCE_F20_FIREWALLD)"},{"line_number":108,"context_line":"    if [[ $DISTRO \u003d\u003d \"f20\" \u0026\u0026 $FORCE_F20_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":109,"context_line":"        # On Fedora 20 firewalld interacts badly with libvirt and"},{"line_number":110,"context_line":"        # slows things down significantly.  However, for those cases"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1abeadc6_2bfc5f3e","line":107,"updated":"2014-08-18 08:57:59.000000000","message":"May be doing it based on libvirt version makes more sense,\nbut it is doable only in after libvirt installation, in the libvirt related file.","commit_id":"dbf9f9fd6c1714e9f5c4734c1bad85de789ab977"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"735dbc765eb8ae30f7ad2f2f5eb85a31736630e2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        sudo setenforce 0"},{"line_number":105,"context_line":"    fi"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    FORCE_F20_FIREWALLD\u003d$(trueorfalse False $FORCE_F20_FIREWALLD)"},{"line_number":108,"context_line":"    if [[ $DISTRO \u003d\u003d \"f20\" \u0026\u0026 $FORCE_F20_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":109,"context_line":"        # On Fedora 20 firewalld interacts badly with libvirt and"},{"line_number":110,"context_line":"        # slows things down significantly.  However, for those cases"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1abeadc6_f93598db","line":107,"in_reply_to":"1abeadc6_2bfc5f3e","updated":"2014-08-19 19:11:07.000000000","message":"We\u0027re addressing a specific broken combination of packages and distro.","commit_id":"dbf9f9fd6c1714e9f5c4734c1bad85de789ab977"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"632d3e0d7aecd1608a6397bece80298db1b88274","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    fi"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    FORCE_F20_FIREWALLD\u003d$(trueorfalse False $FORCE_F20_FIREWALLD)"},{"line_number":108,"context_line":"    if [[ $DISTRO \u003d\u003d \"f20\" \u0026\u0026 $FORCE_F20_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":109,"context_line":"        # On Fedora 20 firewalld interacts badly with libvirt and"},{"line_number":110,"context_line":"        # slows things down significantly.  However, for those cases"},{"line_number":111,"context_line":"        # where that combination is desired, allow this fix to be skipped."}],"source_content_type":"text/x-sh","patch_set":6,"id":"1abeadc6_aef31d09","line":108,"updated":"2014-08-18 09:08:05.000000000","message":"If we\u0027re going to add a env variable to control this, it would be much better to add one that is more generally useful long term. Ignoring the particular bug we care about right now, it is valid to test Nova either with or without firewalld, so would be desirable to be able to explicitly instruct devstack in this regard, so developers and gate CI admins can guarantee a particular setup regardless of what the OS installer or cloud image has pre-installed. \n\n * LIBVIRT_NWFILTER\u003dauto -\u003e prefer whatever is already installed, unless known bugs require uninstalling firewalld (default)\n * LIBVIRT_NWFILTER\u003diptables -\u003e use plain iptables. Ensure firewalld is *not* installed\n * LIBVIRT_NWFILTER\u003dfirewalld -\u003e use firewalld. Install + start firewalld if not already present\n\nSo for \u0027auto\u0027 we\u0027d uninstall firewalld if we have the known buggy scenario.\n\nAlso note, this problem isn\u0027t Fedora 20 specific - it affects all previous Fedora too, eg F19. so we should not restrict this to f20 only.","commit_id":"dbf9f9fd6c1714e9f5c4734c1bad85de789ab977"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"735dbc765eb8ae30f7ad2f2f5eb85a31736630e2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    fi"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    FORCE_F20_FIREWALLD\u003d$(trueorfalse False $FORCE_F20_FIREWALLD)"},{"line_number":108,"context_line":"    if [[ $DISTRO \u003d\u003d \"f20\" \u0026\u0026 $FORCE_F20_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":109,"context_line":"        # On Fedora 20 firewalld interacts badly with libvirt and"},{"line_number":110,"context_line":"        # slows things down significantly.  However, for those cases"},{"line_number":111,"context_line":"        # where that combination is desired, allow this fix to be skipped."}],"source_content_type":"text/x-sh","patch_set":6,"id":"1abeadc6_7903480d","line":108,"in_reply_to":"1abeadc6_aef31d09","updated":"2014-08-19 19:11:07.000000000","message":"I don\u0027t want DevStack getting into this business outside of what is required for Neutron.  You are right about accepting the system state as-is when possible and we strive to do that but still need to address specific broken combinations as here.","commit_id":"dbf9f9fd6c1714e9f5c4734c1bad85de789ab977"}]}