)]}'
{"id":"openstack%2Fdevstack~113856","triplet_id":"openstack%2Fdevstack~master~I5252a12223a35f7fb7a4ac3c58aa4a3cd1bc4799","project":"openstack/devstack","branch":"master","topic":"fixup-stuff","hashtags":[],"change_id":"I5252a12223a35f7fb7a4ac3c58aa4a3cd1bc4799","subject":"Remove firewalld on Fedora 20 by default","status":"MERGED","created":"2014-08-13 11:44:44.000000000","updated":"2014-08-24 01:23:15.000000000","submitted":"2014-08-24 01:23:14.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"933182f0fbd280fbd81aa2c65aca75c51b4851d0","_number":113856,"virtual_id_number":113856,"owner":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":1,"date":"2014-08-19 20:39:52.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2014-08-24 01:23:14.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"date":"2014-08-20 04:15:41.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"disliked":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"all":[{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2014-08-20 08:55:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":2,"date":"2014-08-19 19:23:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":2,"date":"2014-08-22 19:10:42.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2014-08-22 19:10:42.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-08-14 00:55:35.000000000","updated_by":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-08-14 10:38:56.000000000","updated_by":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"reviewer":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"state":"REVIEWER"},{"updated":"2014-08-18 22:02:46.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2014-08-19 19:23:42.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2014-08-19 20:39:52.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-08-20 04:15:41.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-08-20 08:55:20.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2014-08-22 19:10:42.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-08-24 01:23:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bda087ebff3e560752a198c1f970e77dd144a26d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-13 11:44:44.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0916c7b051386548cadb9c28e11aebea8053d02e","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2014-08-13 11:44:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ce6623a1eee63a82eb870f8e230469efb4e910d","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-13 11:53:53.000000000","message":"Patch Set 1: Code-Review-1\n\nI don\u0027t think it is acceptable to disable firewalld on all developers machines, despite the speed implications. It will silently leave them vulnerable to the network. I certainly don\u0027t want devstack doing this on my laptop. Developers can choose what firewall setup to use and we should honour that in devstack.\n\nWe should solely disable it in the gate CI systems we use.","accounts_in_message":[],"_revision_number":1},{"id":"d48bea90792c801e7a144ca4df9813be9b24ab85","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2014-08-13 12:14:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7b5b03ac4096c8dea8172ceda7bce3780c02aa56","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-13 12:15:00.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"f9b6b7d366a50761f72925a1b273d3f555515fa8","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-13 12:27:39.000000000","message":"Patch Set 2: Code-Review+1\n\nThat looks better now","accounts_in_message":[],"_revision_number":2},{"id":"6068e6ff44e765c80216eb337382e6010e8faf47","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-13 12:29:45.000000000","message":"Patch Set 2: Code-Review-1\n\nHmm, actually no, that is still going to disable firewalld by default on machines where it is currently running. The default behaviour should be to use the current OS firewall setup without change.\n\nie you need a tri-state\n\n * LIBVIRT_USE_FIREWALLD unset -\u003e restart firewalld if already running\n * LIBVIRT_USE_FIREWALLD\u003dTRUE -\u003e install \u0026 enable firewalld\n * LIBVIRT_USE_FIREWALLD\u003dFALSE -\u003e stop firewalld if running","accounts_in_message":[],"_revision_number":2},{"id":"9ec5f3ed64809ed21cab7930f534158c990591ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-13 13:21:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/56/113856/2/check/check-tempest-dsvm-full/4d1f03b : SUCCESS in 39m 42s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/2/check/check-tempest-dsvm-postgres-full/531f8e3 : SUCCESS in 55m 03s\n- check-tempest-dsvm-neutron http://logs.openstack.org/56/113856/2/check/check-tempest-dsvm-neutron/35d2a2e : SUCCESS in 54m 58s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/2/check/check-tempest-dsvm-neutron-heat-slow/bf3148e : SUCCESS in 23m 52s\n- check-grenade-dsvm http://logs.openstack.org/56/113856/2/check/check-grenade-dsvm/7997a50 : SUCCESS in 43m 11s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/2/check/gate-tempest-dsvm-large-ops/6931e66 : SUCCESS in 26m 02s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/2/check/gate-tempest-dsvm-neutron-large-ops/cdb74b3 : SUCCESS in 23m 08s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/2/check/gate-devstack-bashate/8d460ab : SUCCESS in 10s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/113856/2/check/check-devstack-dsvm-cells/c63ba4d : SUCCESS in 18m 55s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/2/check/check-tempest-dsvm-neutron-full/37a4c35 : FAILURE in 1h 06m 36s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/2/check/check-grenade-dsvm-partial-ncpu/4561c50 : SUCCESS in 45m 18s\n- check-neutron-dsvm-functional http://logs.openstack.org/56/113856/2/check/check-neutron-dsvm-functional/fdc299f : SUCCESS in 20m 06s\n- check-swift-dsvm-functional http://logs.openstack.org/56/113856/2/check/check-swift-dsvm-functional/2be8011 : SUCCESS in 19m 00s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/56/113856/2/check/check-tempest-dsvm-ironic-nv/29ac9e3 : SUCCESS in 30m 43s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/56/113856/2/check/check-tempest-dsvm-ironic-postgres-nv/2826342 : SUCCESS in 36m 31s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/56/113856/2/check/check-tempest-dsvm-virtual-ironic-nv/114577c : SUCCESS in 27m 45s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/56/113856/2/check/check-tempest-dsvm-f20/ada02c8 : SUCCESS in 29m 29s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"049da733e2a15ec6c1bee3972c9b5de33ea06835","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2014-08-13 13:25:54.000000000","message":"Patch Set 2:\n\nIt would require an additional change on the devstack gate side, and new gate variable to be used.\n\nA possible alternative way:\nhttps://review.openstack.org/#/c/113884/","accounts_in_message":[],"_revision_number":2},{"id":"07e3bf57f6e24a7e58ebde2aaa68d776a53e9a86","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-08-13 14:52:29.000000000","message":"Patch Set 2: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/56/113856/2/21756/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2},{"id":"2e4d3a159d62bc10847416cb68c215dbefb4c7a0","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2014-08-13 21:34:18.000000000","message":"Patch Set 2: Code-Review+1\n\nThe devstack gate is meant to test devstack as developers use it.  Part of the frustration that we\u0027ve seen in the past few cycles is due to the gate configuration drifting from the standard devstack configuration.  Therefore, we are taking a harder line on ensuring that devstack works as intended from scratch in as close to the default configuration as possible.  If devstack needs to modify the firewall configuration for openstack to work correctly, it should.  But we should not have a gate configuration where all of the \"correct\" options are set which differs from the default configuration which is known not to work (or work well).\n\nI believe that using iptables instead of firewalld was an option; perhaps devstack could handle making that transition?\n\nRegardless, Devstack does all kinds of horrible things to a machine in order for openstack to run.  I don\u0027t think any of them would be acceptable on a developer workstation; rather it should be run on a dedicated vm, or in an environment appropriately externally firewalled.","accounts_in_message":[],"_revision_number":2},{"id":"bf3a28dc33fc61d3d4bdc9f143c3d1d2cc3af4f2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-13 21:34:30.000000000","message":"Patch Set 2: Code-Review-1\n\nI think I\u0027d rather see something simpler, just a FIREWALLD_DISABLE[0] or something that defaults to unset, and when True simply stops the firewalld service or removes it if there are things that might restart it later.\n\ndevstack-gate can set it True to get the benefit.\n\n[0] I don\u0027t really care about the name but it should default to being unset and make sense when set...in my mind unset \u003d\u003d False.\n\nBTW, the changes to the prereq files don\u0027t change anything except cache the firewalld package on distros that wouldn\u0027t have it by default otherwise...why install it just to turn it off?","accounts_in_message":[],"_revision_number":2},{"id":"d7094a40efc3a5cb07e31fb566846677f4297c44","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-13 21:40:01.000000000","message":"Patch Set 2:\n\nUpon further review...\n\ntools/fixup_stuff.sh already turns off selinux enforcement for fedora systems, adding the removal/stoppage of firewalld there makes the best sense in my mind.","accounts_in_message":[],"_revision_number":2},{"id":"9417ea5fbc5900c48a55df6e3470532adc427ac8","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-13 22:08:21.000000000","message":"Patch Set 2:\n\n@Daniel ; I hear your complaint that it shouldn\u0027t disable your specific firewall rules, but in reality devstack is taking over the host completely\n\nadditionally, firewalld is not part of the default f20 cloud image; it appears to be something extra added by the rax f20 image\n\nthere seems to be no benefit to workarounds a) outside devstack and b) that will be rarely used.\n\nBTW, the change does appear to drop the run time from about 1hour to about 30 minutes; in-line with Ubuntu.","accounts_in_message":[],"_revision_number":2},{"id":"b62163c2b6c80508debb1f0254f04b5f68d519e3","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-13 22:21:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a1c479b782ab8da258b7f1114df8f5d162c4a8f7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-13 22:21:54.000000000","message":"Patch Set 3:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"75628fbc7d005e4d0186e82352fb2d78666a6922","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2014-08-13 22:26:29.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8046c099534c75cab6fbd79a11125e1c1ecf7a68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-13 23:35:02.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/56/113856/3/check/check-tempest-dsvm-full/af5c038 : SUCCESS in 48m 45s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/3/check/check-tempest-dsvm-postgres-full/9e35287 : SUCCESS in 52m 23s\n- check-tempest-dsvm-neutron http://logs.openstack.org/56/113856/3/check/check-tempest-dsvm-neutron/30deca9 : SUCCESS in 1h 00m 15s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/3/check/check-tempest-dsvm-neutron-full/7eacfd3 : SUCCESS in 1h 04m 15s (non-voting)\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/3/check/check-tempest-dsvm-neutron-heat-slow/95e789a : SUCCESS in 24m 24s\n- check-grenade-dsvm http://logs.openstack.org/56/113856/3/check/check-grenade-dsvm/21babcd : SUCCESS in 47m 08s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/3/check/gate-tempest-dsvm-large-ops/bf2a19e : SUCCESS in 25m 39s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/3/check/gate-tempest-dsvm-neutron-large-ops/2052051 : SUCCESS in 24m 00s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/3/check/gate-devstack-bashate/6d84ba4 : SUCCESS in 41s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/113856/3/check/check-devstack-dsvm-cells/984662f : SUCCESS in 17m 09s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/3/check/check-grenade-dsvm-partial-ncpu/82a6a67 : SUCCESS in 37m 58s\n- check-neutron-dsvm-functional http://logs.openstack.org/56/113856/3/check/check-neutron-dsvm-functional/ed88e5e : SUCCESS in 21m 24s\n- check-swift-dsvm-functional http://logs.openstack.org/56/113856/3/check/check-swift-dsvm-functional/29c887a : SUCCESS in 20m 17s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/56/113856/3/check/check-tempest-dsvm-ironic-nv/9e49496 : SUCCESS in 35m 38s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/56/113856/3/check/check-tempest-dsvm-ironic-postgres-nv/e426195 : SUCCESS in 36m 45s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/56/113856/3/check/check-tempest-dsvm-virtual-ironic-nv/9d661b9 : SUCCESS in 30m 48s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/56/113856/3/check/check-tempest-dsvm-f20/87f9092 : FAILURE in 21m 34s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d8bc7ab99e9a858399bc0263be0b3048e0471c63","author":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"date":"2014-08-13 23:35:35.000000000","message":"Patch Set 3:\n\nredhatci results for change 113856\n\nLogs at http://people.redhat.com/~iwienand/113856/\n\n* OSLAB_FEDORA20 http://people.redhat.com/~iwienand/113856/20140813222637.OSLAB_FEDORA20.3.log.gz : SUCCESS Patch Set 3 in 01:06\n* OSLAB_RHEL7 http://people.redhat.com/~iwienand/113856/20140813222637.OSLAB_RHEL7.3.log.gz : SUCCESS Patch Set 3 in 00:29\n* OSLAB_RHEL65 http://people.redhat.com/~iwienand/113856/20140813222637.OSLAB_RHEL65.3.log.gz : SUCCESS Patch Set 3 in 00:42\n* OSLAB_CENTOS65 http://people.redhat.com/~iwienand/113856/20140813222637.OSLAB_CENTOS65.3.log.gz : SUCCESS Patch Set 3 in 00:29\n\nend","accounts_in_message":[],"_revision_number":3},{"id":"a21ced6e1b73bf2ced67c4e125a160bcbee9e59a","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-14 00:04:16.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"10b26f0301aa941fa82abf2d1d9b293ce6d88acc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-14 00:04:27.000000000","message":"Patch Set 4:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"df036308e3184dc222e65bce8523878266110bdc","author":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"date":"2014-08-14 00:55:35.000000000","message":"Patch Set 4:\n\nredhatci results for change 113856\n\nLogs at http://people.redhat.com/~iwienand/113856/\n\n* OSLAB_RHEL65 http://people.redhat.com/~iwienand/113856/20140814001238.OSLAB_RHEL65.4.log.gz : SUCCESS Patch Set 4 in 00:22\n* OSLAB_RHEL7 http://people.redhat.com/~iwienand/113856/20140814001238.OSLAB_RHEL7.4.log.gz : SUCCESS Patch Set 4 in 00:36\n* OSLAB_FEDORA20 http://people.redhat.com/~iwienand/113856/20140814001238.OSLAB_FEDORA20.4.log.gz : SUCCESS Patch Set 4 in 00:34\n* OSLAB_CENTOS65 http://people.redhat.com/~iwienand/113856/20140814001238.OSLAB_CENTOS65.4.log.gz : SUCCESS Patch Set 4 in 00:39\n\nend","accounts_in_message":[],"_revision_number":4},{"id":"e0e54f95c08a4dea0c626171c0a95bc7a2c2bf9f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-14 01:10:21.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/56/113856/4/check/check-tempest-dsvm-full/ecafdc9 : SUCCESS in 48m 59s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/4/check/check-tempest-dsvm-postgres-full/0d3f356 : SUCCESS in 40m 29s\n- check-tempest-dsvm-neutron http://logs.openstack.org/56/113856/4/check/check-tempest-dsvm-neutron/d854c1a : SUCCESS in 49m 01s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/4/check/check-tempest-dsvm-neutron-full/ac02294 : SUCCESS in 55m 55s (non-voting)\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/4/check/check-tempest-dsvm-neutron-heat-slow/927e26c : SUCCESS in 20m 53s\n- check-grenade-dsvm http://logs.openstack.org/56/113856/4/check/check-grenade-dsvm/876e4a2 : SUCCESS in 39m 17s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/4/check/gate-tempest-dsvm-large-ops/d9ad14d : SUCCESS in 18m 08s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/4/check/gate-tempest-dsvm-neutron-large-ops/a84b565 : SUCCESS in 20m 11s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/4/check/gate-devstack-bashate/e50b90e : SUCCESS in 51s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/113856/4/check/check-devstack-dsvm-cells/7057bec : SUCCESS in 18m 38s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/4/check/check-grenade-dsvm-partial-ncpu/673ba55 : SUCCESS in 50m 09s\n- check-neutron-dsvm-functional http://logs.openstack.org/56/113856/4/check/check-neutron-dsvm-functional/8c26bcd : SUCCESS in 20m 24s\n- check-swift-dsvm-functional http://logs.openstack.org/56/113856/4/check/check-swift-dsvm-functional/9e438fd : SUCCESS in 16m 29s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/56/113856/4/check/check-tempest-dsvm-ironic-nv/ca96f51 : SUCCESS in 32m 48s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/56/113856/4/check/check-tempest-dsvm-ironic-postgres-nv/863fa9f : SUCCESS in 36m 55s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/56/113856/4/check/check-tempest-dsvm-virtual-ironic-nv/c57c79f : SUCCESS in 27m 42s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/56/113856/4/check/check-tempest-dsvm-f20/0cedc03 : SUCCESS in 28m 55s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"8b2b7e76db8e0ad8c8b1d2362f81ae005bd9b872","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-14 01:39:04.000000000","message":"Patch Set 4: Code-Review+1\n\nI\u0027m good with this now.  +1 until afazekas and berrange get a chance to see it","accounts_in_message":[],"_revision_number":4},{"id":"0f0f4b7280acefc6884aeff5f897d62f45f76608","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2014-08-14 07:56:27.000000000","message":"Patch Set 4: Code-Review+1\n\nLGTM\n\nThe firewalld also not handled by the puppet modules, so we might want to remove at noodepool image creation time as well.\nhttps://review.openstack.org/#/c/113884/","accounts_in_message":[],"_revision_number":4},{"id":"25b2cfb85766adf72ea13989169215668cc7d979","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-14 08:22:19.000000000","message":"Patch Set 4: Code-Review-1\n\nSeriously no, just no. Disabling the firewall on a users machine is just not an acceptable thing todo, especially for a bug that is really not an issue for developers. Only the gate systems are majorly impacted by this, and the performance problem doesn\u0027t exist in newer versions of libvirt either.","accounts_in_message":[],"_revision_number":4},{"id":"0de1507a5c9d08d951e0bd423d085787c35cb64c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-14 09:42:44.000000000","message":"Patch Set 4:\n\n@Daniel - I get where you\u0027re coming from that removing firewalld is bad, but several counter points:\n\n- this is guarded as f20 only; when it comes time to switch to f21 it will use the status quo\n\n- if firewalld is not removed/disabled by default, every developer is left to debug why tempest/vms are running so slowly -- how else do they know to turn on the magic flag?.  unless we do it by default (this change).  I *hate* spending hours debugging a problem, only to find it\u0027s a known issue and I just needed to turn this or that hidden knob \n\n- just before this we turn off selinux (one day I hope to get it on, lower priority than getting the job working) and then we proceed to destroy the system with pip.  devstack never agreed to keep your firewall for you, and given it destroys everything else, this is not out of character.\n\n- out of 3 images (upstream, hp, rax), only rax has firewalld turned on.  it\u0027s not the common case.  the others boot with nothing\n\n- as an end-user there is an argument that this should be fixed upstream.  you\u0027re upstream, so I defer to you on that :)","accounts_in_message":[],"_revision_number":4},{"id":"f433dde68c80e0515c7a907fe45c0318baf69d20","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-14 09:54:29.000000000","message":"Patch Set 4:\n\n\u003e - this is guarded as f20 only; when it comes time to switch to f21 it will use the status quo\n\nAs someone running F20 it is of no consolation once you\u0027ve exposed my machine countless malicious attackers on the network\n\n\u003e - if firewalld is not removed/disabled by default, every developer is left to debug\n\u003e  why tempest/vms are running so slowly -- how else do they know to turn on the magic\n\u003e  flag?.  unless we do it by default (this change).  I *hate* spending hours debugging\n\u003e  a problem, only to find it\u0027s a known issue and I just needed to turn this or that\n\u003e  hidden knob \n\nOut of the total number of people running devstack, I venture to suggest that the percentage\nwho also run tempest is in single figures. The severity of the problem of slow VMs under\ntempest does not justify making *every* single developers\u0027 machines more insecure by disabling\ntheir firewall.\n\n\u003e - just before this we turn off selinux (one day I hope to get it on, lower priority\n\u003e than getting the job working) and then we proceed to destroy the system with pip. \n\u003e devstack never agreed to keep your firewall for you, and given it destroys everything\n\u003e else, this is not out of character.\n\nDisabling SELinux is clearly not great but is a much less severe action than disabling\nthe firewall IMHO. Yes, devstack does a lot of changes to the make but I would not\ncharacterize that as \"destroying everything\". After running devstack I expect that\nthe machine is broadly as functional as before, with the exception that more software\nis running. Some things like apache / mysql have been screwed around with, but that is\nfar from destroying the machine.  I certainly do not expect that devstack opens up the\nmachine to network attacks on any listening services.\n\n\u003e - out of 3 images (upstream, hp, rax), only rax has firewalld turned on.  it\u0027s not\n\u003e the common case.  the others boot with nothing\n\nWhat is in the cloud images doesn\u0027t concern me here as that is not what most\ndevelopers using devstack are running. Developers run devstack on laptops /\nservers they own with a \"standard\" Fedora installation which absolutely\nhas firewalld as the default integral part of the OS.\n\n\u003e - as an end-user there is an argument that this should be fixed upstream. \n\u003e you\u0027re upstream, so I defer to you on that :)\n\nAs I mentioned already this is already fixed upstream and in Fedora 21 and\nin the virt-preview add-on repo for Fedora 20. It is too risky to include\nthe change in standard Fedora 20 repos.","accounts_in_message":[],"_revision_number":4},{"id":"4fa04ba9c39c94529c193cb65023e7faa06cb0b9","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-14 10:14:49.000000000","message":"Patch Set 4:\n\n\u003e and in the virt-preview add-on repo for Fedora 20\n\nWhy don\u0027t we enable this repo?  is this unstable enough that it\u0027s going to cause more trouble than it\u0027s worth?  \n\nseems by using this we could be shaking out problems before the fedoraX+1 release day and easing everyone\u0027s pain at transition time","accounts_in_message":[],"_revision_number":4},{"id":"dfeddd2809eeeab0dc052b46b724f825714d0aec","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-14 10:21:03.000000000","message":"Patch Set 4:\n\nThe virt-preview repository is a rebuild of the packages from current rawhide with no QA testing applied. Stuff goes in there with little-to-no user testing. It is intended as a way for people who want to be able to test functionality from future Fedora without upgrading their entire distro to rawhide. It is not something you want to unconditionally enable because most OpenStack developers don\u0027t want to be used as guinea pigs for as yet untested libvirt/qemu packages - they just want to focus on getting their own OpenStack work right.","accounts_in_message":[],"_revision_number":4},{"id":"bc078afd41210f4b78bcece3cb37f96cdd20e7b2","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2014-08-14 10:38:56.000000000","message":"Patch Set 4: Code-Review-1\n\nFWIW - I fully agree with danpb on this - leaving users who run devstack with firewalld _removed_ by default is really not an acceptable way to deal with occasional gate failures. \n\nI cannot possibly see how this can be a prefered solution to https://review.openstack.org/#/c/113884/\n\nI will add a comment on there as well - but faced with these two choices - removing it in our CI vms only is by far more acceptable one, from the standpoint of devstack as a tool.","accounts_in_message":[],"_revision_number":4},{"id":"c69272b751e91c25dfe40c325b8ef59c4b82acf5","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-14 15:14:37.000000000","message":"Patch Set 4: Code-Review+2\n\nDaniel, running DevStack on a machine you care about is not a supported configuration. As you have noted publicly a number of times it makes assumptions about what it can do to its host and does them.  Joshua Harlow has a radically different approach which should be friendlier to \u0027pet\u0027 systems.\n\n\u003e Out of the total number of people running devstack, I venture to suggest that the percentage who also run tempest is in single figures. The severity of the problem of slow VMs under tempest does not justify making *every* single developers\u0027 machines more insecure by disabling their firewall.\n\nI\u0027ll suggest that the percentage of developers running DevStack on Fedora is smaller than you imagine. This is only a problem for devs running F20 on a machine that needs to protect itself from a hostile network without help.  firewalld may be that help, but then you are running an app on your firewall.  An app which itself takes great liberties with iptables directly.\n\nSadly, security and devstack do not belong in the same sentence.  I honestly hate that.  We do occasionally take steps to improve that situation.  But I assure you it will be a long time (possibly never) before I\u0027ll ever suggest that a DevStack build is the right model to secure OpenStack.  DevStack is a 20lb sledge hammer and security is finish nails.\n\n\u003e Developers run devstack on laptops / servers they own with a \"standard\" Fedora installation which absolutely has firewalld as the default integral part of the OS.\n\nThat sounds like what happens at your job, but I haven\u0027t seen that situation yet first hand.  Developers run DevStack in virtual machines, either locally on laptops/servers they own or in some cloud somewhere (including AWS).","accounts_in_message":[],"_revision_number":4},{"id":"f04db0a3266905512778d30a6a6172eb5c7860f2","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-14 15:23:41.000000000","message":"Patch Set 4:\n\nThere are certainly things devstack does to a system which are not nice, but it is the only supported option we have for openstack development whether or not it is intended for \"pet\" machines at all. This is not an argument for making devstack ever more hostile to people\u0027s machines. Also note that running with firewalld is an supported scenario in production deployments on Fedora \u0026 RHEL, so unconditionally disabling this means devs won\u0027t be exercising the codepath that real deployments will. So I really fail to see any credible justification for why this needs to be inflicted on every developer instead of simply temporarily disable in the gate CI config as proposed earlier.","accounts_in_message":[],"_revision_number":4},{"id":"db2dc0a7a4e319bb58df5708530628145d505416","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-14 22:42:38.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"91b7f5a3ffbad0fc4db55920aaec16b18fba4f78","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-14 22:42:39.000000000","message":"Patch Set 5:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"ee147f95c0d999b912ca795d31b9258ca63bcaf4","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-14 22:48:33.000000000","message":"Patch Set 5:\n\nhttps://review.openstack.org/#/c/113884/ will remove firewalld from *all* slaves.  This will solve the issue in the gate\n\nStopping devstack when it sees firewalld on f20 will avoid others having to debug this rather obscure issue.\n\nIf someone feels strongly enough that their f20 devstack host needs some firewalling, they can do that outside firewalld.","accounts_in_message":[],"_revision_number":5},{"id":"3755c8fba4e45f2ee30ceaf98f9e69002368e60b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-15 00:21:45.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/56/113856/5/check/check-tempest-dsvm-full/d1ef2e4 : SUCCESS in 49m 07s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/5/check/check-tempest-dsvm-postgres-full/5cdda73 : SUCCESS in 53m 33s\n- check-tempest-dsvm-neutron http://logs.openstack.org/56/113856/5/check/check-tempest-dsvm-neutron/c07598c : SUCCESS in 55m 17s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/5/check/check-tempest-dsvm-neutron-full/882e157 : SUCCESS in 1h 02m 50s (non-voting)\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/5/check/check-tempest-dsvm-neutron-heat-slow/f2bde9a : SUCCESS in 23m 53s\n- check-grenade-dsvm http://logs.openstack.org/56/113856/5/check/check-grenade-dsvm/9f1095a : SUCCESS in 49m 43s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/5/check/gate-tempest-dsvm-large-ops/20e798f : SUCCESS in 18m 04s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/5/check/gate-tempest-dsvm-neutron-large-ops/bc724e7 : SUCCESS in 21m 51s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/5/check/gate-devstack-bashate/0e2b46d : SUCCESS in 34s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/113856/5/check/check-devstack-dsvm-cells/3af6936 : SUCCESS in 17m 52s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/5/check/check-grenade-dsvm-partial-ncpu/34bc7dd : SUCCESS in 46m 01s\n- check-neutron-dsvm-functional http://logs.openstack.org/56/113856/5/check/check-neutron-dsvm-functional/8a7f195 : SUCCESS in 18m 34s\n- check-swift-dsvm-functional http://logs.openstack.org/56/113856/5/check/check-swift-dsvm-functional/5bd3d71 : SUCCESS in 19m 38s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/56/113856/5/check/check-tempest-dsvm-ironic-nv/b7e46b2 : SUCCESS in 33m 56s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/56/113856/5/check/check-tempest-dsvm-ironic-postgres-nv/c564bab : SUCCESS in 35m 48s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/56/113856/5/check/check-tempest-dsvm-virtual-ironic-nv/cb47540 : SUCCESS in 33m 16s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/56/113856/5/check/check-tempest-dsvm-f20/4e7d6b9 : FAILURE in 4m 51s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"5109b65ec5f6794efd5aa44d7597e24e42705b46","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-15 09:01:24.000000000","message":"Patch Set 5: Code-Review-1\n\nfirewalld is a valid solution to use in production deployments of OpenStack on Fedora \u0026 RHEL and as such developers need to be able to use this scenario during development. Blocking use of devstack when firewalld is running prevents that, even if they don\u0027t care about the performance hit because they\u0027re not using tempest at all or have a newer libvirt installed.\n\nHow about at the end of running devstack, after we print out the address of horizon, we do this:\n\n  if ...firewalld is running... and libvirt is less than 1.2.4...\n\n     echo \"WARNING: using firewalld in combination with libvirt \u003c 1.2.4 has a major performance penalty on VM startup\"\n     echo \"WARNING: recommend updating to newer libvirt or disabling firewalld as a workaround\"\n  fi\n\nthat will make it pretty obvious to developers without blocking valid usage scenarios for them","accounts_in_message":[],"_revision_number":5},{"id":"a9854aa37b66c9a0f05b1bb426a62cce7dbe4160","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-15 11:50:30.000000000","message":"Patch Set 5:\n\nf20+default libvirt+firewalld is *not* a valid solution.  If it can\u0027t run tempest in under 2 hours by default -- out-of-the-box without touching anything -- it is just as broken as if it were segfaulting.   devstack can not default to a case where tempest takes more than two hours because you happen to never run it.  nobody reads warnings\n\nnobody but me has seemed to notice this so it\u0027s a storm in a tea-cup anyway.  Or perhaps people tried fedora, their CI took 4 times as long as Ubuntu so they just said \"fedora is crap\" and moved on (who\u0027d blame them)","accounts_in_message":[],"_revision_number":5},{"id":"ec8b163355c952f55b8b3010d43f822cb06efd2f","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-15 11:57:31.000000000","message":"Patch Set 5:\n\nI\u0027ve proposed a patch which adds a highly visible warning message here:\n\nhttps://review.openstack.org/114513","accounts_in_message":[],"_revision_number":5},{"id":"b8cc1b27089fc774c60046a5d564ad96f33227a4","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-15 12:10:59.000000000","message":"Patch Set 5:\n\n\u003e f20+default libvirt+firewalld is *not* a valid solution. If it can\u0027t\n\u003e run tempest in under 2 hours by default -- out-of-the-box without\n\u003e touching anything -- it is just as broken as if it were segfaulting.\n\u003e devstack can not default to a case where tempest takes more than two\n\u003e hours because you happen to never run it. nobody reads warnings\n\u003e\n\u003e nobody but me has seemed to notice this so it\u0027s a storm in a tea-cup\n\u003e anyway. Or perhaps people tried fedora, their CI took 4 times as long\n\u003e as Ubuntu so they just said \"fedora is crap\" and moved on (who\u0027d blame them)\n\nThat no one has ever complained before suggests that in fact the performance\nimpact of firewalld is irrelevant for most people using devstack and thus has\nno need to forcably disable its usage for them. Unless you\u0027re running tempest,\nwhich few people do on a regular day-to-day basis, the peformance hit is not\na factor that impacts development at all. A warning message is perfectly\nsatisfactory to alert people to the potential problem - something devstack\nalready does in a number of other cases. Don\u0027t insult my intelligence by\nclaiming that people can\u0027t see / read such messages.","accounts_in_message":[],"_revision_number":5},{"id":"caea36405b4e7290a7e3d91230ba82aaa6a8c367","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-15 19:22:39.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"27fd2703a730c888443d082c8ef57517b9dc0fd2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-15 19:22:41.000000000","message":"Patch Set 6:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"a64b968399b92406fa842f656e2d42e15081aaff","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-15 19:29:41.000000000","message":"Patch Set 6:\n\nI\u0027ve taken the approach here to fix platform brokenness and make the defaults in DevStack closer to what runs in the gates. There are \u003e80 3rd party CIs running^H^H^H^H^Hregistered now, so making this change in devstack-gate does not fix all of the gates.\n\nThis changes the default behaviour so I added a flag FORCE_F20_FIREWALLD for those who have the desire/need to leave firewalld in place.  I believe the population of developers who know and want firewalld on F20 is significantly smaller than those who do not know or care.","accounts_in_message":[],"_revision_number":6},{"id":"5781799c3ab61345e4bde52779efb12a3ea74b04","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-15 20:49:12.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-full/2e9eaae : SUCCESS in 45m 06s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-postgres-full/b8f0163 : SUCCESS in 51m 15s\n- check-tempest-dsvm-neutron http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-neutron/406e7e7 : SUCCESS in 57m 14s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-neutron-full/ce95ff7 : SUCCESS in 1h 03m 29s (non-voting)\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-neutron-heat-slow/0b34bac : SUCCESS in 24m 39s\n- check-grenade-dsvm http://logs.openstack.org/56/113856/6/check/check-grenade-dsvm/50207f9 : SUCCESS in 46m 58s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/6/check/gate-tempest-dsvm-large-ops/8f5101c : SUCCESS in 20m 20s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/6/check/gate-tempest-dsvm-neutron-large-ops/3eef234 : SUCCESS in 22m 49s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/6/check/gate-devstack-bashate/214fb84 : SUCCESS in 8s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/113856/6/check/check-devstack-dsvm-cells/c915fca : SUCCESS in 16m 20s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/6/check/check-grenade-dsvm-partial-ncpu/71c17e2 : SUCCESS in 37m 17s\n- check-neutron-dsvm-functional http://logs.openstack.org/56/113856/6/check/check-neutron-dsvm-functional/d6eac1f : SUCCESS in 20m 04s\n- check-swift-dsvm-functional http://logs.openstack.org/56/113856/6/check/check-swift-dsvm-functional/17a7101 : SUCCESS in 19m 43s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-ironic-nv/e0cb4b9 : SUCCESS in 35m 41s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-ironic-postgres-nv/d0a2194 : SUCCESS in 38m 11s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-virtual-ironic-nv/8ce9b81 : FAILURE in 29m 56s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-f20/19070c6 : SUCCESS in 30m 21s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"1fbf5ec303a79d65e5cbb2dd524669185bc21e13","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-08-15 20:50:05.000000000","message":"Patch Set 6: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/56/113856/6/21953/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":6},{"id":"498cf33538e59d0a065ce48175ee20bb3101d356","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-15 23:16:15.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"e8c8422706e4799411aa6cbfd15aa64b80ecebb5","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2014-08-16 06:22:02.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6},{"id":"88863f75112a159653a7cfe60b481eddf8687312","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2014-08-18 08:57:59.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"632d3e0d7aecd1608a6397bece80298db1b88274","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-18 09:08:05.000000000","message":"Patch Set 6: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":6},{"id":"a521bc2616d1e7dbbb08cc62fc54f9ce64971599","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2014-08-18 15:13:21.000000000","message":"Patch Set 6: -Code-Review\n\nI remove my vote until I do not see Daniel Berrange\u0027s version,\nwhich sounds reasonable per the description.","accounts_in_message":[],"_revision_number":6},{"id":"c332b8e20156a82391d365033c1792c38681bdfd","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2014-08-18 22:02:46.000000000","message":"Patch Set 6: Code-Review-1\n\nI think Daniel\u0027s point is correct.  With that addressed, this approach lgtm.","accounts_in_message":[],"_revision_number":6},{"id":"c7aa14f90204d064b7e4a01b39a821a9be1c0295","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-18 22:02:46.000000000","message":"Patch Set 6: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"66bf7315b4155082409db8d3c03d9d142bdb7d32","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-18 23:35:27.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-dsvm-full http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-full/dce11c4 : SUCCESS in 47m 56s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-postgres-full/ef83629 : SUCCESS in 52m 18s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-neutron-full/bcdb0df : SUCCESS in 1h 05m 29s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-neutron-heat-slow/19c51f4 : SUCCESS in 25m 01s\n- check-grenade-dsvm http://logs.openstack.org/56/113856/6/check/check-grenade-dsvm/d478db2 : SUCCESS in 42m 35s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/6/check/gate-tempest-dsvm-large-ops/9bc09ab : SUCCESS in 26m 35s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/6/check/gate-tempest-dsvm-neutron-large-ops/b60b812 : SUCCESS in 24m 04s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/6/check/gate-devstack-bashate/6e4a0f9 : SUCCESS in 13s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/113856/6/check/check-devstack-dsvm-cells/d74f4ba : SUCCESS in 17m 04s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/6/check/check-grenade-dsvm-partial-ncpu/cb24bd9 : FAILURE in 32m 56s\n- check-neutron-dsvm-functional http://logs.openstack.org/56/113856/6/check/check-neutron-dsvm-functional/12e80e6 : SUCCESS in 19m 34s\n- check-swift-dsvm-functional http://logs.openstack.org/56/113856/6/check/check-swift-dsvm-functional/b2b98ca : SUCCESS in 19m 02s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-ironic-nv/33a40b7 : SUCCESS in 34m 56s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-ironic-postgres-nv/f0737bb : SUCCESS in 35m 24s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-virtual-ironic-nv/93e2a55 : SUCCESS in 36m 21s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/56/113856/6/check/check-tempest-dsvm-f20/43616dc : SUCCESS in 33m 06s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"735dbc765eb8ae30f7ad2f2f5eb85a31736630e2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-19 19:11:07.000000000","message":"Patch Set 6:\n\n(3 comments)\n\nRefinement of FORCE_* flag patchset","accounts_in_message":[],"_revision_number":6},{"id":"76eba938f5ac30e583e084e979f36b487d6e7b52","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-19 19:11:23.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"5f461a8b6fffe661fd90bb8c21f0827e538a05a6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-19 19:12:11.000000000","message":"Patch Set 7:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"068f72b791a676ee569f69f52a5cb55609de62a6","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-19 19:23:42.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"af4871973d77db4c9b2d6ba4df71fce4f9853c9b","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-08-19 20:39:52.000000000","message":"Patch Set 7: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/56/113856/7/22311/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":7},{"id":"791d1c7853f5e21e2159e62ddc74e2d7a6d06453","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-19 21:48:04.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-dsvm-full http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-full/b1a3574 : SUCCESS in 49m 30s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-postgres-full/68bc49b : SUCCESS in 43m 42s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-neutron-full/ba7de84 : SUCCESS in 56m 07s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-neutron-heat-slow/23a8839 : SUCCESS in 25m 25s\n- check-grenade-dsvm http://logs.openstack.org/56/113856/7/check/check-grenade-dsvm/5ec50cd : SUCCESS in 44m 01s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/7/check/gate-tempest-dsvm-large-ops/b7a1e8b : SUCCESS in 20m 03s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/7/check/gate-tempest-dsvm-neutron-large-ops/87ffa58 : SUCCESS in 24m 00s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/7/check/gate-devstack-bashate/21ca4ce : SUCCESS in 35s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/113856/7/check/check-devstack-dsvm-cells/54866c5 : SUCCESS in 14m 41s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/7/check/check-grenade-dsvm-partial-ncpu/d71c938 : FAILURE in 27m 46s\n- check-neutron-dsvm-functional http://logs.openstack.org/56/113856/7/check/check-neutron-dsvm-functional/aac3409 : SUCCESS in 19m 12s\n- check-swift-dsvm-functional http://logs.openstack.org/56/113856/7/check/check-swift-dsvm-functional/a85b3bd : SUCCESS in 20m 54s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-ironic-nv/8e0dd1e : SUCCESS in 36m 47s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-ironic-postgres-nv/c19bd6c : SUCCESS in 35m 57s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-virtual-ironic-nv/6f9ce92 : SUCCESS in 36m 20s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-f20/1e15608 : SUCCESS in 37m 32s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"59fbfbd5ab7d8a4520de0ed341bf8a30c7f189cf","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-20 04:15:41.000000000","message":"Patch Set 7:\n\nrecheck bug 1334272","accounts_in_message":[],"_revision_number":7},{"id":"a1efdfed1430e1e462d61ffde3361643ab8c8321","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-20 05:05:19.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-full/d547a6b : SUCCESS in 49m 31s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-postgres-full/b6b954e : SUCCESS in 42m 40s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-neutron-full/fe48c75 : SUCCESS in 44m 47s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-neutron-heat-slow/724e25c : SUCCESS in 23m 09s\n- check-grenade-dsvm http://logs.openstack.org/56/113856/7/check/check-grenade-dsvm/a2e1938 : SUCCESS in 39m 42s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/7/check/gate-tempest-dsvm-large-ops/b20aece : SUCCESS in 26m 18s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/7/check/gate-tempest-dsvm-neutron-large-ops/2beb879 : SUCCESS in 25m 04s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/7/check/gate-devstack-bashate/7292d4f : SUCCESS in 11s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/113856/7/check/check-devstack-dsvm-cells/8e8ff61 : SUCCESS in 16m 48s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/7/check/check-grenade-dsvm-partial-ncpu/c700bbe : SUCCESS in 43m 54s\n- check-neutron-dsvm-functional http://logs.openstack.org/56/113856/7/check/check-neutron-dsvm-functional/f2c7163 : SUCCESS in 14m 23s\n- check-swift-dsvm-functional http://logs.openstack.org/56/113856/7/check/check-swift-dsvm-functional/d694f84 : SUCCESS in 18m 42s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-ironic-nv/baa5f7c : SUCCESS in 36m 41s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-ironic-postgres-nv/a8fd5c1 : SUCCESS in 30m 12s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-virtual-ironic-nv/b800c62 : SUCCESS in 34m 50s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-f20/0d6f1df : SUCCESS in 38m 40s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"bb1ce9c4adbe3230e69022b4a7f8933a5d77ddfc","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-20 08:55:20.000000000","message":"Patch Set 7: Code-Review-1\n\nNo response to my previous feedback which outlines a much more generally useful solution than what you\u0027ve done here.","accounts_in_message":[],"_revision_number":7},{"id":"a169915fa907fd6908bc0cd8ebb9dd721d8d3731","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-20 15:56:11.000000000","message":"Patch Set 7:\n\ndanpb, the response was (and is): DevStack is not in the business of configuring networking more than what is required for Nova-Net or Neutron.  We\u0027ll leave well enough alone except for addressing brokenness (this review) as needed.\n\nCan you show me how to undo the network config effects of launching a server using either Nova-Network or Neutron?","accounts_in_message":[],"_revision_number":7},{"id":"99d4382e6df222d5297f7f4c586254cc5e53df27","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-20 16:13:38.000000000","message":"Patch Set 7:\n\n\u003e danpb, the response was (and is): DevStack is not in the business of configuring networking more than what is required for Nova-Net or Neutron. We\u0027ll leave well enough alone except for addressing brokenness (this review) as needed.\n\nThat doesn\u0027t make any sense at all. Throughout OpenStack there are a variety of underlying OS technologies that can be used in combination with the OpenStack layer and devstack has support for explicitly turning on/off these options. Supporting an explicit choice of iptables vs firewalld is no different to the countless other things devstack configures.","accounts_in_message":[],"_revision_number":7},{"id":"1cbdb311431fd89d993009eca3a17a2d133b8227","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-20 16:40:42.000000000","message":"Patch Set 7:\n\nWhen Docker was still supported we required them to do the basic Docker installation and configuration before stack.sh ran.  It was in a script in tools so it was in the repo, but otherwise DevStack stayed out of preparing the system.  OpenDaylight was in a similar situation, Kyle and I came up with a split that seems to have worked.  On the other hand, Ceph is completely installed from within lib/ceph when it is enabled.\n\nAs you can see, there isn\u0027t a lot of consistency in regard to extra-curricular services.  But there was a demand for all of them in one way or another.  I do not see any demand (before your request) for adding basic network firewall configuration to DevStack, nor do I see why it should be included.  If Nova-Net or Neutron needed it that would be different.  And if there was, it would be in an additional review anyway.","accounts_in_message":[],"_revision_number":7},{"id":"606d7bca5ff4cd4972903df7afe6af1df70da911","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-08-22 19:10:42.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nI agree with dean, we\u0027re allowed to take opinions here, and this is one of them.","accounts_in_message":[],"_revision_number":7},{"id":"b0beafcbb837b3ea694f1337786c2620732012c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-22 19:10:43.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"233f79d13f1f88276185fdfa907f9c0254d2049b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-23 08:30:05.000000000","message":"Patch Set 7: Verified-2\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-tempest-dsvm-full http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-full/cae08ce : SUCCESS in 54m 46s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-postgres-full/7e0a9db : SUCCESS in 56m 23s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-neutron-full/2602ae0 : SUCCESS in 1h 00m 03s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-neutron-heat-slow/d314dc7 : SUCCESS in 24m 16s\n- gate-grenade-dsvm http://logs.openstack.org/56/113856/7/gate/gate-grenade-dsvm/6974221 : SUCCESS in 47m 57s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-large-ops/e3b543f : SUCCESS in 21m 36s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-neutron-large-ops/4359690 : SUCCESS in 20m 40s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/7/gate/gate-devstack-bashate/b72b86c : SUCCESS in 21s\n- gate-devstack-dsvm-cells http://logs.openstack.org/56/113856/7/gate/gate-devstack-dsvm-cells/c6de5b1 : SUCCESS in 15m 38s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/7/gate/gate-grenade-dsvm-partial-ncpu/20fcd3b : FAILURE in 22m 20s\n- gate-neutron-dsvm-functional http://logs.openstack.org/56/113856/7/gate/gate-neutron-dsvm-functional/e89d40b : SUCCESS in 24m 46s\n- gate-swift-dsvm-functional http://logs.openstack.org/56/113856/7/gate/gate-swift-dsvm-functional/d7c60b6 : SUCCESS in 23m 24s","accounts_in_message":[],"_revision_number":7},{"id":"aad4bf5466887bc62b67ee544613046b2b46bd56","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-23 23:21:42.000000000","message":"Patch Set 7:\n\nreverify bug 1213212","accounts_in_message":[],"_revision_number":7},{"id":"1a47f625044c9ac709a33384778d9e4107f0824f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-24 00:20:30.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-full/d529c01 : SUCCESS in 55m 46s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-postgres-full/c04f9c4 : SUCCESS in 58m 43s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-neutron-full/0753280 : SUCCESS in 52m 33s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-neutron-heat-slow/a08fae0 : SUCCESS in 20m 52s\n- check-grenade-dsvm http://logs.openstack.org/56/113856/7/check/check-grenade-dsvm/61db0b1 : SUCCESS in 41m 44s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/7/check/gate-tempest-dsvm-large-ops/9f11308 : SUCCESS in 26m 59s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/7/check/gate-tempest-dsvm-neutron-large-ops/942fed9 : SUCCESS in 24m 38s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/7/check/gate-devstack-bashate/4ff818f : SUCCESS in 12s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/113856/7/check/check-devstack-dsvm-cells/09f31e7 : SUCCESS in 17m 38s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/7/check/check-grenade-dsvm-partial-ncpu/42ac404 : SUCCESS in 58m 19s\n- check-neutron-dsvm-functional http://logs.openstack.org/56/113856/7/check/check-neutron-dsvm-functional/b0759c8 : SUCCESS in 18m 47s\n- check-swift-dsvm-functional http://logs.openstack.org/56/113856/7/check/check-swift-dsvm-functional/78e25d1 : SUCCESS in 20m 21s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-ironic-nv/013d8b0 : SUCCESS in 32m 21s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-ironic-postgres-nv/baefdbc : SUCCESS in 40m 27s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-virtual-ironic-nv/58a691f : SUCCESS in 34m 02s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/56/113856/7/check/check-tempest-dsvm-f20/7ba2b07 : SUCCESS in 33m 25s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"25e474fe6ea30314fc31392cd7d03cd930df7c37","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-24 00:20:31.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"420d121707d82696c929e73a3a20728dd6c4e398","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-24 01:23:14.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded.\n\n- gate-tempest-dsvm-full http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-full/65a66f4 : SUCCESS in 42m 27s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-postgres-full/c8ad183 : SUCCESS in 58m 13s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-neutron-full/d315738 : SUCCESS in 1h 02m 38s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-neutron-heat-slow/172c39a : SUCCESS in 19m 54s\n- gate-grenade-dsvm http://logs.openstack.org/56/113856/7/gate/gate-grenade-dsvm/6f2258a : SUCCESS in 37m 52s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-large-ops/498d07f : SUCCESS in 19m 06s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/113856/7/gate/gate-tempest-dsvm-neutron-large-ops/d3c855f : SUCCESS in 24m 58s\n- gate-devstack-bashate http://logs.openstack.org/56/113856/7/gate/gate-devstack-bashate/15a3e86 : SUCCESS in 13s\n- gate-devstack-dsvm-cells http://logs.openstack.org/56/113856/7/gate/gate-devstack-dsvm-cells/c594b84 : SUCCESS in 14m 34s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/56/113856/7/gate/gate-grenade-dsvm-partial-ncpu/884d126 : SUCCESS in 36m 31s\n- gate-neutron-dsvm-functional http://logs.openstack.org/56/113856/7/gate/gate-neutron-dsvm-functional/c3046e3 : SUCCESS in 16m 58s\n- gate-swift-dsvm-functional http://logs.openstack.org/56/113856/7/gate/gate-swift-dsvm-functional/27dc799 : SUCCESS in 16m 23s","accounts_in_message":[],"_revision_number":7},{"id":"e778d1b85c18eb864987358a2f9e30e6095f0c37","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-24 01:23:15.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"85ebb3a868560c5272c0c8a16a99d5073edcad1e","revisions":{"76f40cd7a26b69d24d6236cc2b17d35202d19375":{"kind":"REWORK","_number":1,"created":"2014-08-13 11:44:44.000000000","uploader":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"ref":"refs/changes/56/113856/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/56/113856/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/56/113856/1"}}},"commit":{"parents":[{"commit":"fe3be5c38eb35f1f8c604b30e12745644c807869","subject":"Merge \"Don\u0027t set tunnel_types on VLAN network type\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fe3be5c38eb35f1f8c604b30e12745644c807869"}]}],"author":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2014-08-13 11:36:48.000000000","tz":120},"committer":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2014-08-13 11:44:05.000000000","tz":120},"subject":"Do not use firewalld","message":"Do not use firewalld\n\nLibvirt is significantly slower when it used together with firewalld.\n\nThe firewalld previously attempted to be started, to hide the differences\nbetween cloud images.\n\nNow it will be stopped an all instances in-order to behave as the official\n f20 cloud image (no firewalld).\n\nSee also:\nhttp://lists.openstack.org/pipermail/openstack-infra/2014-August/001715.html\n\nChange-Id: I5252a12223a35f7fb7a4ac3c58aa4a3cd1bc4799\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/76f40cd7a26b69d24d6236cc2b17d35202d19375"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/76f40cd7a26b69d24d6236cc2b17d35202d19375"}]},"branch":"refs/heads/master"},"e36283e358120f32613606a78bc0edefd235f327":{"kind":"REWORK","_number":2,"created":"2014-08-13 12:14:56.000000000","uploader":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"ref":"refs/changes/56/113856/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/56/113856/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/56/113856/2"}}},"commit":{"parents":[{"commit":"fe3be5c38eb35f1f8c604b30e12745644c807869","subject":"Merge \"Don\u0027t set tunnel_types on VLAN network type\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fe3be5c38eb35f1f8c604b30e12745644c807869"}]}],"author":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2014-08-13 11:36:48.000000000","tz":120},"committer":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2014-08-13 12:14:18.000000000","tz":120},"subject":"Do not use firewalld on gate by default","message":"Do not use firewalld on gate by default\n\nLibvirt is significantly slower when it used together with firewalld,\nat the moment.\n\nThe firewalld previously attempted to be started, to hide the differences\nbetween cloud images, now using or not using firewalld will bo\nconfigure-able by the LIBVIRT_USE_FIREWALLD. Default False.\n\nSee also:\nhttp://lists.openstack.org/pipermail/openstack-infra/2014-August/001715.html\n\nChange-Id: I5252a12223a35f7fb7a4ac3c58aa4a3cd1bc4799\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e36283e358120f32613606a78bc0edefd235f327"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e36283e358120f32613606a78bc0edefd235f327"}]},"branch":"refs/heads/master"},"d2dea63362ae59c62baf3fb1fdef95e69f569745":{"kind":"REWORK","_number":3,"created":"2014-08-13 22:21:53.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/56/113856/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/56/113856/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/56/113856/3"}}},"commit":{"parents":[{"commit":"0824c175ce5df32f81877c785d82cd79f7c8ce83","subject":"Merge \"Add MAINTAINERS.rst\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0824c175ce5df32f81877c785d82cd79f7c8ce83"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-08-13 22:19:01.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-08-13 22:19:01.000000000","tz":600},"subject":"Remove firewalld on Fedora 20","message":"Remove firewalld on Fedora 20\n\nfirewalld interacts badly with the libvirt on f20, causing slow-downs\nso great that it can timeout the gate.\n\nChange-Id: I5252a12223a35f7fb7a4ac3c58aa4a3cd1bc4799\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d2dea63362ae59c62baf3fb1fdef95e69f569745"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d2dea63362ae59c62baf3fb1fdef95e69f569745"}]},"branch":"refs/heads/master"},"c1ba72214b4aa0a6a75db9e94cfb571ecdb563e6":{"kind":"REWORK","_number":4,"created":"2014-08-14 00:04:16.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/56/113856/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/56/113856/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/56/113856/4"}}},"commit":{"parents":[{"commit":"0824c175ce5df32f81877c785d82cd79f7c8ce83","subject":"Merge \"Add MAINTAINERS.rst\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0824c175ce5df32f81877c785d82cd79f7c8ce83"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-08-13 22:19:01.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-08-14 00:03:55.000000000","tz":600},"subject":"Remove firewalld on Fedora 20","message":"Remove firewalld on Fedora 20\n\nfirewalld interacts badly with the libvirt on f20, causing slow-downs\nso great that it can timeout the gate.\n\nChange-Id: I5252a12223a35f7fb7a4ac3c58aa4a3cd1bc4799\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c1ba72214b4aa0a6a75db9e94cfb571ecdb563e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c1ba72214b4aa0a6a75db9e94cfb571ecdb563e6"}]},"branch":"refs/heads/master"},"be784b5aebbbcaa6b1055542aac01586bd6829cb":{"kind":"REWORK","_number":5,"created":"2014-08-14 22:42:38.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/56/113856/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/56/113856/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/56/113856/5"}}},"commit":{"parents":[{"commit":"0824c175ce5df32f81877c785d82cd79f7c8ce83","subject":"Merge \"Add MAINTAINERS.rst\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0824c175ce5df32f81877c785d82cd79f7c8ce83"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-08-13 22:19:01.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-08-14 22:41:03.000000000","tz":600},"subject":"Halt if firewalld found on Fedora 20","message":"Halt if firewalld found on Fedora 20\n\nfirewalld interacts badly with the libvirt on f20, causing slow-downs\nso great that it can timeout the gate.\n\nTo avoid people having to debug this problem over and over, we stop\nthe devstack install.  We do not simply auto-remove firewalld, as some\npeople might like to ensure they have another firewall solution for\ntheir devstack machine.\n\nChange-Id: I5252a12223a35f7fb7a4ac3c58aa4a3cd1bc4799\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/be784b5aebbbcaa6b1055542aac01586bd6829cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/be784b5aebbbcaa6b1055542aac01586bd6829cb"}]},"branch":"refs/heads/master"},"dbf9f9fd6c1714e9f5c4734c1bad85de789ab977":{"kind":"REWORK","_number":6,"created":"2014-08-15 19:22:39.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/56/113856/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/56/113856/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/56/113856/6"}}},"commit":{"parents":[{"commit":"04a351133a5f4819df1a6474d5599900d55ae501","subject":"Source fixup_stuff...","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/04a351133a5f4819df1a6474d5599900d55ae501"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-08-13 22:19:01.000000000","tz":600},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-08-15 19:06:03.000000000","tz":-300},"subject":"Remove firewalld on Fedora 20 by default","message":"Remove firewalld on Fedora 20 by default\n\nfirewalld interacts badly with the libvirt on f20, causing slow-downs\nso great that it can timeout the gate.\n\nDevelopers who want to leave it enabled should set FORCE_F20_FIREWALLD\u003dTrue\n\nChange-Id: I5252a12223a35f7fb7a4ac3c58aa4a3cd1bc4799\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/dbf9f9fd6c1714e9f5c4734c1bad85de789ab977"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/dbf9f9fd6c1714e9f5c4734c1bad85de789ab977"}]},"branch":"refs/heads/master"},"85ebb3a868560c5272c0c8a16a99d5073edcad1e":{"kind":"REWORK","_number":7,"created":"2014-08-19 19:11:23.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/56/113856/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/56/113856/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/56/113856/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/56/113856/7"}}},"commit":{"parents":[{"commit":"04a351133a5f4819df1a6474d5599900d55ae501","subject":"Source fixup_stuff...","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/04a351133a5f4819df1a6474d5599900d55ae501"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-08-19 15:54:59.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-08-19 16:18:15.000000000","tz":-300},"subject":"Remove firewalld on Fedora 20 by default","message":"Remove firewalld on Fedora 20 by default\n\nfirewalld interacts badly with the libvirt on f20, causing slow-downs\nso great that it can timeout the gate.\n\nDevelopers who want to leave it enabled should set FORCE_FIREWALLD\u003dTrue\n\nChange-Id: I5252a12223a35f7fb7a4ac3c58aa4a3cd1bc4799\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/85ebb3a868560c5272c0c8a16a99d5073edcad1e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/85ebb3a868560c5272c0c8a16a99d5073edcad1e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}