)]}'
{"id":"openstack%2Fdevstack~114277","triplet_id":"openstack%2Fdevstack~master~Idaf377b8bf092d631bf77522af570faf2b47252a","project":"openstack/devstack","branch":"master","topic":"bug/1356946","hashtags":[],"change_id":"Idaf377b8bf092d631bf77522af570faf2b47252a","subject":"Fix check path of pxebin when variable isn\u0027t set","status":"ABANDONED","created":"2014-08-14 15:37:24.000000000","updated":"2014-12-05 14:31:34.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"39b13f202fb133799ad40f72810034fdf84f3e3b","_number":114277,"virtual_id_number":114277,"owner":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2014-08-22 07:25:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"date":"2014-12-05 14:31:34.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-08-19 20:00:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-08-19 20:00:12.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-08-22 07:25:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-12-05 14:31:34.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"1daafc760b214ef280e94dad3964715c6c0d91b2","author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"date":"2014-08-14 15:37:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c9d1684dcc54e60088221b2efa924a721829dba2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-14 15:37:25.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f7f733df9b23ab89624dd9c2103ffff3c46b03b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-14 16:51:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-full/4273e53 : SUCCESS in 47m 25s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-postgres-full/1996f96 : SUCCESS in 50m 27s\n- check-tempest-dsvm-neutron http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-neutron/5cd2231 : SUCCESS in 57m 10s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-neutron-full/be7900c : SUCCESS in 50m 08s (non-voting)\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-neutron-heat-slow/e0f0f5d : SUCCESS in 23m 55s\n- check-grenade-dsvm http://logs.openstack.org/77/114277/1/check/check-grenade-dsvm/a143e99 : SUCCESS in 40m 02s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/77/114277/1/check/gate-tempest-dsvm-large-ops/72207b4 : SUCCESS in 17m 27s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/77/114277/1/check/gate-tempest-dsvm-neutron-large-ops/75a0b3f : SUCCESS in 17m 28s\n- gate-devstack-bashate http://logs.openstack.org/77/114277/1/check/gate-devstack-bashate/08c8a3e : SUCCESS in 30s\n- check-devstack-dsvm-cells http://logs.openstack.org/77/114277/1/check/check-devstack-dsvm-cells/40c4208 : SUCCESS in 15m 19s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/77/114277/1/check/check-grenade-dsvm-partial-ncpu/039e431 : SUCCESS in 42m 39s\n- check-neutron-dsvm-functional http://logs.openstack.org/77/114277/1/check/check-neutron-dsvm-functional/b554989 : SUCCESS in 19m 30s\n- check-swift-dsvm-functional http://logs.openstack.org/77/114277/1/check/check-swift-dsvm-functional/f77a4c5 : SUCCESS in 17m 59s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-ironic-nv/82cd35b : SUCCESS in 36m 37s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-ironic-postgres-nv/28f5657 : SUCCESS in 35m 59s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-virtual-ironic-nv/971f52b : SUCCESS in 33m 48s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-f20/c129497 : SUCCESS in 1h 14m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f47a6cad6814ed8878a84ebe6587460c0c50eb02","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-19 20:00:12.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1ea9763179fdea7832c8f66500472e0a4e972ba1","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-19 20:00:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7b708071c3d9973c6fd254447e6cb1b5485ad5e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-19 22:15:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-full/64dee95 : SUCCESS in 39m 23s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-postgres-full/f675d68 : SUCCESS in 42m 50s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-neutron-full/ebf289e : SUCCESS in 42m 44s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-neutron-heat-slow/14755bc : SUCCESS in 24m 55s\n- check-grenade-dsvm http://logs.openstack.org/77/114277/1/check/check-grenade-dsvm/a3e9ee1 : SUCCESS in 39m 48s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/77/114277/1/check/gate-tempest-dsvm-large-ops/2a4d5d2 : SUCCESS in 21m 34s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/77/114277/1/check/gate-tempest-dsvm-neutron-large-ops/168c6e6 : SUCCESS in 24m 54s\n- gate-devstack-bashate http://logs.openstack.org/77/114277/1/check/gate-devstack-bashate/3734abf : SUCCESS in 1m 04s\n- check-devstack-dsvm-cells http://logs.openstack.org/77/114277/1/check/check-devstack-dsvm-cells/c661c3b : SUCCESS in 20m 30s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/77/114277/1/check/check-grenade-dsvm-partial-ncpu/ef35123 : SUCCESS in 35m 49s\n- check-neutron-dsvm-functional http://logs.openstack.org/77/114277/1/check/check-neutron-dsvm-functional/c0e5317 : SUCCESS in 19m 35s\n- check-swift-dsvm-functional http://logs.openstack.org/77/114277/1/check/check-swift-dsvm-functional/b7d1531 : SUCCESS in 23m 59s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-ironic-nv/cd6740c : SUCCESS in 30m 45s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-ironic-postgres-nv/399b5ec : SUCCESS in 31m 02s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-virtual-ironic-nv/8dcadc2 : SUCCESS in 38m 37s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/77/114277/1/check/check-tempest-dsvm-f20/6227f8d : SUCCESS in 35m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8b595bb7b7f4218da4236acb097060b8ed45b703","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-22 07:25:16.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"6e8fe47bb91f650478a9a8a2b6a4b775d5d7b7e1","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-12-05 14:31:34.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1},{"id":"54c420ebd3533b1b640182010e9a55c870a98d8b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-12-05 14:31:34.000000000","message":"Patch Set 1:\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3e3511672315c2fa612523bf8599376f7feddc42","revisions":{"3e3511672315c2fa612523bf8599376f7feddc42":{"kind":"REWORK","_number":1,"created":"2014-08-14 15:37:24.000000000","uploader":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"ref":"refs/changes/77/114277/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/77/114277/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/114277/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/114277/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/114277/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/77/114277/1"}}},"commit":{"parents":[{"commit":"6db41b9716c5a82a32818d87ad3af662ecc1382a","subject":"Merge \"Exact match rhel6\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6db41b9716c5a82a32818d87ad3af662ecc1382a"}]}],"author":{"name":"Felipe Reyes","email":"freyes@suse.com","date":"2014-08-14 15:31:33.000000000","tz":120},"committer":{"name":"Felipe Reyes","email":"freyes@suse.com","date":"2014-08-14 15:31:33.000000000","tz":120},"subject":"Fix check path of pxebin when variable isn\u0027t set","message":"Fix check path of pxebin when variable isn\u0027t set\n\nThis patch fixes the case where devstack is configured to install\nironic and the host OS isn\u0027t supported.\n\nHere is an example script to illustrate that the validation fails when $pxebin\nis not set:\n\n$ cat \u003e test.sh \u003c\u003cEOF\ntouch /tmp/foo\ntest -f /tmp \u0026\u0026 echo \"/tmp/foo is a file\"\ntest -f $bar \u0026\u0026 echo \"This shouldn\u0027t be printed\"\ntest -f \"$bar\" \u0026\u0026 echo \"This isn\u0027t printed\"\nbar\u003d/tmp/foo\ntest -f \"$bar\" \u0026\u0026 echo \"this is OK\"\nEOF\n$ bash -x test.sh\n+ touch /tmp/foo\n+ test -f /tmp\n+ test -f\n+ echo \u0027This shouldn\u0027\\\u0027\u0027t be printed\u0027\nThis shouldn\u0027t be printed\n+ test -f \u0027\u0027\n+ bar\u003d/tmp/foo\n+ test -f /tmp/foo\n+ echo \u0027this is OK\u0027\nthis is OK\n\nChange-Id: Idaf377b8bf092d631bf77522af570faf2b47252a\nCloses-Bug: 1356946\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3e3511672315c2fa612523bf8599376f7feddc42"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3e3511672315c2fa612523bf8599376f7feddc42"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}