)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d60996879056b5314b19d0fcad290881bf10b623","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This provides a way to test Ironic-python-agent code that is"},{"line_number":10,"context_line":"not yet merged."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I85084c383263173a33250592a95a17f46827b347"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_2c49c38b","line":11,"updated":"2014-08-25 21:34:10.000000000","message":"Does this need to reference the IPA blueprint in Ironic?","commit_id":"df11a66de1d87e6e911ba18990dbbb80ec0b75f8"}],"lib/ironic":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d60996879056b5314b19d0fcad290881bf10b623","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    ironic_ssh_check $IRONIC_SSH_KEY_DIR/$IRONIC_SSH_KEY_FILENAME $IRONIC_VM_SSH_ADDRESS $IRONIC_VM_SSH_PORT $IRONIC_SSH_USERNAME 10"},{"line_number":490,"context_line":"}"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"function build_ipa_ramdisk {"},{"line_number":493,"context_line":"    echo \"Building ironic-python-agent deploy ramdisk\""},{"line_number":494,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":495,"context_line":"    sudo apt-get update"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1abeadc6_ec67cb23","line":492,"updated":"2014-08-25 21:34:10.000000000","message":"A few things:\n\n1) This only supports the CoreOS image. It\u0027s the only one we have right now but might be worth saying explicitly here.\n\n2) So, we already have a script in ipa/imagebuild/coreos that should build a container from a trusty install. Now, it does setup and build in the same steps, but it should be easy to break up so that here, we only call a script with a couple of variables set.\n\nThis way if the build process changes, we can put it in one commit and have tests pass on old and new build methods rather than coordinating multiple repository merges with a gate breakage in the middle.","commit_id":"df11a66de1d87e6e911ba18990dbbb80ec0b75f8"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"dce0aa0e052292c09af9a394fe37e93a268105db","unresolved":false,"context_lines":[{"line_number":492,"context_line":"function build_ipa_ramdisk {"},{"line_number":493,"context_line":"    echo \"Building ironic-python-agent deploy ramdisk\""},{"line_number":494,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":495,"context_line":"    sudo apt-get update"},{"line_number":496,"context_line":"    sudo apt-get install -y docker.io"},{"line_number":497,"context_line":"    sudo ln -sf /usr/bin/docker.io /usr/local/bin/docker"},{"line_number":498,"context_line":"    sudo sed -i \u0027$acomplete -F _docker docker\u0027 /etc/bash_completion.d/docker.io"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7ac7a964_199a7263","line":495,"updated":"2014-08-15 03:11:21.000000000","message":"ubuntu only?  it should be using pkg install fns","commit_id":"df11a66de1d87e6e911ba18990dbbb80ec0b75f8"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"a24627170e7b8db800d8a2395553fae0f2527895","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    echo \"Building ironic-python-agent deploy ramdisk\""},{"line_number":494,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":495,"context_line":"    sudo apt-get update"},{"line_number":496,"context_line":"    sudo apt-get install -y docker.io"},{"line_number":497,"context_line":"    sudo ln -sf /usr/bin/docker.io /usr/local/bin/docker"},{"line_number":498,"context_line":"    sudo sed -i \u0027$acomplete -F _docker docker\u0027 /etc/bash_completion.d/docker.io"},{"line_number":499,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR/imagebuild/coreos/"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7ac7a964_e331830c","line":496,"updated":"2014-08-15 01:40:33.000000000","message":"Is there any reason not to add docker.io to files/apts/ironic?  Doing so would get it added to the devstack slaves package cache during image creation.  It would also remove the need to add a debian/ubuntu-ism directly inline, simplifying fedora support in the future.","commit_id":"df11a66de1d87e6e911ba18990dbbb80ec0b75f8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d60996879056b5314b19d0fcad290881bf10b623","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    echo \"Building ironic-python-agent deploy ramdisk\""},{"line_number":494,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":495,"context_line":"    sudo apt-get update"},{"line_number":496,"context_line":"    sudo apt-get install -y docker.io"},{"line_number":497,"context_line":"    sudo ln -sf /usr/bin/docker.io /usr/local/bin/docker"},{"line_number":498,"context_line":"    sudo sed -i \u0027$acomplete -F _docker docker\u0027 /etc/bash_completion.d/docker.io"},{"line_number":499,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR/imagebuild/coreos/"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1abeadc6_0c440773","line":496,"in_reply_to":"7ac7a964_e331830c","updated":"2014-08-25 21:34:10.000000000","message":"As a note; this installs an old version of Docker. For builds this may be OK but as time goes on this will get more out of date, which probably matters for a project that moves as fast as Docker. Not a reason for -1 but maybe something to look at in the future.","commit_id":"df11a66de1d87e6e911ba18990dbbb80ec0b75f8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bd7cbcf4ee5e491427f800efc7e86005dcdb5d0b","unresolved":false,"context_lines":[{"line_number":562,"context_line":"function build_ipa_ramdisk {"},{"line_number":563,"context_line":"    echo \"Building ironic-python-agent deploy ramdisk\""},{"line_number":564,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":565,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR"},{"line_number":566,"context_line":"    ./full_trusty_build.sh"},{"line_number":567,"context_line":"    cp UPLOAD/coreos_production_pxe_image-oem.cpio.gz $IRONIC_DEPLOY_RAMDISK_PATH"},{"line_number":568,"context_line":"    cp UPLOAD/coreos_production_pxe.vmlinuz $IRONIC_DEPLOY_KERNEL_PATH"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1abeadc6_e398b96c","line":565,"updated":"2014-08-25 22:38:40.000000000","message":"./full_trusty_build.sh is in imagebuild/coreos/ not the root of the repo... and is trusty specific (at least right now, although I suspect a patchset is coming...)","commit_id":"a04d0a9e3bc5776a6df38236984c28792310fcf3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3e1af8ad8d2cd430d3953b50f476017a16a8af41","unresolved":false,"context_lines":[{"line_number":562,"context_line":"function build_ipa_ramdisk {"},{"line_number":563,"context_line":"    echo \"Building ironic-python-agent deploy ramdisk\""},{"line_number":564,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":565,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR"},{"line_number":566,"context_line":"    ./full_trusty_build.sh"},{"line_number":567,"context_line":"    cp UPLOAD/coreos_production_pxe_image-oem.cpio.gz $IRONIC_DEPLOY_RAMDISK_PATH"},{"line_number":568,"context_line":"    cp UPLOAD/coreos_production_pxe.vmlinuz $IRONIC_DEPLOY_KERNEL_PATH"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1abeadc6_e33a79e6","line":565,"in_reply_to":"1abeadc6_e398b96c","updated":"2014-08-25 22:52:54.000000000","message":"Good catch, done","commit_id":"a04d0a9e3bc5776a6df38236984c28792310fcf3"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bd7cbcf4ee5e491427f800efc7e86005dcdb5d0b","unresolved":false,"context_lines":[{"line_number":582,"context_line":"    fi"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    if [ -z \"$IRONIC_DEPLOY_KERNEL\" -o -z \"$IRONIC_DEPLOY_RAMDISK\" ]; then"},{"line_number":585,"context_line":"        IRONIC_DEPLOY_KERNEL_PATH\u003d$TOP_DIR/files/ir-deploy.kernel"},{"line_number":586,"context_line":"        IRONIC_DEPLOY_RAMDISK_PATH\u003d$TOP_DIR/files/ir-deploy.initramfs"},{"line_number":587,"context_line":"    else"},{"line_number":588,"context_line":"        IRONIC_DEPLOY_KERNEL_PATH\u003d$IRONIC_DEPLOY_KERNEL"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1abeadc6_43c6cd4a","line":585,"updated":"2014-08-25 22:38:40.000000000","message":"Can we use a different name than the pxe driver uses? It should be very clear what deploy ramdisk is being used (pxe or ipa)","commit_id":"a04d0a9e3bc5776a6df38236984c28792310fcf3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3e1af8ad8d2cd430d3953b50f476017a16a8af41","unresolved":false,"context_lines":[{"line_number":582,"context_line":"    fi"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    if [ -z \"$IRONIC_DEPLOY_KERNEL\" -o -z \"$IRONIC_DEPLOY_RAMDISK\" ]; then"},{"line_number":585,"context_line":"        IRONIC_DEPLOY_KERNEL_PATH\u003d$TOP_DIR/files/ir-deploy.kernel"},{"line_number":586,"context_line":"        IRONIC_DEPLOY_RAMDISK_PATH\u003d$TOP_DIR/files/ir-deploy.initramfs"},{"line_number":587,"context_line":"    else"},{"line_number":588,"context_line":"        IRONIC_DEPLOY_KERNEL_PATH\u003d$IRONIC_DEPLOY_KERNEL"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1abeadc6_c3357df8","line":585,"in_reply_to":"1abeadc6_43c6cd4a","updated":"2014-08-25 22:52:54.000000000","message":"I disagree, I don\u0027t think it matters, we don\u0027t support using both in parallel at the moment.","commit_id":"a04d0a9e3bc5776a6df38236984c28792310fcf3"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4838b4d5ae7468c2485dbb27ec9208f8164a9e6b","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        pip_install diskimage_builder"},{"line_number":570,"context_line":"    fi"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    if [ -z \"$IRONIC_DEPLOY_KERNEL\" -o -z \"$IRONIC_DEPLOY_RAMDISK\" ]; then"},{"line_number":573,"context_line":"        local IRONIC_DEPLOY_KERNEL_PATH\u003d$TOP_DIR/files/ir-deploy.kernel"},{"line_number":574,"context_line":"        local IRONIC_DEPLOY_RAMDISK_PATH\u003d$TOP_DIR/files/ir-deploy.initramfs"},{"line_number":575,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1abeadc6_21061221","side":"PARENT","line":572,"updated":"2014-08-26 13:14:29.000000000","message":"If these are intended to be globals they should be documented and declared above next to IRONIC_DEPLOY_*_ID.\n\nOn the other hand, they really should be local as they are only used outside this function in the new ramdisk build function above and should be passed as arguments.","commit_id":"ddcde92e9098fdc3f43b56aa767a2ea584e402a9"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"0a9b8d7d4283dc38a3634584fb7921fe8646c10e","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        pip_install diskimage_builder"},{"line_number":570,"context_line":"    fi"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    if [ -z \"$IRONIC_DEPLOY_KERNEL\" -o -z \"$IRONIC_DEPLOY_RAMDISK\" ]; then"},{"line_number":573,"context_line":"        local IRONIC_DEPLOY_KERNEL_PATH\u003d$TOP_DIR/files/ir-deploy.kernel"},{"line_number":574,"context_line":"        local IRONIC_DEPLOY_RAMDISK_PATH\u003d$TOP_DIR/files/ir-deploy.initramfs"},{"line_number":575,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1abeadc6_ab8e4bce","side":"PARENT","line":572,"in_reply_to":"1abeadc6_21061221","updated":"2014-08-27 13:33:44.000000000","message":"Done","commit_id":"ddcde92e9098fdc3f43b56aa767a2ea584e402a9"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4838b4d5ae7468c2485dbb27ec9208f8164a9e6b","unresolved":false,"context_lines":[{"line_number":559,"context_line":"    ironic_ssh_check $IRONIC_SSH_KEY_DIR/$IRONIC_SSH_KEY_FILENAME $IRONIC_VM_SSH_ADDRESS $IRONIC_VM_SSH_PORT $IRONIC_SSH_USERNAME 10"},{"line_number":560,"context_line":"}"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"function build_ipa_ramdisk {"},{"line_number":563,"context_line":"    echo \"Building ironic-python-agent deploy ramdisk\""},{"line_number":564,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":565,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1abeadc6_c4448c1d","line":562,"updated":"2014-08-26 13:14:29.000000000","message":"It looks like this function name doesn\u0027t match what is called below.","commit_id":"fd0d3379f150ae0f9826ca7448faa10553226cc1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"0a9b8d7d4283dc38a3634584fb7921fe8646c10e","unresolved":false,"context_lines":[{"line_number":559,"context_line":"    ironic_ssh_check $IRONIC_SSH_KEY_DIR/$IRONIC_SSH_KEY_FILENAME $IRONIC_VM_SSH_ADDRESS $IRONIC_VM_SSH_PORT $IRONIC_SSH_USERNAME 10"},{"line_number":560,"context_line":"}"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"function build_ipa_ramdisk {"},{"line_number":563,"context_line":"    echo \"Building ironic-python-agent deploy ramdisk\""},{"line_number":564,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":565,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1abeadc6_0ba01f42","line":562,"in_reply_to":"1abeadc6_c4448c1d","updated":"2014-08-27 13:33:44.000000000","message":"Done","commit_id":"fd0d3379f150ae0f9826ca7448faa10553226cc1"},{"author":{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},"change_message_id":"97b32478845b463ea94b8baffd932220fc81967e","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            # we can build them only if we\u0027re not offline"},{"line_number":596,"context_line":"            if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":597,"context_line":"                if [ \"$IRONIC_DEPLOY_DRIVER\" \u003d\u003d \"agent_ssh\" ]; then"},{"line_number":598,"context_line":"                    build_ipa_coreos_ramdisk"},{"line_number":599,"context_line":"                else"},{"line_number":600,"context_line":"                    ramdisk-image-create $IRONIC_DEPLOY_FLAVOR \\"},{"line_number":601,"context_line":"                        -o $TOP_DIR/files/ir-deploy"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1abeadc6_53583756","line":598,"updated":"2014-08-26 17:12:41.000000000","message":"Suggest keeping this more descriptive name over the shorter one.","commit_id":"fd0d3379f150ae0f9826ca7448faa10553226cc1"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4838b4d5ae7468c2485dbb27ec9208f8164a9e6b","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            # we can build them only if we\u0027re not offline"},{"line_number":596,"context_line":"            if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":597,"context_line":"                if [ \"$IRONIC_DEPLOY_DRIVER\" \u003d\u003d \"agent_ssh\" ]; then"},{"line_number":598,"context_line":"                    build_ipa_coreos_ramdisk"},{"line_number":599,"context_line":"                else"},{"line_number":600,"context_line":"                    ramdisk-image-create $IRONIC_DEPLOY_FLAVOR \\"},{"line_number":601,"context_line":"                        -o $TOP_DIR/files/ir-deploy"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1abeadc6_e4f8a8c6","line":598,"updated":"2014-08-26 13:14:29.000000000","message":"This doesn\u0027t match the function declaration above any more.","commit_id":"fd0d3379f150ae0f9826ca7448faa10553226cc1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"0a9b8d7d4283dc38a3634584fb7921fe8646c10e","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            # we can build them only if we\u0027re not offline"},{"line_number":596,"context_line":"            if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":597,"context_line":"                if [ \"$IRONIC_DEPLOY_DRIVER\" \u003d\u003d \"agent_ssh\" ]; then"},{"line_number":598,"context_line":"                    build_ipa_coreos_ramdisk"},{"line_number":599,"context_line":"                else"},{"line_number":600,"context_line":"                    ramdisk-image-create $IRONIC_DEPLOY_FLAVOR \\"},{"line_number":601,"context_line":"                        -o $TOP_DIR/files/ir-deploy"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1abeadc6_6b8433b1","line":598,"in_reply_to":"1abeadc6_53583756","updated":"2014-08-27 13:33:44.000000000","message":"Done","commit_id":"fd0d3379f150ae0f9826ca7448faa10553226cc1"}]}