)]}'
{"id":"openstack%2Fdevstack~114513","triplet_id":"openstack%2Fdevstack~master~I1dc610dfb8966e6e4e70c19416ee85e332bde9f2","project":"openstack/devstack","branch":"master","topic":"firewalld-warn","hashtags":[],"change_id":"I1dc610dfb8966e6e4e70c19416ee85e332bde9f2","subject":"libvirt: display warning message if firewalld is enabled","status":"ABANDONED","created":"2014-08-15 11:56:44.000000000","updated":"2014-08-27 13:33:47.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0a65f03e971987a8e9ace13a9ce9ba59a16a2795","_number":114513,"virtual_id_number":114513,"owner":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-08-15 13:24:50.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2014-08-15 13:11:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-08-15 11:59:05.000000000","_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":-1,"date":"2014-08-26 17:08:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},{"value":-1,"date":"2014-08-18 08:18:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":-1,"date":"2014-08-15 12:10:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-08-15 12:10:46.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2014-08-15 13:11:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-08-15 13:24:50.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-08-18 08:18:31.000000000","updated_by":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"reviewer":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"state":"REVIEWER"},{"updated":"2014-08-26 17:08:16.000000000","updated_by":{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},"reviewer":{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},"state":"REVIEWER"}],"messages":[{"id":"d952e1eec9006ae965debcde7999c4c19fc2dadc","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-15 11:56:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bf4ed5850506183ab1c94b49fb0c9dd6c331b2b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-15 11:56:45.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"84b1f4675eab326991ccf6f1d2d0df77f86f8c14","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-15 11:59:05.000000000","message":"Patch Set 1:\n\nAs an example of what this does when run on Fedora 19/20:\n\n # ./stack.sh \n ....snip....\n 2014-08-15 11:55:14.300 | ++ /bin/true\n 2014-08-15 11:55:14.301 | + failures\u003d\n 2014-08-15 11:55:14.301 | + \u0027[\u0027 -n \u0027\u0027 \u0027]\u0027\n \n \n \n Horizon is now available at http://10.33.8.112/\n Keystone is serving at http://10.33.8.112:5000/v2.0/\n Examples on using novaclient command line is in exercise.sh\n The default users are: admin and demo\n The password: 123456\n This is your host ip: 10.33.8.112\n\n You are using Q_AGENT_EXTRA_AGENT_OPTS to pass configuration into /etc/neutron/neutron.conf.\n Please convert that configuration in localrc to a /etc/neutron/neutron.conf section in local.conf:\n Q_AGENT_EXTRA_AGENT_OPTS will be removed early in the \u0027K\u0027 development cycle\n\n [[post-config|/$Q_PLUGIN_CONF_FILE]]\n [DEFAULT]\n\n tunnel_types\u003dvxlan\n\n WARNING: \n WARNING: This host/distro is running firewalld and includes libvirt\n WARNING: less than 1.2.4. This combination of software results in a\n WARNING: significant (~ x18) performance slowdown for firewall\n WARNING: operations.\n WARNING: \n WARNING: It is recommended that you configure a different firewall\n WARNING: service and then restart libvirtd. If you continue to use\n WARNING: openstack with firewalld running, expect to see tempest\n WARNING: test suite timeout failures and slow VM boot times from\n WARNING: Nova in general. For further information read\n WARNING: \n WARNING: https://www.berrange.com/posts/2014/05/02/improving-libvirt-firewall-performance/\n WARNING:","accounts_in_message":[],"_revision_number":1},{"id":"5af3b110dd6b224c5048bb6648873f2229c23d74","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-15 12:10:46.000000000","message":"Patch Set 1: Code-Review-1\n\nIMO devstack should consider tempest not being able to run under the default timeouts provided by the upstream infrastructure (same infrastructure that is widely deployed as 3rd party CI) as a fatal problem, not a warning","accounts_in_message":[],"_revision_number":1},{"id":"c69a2bc593bd4f68468112e4a78d6081a3330328","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-15 12:18:49.000000000","message":"Patch Set 1:\n\nFundamentally being able to test \u0026 develop openstack with firewalld enabled *is* a valid \u0026 necessary development scenario to support. Unconditionally blocking use of devstack is not an acceptable solution, because it is taking the decision out of the hands of the developer. devstack is here to serve the needs of the developers.\n\nThose developers who care about tempest are more than intelligent enough to see the warning message \u0026 deal with it if they so desire.","accounts_in_message":[],"_revision_number":1},{"id":"a7f03920167e26f79e792b628b67ca259b5a4ecb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-15 13:11:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/13/114513/1/check/check-tempest-dsvm-full/8e267f8 : SUCCESS in 47m 12s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/13/114513/1/check/check-tempest-dsvm-postgres-full/bf7f31c : SUCCESS in 41m 48s\n- check-tempest-dsvm-neutron http://logs.openstack.org/13/114513/1/check/check-tempest-dsvm-neutron/c5b35e5 : SUCCESS in 52m 59s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/13/114513/1/check/check-tempest-dsvm-neutron-full/ded16f1 : SUCCESS in 51m 14s (non-voting)\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/13/114513/1/check/check-tempest-dsvm-neutron-heat-slow/c369b16 : SUCCESS in 23m 06s\n- check-grenade-dsvm http://logs.openstack.org/13/114513/1/check/check-grenade-dsvm/f5c55bd : SUCCESS in 44m 41s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/13/114513/1/check/gate-tempest-dsvm-large-ops/0f1fbb2 : SUCCESS in 24m 51s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/13/114513/1/check/gate-tempest-dsvm-neutron-large-ops/b755ca8 : SUCCESS in 19m 14s\n- gate-devstack-bashate http://logs.openstack.org/13/114513/1/check/gate-devstack-bashate/0634a77 : SUCCESS in 30s\n- check-devstack-dsvm-cells http://logs.openstack.org/13/114513/1/check/check-devstack-dsvm-cells/066d69f : SUCCESS in 13m 47s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/13/114513/1/check/check-grenade-dsvm-partial-ncpu/5f68ca7 : SUCCESS in 43m 58s\n- check-neutron-dsvm-functional http://logs.openstack.org/13/114513/1/check/check-neutron-dsvm-functional/ddc2e68 : SUCCESS in 18m 49s\n- check-swift-dsvm-functional http://logs.openstack.org/13/114513/1/check/check-swift-dsvm-functional/6676320 : SUCCESS in 18m 54s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/13/114513/1/check/check-tempest-dsvm-ironic-nv/2a56143 : SUCCESS in 34m 52s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/13/114513/1/check/check-tempest-dsvm-ironic-postgres-nv/3f353bc : SUCCESS in 39m 45s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/13/114513/1/check/check-tempest-dsvm-virtual-ironic-nv/eede3ff : FAILURE in 29m 24s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/13/114513/1/check/check-tempest-dsvm-f20/b45725a : SUCCESS in 1h 04m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2376216aa4768bae3417e0def7281a53f56f8314","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-08-15 13:24:50.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/13/114513/1/21876/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"aba4787c897bfe0b84749c3e338c8a8271fdb23e","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2014-08-18 08:18:31.000000000","message":"Patch Set 1: Code-Review-1\n\nPlease disable (stop/uninstall) firewalld by default on old libvirt.\nYou can add a key for force enable it.","accounts_in_message":[],"_revision_number":1},{"id":"3822b3def4027e48c493b388dde0061fc0f99392","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2014-08-18 08:21:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"64a63aa7d1a067819a9585edc760969c83027722","author":{"_account_id":7175,"name":"Robbie Harwood","email":"rharwood@redhat.com","username":"frozencemetery"},"date":"2014-08-26 17:08:16.000000000","message":"Patch Set 1: Code-Review-1\n\nI think I\u0027d rather have devstack turn off firewalld and log a message explaining how to turn it back on (forcing variable of some kind).  I\u0027d rather have the performance by default since many users do not want to think about their firewall setup.","accounts_in_message":[],"_revision_number":1},{"id":"b450c349160421682965d078747837732e7435de","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-08-27 13:33:47.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fcb8632664aa76a722da756c81a67d07f5ce4ecc","revisions":{"fcb8632664aa76a722da756c81a67d07f5ce4ecc":{"kind":"REWORK","_number":1,"created":"2014-08-15 11:56:44.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/13/114513/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/13/114513/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/13/114513/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/13/114513/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/13/114513/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/13/114513/1"}}},"commit":{"parents":[{"commit":"735f4d340f5772bac29c1aa23fdfb5e2df500ca3","subject":"Merge \"Hide output when configuring apt retry\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/735f4d340f5772bac29c1aa23fdfb5e2df500ca3"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2014-08-15 11:11:05.000000000","tz":60},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2014-08-15 11:56:05.000000000","tz":60},"subject":"libvirt: display warning message if firewalld is enabled","message":"libvirt: display warning message if firewalld is enabled\n\nLibvirt versions \u003c 1.2.4 are very inefficient at talking to\nfirewalld. This results in slow VM startup/shutdown which\nin turn causes tempest to often time out.\n\nDisplay a warning if firewalld is enabled on distros which\ncommonly have this inefficient combination enabled, so that\ndevelopers can decide whether to disable firewalld or to\nupdate their libvirt or ignore the problem.\n\nChange-Id: I1dc610dfb8966e6e4e70c19416ee85e332bde9f2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fcb8632664aa76a722da756c81a67d07f5ce4ecc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fcb8632664aa76a722da756c81a67d07f5ce4ecc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}