)]}'
{"id":"openstack%2Fdevstack~115066","triplet_id":"openstack%2Fdevstack~master~I77968849ebd3e3bebd2e5929b87b60fc1b6541bf","project":"openstack/devstack","branch":"master","topic":"bug/1333321","hashtags":[],"change_id":"I77968849ebd3e3bebd2e5929b87b60fc1b6541bf","subject":"Guard for worlddump in case LOGDIR is undefined","status":"MERGED","created":"2014-08-18 18:55:25.000000000","updated":"2014-08-19 20:39:27.000000000","submitted":"2014-08-19 20:39:27.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3495b7c4586c74a41aaf446b7b4b1b8082c70c89","_number":115066,"virtual_id_number":115066,"owner":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2014-08-18 20:19:17.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":2,"date":"2014-08-19 20:39:27.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-08-19 19:40:49.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2014-08-18 23:47:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-08-19 19:40:49.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-08-18 20:19:17.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-08-18 23:47:48.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2014-08-19 19:40:49.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-08-19 20:39:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"00cf12ec1bb75cccc036a0b9b40f0ce276f41d76","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2014-08-18 18:55:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f56af1586957208c7dc69c8bece553ee56794f1d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-18 18:55:26.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"388c973ecf4156daeb587e52692f8390c75118ba","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-18 20:17:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/66/115066/1/check/check-tempest-dsvm-full/3821cb9 : SUCCESS in 36m 56s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/66/115066/1/check/check-tempest-dsvm-postgres-full/52ed561 : SUCCESS in 51m 29s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/66/115066/1/check/check-tempest-dsvm-neutron-full/2c46b24 : SUCCESS in 1h 08m 07s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/66/115066/1/check/check-tempest-dsvm-neutron-heat-slow/87e76eb : SUCCESS in 24m 04s\n- check-grenade-dsvm http://logs.openstack.org/66/115066/1/check/check-grenade-dsvm/bc8a096 : SUCCESS in 37m 21s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/66/115066/1/check/gate-tempest-dsvm-large-ops/8c4364e : SUCCESS in 24m 53s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/66/115066/1/check/gate-tempest-dsvm-neutron-large-ops/4269967 : SUCCESS in 19m 02s\n- gate-devstack-bashate http://logs.openstack.org/66/115066/1/check/gate-devstack-bashate/a0fdcfe : SUCCESS in 46s\n- check-devstack-dsvm-cells http://logs.openstack.org/66/115066/1/check/check-devstack-dsvm-cells/1de3d0f : SUCCESS in 19m 09s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/66/115066/1/check/check-grenade-dsvm-partial-ncpu/5101306 : SUCCESS in 37m 28s\n- check-neutron-dsvm-functional http://logs.openstack.org/66/115066/1/check/check-neutron-dsvm-functional/ce66fcf : SUCCESS in 15m 59s\n- check-swift-dsvm-functional http://logs.openstack.org/66/115066/1/check/check-swift-dsvm-functional/dde252c : SUCCESS in 17m 22s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/66/115066/1/check/check-tempest-dsvm-ironic-nv/36ea779 : SUCCESS in 37m 14s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/66/115066/1/check/check-tempest-dsvm-ironic-postgres-nv/fdec013 : SUCCESS in 38m 43s (non-voting)\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/66/115066/1/check/check-tempest-dsvm-virtual-ironic-nv/74b3cba : SUCCESS in 33m 40s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/66/115066/1/check/check-tempest-dsvm-f20/0c3dfda : SUCCESS in 1h 15m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9095f03e042977c43e35f08732b05927e9386a29","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-08-18 20:19:17.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/66/115066/1/22104/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"d75148a19140aa3a5eb927e0cd950f840589f549","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-08-18 23:47:48.000000000","message":"Patch Set 1: Code-Review+2\n\nI also like to see worlddump.py directing to stdout if -d isn\u0027t set ... seems it will currently just dump the file in \u0027.\u0027","accounts_in_message":[],"_revision_number":1},{"id":"7787934c9577fded042d7a7ec67413ea9595f7db","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-19 19:40:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nIan, I think I agree, but we\u0027d need to check with Sean, he may have had a reason for that behaviour.","accounts_in_message":[],"_revision_number":1},{"id":"cabed46968c657ceac8493ab2e9680585532d0ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-19 19:40:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"395204b307ef852cfbf2c17c8a92169982d6ad5e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-19 20:39:27.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"6b5abe3ebc107551d3947ee289d56744fe18a1b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-19 20:39:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded.\n\n- gate-tempest-dsvm-full http://logs.openstack.org/66/115066/1/gate/gate-tempest-dsvm-full/6b6b721 : SUCCESS in 43m 43s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/66/115066/1/gate/gate-tempest-dsvm-postgres-full/f64c390 : SUCCESS in 41m 29s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/66/115066/1/gate/gate-tempest-dsvm-neutron-full/484a4bd : SUCCESS in 48m 54s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/66/115066/1/gate/gate-tempest-dsvm-neutron-heat-slow/813fb65 : SUCCESS in 24m 52s\n- gate-grenade-dsvm http://logs.openstack.org/66/115066/1/gate/gate-grenade-dsvm/2d7e172 : SUCCESS in 33m 27s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/66/115066/1/gate/gate-tempest-dsvm-large-ops/da802ba : SUCCESS in 20m 04s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/66/115066/1/gate/gate-tempest-dsvm-neutron-large-ops/cb12752 : SUCCESS in 17m 45s\n- gate-devstack-bashate http://logs.openstack.org/66/115066/1/gate/gate-devstack-bashate/cb48b90 : SUCCESS in 20s\n- gate-devstack-dsvm-cells http://logs.openstack.org/66/115066/1/gate/gate-devstack-dsvm-cells/0feeb0d : SUCCESS in 17m 17s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/66/115066/1/gate/gate-grenade-dsvm-partial-ncpu/fcaf69e : SUCCESS in 34m 30s\n- gate-neutron-dsvm-functional http://logs.openstack.org/66/115066/1/gate/gate-neutron-dsvm-functional/5d969f3 : SUCCESS in 21m 42s\n- gate-swift-dsvm-functional http://logs.openstack.org/66/115066/1/gate/gate-swift-dsvm-functional/aecfa94 : SUCCESS in 19m 18s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2696e5a0676c1ba39ee7f97b48ef65f5dc986d4f","revisions":{"2696e5a0676c1ba39ee7f97b48ef65f5dc986d4f":{"kind":"REWORK","_number":1,"created":"2014-08-18 18:55:25.000000000","uploader":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"ref":"refs/changes/66/115066/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/66/115066/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/66/115066/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/66/115066/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/66/115066/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/66/115066/1"}}},"commit":{"parents":[{"commit":"a6a45467c412476b2cddb8526a97e421b0b74db7","subject":"Add ironic-python-agent support to devstack","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a6a45467c412476b2cddb8526a97e421b0b74db7"}]}],"author":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2014-08-18 18:53:42.000000000","tz":-300},"committer":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2014-08-18 18:55:23.000000000","tz":-300},"subject":"Guard for worlddump in case LOGDIR is undefined","message":"Guard for worlddump in case LOGDIR is undefined\n\nIf LOGDIR is undefined, we\u0027ll end up calling worldump with the `-d` option but\npass in an empty string as the option value. This causes an argument parsing\nerror inside worlddump.\n\nThe proposed fix is to detect if LOGDIR is undefined, and if so, omit the `-d`\nargument.\n\nChange-Id: I77968849ebd3e3bebd2e5929b87b60fc1b6541bf\nCloses-Bug: 1333321\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2696e5a0676c1ba39ee7f97b48ef65f5dc986d4f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2696e5a0676c1ba39ee7f97b48ef65f5dc986d4f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}