)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7562d4037790e85398874e7e42d558cf186f5748","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reset no_proxy when the node is installed behind a proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1291111/1322200"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Problem:"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa98f980_a612c554","line":9,"updated":"2014-09-03 14:44:19.000000000","message":"just minor nit, please leave only one bug report (that one that\u0027s related to devstack)","commit_id":"8c97377e859caeaf6cb39af913ea9862391f1b81"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3028fe3e97e17a739970f965a444f36985b997d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reset no_proxy when the node is installed behind a proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1291111/1322200"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Problem:"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa98f980_e67ccdb7","line":9,"in_reply_to":"fa98f980_069e31b9","updated":"2014-09-03 15:01:14.000000000","message":"that should be \n\nCloses-Bug: NNN\n\nCloses-Bug: MMM\n\none per line","commit_id":"8c97377e859caeaf6cb39af913ea9862391f1b81"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3c0a6eca50e39112c73fafaf179050c7cdc51c71","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reset no_proxy when the node is installed behind a proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1291111/1322200"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Problem:"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa98f980_069e31b9","line":9,"in_reply_to":"fa98f980_a612c554","updated":"2014-09-03 15:00:29.000000000","message":"why?\n\nIn fact, it should be listed as:\n\nCloses-Bug: NNN\nCloses-Bug: MMM","commit_id":"8c97377e859caeaf6cb39af913ea9862391f1b81"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"9d0816c368e4d1873dec46bc0d86b4abb7265e23","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reset no_proxy when the node is installed behind a proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1322200"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Problem:"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa98f980_3e841d5d","line":9,"updated":"2014-09-03 16:06:43.000000000","message":"I will add the other bug id as well as mentioned in patchset 2 comment","commit_id":"2500bcd79f087ee0993a930b53ea3432b34d8605"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"655e0771e51b4274c10673942737100664aa18e6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"When devstack is installed behind a proxy with proxy variables"},{"line_number":15,"context_line":"http_proxy and https_proxy being exported and without exporting"},{"line_number":16,"context_line":"no_proxy, the installation will fail. The reason is that any REST"},{"line_number":17,"context_line":"request sent to Keystone will be redirected to the proxy server."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Solution:"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa98f980_7b894125","line":17,"updated":"2014-09-12 13:10:33.000000000","message":"the problem is not that no_proxy is not exporting. it was the local host address didn\u0027t included in the no_proxy variables.","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"4c17eddbb54b9e0711cdfe406060899d3c4168ee","unresolved":false,"context_lines":[{"line_number":14,"context_line":"When devstack is installed behind a proxy with proxy variables"},{"line_number":15,"context_line":"http_proxy and https_proxy being exported and without exporting"},{"line_number":16,"context_line":"no_proxy, the installation will fail. The reason is that any REST"},{"line_number":17,"context_line":"request sent to Keystone will be redirected to the proxy server."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Solution:"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa98f980_0938e8d1","line":17,"in_reply_to":"fa98f980_7b894125","updated":"2014-09-12 15:25:18.000000000","message":"If no_proxy variable was not exported in the local terminal it would fail installation when run behind a proxy.\n\nThe original code without this patch just validates the presence of no_proxy and exports only if it is present. So i guess the commit message is fine.\n\nOriginal code snippet for reference.\n\n if [[ -n \"$no_proxy\" ]]; then\n        export no_proxy\u003d$no_proxy\n fi","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"}],"functions-common":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"983f94153639fb1bc587ff170ec5fd31fe1be5c4","unresolved":false,"context_lines":[{"line_number":1722,"context_line":"}"},{"line_number":1723,"context_line":""},{"line_number":1724,"context_line":"# Update no proxy environment variables"},{"line_number":1725,"context_line":"function export_no_proxy_variables {"},{"line_number":1726,"context_line":"    # Add localhost to no_proxy if not present"},{"line_number":1727,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"localhost\" ]]; then"},{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa98f980_ada921e1","line":1725,"updated":"2014-09-01 21:13:26.000000000","message":"How is this new function related to, different or otherwise related to the immediate preceding function, export_proxy_variables","commit_id":"173345c44606c5073520c50b1906cc5fe8641049"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"efe5d8e7659ce2a1cb5cf8a8b04f54db76d075ed","unresolved":false,"context_lines":[{"line_number":1722,"context_line":"}"},{"line_number":1723,"context_line":""},{"line_number":1724,"context_line":"# Update no proxy environment variables"},{"line_number":1725,"context_line":"function export_no_proxy_variables {"},{"line_number":1726,"context_line":"    # Add localhost to no_proxy if not present"},{"line_number":1727,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"localhost\" ]]; then"},{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa98f980_04c2b458","line":1725,"in_reply_to":"fa98f980_2d78bb8e","updated":"2014-09-03 10:56:54.000000000","message":"yes, you can refactor the code to make it more appropriate for the present circumstance. If you have to move some functions around and that\u0027s the best way to make the code clean and readable ...\n\nJust make sure you take care of dependencies that may exist.","commit_id":"173345c44606c5073520c50b1906cc5fe8641049"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"e5d314ccee6e730421749f4e9820fdfc3fda0851","unresolved":false,"context_lines":[{"line_number":1722,"context_line":"}"},{"line_number":1723,"context_line":""},{"line_number":1724,"context_line":"# Update no proxy environment variables"},{"line_number":1725,"context_line":"function export_no_proxy_variables {"},{"line_number":1726,"context_line":"    # Add localhost to no_proxy if not present"},{"line_number":1727,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"localhost\" ]]; then"},{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa98f980_2dd7db24","line":1725,"in_reply_to":"fa98f980_651ca5c2","updated":"2014-09-02 06:09:28.000000000","message":"1. Agreed , have some doubts on that, please provide your valuable input to the comment mentioned in stack.sh\n2. The reason for validating before adding is that, there could be some other IP, that user wants it to bypass proxy like local repositories, etc. There is a mistake in line 1728 (no_proxy\u003dlocalhost), which could have raised this question. I will need to make one more validation to check if variable is empty and upload the next patchset. Thanks","commit_id":"173345c44606c5073520c50b1906cc5fe8641049"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"44dc7c002c08d404548614f1351eadf074793094","unresolved":false,"context_lines":[{"line_number":1722,"context_line":"}"},{"line_number":1723,"context_line":""},{"line_number":1724,"context_line":"# Update no proxy environment variables"},{"line_number":1725,"context_line":"function export_no_proxy_variables {"},{"line_number":1726,"context_line":"    # Add localhost to no_proxy if not present"},{"line_number":1727,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"localhost\" ]]; then"},{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa98f980_651ca5c2","line":1725,"in_reply_to":"fa98f980_ada921e1","updated":"2014-09-02 01:46:34.000000000","message":"1.I agree with amrith. It seems that this logic should be in export_proxy_variables\n2.If there is a need to include these addresses - why not just add them without checking?","commit_id":"173345c44606c5073520c50b1906cc5fe8641049"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"e5d314ccee6e730421749f4e9820fdfc3fda0851","unresolved":false,"context_lines":[{"line_number":1722,"context_line":"}"},{"line_number":1723,"context_line":""},{"line_number":1724,"context_line":"# Update no proxy environment variables"},{"line_number":1725,"context_line":"function export_no_proxy_variables {"},{"line_number":1726,"context_line":"    # Add localhost to no_proxy if not present"},{"line_number":1727,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"localhost\" ]]; then"},{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa98f980_2d78bb8e","line":1725,"in_reply_to":"fa98f980_ada921e1","updated":"2014-09-02 06:09:28.000000000","message":"The reply for this is depends on reply comment on stack.sh. If that variables can be moved, then it sounds good to make it a single function.","commit_id":"173345c44606c5073520c50b1906cc5fe8641049"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3c0a6eca50e39112c73fafaf179050c7cdc51c71","unresolved":false,"context_lines":[{"line_number":1724,"context_line":"        export https_proxy\u003d$https_proxy"},{"line_number":1725,"context_line":"    fi"},{"line_number":1726,"context_line":"    # Add localhost to no_proxy if not present"},{"line_number":1727,"context_line":"    if [[ ! -n \"$no_proxy\" ]]; then"},{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"},{"line_number":1729,"context_line":"    fi"},{"line_number":1730,"context_line":"    # Add HOST_IP to no_proxy if not present"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa98f980_2666d5c1","line":1727,"range":{"start_line":1727,"start_character":15,"end_line":1727,"end_character":17},"updated":"2014-09-03 15:00:29.000000000","message":"! -n ~ -z","commit_id":"8c97377e859caeaf6cb39af913ea9862391f1b81"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3c0a6eca50e39112c73fafaf179050c7cdc51c71","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"},{"line_number":1729,"context_line":"    fi"},{"line_number":1730,"context_line":"    # Add HOST_IP to no_proxy if not present"},{"line_number":1731,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$HOST_IP\" ]]; then"},{"line_number":1732,"context_line":"        no_proxy\u003d$no_proxy,$HOST_IP"},{"line_number":1733,"context_line":"    fi"},{"line_number":1734,"context_line":"    # Add FLOATING_RANGE to no_proxy if not present"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa98f980_8604e14a","line":1731,"updated":"2014-09-03 15:00:29.000000000","message":"How do we know that HOSTIP is non zero? what happens if it is?","commit_id":"8c97377e859caeaf6cb39af913ea9862391f1b81"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"9d0816c368e4d1873dec46bc0d86b4abb7265e23","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"},{"line_number":1729,"context_line":"    fi"},{"line_number":1730,"context_line":"    # Add HOST_IP to no_proxy if not present"},{"line_number":1731,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$HOST_IP\" ]]; then"},{"line_number":1732,"context_line":"        no_proxy\u003d$no_proxy,$HOST_IP"},{"line_number":1733,"context_line":"    fi"},{"line_number":1734,"context_line":"    # Add FLOATING_RANGE to no_proxy if not present"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_3ebc1ddc","line":1731,"updated":"2014-09-03 16:06:43.000000000","message":"Reply to comment in patchset 2\n\nIn stack.sh , the \"export_proxy_variables\" is called after HOST_IP validation\nThe snippet is as follows\n\nHOST_IP\u003d$(get_default_host_ip $FIXED_RANGE $FLOATING_RANGE \"$HOST_IP_IFACE\" \"$HOST_IP\")\nif [ \"$HOST_IP\" \u003d\u003d \"\" ]; then\n    die $LINENO \"Could not determine host ip address.  See local.conf for suggestions on setting HOST_IP.\"\nfi\n\n# Make sure the proxy config is visible to sub-processes and no_proxy variable is set\nexport_proxy_variables\n\nI guess that should take care of the problem.","commit_id":"2500bcd79f087ee0993a930b53ea3432b34d8605"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"ae937ab01f930967292ee5fca6345c418c8ea6f6","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"},{"line_number":1729,"context_line":"    fi"},{"line_number":1730,"context_line":"    # Add HOST_IP to no_proxy if not present"},{"line_number":1731,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$HOST_IP\" ]]; then"},{"line_number":1732,"context_line":"        no_proxy\u003d$no_proxy,$HOST_IP"},{"line_number":1733,"context_line":"    fi"},{"line_number":1734,"context_line":"    # Add FLOATING_RANGE to no_proxy if not present"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_fe7e15ae","line":1731,"in_reply_to":"fa98f980_3ebc1ddc","updated":"2014-09-03 16:26:04.000000000","message":"and the others, I assume are similarly verified.","commit_id":"2500bcd79f087ee0993a930b53ea3432b34d8605"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"5ccd095ae33949c2eac4afa07b5acad1a2893018","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"},{"line_number":1729,"context_line":"    fi"},{"line_number":1730,"context_line":"    # Add HOST_IP to no_proxy if not present"},{"line_number":1731,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$HOST_IP\" ]]; then"},{"line_number":1732,"context_line":"        no_proxy\u003d$no_proxy,$HOST_IP"},{"line_number":1733,"context_line":"    fi"},{"line_number":1734,"context_line":"    # Add FLOATING_RANGE to no_proxy if not present"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_61c1a453","line":1731,"in_reply_to":"fa98f980_fe7e15ae","updated":"2014-09-03 16:39:41.000000000","message":"Other variables carry a default value if not explicitly mentioned","commit_id":"2500bcd79f087ee0993a930b53ea3432b34d8605"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"ae937ab01f930967292ee5fca6345c418c8ea6f6","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$FIXED_RANGE\" ]]; then"},{"line_number":1740,"context_line":"        no_proxy\u003d$no_proxy,$FIXED_RANGE"},{"line_number":1741,"context_line":"    fi"},{"line_number":1742,"context_line":"    export no_proxy"},{"line_number":1743,"context_line":"}"},{"line_number":1744,"context_line":""},{"line_number":1745,"context_line":"# Returns true if the directory is on a filesystem mounted via NFS."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_c1141046","line":1742,"updated":"2014-09-03 16:26:04.000000000","message":"shouldn\u0027t this be\n\nexport no_proxy\u003d$no_proxy","commit_id":"2500bcd79f087ee0993a930b53ea3432b34d8605"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"5ccd095ae33949c2eac4afa07b5acad1a2893018","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$FIXED_RANGE\" ]]; then"},{"line_number":1740,"context_line":"        no_proxy\u003d$no_proxy,$FIXED_RANGE"},{"line_number":1741,"context_line":"    fi"},{"line_number":1742,"context_line":"    export no_proxy"},{"line_number":1743,"context_line":"}"},{"line_number":1744,"context_line":""},{"line_number":1745,"context_line":"# Returns true if the directory is on a filesystem mounted via NFS."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_e1ccb48b","line":1742,"in_reply_to":"fa98f980_c1141046","updated":"2014-09-03 16:39:41.000000000","message":"You are right. Made the changes for next patchset","commit_id":"2500bcd79f087ee0993a930b53ea3432b34d8605"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"298173685904683d67657476dcdf4e54d85aabff","unresolved":false,"context_lines":[{"line_number":1725,"context_line":"    fi"},{"line_number":1726,"context_line":"    # Add localhost to no_proxy if not present"},{"line_number":1727,"context_line":"    if [[ ! -n \"$no_proxy\" ]]; then"},{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"},{"line_number":1729,"context_line":"    fi"},{"line_number":1730,"context_line":"    # Add HOST_IP to no_proxy if not present"},{"line_number":1731,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$HOST_IP\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fa98f980_05729d10","line":1728,"updated":"2014-09-03 20:03:09.000000000","message":"What about the case where no_proxy is not empty?","commit_id":"445b96c584487dc0360c6dc31478fd40f7b21442"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"217909730eafd3d0aa6890e50f534a36666a0485","unresolved":false,"context_lines":[{"line_number":1725,"context_line":"    fi"},{"line_number":1726,"context_line":"    # Add localhost to no_proxy if not present"},{"line_number":1727,"context_line":"    if [[ ! -n \"$no_proxy\" ]]; then"},{"line_number":1728,"context_line":"        no_proxy\u003dlocalhost"},{"line_number":1729,"context_line":"    fi"},{"line_number":1730,"context_line":"    # Add HOST_IP to no_proxy if not present"},{"line_number":1731,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$HOST_IP\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fa98f980_68a34000","line":1728,"in_reply_to":"fa98f980_05729d10","updated":"2014-09-03 20:12:46.000000000","message":"Thanks Itzik Brown, Made the change in the test environment and just missed it while uploading. Please check the new patchset","commit_id":"445b96c584487dc0360c6dc31478fd40f7b21442"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"56e5eb53a115d348a02c71503c74b7761d4b71b0","unresolved":false,"context_lines":[{"line_number":1742,"context_line":"    # Add FIXED_RANGE to no_proxy if not present"},{"line_number":1743,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$FIXED_RANGE\" ]]; then"},{"line_number":1744,"context_line":"        no_proxy\u003d$no_proxy,$FIXED_RANGE"},{"line_number":1745,"context_line":"    fi"},{"line_number":1746,"context_line":"    export no_proxy\u003d$no_proxy"},{"line_number":1747,"context_line":"}"},{"line_number":1748,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_680d00e8","line":1745,"updated":"2014-09-03 20:18:22.000000000","message":"I think that a loop here looks better but maybe it\u0027s just a matter of style.","commit_id":"b6107287b6c56d84de37b6f525607f04b0c0000b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"31dc7c3bef0660d0848efc583b6571d2cb4da72b","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"    if [[ -n \"$https_proxy\" ]]; then"},{"line_number":1737,"context_line":"        export https_proxy\u003d$https_proxy"},{"line_number":1738,"context_line":"    fi"},{"line_number":1739,"context_line":"    # Add localhost to no_proxy if no_proxy is empty"},{"line_number":1740,"context_line":"    if [[ -z \"$no_proxy\" ]]; then"},{"line_number":1741,"context_line":"        no_proxy\u003dlocalhost"},{"line_number":1742,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa98f980_8367fe24","line":1739,"updated":"2014-09-08 04:11:43.000000000","message":"why is this done twice?","commit_id":"07fb4f1dcf2f8c03ff30700fb1b46f3f120b5906"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"1dbd7bc6d0eb1d67889b4366ce6f7a484386ea5c","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"    if [[ -n \"$https_proxy\" ]]; then"},{"line_number":1737,"context_line":"        export https_proxy\u003d$https_proxy"},{"line_number":1738,"context_line":"    fi"},{"line_number":1739,"context_line":"    # Add localhost to no_proxy if no_proxy is empty"},{"line_number":1740,"context_line":"    if [[ -z \"$no_proxy\" ]]; then"},{"line_number":1741,"context_line":"        no_proxy\u003dlocalhost"},{"line_number":1742,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa98f980_89d706ed","line":1739,"in_reply_to":"fa98f980_8367fe24","updated":"2014-09-08 18:37:15.000000000","message":"First if no_proxy is empty\nSecond no_proxy not empty but \"localhost\" entry not present.","commit_id":"07fb4f1dcf2f8c03ff30700fb1b46f3f120b5906"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"31dc7c3bef0660d0848efc583b6571d2cb4da72b","unresolved":false,"context_lines":[{"line_number":1749,"context_line":"        no_proxy\u003d$no_proxy,$HOST_IP"},{"line_number":1750,"context_line":"    fi"},{"line_number":1751,"context_line":"    # Add FLOATING_RANGE to no_proxy if not present"},{"line_number":1752,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$FLOATING_RANGE\" ]]; then"},{"line_number":1753,"context_line":"        no_proxy\u003d$no_proxy,$FLOATING_RANGE"},{"line_number":1754,"context_line":"    fi"},{"line_number":1755,"context_line":"    # Add FIXED_RANGE to no_proxy if not present"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa98f980_a61fb05a","line":1752,"updated":"2014-09-08 04:11:43.000000000","message":"does this actually work?  I can\u0027t see anywhere that a subnet range is allowed?  from curl man\n\n NO_PROXY \u003ccomma-separated list of hosts\u003e\n list of host names that shouldn\u0027t go through any proxy.  If set to a asterisk \u0027*\u0027 only, it matches all hosts.\n\nif it\u0027s a /24 192.*.*.* may work, not sure","commit_id":"07fb4f1dcf2f8c03ff30700fb1b46f3f120b5906"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"1dbd7bc6d0eb1d67889b4366ce6f7a484386ea5c","unresolved":false,"context_lines":[{"line_number":1749,"context_line":"        no_proxy\u003d$no_proxy,$HOST_IP"},{"line_number":1750,"context_line":"    fi"},{"line_number":1751,"context_line":"    # Add FLOATING_RANGE to no_proxy if not present"},{"line_number":1752,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$FLOATING_RANGE\" ]]; then"},{"line_number":1753,"context_line":"        no_proxy\u003d$no_proxy,$FLOATING_RANGE"},{"line_number":1754,"context_line":"    fi"},{"line_number":1755,"context_line":"    # Add FIXED_RANGE to no_proxy if not present"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa98f980_a9784af9","line":1752,"in_reply_to":"fa98f980_a61fb05a","updated":"2014-09-08 18:37:15.000000000","message":"You are right about that. I have infact analyzed that it is not necessary to set FLOATING_RANGE and FIXED_RANGE in no_proxy. The installation goes smooth just with localhost,\u003chost ip\u003e. Uploading a new patchset, kindly review it.","commit_id":"07fb4f1dcf2f8c03ff30700fb1b46f3f120b5906"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"b1d2ce8e49d9e124fdf6f45de780632de73c6d12","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"        no_proxy\u003d$no_proxy,localhost"},{"line_number":1747,"context_line":"    fi"},{"line_number":1748,"context_line":"    # Add HOST_IP to no_proxy if not present"},{"line_number":1749,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$HOST_IP\" ]]; then"},{"line_number":1750,"context_line":"        no_proxy\u003d$no_proxy,$HOST_IP"},{"line_number":1751,"context_line":"    fi"},{"line_number":1752,"context_line":"    export no_proxy\u003d$no_proxy"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"fa98f980_8b6e1395","line":1749,"updated":"2014-09-08 23:12:29.000000000","message":"I think that in a multi node setup this is not enough. e.g. SERVICE_HOST should also be added.","commit_id":"3ba2c6654ebcc76cba3157e8eba85a74b3570760"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"4c5d42d399afbd2cf4b77036b97e264636807ac5","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"        no_proxy\u003d$no_proxy,localhost"},{"line_number":1747,"context_line":"    fi"},{"line_number":1748,"context_line":"    # Add HOST_IP to no_proxy if not present"},{"line_number":1749,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$HOST_IP\" ]]; then"},{"line_number":1750,"context_line":"        no_proxy\u003d$no_proxy,$HOST_IP"},{"line_number":1751,"context_line":"    fi"},{"line_number":1752,"context_line":"    export no_proxy\u003d$no_proxy"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"fa98f980_bc54fc21","line":1749,"in_reply_to":"fa98f980_8b6e1395","updated":"2014-09-09 05:14:20.000000000","message":"I guess you are right. I am just testing the scenario. Will upload the new patchset making the required changes","commit_id":"3ba2c6654ebcc76cba3157e8eba85a74b3570760"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"33868008b9fd6b2b25c440bc0033fff5b1a42a2c","unresolved":false,"context_lines":[{"line_number":1743,"context_line":"    fi"},{"line_number":1744,"context_line":"    # Add localhost to no_proxy if not present"},{"line_number":1745,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"localhost\" ]]; then"},{"line_number":1746,"context_line":"        no_proxy\u003d$no_proxy,localhost"},{"line_number":1747,"context_line":"    fi"},{"line_number":1748,"context_line":"    # Add HOST_IP to no_proxy if not present"},{"line_number":1749,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$HOST_IP\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa98f980_9b31855c","line":1746,"updated":"2014-09-12 13:15:53.000000000","message":"the above 7 line code are duplicated. please optimize it.","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"4c17eddbb54b9e0711cdfe406060899d3c4168ee","unresolved":false,"context_lines":[{"line_number":1743,"context_line":"    fi"},{"line_number":1744,"context_line":"    # Add localhost to no_proxy if not present"},{"line_number":1745,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"localhost\" ]]; then"},{"line_number":1746,"context_line":"        no_proxy\u003d$no_proxy,localhost"},{"line_number":1747,"context_line":"    fi"},{"line_number":1748,"context_line":"    # Add HOST_IP to no_proxy if not present"},{"line_number":1749,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$HOST_IP\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa98f980_d6375f4b","line":1746,"in_reply_to":"fa98f980_9b31855c","updated":"2014-09-12 15:25:18.000000000","message":"There is a need for two sets of validation, one when no_proxy is empty and other when no_proxy has values but \u0027localhost\u0027 not present. I will think of optimizing further. Thanks","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"945cd8b366d3e3bc88f03636902610dfcbe465d8","unresolved":false,"context_lines":[{"line_number":1753,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$SERVICE_HOST\" ]]; then"},{"line_number":1754,"context_line":"        no_proxy\u003d$no_proxy,$SERVICE_HOST"},{"line_number":1755,"context_line":"    fi"},{"line_number":1756,"context_line":"    export no_proxy\u003d$no_proxy"},{"line_number":1757,"context_line":"}"},{"line_number":1758,"context_line":""},{"line_number":1759,"context_line":"# Returns true if the directory is on a filesystem mounted via NFS."}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa98f980_1b52f566","line":1756,"updated":"2014-09-12 13:17:59.000000000","message":"Don\u0027t you need to add FLOATING_RANG?","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"2755896ecb05d16f0fb14f12f81850831a07a304","unresolved":false,"context_lines":[{"line_number":1753,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$SERVICE_HOST\" ]]; then"},{"line_number":1754,"context_line":"        no_proxy\u003d$no_proxy,$SERVICE_HOST"},{"line_number":1755,"context_line":"    fi"},{"line_number":1756,"context_line":"    export no_proxy\u003d$no_proxy"},{"line_number":1757,"context_line":"}"},{"line_number":1758,"context_line":""},{"line_number":1759,"context_line":"# Returns true if the directory is on a filesystem mounted via NFS."}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa98f980_5b203af7","line":1756,"updated":"2014-09-10 19:57:17.000000000","message":"What do you think about:\n\nSERVICE_IPS\u003d\"localhost $HOST_IP $SERVICE_HOST $GLANCE_HOST $HEAT_API_CFN_HOST\"\n\nfunction export_proxy_variables {\n    if [[ -n \"$http_proxy\" ]]; then\n        export http_proxy\u003d$http_proxy\n    fi\n    if [[ -n \"$https_proxy\" ]]; then\n        export https_proxy\u003d$https_proxy\n    fi\n    if [[ -z \"$no_proxy\" ]]; then\n        no_proxy\u003dlocalhost\n    fi\n    for IP in $SERVICE_IPS;do\n        if [[ -n $IP  \u0026\u0026  ! \"$no_proxy\" \u003d~ \"$IP\" ]]; then\n            no_proxy\u003d$no_proxy,$IP\n        fi\n    done\n    export no_proxy\u003d$no_proxy\n}","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"4c17eddbb54b9e0711cdfe406060899d3c4168ee","unresolved":false,"context_lines":[{"line_number":1753,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$SERVICE_HOST\" ]]; then"},{"line_number":1754,"context_line":"        no_proxy\u003d$no_proxy,$SERVICE_HOST"},{"line_number":1755,"context_line":"    fi"},{"line_number":1756,"context_line":"    export no_proxy\u003d$no_proxy"},{"line_number":1757,"context_line":"}"},{"line_number":1758,"context_line":""},{"line_number":1759,"context_line":"# Returns true if the directory is on a filesystem mounted via NFS."}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa98f980_d6b83f77","line":1756,"in_reply_to":"fa98f980_1b52f566","updated":"2014-09-12 15:25:18.000000000","message":"For just devstack to complete, only servicing IPs like HOST_IP,etc need to be exported. It is not necessary for FIXED or FLOATING_RANGE in this list as they are not a part of service IPs. Again the above statement is based on testing results.\n\nThe above patch needs to be extended further as mentioned by Itzik Brown in the above comment.","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"e1c3bf300e3936411553b427a119dad66284d59a","unresolved":false,"context_lines":[{"line_number":1753,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$SERVICE_HOST\" ]]; then"},{"line_number":1754,"context_line":"        no_proxy\u003d$no_proxy,$SERVICE_HOST"},{"line_number":1755,"context_line":"    fi"},{"line_number":1756,"context_line":"    export no_proxy\u003d$no_proxy"},{"line_number":1757,"context_line":"}"},{"line_number":1758,"context_line":""},{"line_number":1759,"context_line":"# Returns true if the directory is on a filesystem mounted via NFS."}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa98f980_7e8065bf","line":1756,"in_reply_to":"fa98f980_5b203af7","updated":"2014-09-11 21:11:15.000000000","message":"This looks more crisp. But i think just GLANCE_HOST and HEAT_API_CFN_HOST alone are not enough, few more variables like RABBIT_HOST,CINDER_SERVICE_HOST, etc.\nI am trying to figure out, which are the variables that need to be exported and also, the place where export_proxy_variable needs to be called in stack.sh if the above variables need to be exported. I will soon upload the new patchset","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"1694d293a409b4c4b8347b4d0a6fd55f655a5780","unresolved":false,"context_lines":[{"line_number":1753,"context_line":"    if [[ ! \"$no_proxy\" \u003d~ \"$SERVICE_HOST\" ]]; then"},{"line_number":1754,"context_line":"        no_proxy\u003d$no_proxy,$SERVICE_HOST"},{"line_number":1755,"context_line":"    fi"},{"line_number":1756,"context_line":"    export no_proxy\u003d$no_proxy"},{"line_number":1757,"context_line":"}"},{"line_number":1758,"context_line":""},{"line_number":1759,"context_line":"# Returns true if the directory is on a filesystem mounted via NFS."}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa98f980_68c6b969","line":1756,"in_reply_to":"fa98f980_7e8065bf","updated":"2014-09-13 23:55:06.000000000","message":"You are right.Searching for SERVICE_PROTOCOL\u003dhttp may be helpful.\nNot sure about RABBIT_HOST tough.","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"}],"stack.sh":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"983f94153639fb1bc587ff170ec5fd31fe1be5c4","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    die $LINENO \"Could not determine host ip address.  See local.conf for suggestions on setting HOST_IP.\""},{"line_number":316,"context_line":"fi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"# Reset no_porxy variables"},{"line_number":319,"context_line":"export_no_proxy_variables"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa98f980_2d47f14c","line":318,"updated":"2014-09-01 21:13:26.000000000","message":"typo (porxy)","commit_id":"173345c44606c5073520c50b1906cc5fe8641049"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"e5d314ccee6e730421749f4e9820fdfc3fda0851","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    die $LINENO \"Could not determine host ip address.  See local.conf for suggestions on setting HOST_IP.\""},{"line_number":316,"context_line":"fi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"# Reset no_porxy variables"},{"line_number":319,"context_line":"export_no_proxy_variables"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa98f980_b2bfaafb","line":318,"in_reply_to":"fa98f980_2d47f14c","updated":"2014-09-02 06:09:28.000000000","message":"Thanks i will correct it.","commit_id":"173345c44606c5073520c50b1906cc5fe8641049"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"983f94153639fb1bc587ff170ec5fd31fe1be5c4","unresolved":false,"context_lines":[{"line_number":316,"context_line":"fi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"# Reset no_porxy variables"},{"line_number":319,"context_line":"export_no_proxy_variables"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":322,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa98f980_ad7201ab","line":319,"updated":"2014-09-01 21:13:26.000000000","message":"How is this new function related to, different from export_proxy_variables which already exists?","commit_id":"173345c44606c5073520c50b1906cc5fe8641049"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"f487e5e70734d8efb305ba2bca957d793e228e20","unresolved":false,"context_lines":[{"line_number":316,"context_line":"fi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"# Reset no_porxy variables"},{"line_number":319,"context_line":"export_no_proxy_variables"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":322,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa98f980_f23599f7","line":319,"in_reply_to":"fa98f980_72162257","updated":"2014-09-02 15:43:37.000000000","message":"So maybe export_proxy_variables should be moved..","commit_id":"173345c44606c5073520c50b1906cc5fe8641049"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"e5d314ccee6e730421749f4e9820fdfc3fda0851","unresolved":false,"context_lines":[{"line_number":316,"context_line":"fi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"# Reset no_porxy variables"},{"line_number":319,"context_line":"export_no_proxy_variables"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":322,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa98f980_72162257","line":319,"in_reply_to":"fa98f980_ad7201ab","updated":"2014-09-02 06:09:28.000000000","message":"I could have used the same function \"export_proxy_variables\" , but the variables like \"HOST_IP\",\"FLOATING_IP\",\"FIXED_IP\" are all set at lines just above this call. If this is to be merged on a single method, is it alright to move these configuration variables right above \"export_proxy_variables\" call ?","commit_id":"173345c44606c5073520c50b1906cc5fe8641049"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3c0a6eca50e39112c73fafaf179050c7cdc51c71","unresolved":false,"context_lines":[{"line_number":314,"context_line":"fi"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"# Make sure the proxy config is visible to sub-processes and no_proxy variable is set"},{"line_number":317,"context_line":"export_proxy_variables"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":320,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa98f980_66ba9d6f","line":317,"updated":"2014-09-03 15:00:29.000000000","message":"are we sure that nothing between the old place and this place depend on the settings done in export_proxy_variables?","commit_id":"8c97377e859caeaf6cb39af913ea9862391f1b81"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"9d0816c368e4d1873dec46bc0d86b4abb7265e23","unresolved":false,"context_lines":[{"line_number":314,"context_line":"fi"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"# Make sure the proxy config is visible to sub-processes and no_proxy variable is set"},{"line_number":317,"context_line":"export_proxy_variables"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":320,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa98f980_5e8f212a","line":317,"updated":"2014-09-03 16:06:43.000000000","message":"Yes i have made a check on it. All the code that lies between old place and new place are just configurations which do not make use of proxy. I will make a double check","commit_id":"2500bcd79f087ee0993a930b53ea3432b34d8605"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"655e0771e51b4274c10673942737100664aa18e6","unresolved":false,"context_lines":[{"line_number":318,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"# Make sure the proxy config is visible to sub-processes and no_proxy variable is set"},{"line_number":321,"context_line":"export_proxy_variables"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"# Configure services to use syslog instead of writing to individual log files"},{"line_number":324,"context_line":"SYSLOG\u003d`trueorfalse False $SYSLOG`"}],"source_content_type":"text/x-sh","patch_set":9,"id":"fa98f980_bb5569c3","line":321,"updated":"2014-09-12 13:10:33.000000000","message":"Can you make sure the proxy variables are not used before this line?","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"4c17eddbb54b9e0711cdfe406060899d3c4168ee","unresolved":false,"context_lines":[{"line_number":318,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"# Make sure the proxy config is visible to sub-processes and no_proxy variable is set"},{"line_number":321,"context_line":"export_proxy_variables"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"# Configure services to use syslog instead of writing to individual log files"},{"line_number":324,"context_line":"SYSLOG\u003d`trueorfalse False $SYSLOG`"}],"source_content_type":"text/x-sh","patch_set":9,"id":"fa98f980_f6caa34d","line":321,"in_reply_to":"fa98f980_bb5569c3","updated":"2014-09-12 15:25:18.000000000","message":"Yes i have checked it and tested on a setup behind proxy","commit_id":"69f51f997be69d93c43a223f261ad4648c0fe500"}]}