)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bb8efb257c64dd710cd3916312a7d13e44f63b61","unresolved":false,"context_lines":[{"line_number":15,"context_line":"command even if it sets SEGMENTATION_ID with flat option."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"To fix this issue, this patch just skip checking SEGMENTATION_ID if"},{"line_number":18,"context_line":"PROVIDER_NETWORK_TYPE is set to \"flat\"."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I2273e3369c688bbce1a6e39b43635b5548cc2b98"},{"line_number":21,"context_line":"Closes-Bug: #1362382"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa98f980_03914e52","line":18,"updated":"2014-09-08 03:28:35.000000000","message":"as neutron allows partial specs these days,\nit\u0027s better to remove the check regardless of PROVIDER_NETWORK_TYPE.\ncf. https://blueprints.launchpad.net/neutron/+spec/provider-network-partial-specs\n\nditto for PHYSICAL_NETWORK.","commit_id":"546c799ec7205a307264966bf83134dbf4f8bba0"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"7ce4776a8992506eff40c91c147df51f926f6dbb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"command even if it sets SEGMENTATION_ID with flat option."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"To fix this issue, this patch just skip checking SEGMENTATION_ID if"},{"line_number":18,"context_line":"PROVIDER_NETWORK_TYPE is set to \"flat\"."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I2273e3369c688bbce1a6e39b43635b5548cc2b98"},{"line_number":21,"context_line":"Closes-Bug: #1362382"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa98f980_97fb9146","line":18,"in_reply_to":"fa98f980_03914e52","updated":"2014-09-09 06:14:57.000000000","message":"OK, I\u0027ll remove the check for PROVIDER_NETWORK_TYPE.\n\nBut for PHYSICAL_NETWORK, I think devstack should add die_if_not_set check for it rather than making it optional. The reason is:\n\nCurrent devstack uses PHYSICAL_NETWORK both as network name and physical network name like following.\n\nneutron net-create $PHYSICAL_NETWORK  \u003csnip\u003e --provider:physical_network \"$PHYSICAL_NETWORK\" \u003csnip\u003e\n\nThat means that if we don\u0027t provide PHYSICAL_NETWORK, neutron command just fails. What do you think about it?","commit_id":"546c799ec7205a307264966bf83134dbf4f8bba0"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"25bc953de18ccb7cdd98e345d5cfc0b0a59ce57a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"command even if it sets SEGMENTATION_ID with flat option."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"To fix this issue, this patch just skip checking SEGMENTATION_ID if"},{"line_number":18,"context_line":"PROVIDER_NETWORK_TYPE is set to \"flat\"."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I2273e3369c688bbce1a6e39b43635b5548cc2b98"},{"line_number":21,"context_line":"Closes-Bug: #1362382"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa98f980_b2a9837d","line":18,"in_reply_to":"fa98f980_12ddef42","updated":"2014-09-09 06:37:20.000000000","message":"Oops, I made a mistake.\n\nI\u0027ll remove SEGMENTATION_ID check not PROVIDER_NETWORK_TYPE.\nAnyway, I\u0027ll update my patch soon.","commit_id":"546c799ec7205a307264966bf83134dbf4f8bba0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"47adc84952f78f0fb26b63677263864bad0fcc7a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"command even if it sets SEGMENTATION_ID with flat option."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"To fix this issue, this patch just skip checking SEGMENTATION_ID if"},{"line_number":18,"context_line":"PROVIDER_NETWORK_TYPE is set to \"flat\"."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I2273e3369c688bbce1a6e39b43635b5548cc2b98"},{"line_number":21,"context_line":"Closes-Bug: #1362382"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa98f980_12ddef42","line":18,"in_reply_to":"fa98f980_97fb9146","updated":"2014-09-09 06:29:38.000000000","message":"sounds reasonable to me.","commit_id":"546c799ec7205a307264966bf83134dbf4f8bba0"}]}