)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"901441153c06e97a7b50e603abf439c0d436e7ec","unresolved":false,"context_lines":[{"line_number":12,"context_line":"are lvmdriver-1 and lvmdriver-2."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch updates the backend names. Added support for"},{"line_number":15,"context_line":"CINDER_ENABLED_BACKENDS and aded todo to remove"},{"line_number":16,"context_line":"CINDER_MULTI_LVM_BACKEND once its formally removed"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If44f5eb206616afb0fbaf333f3fa6a296d4650cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa98f980_9e277362","line":15,"updated":"2014-09-16 02:06:50.000000000","message":"tough very nit, s/aded/added","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"9e14358725b26c6bbcf1e5f4a32e65958e8e924e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"are lvmdriver-1 and lvmdriver-2."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch updates the backend names. Added support for"},{"line_number":15,"context_line":"CINDER_ENABLED_BACKENDS and aded todo to remove"},{"line_number":16,"context_line":"CINDER_MULTI_LVM_BACKEND once its formally removed"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If44f5eb206616afb0fbaf333f3fa6a296d4650cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa98f980_3fd83e52","line":15,"in_reply_to":"fa98f980_9e277362","updated":"2014-09-16 06:47:20.000000000","message":"Done","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"}],"lib/tempest":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e6c5f88beafe3728400a2f9b9b7cb211836a4468","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    if [ $CINDER_MULTI_LVM_BACKEND \u003d\u003d \"True\" ]; then"},{"line_number":357,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":358,"context_line":"        iniset $TEMPEST_CONFIG volume backend1_name \"lvmdriver-1\""},{"line_number":359,"context_line":"        iniset $TEMPEST_CONFIG volume backend2_name \"lvmdriver-2\""},{"line_number":360,"context_line":"    fi"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    if [ $TEMPEST_VOLUME_DRIVER !\u003d \"default\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa98f980_adb49a35","line":359,"updated":"2014-09-10 11:38:43.000000000","message":"lvmdriver-1 and lvmdriver-2 seems default value of CINDER_ENABLED_BACKENDS.\nFor supporting the configured value of CINDER_ENABLED_BACKENDS also, can we get the above values from CINDER_ENABLED_BACKENDS?","commit_id":"8ffa06c67989d10443f832a24243fab8ccd6c42c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7cd40fc9ba9976abf318d5304db9a5654149363f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# - ``LIVE_MIGRATION_AVAILABLE``"},{"line_number":27,"context_line":"# - ``USE_BLOCK_MIGRATION_FOR_LIVE_MIGRATION``"},{"line_number":28,"context_line":"# - ``DEFAULT_INSTANCE_TYPE``"},{"line_number":29,"context_line":"# - ``DEFAULT_INSTANCE_USER``"},{"line_number":30,"context_line":"# - ``CINDER_MULTI_LVM_BACKEND``"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# ``stack.sh`` calls the entry points in this order:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_e4de9010","line":29,"updated":"2014-09-15 08:39:32.000000000","message":"Add a line here to mention CINDER_ENABLED_BACKENDS","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"9e14358725b26c6bbcf1e5f4a32e65958e8e924e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# - ``LIVE_MIGRATION_AVAILABLE``"},{"line_number":27,"context_line":"# - ``USE_BLOCK_MIGRATION_FOR_LIVE_MIGRATION``"},{"line_number":28,"context_line":"# - ``DEFAULT_INSTANCE_TYPE``"},{"line_number":29,"context_line":"# - ``DEFAULT_INSTANCE_USER``"},{"line_number":30,"context_line":"# - ``CINDER_MULTI_LVM_BACKEND``"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# ``stack.sh`` calls the entry points in this order:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_ff1236fb","line":29,"in_reply_to":"fa98f980_9ede933c","updated":"2014-09-16 06:47:20.000000000","message":"Done. Missed that.","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"901441153c06e97a7b50e603abf439c0d436e7ec","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# - ``LIVE_MIGRATION_AVAILABLE``"},{"line_number":27,"context_line":"# - ``USE_BLOCK_MIGRATION_FOR_LIVE_MIGRATION``"},{"line_number":28,"context_line":"# - ``DEFAULT_INSTANCE_TYPE``"},{"line_number":29,"context_line":"# - ``DEFAULT_INSTANCE_USER``"},{"line_number":30,"context_line":"# - ``CINDER_MULTI_LVM_BACKEND``"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# ``stack.sh`` calls the entry points in this order:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_9ede933c","line":29,"in_reply_to":"fa98f980_e4de9010","updated":"2014-09-16 02:06:50.000000000","message":"I agree with Jordan.","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"9e14358725b26c6bbcf1e5f4a32e65958e8e924e","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled backup False"},{"line_number":354,"context_line":"    fi"},{"line_number":355,"context_line":"    # TODO(coolsvap) Currently deprecated, remove CINDER_MULTI_LVM_BACKEND once its formally removed"},{"line_number":356,"context_line":"    CINDER_MULTI_LVM_BACKEND\u003d$(trueorfalse False $CINDER_MULTI_LVM_BACKEND)"},{"line_number":357,"context_line":"    if [ $CINDER_MULTI_LVM_BACKEND \u003d\u003d \"True\" ]; then"},{"line_number":358,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":359,"context_line":"        iniset $TEMPEST_CONFIG volume backend1_name \"lvmdriver-1\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_1f07faca","line":356,"updated":"2014-09-16 06:47:20.000000000","message":"Done","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7cd40fc9ba9976abf318d5304db9a5654149363f","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        iniset $TEMPEST_CONFIG volume backend1_name \"lvmdriver-1\""},{"line_number":360,"context_line":"        iniset $TEMPEST_CONFIG volume backend2_name \"lvmdriver-2\""},{"line_number":361,"context_line":"    fi"},{"line_number":362,"context_line":"    # Using CINDER_ENABLED_BACKENDS"},{"line_number":363,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":364,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":365,"context_line":"        i\u003d\u00271\u0027"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_190bb624","line":362,"updated":"2014-09-15 08:39:32.000000000","message":"I would concider using a if/elif instead of two if (L356 and L363), otherwise you could end up with configuring $backend$i_name possibly 2 times.\n\nBut I would start with the CINDER_ENABLED_BACKENDS block because this is the now right way  to do it.","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6ae39f0d990435a00b69da23aae6a5eae51616fd","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        iniset $TEMPEST_CONFIG volume backend1_name \"lvmdriver-1\""},{"line_number":360,"context_line":"        iniset $TEMPEST_CONFIG volume backend2_name \"lvmdriver-2\""},{"line_number":361,"context_line":"    fi"},{"line_number":362,"context_line":"    # Using CINDER_ENABLED_BACKENDS"},{"line_number":363,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":364,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":365,"context_line":"        i\u003d\u00271\u0027"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_de9f3b4e","line":362,"in_reply_to":"fa98f980_190bb624","updated":"2014-09-16 00:36:00.000000000","message":"Nice idea, I agree with Jordan like:\n\n if [ -n \"$CINDER_ENABLED_BACKENDS\" ]:\n     ..\n elif [ $CINDER_MULTI_LVM_BACKEND \u003d\u003d \"True\" ]; then\n     ..","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"9e14358725b26c6bbcf1e5f4a32e65958e8e924e","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        iniset $TEMPEST_CONFIG volume backend1_name \"lvmdriver-1\""},{"line_number":360,"context_line":"        iniset $TEMPEST_CONFIG volume backend2_name \"lvmdriver-2\""},{"line_number":361,"context_line":"    fi"},{"line_number":362,"context_line":"    # Using CINDER_ENABLED_BACKENDS"},{"line_number":363,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":364,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":365,"context_line":"        i\u003d\u00271\u0027"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_fffb16bb","line":362,"in_reply_to":"fa98f980_de9f3b4e","updated":"2014-09-16 06:47:20.000000000","message":"I currently updated the patch, my only intention for keeping separate if was to have distinct and easy remove for CINDER_MULTI_LVM_BACKEND when its officially unsupported.","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6ae39f0d990435a00b69da23aae6a5eae51616fd","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":364,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":365,"context_line":"        i\u003d\u00271\u0027"},{"line_number":366,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":367,"context_line":"            be_name\u003d`echo ${be##*:} | cut -d\u0027:\u0027 -f2`"},{"line_number":368,"context_line":"            iniset $TEMPEST_CONFIG volume \"backend${i}_name\" \"$be_name\""},{"line_number":369,"context_line":"            i\u003d`expr $i + 1`"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_5ecc2b35","line":366,"updated":"2014-09-16 00:36:00.000000000","message":"On my test env, the above line outputs \"Bad substitution\".\n\nIs the following line OK instead for this patch?\n\n for be in `echo ${CINDER_ENABLED_BACKENDS} | sed -e \"s/,/ /g\"`; do","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"9e14358725b26c6bbcf1e5f4a32e65958e8e924e","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":364,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":365,"context_line":"        i\u003d\u00271\u0027"},{"line_number":366,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":367,"context_line":"            be_name\u003d`echo ${be##*:} | cut -d\u0027:\u0027 -f2`"},{"line_number":368,"context_line":"            iniset $TEMPEST_CONFIG volume \"backend${i}_name\" \"$be_name\""},{"line_number":369,"context_line":"            i\u003d`expr $i + 1`"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa98f980_bf1c2e14","line":366,"in_reply_to":"fa98f980_5ecc2b35","updated":"2014-09-16 06:47:20.000000000","message":"Let me check, I will update, which system you are using, since I tested the patch on both Ubuntu 14.04 and Fedora 20.","commit_id":"6925814ead21d3ffb729b608dd8f68abd7e627f6"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4c20c693ce8c76fc08c881d6c1928a0084c613c6","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    if [ $CINDER_MULTI_LVM_BACKEND \u003d\u003d \"True\" ]; then"},{"line_number":357,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":358,"context_line":"        iniset $TEMPEST_CONFIG volume backend1_name \"LVM_iSCSI\""},{"line_number":359,"context_line":"        iniset $TEMPEST_CONFIG volume backend2_name \"LVM_iSCSI_2\""},{"line_number":360,"context_line":"    fi"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    if [ $TEMPEST_VOLUME_DRIVER !\u003d \"default\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_668761b7","side":"PARENT","line":359,"updated":"2014-09-18 03:25:51.000000000","message":"i and be need to be local below","commit_id":"4bd4264960917b6bcd197326020a8a894d1d47f4"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4c20c693ce8c76fc08c881d6c1928a0084c613c6","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    # TODO(coolsvap) Currently deprecated, remove CINDER_MULTI_LVM_BACKEND once its formally removed"},{"line_number":357,"context_line":"    CINDER_MULTI_LVM_BACKEND\u003d$(trueorfalse False $CINDER_MULTI_LVM_BACKEND)"},{"line_number":358,"context_line":"    # Using CINDER_ENABLED_BACKENDS"},{"line_number":359,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":360,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":361,"context_line":"        i\u003d\u00271\u0027"},{"line_number":362,"context_line":"        for be in `echo ${CINDER_ENABLED_BACKENDS} | sed -e \"s/,/ /g\"`; do"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_793546da","line":359,"updated":"2014-09-18 03:25:51.000000000","message":"Why do you need to check for a comma?  If there isn\u0027t one the for loop still does the right thing.","commit_id":"ebb9ce20284b64e97bded2d6cc47f4992004013c"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"0a38bfe2b7ea7938cab343894ec0c0c226b2417d","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    # TODO(coolsvap) Currently deprecated, remove CINDER_MULTI_LVM_BACKEND once its formally removed"},{"line_number":357,"context_line":"    CINDER_MULTI_LVM_BACKEND\u003d$(trueorfalse False $CINDER_MULTI_LVM_BACKEND)"},{"line_number":358,"context_line":"    # Using CINDER_ENABLED_BACKENDS"},{"line_number":359,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":360,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":361,"context_line":"        i\u003d\u00271\u0027"},{"line_number":362,"context_line":"        for be in `echo ${CINDER_ENABLED_BACKENDS} | sed -e \"s/,/ /g\"`; do"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_ad1be4c8","line":359,"in_reply_to":"fa98f980_793546da","updated":"2014-09-18 07:46:11.000000000","message":"We need to check for comma since if there is only one backend, we need to skip the multiple backend configuration.","commit_id":"ebb9ce20284b64e97bded2d6cc47f4992004013c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4c20c693ce8c76fc08c881d6c1928a0084c613c6","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":360,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":361,"context_line":"        i\u003d\u00271\u0027"},{"line_number":362,"context_line":"        for be in `echo ${CINDER_ENABLED_BACKENDS} | sed -e \"s/,/ /g\"`; do"},{"line_number":363,"context_line":"            be_name\u003d`echo ${be##*:} | cut -d\u0027:\u0027 -f2`"},{"line_number":364,"context_line":"            iniset $TEMPEST_CONFIG volume \"backend${i}_name\" \"$be_name\""},{"line_number":365,"context_line":"            i\u003d`expr $i + 1`"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_e6619112","line":362,"updated":"2014-09-18 03:25:51.000000000","message":"Why do the subshell/sed here?\n\n  ${CINDER_ENABLED_BACKENDS//,/ }\n\nAlso below...is the pattern used in lib/cinder not right for this somehow?","commit_id":"ebb9ce20284b64e97bded2d6cc47f4992004013c"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"0a38bfe2b7ea7938cab343894ec0c0c226b2417d","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":360,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":361,"context_line":"        i\u003d\u00271\u0027"},{"line_number":362,"context_line":"        for be in `echo ${CINDER_ENABLED_BACKENDS} | sed -e \"s/,/ /g\"`; do"},{"line_number":363,"context_line":"            be_name\u003d`echo ${be##*:} | cut -d\u0027:\u0027 -f2`"},{"line_number":364,"context_line":"            iniset $TEMPEST_CONFIG volume \"backend${i}_name\" \"$be_name\""},{"line_number":365,"context_line":"            i\u003d`expr $i + 1`"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_ed7c0cee","line":362,"in_reply_to":"fa98f980_d7027971","updated":"2014-09-18 07:46:11.000000000","message":"Np, oomichi, I will do.","commit_id":"ebb9ce20284b64e97bded2d6cc47f4992004013c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2c9bfd27653f13619953ccaf77f37fc48c3eb127","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":360,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":361,"context_line":"        i\u003d\u00271\u0027"},{"line_number":362,"context_line":"        for be in `echo ${CINDER_ENABLED_BACKENDS} | sed -e \"s/,/ /g\"`; do"},{"line_number":363,"context_line":"            be_name\u003d`echo ${be##*:} | cut -d\u0027:\u0027 -f2`"},{"line_number":364,"context_line":"            iniset $TEMPEST_CONFIG volume \"backend${i}_name\" \"$be_name\""},{"line_number":365,"context_line":"            i\u003d`expr $i + 1`"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_d7027971","line":362,"in_reply_to":"fa98f980_e6619112","updated":"2014-09-18 06:05:53.000000000","message":"@Swapnil\n\nSorry, that was my fault.\n\nThe other places(e.g: lib/keystone) also use the above code which Dean mentioned like your previous patch, and it would be nice to use it for code maintenance. Sorry about that.","commit_id":"ebb9ce20284b64e97bded2d6cc47f4992004013c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"76c863dbec92c6d214e16b6407b0d8a1895f797a","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    # Using CINDER_ENABLED_BACKENDS"},{"line_number":359,"context_line":"    if [[ -n \"$CINDER_ENABLED_BACKENDS\" ]] \u0026\u0026 [[ $CINDER_ENABLED_BACKENDS \u003d~ .*,.* ]]; then"},{"line_number":360,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":361,"context_line":"        i\u003d\u00271\u0027"},{"line_number":362,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":363,"context_line":"            be_name\u003d`echo ${be##*:} | cut -d\u0027:\u0027 -f2`"},{"line_number":364,"context_line":"            iniset $TEMPEST_CONFIG volume \"backend${i}_name\" \"$be_name\""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"fa98f980_28ec428f","line":361,"updated":"2014-09-18 08:28:28.000000000","message":"As Dean said, \u0027i\u0027 and \u0027be\u0027 need to be local variables.","commit_id":"16ab929fe72335566c76e88e16d0b7824d83ec89"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8fa174eebb323f5d53cffa77c4950b0d88f7a00a","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            iniset $TEMPEST_CONFIG volume \"backend${i}_name\" \"$be_name\""},{"line_number":366,"context_line":"            i\u003d`expr $i + 1`"},{"line_number":367,"context_line":"        done"},{"line_number":368,"context_line":"    # TODO(coolsvap) Currently deprecated, remove CINDER_MULTI_LVM_BACKEND once its formally removed"},{"line_number":369,"context_line":"    elif [ $CINDER_MULTI_LVM_BACKEND \u003d\u003d \"True\" ]; then"},{"line_number":370,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend \"True\""},{"line_number":371,"context_line":"        iniset $TEMPEST_CONFIG volume backend1_name \"lvmdriver-1\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da9df570_e82500ac","line":368,"updated":"2014-09-22 08:39:29.000000000","message":"I\u0027ve tested this without the elif block. It works all the same. Have a look at lib/cinder and how CINDER_ENABLED_BACKENDS is set based on CINDER_MULTI_LVM_BACKEND","commit_id":"56b7140b93a97d5c7c98f1a2d0e5a653e22e2e19"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"56de956a10a55a83f1924d7e30e14a57b585c890","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        local i\u003d\u00271\u0027"},{"line_number":374,"context_line":"        local be"},{"line_number":375,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":376,"context_line":"            local be_name\u003d`echo ${be##*:} | cut -d\u0027:\u0027 -f2`"},{"line_number":377,"context_line":"            iniset $TEMPEST_CONFIG volume \"backend${i}_name\" \"$be_name\""},{"line_number":378,"context_line":"            i\u003d`expr $i + 1`"},{"line_number":379,"context_line":"        done"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"baa201ad_9962d4ab","line":376,"updated":"2014-10-01 16:32:28.000000000","message":"Each backend configuration is of the form \u0027type:name\u0027 and ${be##*:} already returns just the name...the cut it totally unnecessary.","commit_id":"6d95b63ba5f72bdea445257e03135d497672456d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"56de956a10a55a83f1924d7e30e14a57b585c890","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":376,"context_line":"            local be_name\u003d`echo ${be##*:} | cut -d\u0027:\u0027 -f2`"},{"line_number":377,"context_line":"            iniset $TEMPEST_CONFIG volume \"backend${i}_name\" \"$be_name\""},{"line_number":378,"context_line":"            i\u003d`expr $i + 1`"},{"line_number":379,"context_line":"        done"},{"line_number":380,"context_line":"    fi"},{"line_number":381,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"baa201ad_993014a0","line":378,"updated":"2014-10-01 16:32:28.000000000","message":"This is simpler as \u0027i\u003d$(( i + 1 ))\u0027 and doesn\u0027t need a subshell.","commit_id":"6d95b63ba5f72bdea445257e03135d497672456d"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1ccfc22e91c6a8cd26a2e8f390788c7b5eef9389","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":373,"context_line":"            local be_name\u003d`echo ${be##*:}`"},{"line_number":374,"context_line":"            iniset $TEMPEST_CONFIG volume \"backend${i}_name\" \"$be_name\""},{"line_number":375,"context_line":"            \u0027i\u003d$(( i + 1 ))\u0027"},{"line_number":376,"context_line":"        done"},{"line_number":377,"context_line":"    fi"},{"line_number":378,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"baa201ad_78ff7934","line":375,"updated":"2014-10-16 16:53:46.000000000","message":"What are these single quotes ?","commit_id":"5d4e7bf666c6d140e018354f036f92fdd6f61598"}]}