)]}'
{"lib/neutron":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"38b5077b3b35438cf1746ed644a957c1d30576bc","unresolved":false,"context_lines":[{"line_number":946,"context_line":"    local conf_file\u003d$1"},{"line_number":947,"context_line":"    local section\u003d$2"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI/v2.0"},{"line_number":950,"context_line":"    _neutron_setup_keystone $conf_file $section"},{"line_number":951,"context_line":"}"},{"line_number":952,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_a2eea389","line":949,"updated":"2014-09-30 14:18:22.000000000","message":"I don\u0027t understand why this 1 line isn\u0027t added above?","commit_id":"532db3594c3cc58727db6147203909ee4648034d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f0fe80f80348e85b26d3d7ea931b4dd8e28d52bd","unresolved":false,"context_lines":[{"line_number":946,"context_line":"    local conf_file\u003d$1"},{"line_number":947,"context_line":"    local section\u003d$2"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI/v2.0"},{"line_number":950,"context_line":"    _neutron_setup_keystone $conf_file $section"},{"line_number":951,"context_line":"}"},{"line_number":952,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a8c0949_1941b039","line":949,"in_reply_to":"7a8c0949_fd723348","updated":"2014-10-31 11:48:39.000000000","message":"OK. Done.","commit_id":"532db3594c3cc58727db6147203909ee4648034d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"56f181812c1670891cfa6fe605f904b8b07e7ea0","unresolved":false,"context_lines":[{"line_number":946,"context_line":"    local conf_file\u003d$1"},{"line_number":947,"context_line":"    local section\u003d$2"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI/v2.0"},{"line_number":950,"context_line":"    _neutron_setup_keystone $conf_file $section"},{"line_number":951,"context_line":"}"},{"line_number":952,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_3ec9ce78","line":949,"in_reply_to":"baa201ad_3d5bb455","updated":"2014-10-01 16:01:21.000000000","message":"I don\u0027 t think you gain anything making this function that you wouldn\u0027t also gain with a clear comment in _configure_neutron_metadata_agent().","commit_id":"532db3594c3cc58727db6147203909ee4648034d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4e6873482fe759e7c36eaec673f0c45b056ed1c7","unresolved":false,"context_lines":[{"line_number":946,"context_line":"    local conf_file\u003d$1"},{"line_number":947,"context_line":"    local section\u003d$2"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI/v2.0"},{"line_number":950,"context_line":"    _neutron_setup_keystone $conf_file $section"},{"line_number":951,"context_line":"}"},{"line_number":952,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a8c0949_fd723348","line":949,"in_reply_to":"baa201ad_3ec9ce78","updated":"2014-10-30 03:53:47.000000000","message":"i agree there should be a comment explaining the situation to prevent regressions happening again.\ni don\u0027t mind separate functions or not.","commit_id":"532db3594c3cc58727db6147203909ee4648034d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"bbf52e633318bccf9fe1ab13eb4ba70042235627","unresolved":false,"context_lines":[{"line_number":946,"context_line":"    local conf_file\u003d$1"},{"line_number":947,"context_line":"    local section\u003d$2"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI/v2.0"},{"line_number":950,"context_line":"    _neutron_setup_keystone $conf_file $section"},{"line_number":951,"context_line":"}"},{"line_number":952,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_3d5bb455","line":949,"in_reply_to":"baa201ad_a2eea389","updated":"2014-09-30 14:50:43.000000000","message":"Because everyone removed this 1 line.\n\nhttps://review.openstack.org/#/c/94545/\n\nhttps://review.openstack.org/#/c/122882/\n\nBesides, auth_url in metadata_agent.ini is different from keystone middleware configure.\nSo this function should not be shared so that it does not happen again.","commit_id":"532db3594c3cc58727db6147203909ee4648034d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9eb37619df736d3e617556002b154be4bbc11127","unresolved":false,"context_lines":[{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"    # Configures keystone for metadata_agent"},{"line_number":1017,"context_line":"    # metadata_agent needs auth_url to communicate with keystone"},{"line_number":1018,"context_line":"    if [[ -n $use_auth_url ]]; then"},{"line_number":1019,"context_line":"        iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI/v2.0"},{"line_number":1020,"context_line":"    fi"},{"line_number":1021,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7a8c0949_40eec589","line":1018,"updated":"2014-11-03 00:02:15.000000000","message":"this is confusing ... what if someone set it to \"False\"?\n\nI think the prior comments were saying move it into \"_configure_neutron_metadata_agent\" with a sufficient comment explaining why it needs to be there","commit_id":"4950fbb52241b2e01720e91a7e3648d7c25cd6fe"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1448497c8c4668d56dc34c814b1826e63c674f42","unresolved":false,"context_lines":[{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"    # Configures keystone for metadata_agent"},{"line_number":1017,"context_line":"    # metadata_agent needs auth_url to communicate with keystone"},{"line_number":1018,"context_line":"    if [[ -n $use_auth_url ]]; then"},{"line_number":1019,"context_line":"        iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI/v2.0"},{"line_number":1020,"context_line":"    fi"},{"line_number":1021,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7a8c0949_5ca9427a","line":1018,"in_reply_to":"7a8c0949_40eec589","updated":"2014-11-04 15:13:37.000000000","message":"+1","commit_id":"4950fbb52241b2e01720e91a7e3648d7c25cd6fe"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e0af277d841cc22a8b10a9a22556ec4fba45528e","unresolved":false,"context_lines":[{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"    # Configures keystone for metadata_agent"},{"line_number":1074,"context_line":"    # metadata_agent needs auth_url to communicate with keystone"},{"line_number":1075,"context_line":"    if [[ -n $use_auth_url ]]; then"},{"line_number":1076,"context_line":"        iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI/v2.0"},{"line_number":1077,"context_line":"    fi"},{"line_number":1078,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a961159_b0e9c280","line":1075,"updated":"2014-12-24 07:33:15.000000000","message":"\"-n True\" seems confusing.","commit_id":"e52400cf18b8e9aefd1a85e7c4ef2c974ce45f15"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"3943e7f6f4c7781efdd8c0b39847c67372e1cb9e","unresolved":false,"context_lines":[{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"    # Configures keystone for metadata_agent"},{"line_number":1074,"context_line":"    # metadata_agent needs auth_url to communicate with keystone"},{"line_number":1075,"context_line":"    if [[ -n $use_auth_url ]]; then"},{"line_number":1076,"context_line":"        iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI/v2.0"},{"line_number":1077,"context_line":"    fi"},{"line_number":1078,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a961159_73876461","line":1075,"in_reply_to":"3a961159_b0e9c280","updated":"2014-12-24 07:49:57.000000000","message":"Done.","commit_id":"e52400cf18b8e9aefd1a85e7c4ef2c974ce45f15"}]}