)]}'
{"id":"openstack%2Fdevstack~124467","triplet_id":"openstack%2Fdevstack~master~Id0cb1e6e1cece21bc5dbf427c4d756af86fbd927","project":"openstack/devstack","branch":"master","topic":"124467","hashtags":[],"change_id":"Id0cb1e6e1cece21bc5dbf427c4d756af86fbd927","subject":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values","status":"MERGED","created":"2014-09-26 17:12:07.000000000","updated":"2014-10-13 23:12:37.000000000","submitted":"2014-10-13 23:12:36.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bef2f96fd989c3b9e81505921f4cf8229ded9cb0","_number":124467,"virtual_id_number":124467,"owner":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2014-10-10 13:37:50.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":2,"date":"2014-10-13 23:12:36.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},{"value":2,"date":"2014-10-13 15:12:11.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2014-10-10 12:29:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},{"value":2,"date":"2014-10-13 21:37:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},{"value":1,"date":"2014-10-13 21:37:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-26 17:12:17.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2014-09-28 21:22:40.000000000","updated_by":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-09-29 15:15:44.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-10-10 12:29:47.000000000","updated_by":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"reviewer":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"state":"REVIEWER"},{"updated":"2014-10-10 13:37:50.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-10-13 15:12:11.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-10-13 21:37:23.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2014-10-13 23:12:36.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5636bfcd0b3954920487a71a0e3ef707a3fd418e","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-09-26 17:12:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"67634a6061c5b3fdd6b15b17f4a805d253f4e68d","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2014-09-26 17:12:17.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. The more you\n    participate in the community the more rewarding it is for you. You may also\n    notice that the more you get to know people and get to be known, the faster\n    your patches will be reviewed and eventually approved. Get to know others\n    and become known by doing code reviews: anybody can do it, and it\u0027s a\n    great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: https://wiki.openstack.org/wiki/Gerrit_Workflow\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"2dedf38f0c2769ce3b1c2a6e1139ca3326477572","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-09-26 19:37:49.000000000","message":"Patch Set 1:\n\nThanks for taking this on.  I would like to see some tests added in tests/test_config.sh to verify this continues to work, these ini functions are fairly fragile.","accounts_in_message":[],"_revision_number":1},{"id":"bb928297e991b61cc905ad0986d79c81ee85f6a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-27 01:02:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/67/124467/1/check/check-tempest-dsvm-full/ae99ff3 : SUCCESS in 46m 45s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/67/124467/1/check/check-tempest-dsvm-postgres-full/3650d38 : SUCCESS in 54m 52s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/67/124467/1/check/check-tempest-dsvm-neutron-full/e5c6303 : SUCCESS in 1h 00m 26s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/67/124467/1/check/check-tempest-dsvm-neutron-heat-slow/f0aed9a : SUCCESS in 30m 10s\n- check-grenade-dsvm http://logs.openstack.org/67/124467/1/check/check-grenade-dsvm/5b061d2 : SUCCESS in 45m 51s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/124467/1/check/gate-tempest-dsvm-large-ops/73733ed : SUCCESS in 30m 09s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/124467/1/check/gate-tempest-dsvm-neutron-large-ops/4579c12 : SUCCESS in 20m 30s\n- gate-devstack-bashate http://logs.openstack.org/67/124467/1/check/gate-devstack-bashate/cf73e4b : SUCCESS in 1m 51s\n- check-devstack-dsvm-cells http://logs.openstack.org/67/124467/1/check/check-devstack-dsvm-cells/7633319 : SUCCESS in 13m 48s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/124467/1/check/check-grenade-dsvm-partial-ncpu/8824b2c : SUCCESS in 58m 27s\n- check-neutron-dsvm-functional http://logs.openstack.org/67/124467/1/check/check-neutron-dsvm-functional/d4d7644 : SUCCESS in 17m 24s\n- check-swift-dsvm-functional http://logs.openstack.org/67/124467/1/check/check-swift-dsvm-functional/f10d5b0 : SUCCESS in 18m 50s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/67/124467/1/check/check-tempest-dsvm-ironic-pxe_ssh-nv/5cfabec : SUCCESS in 31m 21s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/67/124467/1/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/55e29bb : SUCCESS in 1h 16m 51s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/67/124467/1/check/check-tempest-dsvm-f20/0f496ec : SUCCESS in 43m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f20e8bb3d53c5c6aa64f01cb63d2a4459e02ec20","author":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"date":"2014-09-28 21:22:40.000000000","message":"Patch Set 1:\n\nredhatci results for change 124467\n\nLogs at http://people.redhat.com/~iwienand/124467/\n\n* OSLAB_RHEL65 http://people.redhat.com/~iwienand/124467/20140928180434.OSLAB_RHEL65.1.log.gz : SUCCESS Patch Set 1 in 00:24\n* OSLAB_RHEL7 http://people.redhat.com/~iwienand/124467/20140928180601.OSLAB_RHEL7.1.log.gz : FAILURE Patch Set 1 in 00:02\n* OSLAB_FEDORA20 http://people.redhat.com/~iwienand/124467/20140928180842.OSLAB_FEDORA20.1.log.gz : SUCCESS Patch Set 1 in 00:36\n* OSLAB_CENTOS65 http://people.redhat.com/~iwienand/124467/20140928182444.OSLAB_CENTOS65.1.log.gz : FAILURE Patch Set 1 in 00:17\n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/RedHat_CI\nend","accounts_in_message":[],"_revision_number":1},{"id":"131c4ab1896b80feadfd5f8b1b753109a5f99e76","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-09-29 15:15:44.000000000","message":"Patch Set 1: Code-Review-1\n\nWhat\u0027s the example where an extra \u003d is needed here?\n\nAlso, like dean said, tests really needed here. Jump on #openstack-qa if you need some assistance with test strategy.","accounts_in_message":[],"_revision_number":1},{"id":"5217c61fa6b9a496c37ded437fe8237b5b8b611b","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-09-30 14:10:48.000000000","message":"Patch Set 1:\n\nSean, as per the current (Juno) nova.conf documentation (http://docs.openstack.org/trunk/config-reference/content/list-of-compute-config-options.html) the example default value for the volume_drivers attribute are:\n\nvolume_drivers \u003d iscsi\u003dnova.virt.libvirt.volume.LibvirtISCSIVolumeDriver, iser\u003dnova.virt.libvirt.volume.LibvirtISERVolumeDriver, local\u003dnova.virt.libvirt.volume.LibvirtVolumeDriver, fake\u003dnova.virt.libvirt.volume.LibvirtFakeVolumeDriver, rbd\u003dnova.virt.libvirt.volume.LibvirtNetVolumeDriver, sheepdog\u003dnova.virt.libvirt.volume.LibvirtNetVolumeDriver, nfs\u003dnova.virt.libvirt.volume.LibvirtNFSVolumeDriver, aoe\u003dnova.virt.libvirt.volume.LibvirtAOEVolumeDriver, glusterfs\u003dnova.virt.libvirt.volume.LibvirtGlusterfsVolumeDriver, fibre_channel\u003dnova.virt.libvirt.volume.LibvirtFibreChannelVolumeDriver, scality\u003dnova.virt.libvirt.volume.LibvirtScalityVolumeDriver\n\nSo picking the first item in the list as an example, without this change to lib/config if your local.conf contains:\n\n[[post-config|$NOVA_CONF]]\n[libvirt]\nvolume_drivers \u003d iscsi\u003dnova.virt.libvirt.volume.LibvirtISCSIVolumeDriver\n\nyour $NOVA_CONF will end up with:\n\n[libvirt]\n...\nvolume_drivers \u003d iscsi\n\nIn fact if you specified the complete example default value in local.conf you would still only see the above value for volume_drivers.\n\nI\u0027ll amend my commit message text when I\u0027m adding tests to make this more clear.\n\nFergal.","accounts_in_message":[],"_revision_number":1},{"id":"300bc5e8b8362052dc6d2240ae8109ce6a4ffc77","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-09-30 14:48:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"557db9da2978cbe6f7abe02946efcb0386e71da3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-30 16:06:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/67/124467/2/check/check-tempest-dsvm-full/ff27753 : SUCCESS in 56m 52s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/67/124467/2/check/check-tempest-dsvm-postgres-full/44501f0 : SUCCESS in 58m 44s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/67/124467/2/check/check-tempest-dsvm-neutron-full/f54afcb : SUCCESS in 1h 14m 09s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/67/124467/2/check/check-tempest-dsvm-neutron-heat-slow/aa8ddcb : SUCCESS in 20m 39s\n- check-grenade-dsvm http://logs.openstack.org/67/124467/2/check/check-grenade-dsvm/71551cf : SUCCESS in 56m 21s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/124467/2/check/gate-tempest-dsvm-large-ops/4c012b5 : SUCCESS in 21m 57s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/124467/2/check/gate-tempest-dsvm-neutron-large-ops/5d0991d : SUCCESS in 24m 21s\n- gate-devstack-bashate http://logs.openstack.org/67/124467/2/check/gate-devstack-bashate/ed9bf4a : SUCCESS in 12s\n- check-devstack-dsvm-cells http://logs.openstack.org/67/124467/2/check/check-devstack-dsvm-cells/c96a82b : SUCCESS in 35m 07s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/124467/2/check/check-grenade-dsvm-partial-ncpu/c01f627 : SUCCESS in 1h 09m 41s\n- check-neutron-dsvm-functional http://logs.openstack.org/67/124467/2/check/check-neutron-dsvm-functional/13ba735 : SUCCESS in 39m 59s\n- check-swift-dsvm-functional http://logs.openstack.org/67/124467/2/check/check-swift-dsvm-functional/aacfb8f : SUCCESS in 22m 59s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/67/124467/2/check/check-tempest-dsvm-ironic-pxe_ssh-nv/0d64286 : SUCCESS in 46m 45s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/67/124467/2/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/a1fd020 : SUCCESS in 27m 59s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/67/124467/2/check/check-tempest-dsvm-f20/b1bee6f : FAILURE in 5m 54s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"388ca2a9c33697b2f93c174402b2358a986a6c65","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-09-30 16:18:12.000000000","message":"Patch Set 2:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/67/124467/2/27115/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2},{"id":"ca403ffe8e90311cffc61402081878ed203ca5ab","author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"date":"2014-10-01 18:14:15.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"abf63c3ab9d5e891cc5eae4c02fc3bb2318c06b5","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-10-02 12:29:48.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"290fc19aa4507b9998ca1da2b0e810f73810a031","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-10-02 13:16:37.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"74717fd873ab0a926f0d91387854af9c58677b43","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-10-02 13:18:05.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"252f94ed5f8344598f0e4e74039951ae1246584b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-02 14:17:29.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/67/124467/3/check/check-tempest-dsvm-full/6633486 : SUCCESS in 55m 38s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/67/124467/3/check/check-tempest-dsvm-postgres-full/dd7f432 : SUCCESS in 59m 09s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/67/124467/3/check/check-tempest-dsvm-neutron-full/5f83d6c : SUCCESS in 48m 47s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/67/124467/3/check/check-tempest-dsvm-neutron-heat-slow/aa37d1e : SUCCESS in 24m 12s\n- check-grenade-dsvm http://logs.openstack.org/67/124467/3/check/check-grenade-dsvm/c862069 : SUCCESS in 53m 33s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/124467/3/check/gate-tempest-dsvm-large-ops/b7787ba : SUCCESS in 26m 35s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/124467/3/check/gate-tempest-dsvm-neutron-large-ops/f2b3937 : SUCCESS in 24m 39s\n- gate-devstack-bashate http://logs.openstack.org/67/124467/3/check/gate-devstack-bashate/4001013 : SUCCESS in 14s\n- check-devstack-dsvm-cells http://logs.openstack.org/67/124467/3/check/check-devstack-dsvm-cells/6d06ab2 : SUCCESS in 14m 40s\n- check-grenade-dsvm-ironic-sideways-nv http://logs.openstack.org/67/124467/3/check/check-grenade-dsvm-ironic-sideways-nv/caebdc9 : SUCCESS in 54m 46s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/124467/3/check/check-grenade-dsvm-partial-ncpu/aaec15b : SUCCESS in 45m 12s\n- check-neutron-dsvm-functional http://logs.openstack.org/67/124467/3/check/check-neutron-dsvm-functional/dc95ee1 : SUCCESS in 21m 50s\n- check-swift-dsvm-functional http://logs.openstack.org/67/124467/3/check/check-swift-dsvm-functional/d73b287 : SUCCESS in 20m 50s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/67/124467/3/check/check-tempest-dsvm-ironic-pxe_ssh-nv/f0b930d : SUCCESS in 33m 40s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/67/124467/3/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/be31b21 : SUCCESS in 33m 16s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/67/124467/3/check/check-tempest-dsvm-f20/e1fe505 : SUCCESS in 45m 42s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"bced313cee740f28fc2b44837a597af6290c7467","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-10-02 14:24:39.000000000","message":"Patch Set 3: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/67/124467/3/27311/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":3},{"id":"1ef207c2bb6526a9236c748b1ec4c71798817fdc","author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"date":"2014-10-02 16:12:18.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\nThanks for taking the recommendation and uploading the new patch. Some further simplification recommendation inline.","accounts_in_message":[],"_revision_number":3},{"id":"c5cdf2afeab96ce93426c3f1256132d0eb365129","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-10-02 17:45:13.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a676d07f30971971e08281494947e9c73bb6ba6b","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-10-02 17:45:21.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d4100f8da6021f150755d2a71f0ec41c0d8a0984","author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"date":"2014-10-02 18:23:24.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)\n\nlooks good except for the tab character.","accounts_in_message":[],"_revision_number":4},{"id":"a159b5546ce50486279622d9a9104697ca9de40e","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-10-02 18:51:44.000000000","message":"Patch Set 4: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/67/124467/4/27346/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":4},{"id":"20c349c89abeb53505ab686bc00c49375ed8e7c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-02 18:57:16.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/67/124467/4/check/check-tempest-dsvm-full/d64c049 : SUCCESS in 45m 16s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/67/124467/4/check/check-tempest-dsvm-postgres-full/d885dcc : SUCCESS in 42m 42s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/67/124467/4/check/check-tempest-dsvm-neutron-full/697da41 : SUCCESS in 1h 03m 58s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/67/124467/4/check/check-tempest-dsvm-neutron-heat-slow/9ffbf74 : SUCCESS in 20m 27s\n- check-grenade-dsvm http://logs.openstack.org/67/124467/4/check/check-grenade-dsvm/854896e : SUCCESS in 43m 09s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/124467/4/check/gate-tempest-dsvm-large-ops/f4f7ebe : SUCCESS in 26m 17s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/124467/4/check/gate-tempest-dsvm-neutron-large-ops/825d62e : SUCCESS in 21m 36s\n- gate-devstack-bashate http://logs.openstack.org/67/124467/4/check/gate-devstack-bashate/ff9ba7f : SUCCESS in 9s\n- check-devstack-dsvm-cells http://logs.openstack.org/67/124467/4/check/check-devstack-dsvm-cells/9ba3f8d : SUCCESS in 14m 10s\n- check-grenade-dsvm-ironic-sideways-nv http://logs.openstack.org/67/124467/4/check/check-grenade-dsvm-ironic-sideways-nv/3520b5a : SUCCESS in 1h 09m 55s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/124467/4/check/check-grenade-dsvm-partial-ncpu/1683fa0 : SUCCESS in 49m 09s\n- check-neutron-dsvm-functional http://logs.openstack.org/67/124467/4/check/check-neutron-dsvm-functional/54b7fdf : SUCCESS in 19m 08s\n- check-swift-dsvm-functional http://logs.openstack.org/67/124467/4/check/check-swift-dsvm-functional/ea8aee9 : SUCCESS in 19m 34s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/67/124467/4/check/check-tempest-dsvm-ironic-pxe_ssh-nv/42fa92a : FAILURE in 19m 10s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/67/124467/4/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/ed4bed4 : FAILURE in 20m 01s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/67/124467/4/check/check-tempest-dsvm-f20/788d5ed : SUCCESS in 39m 31s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"a2c170cae82a221669a1382033063a772b2f8b6c","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-10-02 19:14:50.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"9cb95bb3b30ee31c96c3ac83bf7dd9ffccec8e07","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-10-02 19:16:05.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"4828f7951d10a171b3a6c0a748b8d1a9c6857788","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-02 20:20:14.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/67/124467/5/check/check-tempest-dsvm-full/7a7a04b : SUCCESS in 55m 43s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/67/124467/5/check/check-tempest-dsvm-postgres-full/0b4c9a5 : SUCCESS in 45m 16s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/67/124467/5/check/check-tempest-dsvm-neutron-full/08b0a88 : SUCCESS in 49m 07s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/67/124467/5/check/check-tempest-dsvm-neutron-heat-slow/9ed55cc : SUCCESS in 24m 02s\n- check-grenade-dsvm http://logs.openstack.org/67/124467/5/check/check-grenade-dsvm/39ba337 : SUCCESS in 51m 41s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/124467/5/check/gate-tempest-dsvm-large-ops/31dec25 : SUCCESS in 27m 22s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/124467/5/check/gate-tempest-dsvm-neutron-large-ops/e04fd26 : SUCCESS in 23m 26s\n- gate-devstack-bashate http://logs.openstack.org/67/124467/5/check/gate-devstack-bashate/13d22d2 : SUCCESS in 16s\n- check-devstack-dsvm-cells http://logs.openstack.org/67/124467/5/check/check-devstack-dsvm-cells/83b0170 : SUCCESS in 18m 13s\n- check-grenade-dsvm-ironic-sideways-nv http://logs.openstack.org/67/124467/5/check/check-grenade-dsvm-ironic-sideways-nv/d4f3b14 : SUCCESS in 1h 05m 08s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/124467/5/check/check-grenade-dsvm-partial-ncpu/52b278d : SUCCESS in 45m 03s\n- check-neutron-dsvm-functional http://logs.openstack.org/67/124467/5/check/check-neutron-dsvm-functional/2f716f2 : SUCCESS in 15m 42s\n- check-swift-dsvm-functional http://logs.openstack.org/67/124467/5/check/check-swift-dsvm-functional/f25dfff : SUCCESS in 20m 42s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/67/124467/5/check/check-tempest-dsvm-ironic-pxe_ssh-nv/ea15e6d : FAILURE in 23m 20s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/67/124467/5/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/9c91a36 : SUCCESS in 28m 25s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/67/124467/5/check/check-tempest-dsvm-f20/34a47ff : SUCCESS in 42m 04s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"2f6df7d97dbc2d25338a76d2eaceda0bfc473438","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-10-02 20:21:19.000000000","message":"Patch Set 5: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/67/124467/5/27362/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":5},{"id":"cd0060a9564edb087a8607a132a6b7c8e7669237","author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"date":"2014-10-02 20:29:37.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"cb3bf53c7d2a851d3f6b768609667998b1a8ebc8","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-08 16:52:07.000000000","message":"Patch Set 5: Code-Review+2\n\n(1 comment)\n\nI think this is going to have a conflict with https://review.openstack.org/#/c/124227/.  Fix the comment if/when you rebase.","accounts_in_message":[],"_revision_number":5},{"id":"aaf0152a1a6502914522f72a25335dc544639a44","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-10-09 20:17:00.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"ea0b521b00903089cc91c2d8f3bf0e65b55f3253","author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"date":"2014-10-09 20:19:02.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"4fa023d0bc318ee27a0e6cf07c5dfa896d8f17ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-09 21:16:32.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/67/124467/6/check/check-tempest-dsvm-full/9b9456d : SUCCESS in 59m 20s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/67/124467/6/check/check-tempest-dsvm-postgres-full/9111d2c : SUCCESS in 44m 03s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/67/124467/6/check/check-tempest-dsvm-neutron-full/79f64f7 : SUCCESS in 54m 18s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/67/124467/6/check/check-tempest-dsvm-neutron-heat-slow/720d017 : SUCCESS in 23m 21s\n- check-grenade-dsvm http://logs.openstack.org/67/124467/6/check/check-grenade-dsvm/69e950d : SUCCESS in 50m 40s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/124467/6/check/gate-tempest-dsvm-large-ops/3e8582e : SUCCESS in 23m 18s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/124467/6/check/gate-tempest-dsvm-neutron-large-ops/5aa13b0 : SUCCESS in 22m 30s\n- gate-devstack-bashate http://logs.openstack.org/67/124467/6/check/gate-devstack-bashate/5b46951 : SUCCESS in 32s\n- check-devstack-dsvm-cells http://logs.openstack.org/67/124467/6/check/check-devstack-dsvm-cells/480a71b : SUCCESS in 15m 19s\n- check-grenade-dsvm-ironic-sideways-nv http://logs.openstack.org/67/124467/6/check/check-grenade-dsvm-ironic-sideways-nv/ab1a21c : FAILURE in 20m 55s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/124467/6/check/check-grenade-dsvm-partial-ncpu/0733265 : SUCCESS in 48m 16s\n- check-neutron-dsvm-functional http://logs.openstack.org/67/124467/6/check/check-neutron-dsvm-functional/7518bf8 : SUCCESS in 15m 59s\n- check-swift-dsvm-functional http://logs.openstack.org/67/124467/6/check/check-swift-dsvm-functional/d1d9fe0 : SUCCESS in 18m 38s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/67/124467/6/check/check-tempest-dsvm-ironic-pxe_ssh-nv/f2ced4f : SUCCESS in 34m 16s\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/67/124467/6/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/50754ac : SUCCESS in 27m 32s\n- check-tempest-dsvm-f20 http://logs.openstack.org/67/124467/6/check/check-tempest-dsvm-f20/cf25b44 : SUCCESS in 50m 18s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"89d4f66df7736b9a9b26cc4d577d9271661558c5","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-10-09 21:20:17.000000000","message":"Patch Set 6: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/67/124467/6/28098/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":6},{"id":"5d0935cb72ab52babe94d098832ed71a4469a822","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-09 23:09:01.000000000","message":"Patch Set 6: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":6},{"id":"521ff69c688138c0121b8a2e6a874ad6d0585c7e","author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"date":"2014-10-10 12:26:52.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"4e547db38655851776861a8209e017de5833721b","author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"date":"2014-10-10 12:29:47.000000000","message":"Patch Set 7: Code-Review+1","accounts_in_message":[],"_revision_number":7},{"id":"7e61515a063ed4d77d6e1975f7e61b1b03fc0775","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-10 13:23:08.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/67/124467/7/check/check-tempest-dsvm-full/e85d497 : SUCCESS in 53m 40s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/67/124467/7/check/check-tempest-dsvm-postgres-full/f7913d8 : SUCCESS in 56m 07s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/67/124467/7/check/check-tempest-dsvm-neutron-full/562190e : SUCCESS in 53m 10s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/67/124467/7/check/check-tempest-dsvm-neutron-heat-slow/924f819 : SUCCESS in 35m 09s\n- check-grenade-dsvm http://logs.openstack.org/67/124467/7/check/check-grenade-dsvm/d0e3c55 : SUCCESS in 43m 40s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/124467/7/check/gate-tempest-dsvm-large-ops/921b046 : SUCCESS in 18m 49s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/124467/7/check/gate-tempest-dsvm-neutron-large-ops/086a9f3 : SUCCESS in 22m 01s\n- gate-devstack-bashate http://logs.openstack.org/67/124467/7/check/gate-devstack-bashate/acd2b8b : SUCCESS in 28s\n- check-devstack-dsvm-cells http://logs.openstack.org/67/124467/7/check/check-devstack-dsvm-cells/72e0527 : SUCCESS in 12m 41s\n- check-grenade-dsvm-ironic-sideways-nv http://logs.openstack.org/67/124467/7/check/check-grenade-dsvm-ironic-sideways-nv/5b641e3 : FAILURE in 22m 20s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/124467/7/check/check-grenade-dsvm-partial-ncpu/37d2768 : SUCCESS in 48m 33s\n- check-neutron-dsvm-functional http://logs.openstack.org/67/124467/7/check/check-neutron-dsvm-functional/77a3df0 : SUCCESS in 16m 50s\n- check-swift-dsvm-functional http://logs.openstack.org/67/124467/7/check/check-swift-dsvm-functional/b54673d : SUCCESS in 21m 29s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/67/124467/7/check/check-tempest-dsvm-ironic-pxe_ssh-nv/8ad619d : SUCCESS in 31m 02s\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/67/124467/7/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/871edd3 : SUCCESS in 32m 36s\n- check-tempest-dsvm-f20 http://logs.openstack.org/67/124467/7/check/check-tempest-dsvm-f20/c2dda1c : SUCCESS in 45m 48s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"bcb0f2f6abb77d8445d3e23f6c5cdf955926b8d6","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-10-10 13:37:50.000000000","message":"Patch Set 7: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/67/124467/7/28162/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":7},{"id":"699874197ba5cf7f8949b1ec91391e101e2a25ea","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-13 15:12:11.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"dcce208f07d8d4dd4fd4e3f424c97dcbeafd625d","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-10-13 21:37:23.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nAll getting rather complex, but at least its commented :)","accounts_in_message":[],"_revision_number":7},{"id":"862358af283ef28b99b47122837edbf88aec7d21","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-13 21:37:24.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"c720bfd5ac7e3963f58a4bb25a4288d4c1503744","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-13 23:12:36.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded.\n\n- gate-tempest-dsvm-full http://logs.openstack.org/67/124467/7/gate/gate-tempest-dsvm-full/c760654 : SUCCESS in 48m 59s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/67/124467/7/gate/gate-tempest-dsvm-postgres-full/e98d7ce : SUCCESS in 48m 47s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/67/124467/7/gate/gate-tempest-dsvm-neutron-full/92fd85d : SUCCESS in 56m 24s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/67/124467/7/gate/gate-tempest-dsvm-neutron-heat-slow/bfd32ad : SUCCESS in 19m 21s\n- gate-grenade-dsvm http://logs.openstack.org/67/124467/7/gate/gate-grenade-dsvm/28255b5 : SUCCESS in 47m 47s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/124467/7/gate/gate-tempest-dsvm-large-ops/08ec368 : SUCCESS in 20m 34s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/124467/7/gate/gate-tempest-dsvm-neutron-large-ops/aa2aed9 : SUCCESS in 17m 12s\n- gate-devstack-bashate http://logs.openstack.org/67/124467/7/gate/gate-devstack-bashate/1acf321 : SUCCESS in 13s\n- gate-devstack-dsvm-cells http://logs.openstack.org/67/124467/7/gate/gate-devstack-dsvm-cells/78130f0 : SUCCESS in 15m 04s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/124467/7/gate/gate-grenade-dsvm-partial-ncpu/760ecb6 : SUCCESS in 50m 30s\n- gate-neutron-dsvm-functional http://logs.openstack.org/67/124467/7/gate/gate-neutron-dsvm-functional/6e87d55 : SUCCESS in 17m 10s\n- gate-swift-dsvm-functional http://logs.openstack.org/67/124467/7/gate/gate-swift-dsvm-functional/b469f9f : SUCCESS in 18m 57s","accounts_in_message":[],"_revision_number":7},{"id":"fa7ab4837ac825cf92b7560303b2fccdca1383fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-13 23:12:37.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"cc87c2871dc436b2134f60e9fa4663723a094ebd","revisions":{"35d01c4e423d075dc2319c685c80696438536099":{"kind":"REWORK","_number":1,"created":"2014-09-26 17:12:07.000000000","uploader":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"ref":"refs/changes/67/124467/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/67/124467/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/67/124467/1"}}},"commit":{"parents":[{"commit":"18d4778cf7bffa60eb2e996a13c129c64f83575f","subject":"Configure endpoints to use SSL natively or via proxy","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/18d4778cf7bffa60eb2e996a13c129c64f83575f"}]}],"author":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-09-26 17:11:59.000000000","tz":-240},"committer":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-09-26 17:11:59.000000000","tz":-240},"subject":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values","message":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values\n\nWhen attempting to add a libvirt section with a volume_drivers entry\nto $NOVA_CONF, via a post-config block in the local.conf file, I\nencountered problems; the value part of a volume_drivers setting\nis a comma separate list of driver\u003dpython.import.path.for.driver\nvalues, but the post-config process chops off the value at the \u0027\u003d\u0027\nso the $NOVA_CONF entry ends up as:\n\n[libvirt]\nvolume_driver \u003d driver\n\nThe fix ensures that complete value for volume_drivers is set\ncorrectly in the $NOVA_CONF, by ensuring the \u0027\u003d\u0027 in values are\nhandled appropriately when processing the local.conf.\n\nChange-Id: Id0cb1e6e1cece21bc5dbf427c4d756af86fbd927\nCloses-Bug: #1374482\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/35d01c4e423d075dc2319c685c80696438536099"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/35d01c4e423d075dc2319c685c80696438536099"}]},"branch":"refs/heads/master"},"4ee56e41c8e615be0bc06d39773467fbde755014":{"kind":"REWORK","_number":2,"created":"2014-09-30 14:48:52.000000000","uploader":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"ref":"refs/changes/67/124467/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/67/124467/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/67/124467/2"}}},"commit":{"parents":[{"commit":"8e087fa83b1a1b1a2cdbae6f855c9d742e5650f5","subject":"Merge \"XenAPI: Upgrade built-VM to Trusty\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8e087fa83b1a1b1a2cdbae6f855c9d742e5650f5"}]}],"author":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-09-30 14:32:02.000000000","tz":-240},"committer":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-09-30 14:32:02.000000000","tz":-240},"subject":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values","message":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values\n\nWhen attempting to add a libvirt section with a volume_drivers entry\nto $NOVA_CONF, via a post-config block in the local.conf file, I\nencountered problems; the value for this attribute takes the form\n\n    driver\u003dpython.import.path.to.driver\n\nbut the value actually populated in the $NOVA_CONF was truncated at the\nequals.\n\nTaking the iscsi driver setting specified in the official nova.conf\ndocumentation as an example, if I have the following in my local.conf\nfile:\n\n[[post-config|$NOVA_CONF]]\n[libvirt]\nvolume_drivers \u003d iscsi\u003dnova.virt.libvirt.volume.LibvirtISCSIVolumeDriver\n\nI will see that the generated $NOVA_CONF has the following:\n\n[libvirt]\nvolume_driver \u003d iscsi\n\nThis occurs because the existing handling for a post-config setion, as\nimplemented in merge_config_file(), splits the line on the equals sign,\nand then uses the first and seconds elements of the resulting array as\nattribute name and value respectively.\n\nHowever when an equals occurs as part of the value this results in the\nvalue being truncated at the first equals in the value.\n\nThe fix that I have implemented ensures that a complete value for\nvolume_drivers is set in the $NOVA_CONF, by joining the second and\nremaining elements in the array with \u0027\u003d\u0027 to form an appropriate value.\n\nI\u0027ve also added test5 to tests/test_config.sh to test for an verify\ncorrect operation when this scenario is encountered.\n\nChange-Id: Id0cb1e6e1cece21bc5dbf427c4d756af86fbd927\nCloses-Bug: #1374482\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4ee56e41c8e615be0bc06d39773467fbde755014"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4ee56e41c8e615be0bc06d39773467fbde755014"}]},"branch":"refs/heads/master"},"01964b4ea2d4f21f6226484c19a30f70cd57f18f":{"kind":"REWORK","_number":3,"created":"2014-10-02 13:16:37.000000000","uploader":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"ref":"refs/changes/67/124467/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/67/124467/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/67/124467/3"}}},"commit":{"parents":[{"commit":"d38675cd9e11ba04b57eefcb5df67cb79aa187cc","subject":"Merge \"remove deprecated pip option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d38675cd9e11ba04b57eefcb5df67cb79aa187cc"}]}],"author":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-10-02 13:16:13.000000000","tz":-240},"committer":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-10-02 13:16:35.000000000","tz":-240},"subject":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values","message":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values\n\nWhen attempting to add a libvirt section with a volume_drivers entry\nto $NOVA_CONF, via a post-config block in the local.conf file, I\nencountered problems; the value for this attribute takes the form\n\n    driver\u003dpython.import.path.to.driver\n\nbut the value actually populated in the $NOVA_CONF was truncated at the\nequals.\n\nTaking the iscsi driver setting specified in the official nova.conf\ndocumentation as an example, if I have the following in my local.conf\nfile:\n\n[[post-config|$NOVA_CONF]]\n[libvirt]\nvolume_drivers \u003d iscsi\u003dnova.virt.libvirt.volume.LibvirtISCSIVolumeDriver\n\nI will see that the generated $NOVA_CONF has the following:\n\n[libvirt]\nvolume_driver \u003d iscsi\n\nThis occurs because the existing handling for a post-config setion, as\nimplemented in merge_config_file(), splits the line on the equals sign,\nand then uses the first and seconds elements of the resulting array as\nattribute name and value respectively.\n\nHowever when an equals occurs as part of the value this results in the\nvalue being truncated at the first equals in the value.\n\nThe fix that I have implemented extracts the rest of the line after the\nfirst \u0027\u003d\u0027 character as the value and then strips leading and trailing\nspaces from the value.\n\nI\u0027ve also added test5 to tests/test_config.sh to test for, and verify,\ncorrect operation when this scenario is encountered.  Similarly I\u0027ve\nadded test6 to ensure that trailing spaces in values are stripped\ncorrectly.\n\nChange-Id: Id0cb1e6e1cece21bc5dbf427c4d756af86fbd927\nCloses-Bug: #1374482\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/01964b4ea2d4f21f6226484c19a30f70cd57f18f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/01964b4ea2d4f21f6226484c19a30f70cd57f18f"}]},"branch":"refs/heads/master"},"4a1f2095eb13bceb5ca9c1f597ec36254703de3b":{"kind":"REWORK","_number":4,"created":"2014-10-02 17:45:21.000000000","uploader":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"ref":"refs/changes/67/124467/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/67/124467/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/67/124467/4"}}},"commit":{"parents":[{"commit":"f156ebfaebabcb10ca59cc564e01b72398c53271","subject":"Merge \"Ensure sbin is in PATH.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f156ebfaebabcb10ca59cc564e01b72398c53271"}]}],"author":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-10-02 17:41:09.000000000","tz":-240},"committer":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-10-02 17:45:19.000000000","tz":-240},"subject":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values","message":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values\n\nWhen attempting to add a libvirt section with a volume_drivers entry\nto $NOVA_CONF, via a post-config block in the local.conf file, I\nencountered problems; the value for this attribute takes the form\n\n    driver\u003dpython.import.path.to.driver\n\nbut the value actually populated in the $NOVA_CONF was truncated at the\nequals.\n\nTaking the iscsi driver setting specified in the official nova.conf\ndocumentation as an example, if I have the following in my local.conf\nfile:\n\n[[post-config|$NOVA_CONF]]\n[libvirt]\nvolume_drivers \u003d iscsi\u003dnova.virt.libvirt.volume.LibvirtISCSIVolumeDriver\n\nI will see that the generated $NOVA_CONF has the following:\n\n[libvirt]\nvolume_driver \u003d iscsi\n\nThis occurs because the existing handling for a post-config setion, as\nimplemented in merge_config_file(), splits the line on the equals sign,\nand then uses the first and seconds elements of the resulting array as\nattribute name and value respectively.\n\nHowever when an equals occurs as part of the value this results in the\nvalue being truncated at the first equals in the value.\n\nThe fix I\u0027ve implemented, based upon review feedback, extracts the\ncontents of $0 before the first equals as the attr name, and extracts\nthe remainder after the equals as the value. Then it strips the leading\nand trailing whitespaces from both as appropriate.\n\nI\u0027ve also added test5 to tests/test_config.sh to test for, and verify,\ncorrect operation when this scenario is encountered.  Similarly I\u0027ve\nadded test6 to ensure that trailing spaces in values are stripped\ncorrectly.\n\nChange-Id: Id0cb1e6e1cece21bc5dbf427c4d756af86fbd927\nCloses-Bug: #1374482\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4a1f2095eb13bceb5ca9c1f597ec36254703de3b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4a1f2095eb13bceb5ca9c1f597ec36254703de3b"}]},"branch":"refs/heads/master"},"176f9f5511aa664a968b08533814d05f5c36bbb4":{"kind":"REWORK","_number":5,"created":"2014-10-02 19:14:50.000000000","uploader":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"ref":"refs/changes/67/124467/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/67/124467/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/67/124467/5"}}},"commit":{"parents":[{"commit":"4e10843812a25dd3645bf25f166d9be20ce242a0","subject":"Merge \"Install dib from pip\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4e10843812a25dd3645bf25f166d9be20ce242a0"}]}],"author":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-10-02 19:14:44.000000000","tz":-240},"committer":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-10-02 19:14:49.000000000","tz":-240},"subject":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values","message":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values\n\nWhen attempting to add a libvirt section with a volume_drivers entry\nto $NOVA_CONF, via a post-config block in the local.conf file, I\nencountered problems; the value for this attribute takes the form\n\n    driver\u003dpython.import.path.to.driver\n\nbut the value actually populated in the $NOVA_CONF was truncated at the\nequals.\n\nTaking the iscsi driver setting specified in the official nova.conf\ndocumentation as an example, if I have the following in my local.conf\nfile:\n\n[[post-config|$NOVA_CONF]]\n[libvirt]\nvolume_drivers \u003d iscsi\u003dnova.virt.libvirt.volume.LibvirtISCSIVolumeDriver\n\nI will see that the generated $NOVA_CONF has the following:\n\n[libvirt]\nvolume_driver \u003d iscsi\n\nThis occurs because the existing handling for a post-config setion, as\nimplemented in merge_config_file(), splits the line on the equals sign,\nand then uses the first and seconds elements of the resulting array as\nattribute name and value respectively.\n\nHowever when an equals occurs as part of the value this results in the\nvalue being truncated at the first equals in the value.\n\nThe fix I\u0027ve implemented, based upon review feedback, extracts the\ncontents of $0 before the first equals as the attr name, and extracts\nthe remainder after the equals as the value. Then it strips the leading\nand trailing whitespaces from both as appropriate.\n\nI\u0027ve also added test5 to tests/test_config.sh to test for, and verify,\ncorrect operation when this scenario is encountered.  Similarly I\u0027ve\nadded test6 to ensure that trailing spaces in values are stripped\ncorrectly.\n\nChange-Id: Id0cb1e6e1cece21bc5dbf427c4d756af86fbd927\nCloses-Bug: #1374482\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/176f9f5511aa664a968b08533814d05f5c36bbb4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/176f9f5511aa664a968b08533814d05f5c36bbb4"}]},"branch":"refs/heads/master"},"0128cbd4a8b9dd2ce0b4b197bcfc06983c92eae4":{"kind":"REWORK","_number":6,"created":"2014-10-09 20:17:00.000000000","uploader":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"ref":"refs/changes/67/124467/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/67/124467/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/67/124467/6"}}},"commit":{"parents":[{"commit":"77001dd64ab14ee6cb1daf76fd93490519ed919f","subject":"Merge \"Install latest EPEL release\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/77001dd64ab14ee6cb1daf76fd93490519ed919f"}]}],"author":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-10-09 20:16:42.000000000","tz":-240},"committer":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-10-09 20:16:42.000000000","tz":-240},"subject":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values","message":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values\n\nWhen attempting to add a libvirt section with a volume_drivers entry\nto $NOVA_CONF, via a post-config block in the local.conf file, I\nencountered problems; the value for this attribute takes the form\n\n    driver\u003dpython.import.path.to.driver\n\nbut the value actually populated in the $NOVA_CONF was truncated at the\nequals.\n\nTaking the iscsi driver setting specified in the official nova.conf\ndocumentation as an example, if I have the following in my local.conf\nfile:\n\n[[post-config|$NOVA_CONF]]\n[libvirt]\nvolume_drivers \u003d iscsi\u003dnova.virt.libvirt.volume.LibvirtISCSIVolumeDriver\n\nI will see that the generated $NOVA_CONF has the following:\n\n[libvirt]\nvolume_driver \u003d iscsi\n\nThis occurs because the existing handling for a post-config setion, as\nimplemented in merge_config_file(), splits the line on the equals sign,\nand then uses the first and seconds elements of the resulting array as\nattribute name and value respectively.\n\nHowever when an equals occurs as part of the value this results in the\nvalue being truncated at the first equals in the value.\n\nThe fix I\u0027ve implemented, based upon review feedback, extracts the\ncontents of $0 before the first equals as the attr name, and extracts\nthe remainder after the equals as the value. Then it strips the leading\nand trailing whitespaces from both as appropriate.\n\nI\u0027ve also added test5 to tests/test_config.sh to test for, and verify,\ncorrect operation when this scenario is encountered.  Similarly I\u0027ve\nadded test6 to ensure that trailing spaces in values are stripped\ncorrectly.\n\nChange-Id: Id0cb1e6e1cece21bc5dbf427c4d756af86fbd927\nCloses-Bug: #1374482\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0128cbd4a8b9dd2ce0b4b197bcfc06983c92eae4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0128cbd4a8b9dd2ce0b4b197bcfc06983c92eae4"}]},"branch":"refs/heads/master"},"cc87c2871dc436b2134f60e9fa4663723a094ebd":{"kind":"REWORK","_number":7,"created":"2014-10-10 12:26:52.000000000","uploader":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"ref":"refs/changes/67/124467/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/67/124467/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/67/124467/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/67/124467/7"}}},"commit":{"parents":[{"commit":"284492cc1194bb2f156f860d35b5a1a46ac5b179","subject":"Merge \"Enable DIB service to build with minimal net access\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/284492cc1194bb2f156f860d35b5a1a46ac5b179"}]}],"author":{"name":"Fergal Mc Carthy","email":"fergal.mccarthy@hp.com","date":"2014-10-09 20:16:42.000000000","tz":-240},"committer":{"name":"Robert Li","email":"baoli@cisco.com","date":"2014-10-10 12:25:38.000000000","tz":-240},"subject":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values","message":"local.conf processing doesn\u0027t handle \u0027\u003d\u0027 in values\n\nWhen attempting to add a libvirt section with a volume_drivers entry\nto $NOVA_CONF, via a post-config block in the local.conf file, I\nencountered problems; the value for this attribute takes the form\n\n    driver\u003dpython.import.path.to.driver\n\nbut the value actually populated in the $NOVA_CONF was truncated at the\nequals.\n\nTaking the iscsi driver setting specified in the official nova.conf\ndocumentation as an example, if I have the following in my local.conf\nfile:\n\n[[post-config|$NOVA_CONF]]\n[libvirt]\nvolume_drivers \u003d iscsi\u003dnova.virt.libvirt.volume.LibvirtISCSIVolumeDriver\n\nI will see that the generated $NOVA_CONF has the following:\n\n[libvirt]\nvolume_driver \u003d iscsi\n\nThis occurs because the existing handling for a post-config setion, as\nimplemented in merge_config_file(), splits the line on the equals sign,\nand then uses the first and seconds elements of the resulting array as\nattribute name and value respectively.\n\nHowever when an equals occurs as part of the value this results in the\nvalue being truncated at the first equals in the value.\n\nThe fix I\u0027ve implemented, based upon review feedback, extracts the\ncontents of $0 before the first equals as the attr name, and extracts\nthe remainder after the equals as the value. Then it strips the leading\nand trailing whitespaces from both as appropriate.\n\nI\u0027ve also added test5 to tests/test_config.sh to test for, and verify,\ncorrect operation when this scenario is encountered.  Similarly I\u0027ve\nadded test6 to ensure that trailing spaces in values are stripped\ncorrectly.\n\nChange-Id: Id0cb1e6e1cece21bc5dbf427c4d756af86fbd927\nCloses-Bug: #1374482\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cc87c2871dc436b2134f60e9fa4663723a094ebd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cc87c2871dc436b2134f60e9fa4663723a094ebd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}