)]}'
{"lib/ceph":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6e6336d1f91b59c10b09e936924cd88d2a8551e5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    uninstall_package ceph ceph-common python-ceph libcephfs1 \u003e /dev/null 2\u003e\u00261"},{"line_number":104,"context_line":"    VIRSH_UUID\u003d$(sudo virsh secret-list | awk \u0027/^ ?[0-9a-z]/ { print $1 }\u0027)"},{"line_number":105,"context_line":"    sudo virsh secret-undefine ${VIRSH_UUID} \u003e/dev/null 2\u003e\u00261"},{"line_number":106,"context_line":"    iniset $NOVA_CONF libvirt rbd_secret_uuid \"\""},{"line_number":107,"context_line":"}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# configure_ceph() - Set config files, create data dirs, etc"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_c44e176f","line":106,"updated":"2014-10-02 16:51:02.000000000","message":"This should be inside an \u0027if is_service_enabled nova\u0027 block","commit_id":"fb5c2866d2ecdff2b4a069c4a8890d9fbc424ec7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1dabd51de27d148f8e0a65418e8604d74fd0550b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    uninstall_package ceph ceph-common python-ceph libcephfs1 \u003e /dev/null 2\u003e\u00261"},{"line_number":104,"context_line":"    VIRSH_UUID\u003d$(sudo virsh secret-list | awk \u0027/^ ?[0-9a-z]/ { print $1 }\u0027)"},{"line_number":105,"context_line":"    sudo virsh secret-undefine ${VIRSH_UUID} \u003e/dev/null 2\u003e\u00261"},{"line_number":106,"context_line":"    iniset $NOVA_CONF libvirt rbd_secret_uuid \"\""},{"line_number":107,"context_line":"}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# configure_ceph() - Set config files, create data dirs, etc"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_1d1054a7","line":106,"in_reply_to":"baa201ad_b12a217c","updated":"2014-10-03 19:07:39.000000000","message":"Actually the virsh secret is defined based on whether Cinder is enabled, so I think it should be undefined based on that rather than Nova?","commit_id":"fb5c2866d2ecdff2b4a069c4a8890d9fbc424ec7"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"96ee76ae695a5ec69e0105ab21fff377c2250410","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    uninstall_package ceph ceph-common python-ceph libcephfs1 \u003e /dev/null 2\u003e\u00261"},{"line_number":104,"context_line":"    VIRSH_UUID\u003d$(sudo virsh secret-list | awk \u0027/^ ?[0-9a-z]/ { print $1 }\u0027)"},{"line_number":105,"context_line":"    sudo virsh secret-undefine ${VIRSH_UUID} \u003e/dev/null 2\u003e\u00261"},{"line_number":106,"context_line":"    iniset $NOVA_CONF libvirt rbd_secret_uuid \"\""},{"line_number":107,"context_line":"}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# configure_ceph() - Set config files, create data dirs, etc"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_b12a217c","line":106,"in_reply_to":"baa201ad_c44e176f","updated":"2014-10-03 09:07:03.000000000","message":"the virsh undefined as well :)","commit_id":"fb5c2866d2ecdff2b4a069c4a8890d9fbc424ec7"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"eb54dbfb7a4c59af6335efd69911fc6b84fa57db","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        sudo rm -f ${CEPH_DISK_IMAGE}"},{"line_number":102,"context_line":"    fi"},{"line_number":103,"context_line":"    uninstall_package ceph ceph-common python-ceph libcephfs1 \u003e /dev/null 2\u003e\u00261"},{"line_number":104,"context_line":"    if is_service_enabled cinder; then"},{"line_number":105,"context_line":"        VIRSH_UUID\u003d$(sudo virsh secret-list | awk \u0027/^ ?[0-9a-z]/ { print $1 }\u0027)"},{"line_number":106,"context_line":"        sudo virsh secret-undefine ${VIRSH_UUID} \u003e/dev/null 2\u003e\u00261"},{"line_number":107,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_2f07901a","line":104,"updated":"2014-10-05 22:19:59.000000000","message":"Can you and \u0027or is_service_enabled nova\u0027? if we use only nova and not cinder this might be an issue.","commit_id":"903aa229034aede10670b2bb3a639bf6952675b7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"316577ea8d4bb8f2cef3e27c2b24526b9f355152","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        sudo rm -f ${CEPH_DISK_IMAGE}"},{"line_number":102,"context_line":"    fi"},{"line_number":103,"context_line":"    uninstall_package ceph ceph-common python-ceph libcephfs1 \u003e /dev/null 2\u003e\u00261"},{"line_number":104,"context_line":"    if is_service_enabled cinder; then"},{"line_number":105,"context_line":"        VIRSH_UUID\u003d$(sudo virsh secret-list | awk \u0027/^ ?[0-9a-z]/ { print $1 }\u0027)"},{"line_number":106,"context_line":"        sudo virsh secret-undefine ${VIRSH_UUID} \u003e/dev/null 2\u003e\u00261"},{"line_number":107,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a890539_6e4822cd","line":104,"in_reply_to":"baa201ad_2f07901a","updated":"2014-11-19 17:18:20.000000000","message":"Done","commit_id":"903aa229034aede10670b2bb3a639bf6952675b7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3f8052a09e2e02cb5189606db7de85447eb2a6ec","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    fi"},{"line_number":108,"context_line":"    uninstall_package ceph ceph-common python-ceph libcephfs1 \u003e /dev/null 2\u003e\u00261"},{"line_number":109,"context_line":"    if is_service_enabled cinder || is_service_enabled nova; then"},{"line_number":110,"context_line":"        VIRSH_UUID\u003d$(sudo virsh secret-list | awk \u0027/^ ?[0-9a-z]/ { print $1 }\u0027)"},{"line_number":111,"context_line":"        sudo virsh secret-undefine ${VIRSH_UUID} \u003e/dev/null 2\u003e\u00261"},{"line_number":112,"context_line":"    fi"},{"line_number":113,"context_line":"    if is_service_enabled nova; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a890539_6b8806c7","line":110,"updated":"2014-11-20 00:03:17.000000000","message":"might as well convert this to local while we\u0027re here","commit_id":"de7aad65ab198fa1b33278e238be14f437cb6db9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f71ba647c0f4f8fa46bbe8888983a1b0d7d9d37f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    fi"},{"line_number":108,"context_line":"    uninstall_package ceph ceph-common python-ceph libcephfs1 \u003e /dev/null 2\u003e\u00261"},{"line_number":109,"context_line":"    if is_service_enabled cinder || is_service_enabled nova; then"},{"line_number":110,"context_line":"        VIRSH_UUID\u003d$(sudo virsh secret-list | awk \u0027/^ ?[0-9a-z]/ { print $1 }\u0027)"},{"line_number":111,"context_line":"        sudo virsh secret-undefine ${VIRSH_UUID} \u003e/dev/null 2\u003e\u00261"},{"line_number":112,"context_line":"    fi"},{"line_number":113,"context_line":"    if is_service_enabled nova; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a890539_83b2e446","line":110,"in_reply_to":"5a890539_6b8806c7","updated":"2014-11-25 13:33:48.000000000","message":"Done","commit_id":"de7aad65ab198fa1b33278e238be14f437cb6db9"}]}