)]}'
{"tools/fixup_stuff.sh":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"8e706fc285d21c0ef184ebc13f4cb580fb7ca2e7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    # Get any currently reserved ports, strip off leading whitespace"},{"line_number":58,"context_line":"    reserved_ports\u003d$(sysctl net.ipv4.ip_local_reserved_ports | awk -F\u0027\u003d\u0027 \u0027{print $2;}\u0027 | sed \u0027s/^ //\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if [[ -z \"${reserved_ports}\" ]]; then"},{"line_number":61,"context_line":"        # If there are no currently reserved ports, reserve the keystone ports"},{"line_number":62,"context_line":"        sudo sysctl -w net.ipv4.ip_local_reserved_ports\u003d${keystone_ports}"},{"line_number":63,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":1,"id":"baa201ad_3621d24d","line":60,"updated":"2014-10-02 20:26:47.000000000","message":"this indentation appears to be off","commit_id":"650280092dd50e6514b97741f1cb543a3893e24e"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"6f876224d3a8a0d2afaa1842e0c479a1f585ba25","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    # Get any currently reserved ports, strip off leading whitespace"},{"line_number":58,"context_line":"    reserved_ports\u003d$(sysctl net.ipv4.ip_local_reserved_ports | awk -F\u0027\u003d\u0027 \u0027{print $2;}\u0027 | sed \u0027s/^ //\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if [[ -z \"${reserved_ports}\" ]]; then"},{"line_number":61,"context_line":"        # If there are no currently reserved ports, reserve the keystone ports"},{"line_number":62,"context_line":"        sudo sysctl -w net.ipv4.ip_local_reserved_ports\u003d${keystone_ports}"},{"line_number":63,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":1,"id":"baa201ad_fd164254","line":60,"in_reply_to":"baa201ad_3621d24d","updated":"2014-10-03 06:17:19.000000000","message":"that\u0027s what I get when trying to edit files directly with vim (and not being a vimmers :p)","commit_id":"650280092dd50e6514b97741f1cb543a3893e24e"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"b8293bf96fb4ae4aa914fc004ab075b5bc866c7d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# only do the reserved ports when available, on some system (like containers)"},{"line_number":54,"context_line":"# where it\u0027s not exposed we are almost pretty sure these ports would be"},{"line_number":55,"context_line":"# exclusive for our devstack."},{"line_number":56,"context_line":"if [[ -e /proc/sys/net/ipv4/ip_local_reserved_ports ]];then"},{"line_number":57,"context_line":"    # Get any currently reserved ports, strip off leading whitespace"},{"line_number":58,"context_line":"    reserved_ports\u003d$(sysctl net.ipv4.ip_local_reserved_ports | awk -F\u0027\u003d\u0027 \u0027{print $2;}\u0027 | sed \u0027s/^ //\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"baa201ad_115f6d42","line":56,"updated":"2014-10-03 09:55:44.000000000","message":"We can\u0027t be pretty sure. At least warning message should be shown","commit_id":"f18474bc396e05dafceaee9f3dc72f0a22d6ef7e"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"dff4723fef46bc76ddf6251f11b2c2cfd9e463ca","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# only do the reserved ports when available, on some system (like containers)"},{"line_number":54,"context_line":"# where it\u0027s not exposed we are almost pretty sure these ports would be"},{"line_number":55,"context_line":"# exclusive for our devstack."},{"line_number":56,"context_line":"if [[ -e /proc/sys/net/ipv4/ip_local_reserved_ports ]];then"},{"line_number":57,"context_line":"    # Get any currently reserved ports, strip off leading whitespace"},{"line_number":58,"context_line":"    reserved_ports\u003d$(sysctl net.ipv4.ip_local_reserved_ports | awk -F\u0027\u003d\u0027 \u0027{print $2;}\u0027 | sed \u0027s/^ //\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"baa201ad_47c5b73a","line":56,"in_reply_to":"baa201ad_115f6d42","updated":"2014-10-03 11:13:51.000000000","message":"how a container would have a conflicted port? do you think the warning would change things if that happen?","commit_id":"f18474bc396e05dafceaee9f3dc72f0a22d6ef7e"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"0714e74bd2d2d37dce366e203ebb2dc7964e6915","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# only do the reserved ports when available, on some system (like containers)"},{"line_number":54,"context_line":"# where it\u0027s not exposed we are almost pretty sure these ports would be"},{"line_number":55,"context_line":"# exclusive for our devstack."},{"line_number":56,"context_line":"if [[ -e /proc/sys/net/ipv4/ip_local_reserved_ports ]];then"},{"line_number":57,"context_line":"    # Get any currently reserved ports, strip off leading whitespace"},{"line_number":58,"context_line":"    reserved_ports\u003d$(sysctl net.ipv4.ip_local_reserved_ports | awk -F\u0027\u003d\u0027 \u0027{print $2;}\u0027 | sed \u0027s/^ //\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"baa201ad_628c6980","line":56,"in_reply_to":"baa201ad_47c5b73a","updated":"2014-10-03 12:17:29.000000000","message":"\u003e how a container would have a conflicted port?\n\nin the same way as a not-container\n\nFurthermore, we are all know that sysctl is just interface for /proc, but things may be changed in future. Using both /proc and sysctl for the same variables is looks like dirty hack.\n\nIMO good approach will be checking exit status of sysctl, and showing notification in case of failure","commit_id":"f18474bc396e05dafceaee9f3dc72f0a22d6ef7e"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e23190e8048ce0335c4b619e29a6de3d78d9f9cb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# only do the reserved ports when available, on some system (like containers)"},{"line_number":54,"context_line":"# where it\u0027s not exposed we are almost pretty sure these ports would be"},{"line_number":55,"context_line":"# exclusive for our devstack."},{"line_number":56,"context_line":"if [[ -e /proc/sys/net/ipv4/ip_local_reserved_ports ]];then"},{"line_number":57,"context_line":"    # Get any currently reserved ports, strip off leading whitespace"},{"line_number":58,"context_line":"    reserved_ports\u003d$(sysctl net.ipv4.ip_local_reserved_ports | awk -F\u0027\u003d\u0027 \u0027{print $2;}\u0027 | sed \u0027s/^ //\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a8c0949_9c5e6ee8","line":56,"in_reply_to":"baa201ad_628c6980","updated":"2014-10-31 12:59:31.000000000","message":"Done","commit_id":"f18474bc396e05dafceaee9f3dc72f0a22d6ef7e"}]}