)]}'
{"extras.d/60-ceph.sh":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4ac662c36aca16ecb80ab4bbcecab76c290fd46e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        if is_service_enabled nova; then"},{"line_number":23,"context_line":"            echo_summary \"Configuring Nova for Ceph\""},{"line_number":24,"context_line":"            configure_ceph_nova"},{"line_number":25,"context_line":"            if ! is_service_enabled cinder; then"},{"line_number":26,"context_line":"                echo_summary \"Configuring libvirt secret\""},{"line_number":27,"context_line":"                import_libvirt_secret_ceph"},{"line_number":28,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"baa201ad_6d5c40ee","line":25,"updated":"2014-10-06 07:47:07.000000000","message":"can\u0027t it just be a else from the if is_s_e cinder on line 29 ?","commit_id":"59f3e62aaa0bc36c020879d1ccf9f8784370f813"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"fab810f1b62e09f13def9e39fa62efb615192664","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        if is_service_enabled nova; then"},{"line_number":23,"context_line":"            echo_summary \"Configuring Nova for Ceph\""},{"line_number":24,"context_line":"            configure_ceph_nova"},{"line_number":25,"context_line":"            if ! is_service_enabled cinder; then"},{"line_number":26,"context_line":"                echo_summary \"Configuring libvirt secret\""},{"line_number":27,"context_line":"                import_libvirt_secret_ceph"},{"line_number":28,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"baa201ad_4382ebc8","line":25,"in_reply_to":"baa201ad_0da494b8","updated":"2014-10-06 09:46:07.000000000","message":"since import_libvirt_secret_ceph can\u0027t it  just be outside within it\u0027s own, i.e:\n\nif is_service_enabled nova cinder; then\nimport_libvirt_secret_ceph\nfi","commit_id":"59f3e62aaa0bc36c020879d1ccf9f8784370f813"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"8baf0736a1ac809c790b8720eb6a04d549f05188","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        if is_service_enabled nova; then"},{"line_number":23,"context_line":"            echo_summary \"Configuring Nova for Ceph\""},{"line_number":24,"context_line":"            configure_ceph_nova"},{"line_number":25,"context_line":"            if ! is_service_enabled cinder; then"},{"line_number":26,"context_line":"                echo_summary \"Configuring libvirt secret\""},{"line_number":27,"context_line":"                import_libvirt_secret_ceph"},{"line_number":28,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"baa201ad_1e903849","line":25,"in_reply_to":"baa201ad_4382ebc8","updated":"2014-10-06 10:21:59.000000000","message":"Done","commit_id":"59f3e62aaa0bc36c020879d1ccf9f8784370f813"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"63559e1040a34a4ae92dd2bd1e52de97e35ed2cb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        if is_service_enabled nova; then"},{"line_number":23,"context_line":"            echo_summary \"Configuring Nova for Ceph\""},{"line_number":24,"context_line":"            configure_ceph_nova"},{"line_number":25,"context_line":"            if ! is_service_enabled cinder; then"},{"line_number":26,"context_line":"                echo_summary \"Configuring libvirt secret\""},{"line_number":27,"context_line":"                import_libvirt_secret_ceph"},{"line_number":28,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"baa201ad_0da494b8","line":25,"in_reply_to":"baa201ad_6d5c40ee","updated":"2014-10-06 07:56:39.000000000","message":"yes it could be a \u0027else\u0027, I just thought that it was clearer to put it here...","commit_id":"59f3e62aaa0bc36c020879d1ccf9f8784370f813"}],"lib/ceph":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4ac662c36aca16ecb80ab4bbcecab76c290fd46e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if ! is_service_enabled cinder; then"},{"line_number":226,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create client.${CINDER_CEPH_USER} mon \"allow r\" osd \"allow class-read object_prefix rbd_children, allow rwx pool\u003d${CINDER_CEPH_POOL}, allow rwx pool\u003d${NOVA_CEPH_POOL},allow rx pool\u003d${GLANCE_CEPH_POOL}\" | sudo tee ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":227,"context_line":"        sudo chown ${STACK_USER}:$(id -g -n $whoami) ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_ed6750b5","line":226,"updated":"2014-10-06 07:47:07.000000000","message":"I think you can redirect the tee output to /dev/null as to not pollute the devstack logs","commit_id":"59f3e62aaa0bc36c020879d1ccf9f8784370f813"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"8baf0736a1ac809c790b8720eb6a04d549f05188","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if ! is_service_enabled cinder; then"},{"line_number":226,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create client.${CINDER_CEPH_USER} mon \"allow r\" osd \"allow class-read object_prefix rbd_children, allow rwx pool\u003d${CINDER_CEPH_POOL}, allow rwx pool\u003d${NOVA_CEPH_POOL},allow rx pool\u003d${GLANCE_CEPH_POOL}\" | sudo tee ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":227,"context_line":"        sudo chown ${STACK_USER}:$(id -g -n $whoami) ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_7e978448","line":226,"in_reply_to":"baa201ad_a325570a","updated":"2014-10-06 10:21:59.000000000","message":"Done","commit_id":"59f3e62aaa0bc36c020879d1ccf9f8784370f813"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"fab810f1b62e09f13def9e39fa62efb615192664","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if ! is_service_enabled cinder; then"},{"line_number":226,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create client.${CINDER_CEPH_USER} mon \"allow r\" osd \"allow class-read object_prefix rbd_children, allow rwx pool\u003d${CINDER_CEPH_POOL}, allow rwx pool\u003d${NOVA_CEPH_POOL},allow rx pool\u003d${GLANCE_CEPH_POOL}\" | sudo tee ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":227,"context_line":"        sudo chown ${STACK_USER}:$(id -g -n $whoami) ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_a325570a","line":226,"in_reply_to":"baa201ad_ad7b8826","updated":"2014-10-06 09:46:07.000000000","message":"just do for this one as now and clean up as you go if you have following patches","commit_id":"59f3e62aaa0bc36c020879d1ccf9f8784370f813"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"63559e1040a34a4ae92dd2bd1e52de97e35ed2cb","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if ! is_service_enabled cinder; then"},{"line_number":226,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create client.${CINDER_CEPH_USER} mon \"allow r\" osd \"allow class-read object_prefix rbd_children, allow rwx pool\u003d${CINDER_CEPH_POOL}, allow rwx pool\u003d${NOVA_CEPH_POOL},allow rx pool\u003d${GLANCE_CEPH_POOL}\" | sudo tee ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":227,"context_line":"        sudo chown ${STACK_USER}:$(id -g -n $whoami) ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_ad7b8826","line":226,"in_reply_to":"baa201ad_ed6750b5","updated":"2014-10-06 07:56:39.000000000","message":"well I\u0027ll have to put this for the other ceph commands as well then. I don\u0027t mind doing this, but it\u0027s not the initial purpose of the patch, what do you think?","commit_id":"59f3e62aaa0bc36c020879d1ccf9f8784370f813"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"e3145893be1994704019d5bb90f65a9ac9f2717b","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if ! is_service_enabled cinder; then"},{"line_number":226,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create client.${CINDER_CEPH_USER} mon \"allow r\" osd \"allow class-read object_prefix rbd_children, allow rwx pool\u003d${CINDER_CEPH_POOL}, allow rwx pool\u003d${NOVA_CEPH_POOL},allow rx pool\u003d${GLANCE_CEPH_POOL}\" | sudo tee ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring \u003e /dev/null 2\u003e\u00261"},{"line_number":227,"context_line":"        sudo chown ${STACK_USER}:$(id -g -n $whoami) ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_b819d623","line":226,"updated":"2014-10-07 18:36:12.000000000","message":"We probably want stderr logged here on failure.  \u0027tee -q\u0027 instead of redirection?","commit_id":"d34a74bc35a330d8c2b2a387fbea823af150a158"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"1c1438dbc1fa3b533e0a565988d761cd2799ad30","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if ! is_service_enabled cinder; then"},{"line_number":226,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create client.${CINDER_CEPH_USER} mon \"allow r\" osd \"allow class-read object_prefix rbd_children, allow rwx pool\u003d${CINDER_CEPH_POOL}, allow rwx pool\u003d${NOVA_CEPH_POOL},allow rx pool\u003d${GLANCE_CEPH_POOL}\" | sudo tee ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring \u003e /dev/null 2\u003e\u00261"},{"line_number":227,"context_line":"        sudo chown ${STACK_USER}:$(id -g -n $whoami) ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_6a66942b","line":226,"in_reply_to":"baa201ad_1148dfca","updated":"2014-10-08 19:10:20.000000000","message":"my initial suggestions on previous review was just to redirect stdout not stderr","commit_id":"d34a74bc35a330d8c2b2a387fbea823af150a158"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e98b06b27ccdf29df08fca0214fe003422a2d624","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if ! is_service_enabled cinder; then"},{"line_number":226,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create client.${CINDER_CEPH_USER} mon \"allow r\" osd \"allow class-read object_prefix rbd_children, allow rwx pool\u003d${CINDER_CEPH_POOL}, allow rwx pool\u003d${NOVA_CEPH_POOL},allow rx pool\u003d${GLANCE_CEPH_POOL}\" | sudo tee ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring \u003e /dev/null 2\u003e\u00261"},{"line_number":227,"context_line":"        sudo chown ${STACK_USER}:$(id -g -n $whoami) ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_51b987ca","line":226,"in_reply_to":"baa201ad_4499e36c","updated":"2014-10-08 16:46:34.000000000","message":"Will an error here get logged anywhere?","commit_id":"d34a74bc35a330d8c2b2a387fbea823af150a158"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"5e54a6b5f7e34a14734954531961475a72073998","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if ! is_service_enabled cinder; then"},{"line_number":226,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create client.${CINDER_CEPH_USER} mon \"allow r\" osd \"allow class-read object_prefix rbd_children, allow rwx pool\u003d${CINDER_CEPH_POOL}, allow rwx pool\u003d${NOVA_CEPH_POOL},allow rx pool\u003d${GLANCE_CEPH_POOL}\" | sudo tee ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring \u003e /dev/null 2\u003e\u00261"},{"line_number":227,"context_line":"        sudo chown ${STACK_USER}:$(id -g -n $whoami) ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_1148dfca","line":226,"in_reply_to":"baa201ad_51b987ca","updated":"2014-10-08 16:48:49.000000000","message":"No, so we probably should remove the redirection right?","commit_id":"d34a74bc35a330d8c2b2a387fbea823af150a158"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"c085755406652cbecccbe836e2a2145ff8c30297","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if ! is_service_enabled cinder; then"},{"line_number":226,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create client.${CINDER_CEPH_USER} mon \"allow r\" osd \"allow class-read object_prefix rbd_children, allow rwx pool\u003d${CINDER_CEPH_POOL}, allow rwx pool\u003d${NOVA_CEPH_POOL},allow rx pool\u003d${GLANCE_CEPH_POOL}\" | sudo tee ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring \u003e /dev/null 2\u003e\u00261"},{"line_number":227,"context_line":"        sudo chown ${STACK_USER}:$(id -g -n $whoami) ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_957030a5","line":226,"in_reply_to":"baa201ad_6a66942b","updated":"2014-10-08 23:54:40.000000000","message":"Oops, mixed up grep with tee (pre-coffee).  Removing the stderr would be fine","commit_id":"d34a74bc35a330d8c2b2a387fbea823af150a158"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"647e54b53c5ac23b0301130c8b7055ef1c6e34f3","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    iniset $NOVA_CONF libvirt images_rbd_ceph_conf ${CEPH_CONF_FILE}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if ! is_service_enabled cinder; then"},{"line_number":226,"context_line":"        sudo ceph -c ${CEPH_CONF_FILE} auth get-or-create client.${CINDER_CEPH_USER} mon \"allow r\" osd \"allow class-read object_prefix rbd_children, allow rwx pool\u003d${CINDER_CEPH_POOL}, allow rwx pool\u003d${NOVA_CEPH_POOL},allow rx pool\u003d${GLANCE_CEPH_POOL}\" | sudo tee ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring \u003e /dev/null 2\u003e\u00261"},{"line_number":227,"context_line":"        sudo chown ${STACK_USER}:$(id -g -n $whoami) ${CEPH_CONF_DIR}/ceph.client.${CINDER_CEPH_USER}.keyring"},{"line_number":228,"context_line":"    fi"},{"line_number":229,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_4499e36c","line":226,"in_reply_to":"baa201ad_b819d623","updated":"2014-10-07 20:37:30.000000000","message":"sorry but \"tee -q\" doesn\u0027t seem to exist","commit_id":"d34a74bc35a330d8c2b2a387fbea823af150a158"}]}