)]}'
{"functions":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"faac7ce5f5717ebaf7ad343838a4ec8f9f8a283b","unresolved":false,"context_lines":[{"line_number":312,"context_line":"# Convert a given image to any format"},{"line_number":313,"context_line":"function change_img_format {"},{"line_number":314,"context_line":"    local new_format\u003d$1"},{"line_number":315,"context_line":"    local old_format\u003d$(qemu-img info ${2} | awk \u0027/^file format/ { print $3; exit }\u0027)"},{"line_number":316,"context_line":"    local old_image\u003d$2"},{"line_number":317,"context_line":"    local new_image\u003d$2.raw"},{"line_number":318,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_3dacdf8b","line":315,"updated":"2014-10-08 13:27:08.000000000","message":"Note that this is problematic because qemu-img info can\u0027t distinguish between an image of a particular format and a raw image that has a header written into it.\n\nThis may be ok for this particular scenario (I\u0027m not sure) but we did just have a CVE in Cinder due to this, so it probably merits putting a comment warning to not use this function in places where you don\u0027t know exactly what your image inputs are.","commit_id":"56ace317f8ba2985a67f50e92976cb67439c69f6"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"ced8d78c56b3985266760f292a5bad4e49837184","unresolved":false,"context_lines":[{"line_number":312,"context_line":"# Convert a given image to any format"},{"line_number":313,"context_line":"function change_img_format {"},{"line_number":314,"context_line":"    local new_format\u003d$1"},{"line_number":315,"context_line":"    local old_format\u003d$(qemu-img info ${2} | awk \u0027/^file format/ { print $3; exit }\u0027)"},{"line_number":316,"context_line":"    local old_image\u003d$2"},{"line_number":317,"context_line":"    local new_image\u003d$2.raw"},{"line_number":318,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_8b0b9e7c","line":315,"in_reply_to":"baa201ad_3dacdf8b","updated":"2014-10-09 17:37:43.000000000","message":"I\u0027m not sure how to handle that, so maybe a comment is enough?","commit_id":"56ace317f8ba2985a67f50e92976cb67439c69f6"}],"stackrc":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c52b2ebdc3195176350c4ffb0b8b3954b7850bbf","unresolved":false,"context_lines":[{"line_number":534,"context_line":"    esac"},{"line_number":535,"context_line":"fi"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"# Ceph needs a flat image"},{"line_number":538,"context_line":"# Later this image will be converted in RAW"},{"line_number":539,"context_line":"if [[ \"$ENABLED_SERVICES\" \u003d~ \u0027ceph\u0027 ]]; then"},{"line_number":540,"context_line":"    case \"$VIRT_DRIVER\" in"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_f1e43b0e","line":537,"updated":"2014-10-08 16:41:16.000000000","message":"This should go in either extras.d/60-ceph.sh or lib/ceph.","commit_id":"56ace317f8ba2985a67f50e92976cb67439c69f6"}]}