)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"fc608627092cdc51239b99b2d1ce64dcf9b311b0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omri Marcovitch \u003comrim@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-15 13:49:38 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Setting sriov service for ml2 plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The user should configure the following parameters in local.conf:"},{"line_number":10,"context_line":" - PHYSICAL_DEVICE_MAPPINGS (For Example: default:eth1)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa201ad_ace52339","line":7,"updated":"2014-10-16 18:42:33.000000000","message":"Maybe mechanism driver and not service","commit_id":"cee2c707ef9fa0710ada3064745dca70d760d30c"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"fc608627092cdc51239b99b2d1ce64dcf9b311b0","unresolved":false,"context_lines":[{"line_number":10,"context_line":" - PHYSICAL_DEVICE_MAPPINGS (For Example: default:eth1)"},{"line_number":11,"context_line":"    or"},{"line_number":12,"context_line":"   PHYSICAL_NETWORK (For Example: default) + PHYSICAL_INTERFACE (For Example: eth1 )"},{"line_number":13,"context_line":"- PCI_PASSTHROUGH_WHITELIST (For Example: \u0027{\"address\":\"*:02:00.*\",\"physical_network\":\"default\"}\u0027)"},{"line_number":14,"context_line":"- Q_PLUGIN\u003dml2"},{"line_number":15,"context_line":"- Q_MECHANISM_DRIVER\u003dsriovnicswitch"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa201ad_8c1dbf11","line":13,"updated":"2014-10-16 18:42:33.000000000","message":"If you prefer the post config option I think this should be changed","commit_id":"cee2c707ef9fa0710ada3064745dca70d760d30c"}],"lib/neutron_plugins/ml2":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"e428778879d6cf4a66f3d138dc39c13394177032","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        die $LINENO \"Please provide list of PCI devices available to VMs in your local.conf file.\\n"},{"line_number":64,"context_line":"            For example: PCI_PASSTHROUGH_WHITELIST\u003d\u0027{\\\"address\\\":\\\"*:07:00.*\\\",\\\"physical_network\\\":\\\"default\\\"}\u0027\""},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":"    iniset $NOVA_CONF DEFAULT pci_passthrough_whitelist $PCI_PASSTHROUGH_WHITELIST"},{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"function neutron_plugin_configure_service {"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_18890275","line":66,"updated":"2014-10-07 18:50:34.000000000","message":"pci_passthrough_whitelist is a multi-line option. In addition, it\u0027s used for generic PCI passthrough as well. Therefore, it should not be configured as part of neutron. \nhttps://review.openstack.org/#/c/123599/ is abandoned. and https://review.openstack.org/#/c/124502/ is being worked on so that they can be configured in local.conf meta section","commit_id":"ae845d061887df01bb81c528e00731fe30cebc9c"},{"author":{"_account_id":12441,"name":"omri marcovitch","email":"omrim@mellanox.com","username":"omrim"},"change_message_id":"0c2f59918963e3145cf1bfaf22ab0f502721dcc3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        die $LINENO \"Please provide list of PCI devices available to VMs in your local.conf file.\\n"},{"line_number":64,"context_line":"            For example: PCI_PASSTHROUGH_WHITELIST\u003d\u0027{\\\"address\\\":\\\"*:07:00.*\\\",\\\"physical_network\\\":\\\"default\\\"}\u0027\""},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":"    iniset $NOVA_CONF DEFAULT pci_passthrough_whitelist $PCI_PASSTHROUGH_WHITELIST"},{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"function neutron_plugin_configure_service {"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_454e333c","line":66,"in_reply_to":"baa201ad_18890275","updated":"2014-10-20 09:16:14.000000000","message":"Patch 124502 is still waiting to merge I think that we should add the above line in neutron (ml2) at least until the merge of 124502.","commit_id":"ae845d061887df01bb81c528e00731fe30cebc9c"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"e428778879d6cf4a66f3d138dc39c13394177032","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            PHYSICAL_DEVICE_MAPPINGS\u003d$PHYSICAL_NETWORK:$PHYSICAL_INTERFACE"},{"line_number":122,"context_line":"        fi"},{"line_number":123,"context_line":"        if [[ -n \"$PHYSICAL_DEVICE_MAPPINGS\" ]]; then"},{"line_number":124,"context_line":"            PHYSICAL_DEVICE_MAPPINGS\u003d(physical_device_mappings\u003d$PHYSICAL_DEVICE_MAPPINGS)"},{"line_number":125,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE sriov_nic pysical_device_mappings $PHYSICAL_DEVICE_MAPPINGS"},{"line_number":126,"context_line":"        else"},{"line_number":127,"context_line":"            die $LINENO \"Error: In order to enable SRIOV service you must to provide the parameter: PHYSICAL_DEVICE_MAPPINGS\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_d8a77aa5","line":124,"updated":"2014-10-07 18:50:34.000000000","message":"Why (physical_device_mappings\u003d$PHYSICAL_DEVICE_MAPPINGS)?\n\nthe option physical_device_mappings is given in the \u0027iniset\u0027 command in below.\n\nGuess that you need it at line 150. So the same config needs to appear in two different places.","commit_id":"ae845d061887df01bb81c528e00731fe30cebc9c"},{"author":{"_account_id":12441,"name":"omri marcovitch","email":"omrim@mellanox.com","username":"omrim"},"change_message_id":"0c2f59918963e3145cf1bfaf22ab0f502721dcc3","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            PHYSICAL_DEVICE_MAPPINGS\u003d$PHYSICAL_NETWORK:$PHYSICAL_INTERFACE"},{"line_number":122,"context_line":"        fi"},{"line_number":123,"context_line":"        if [[ -n \"$PHYSICAL_DEVICE_MAPPINGS\" ]]; then"},{"line_number":124,"context_line":"            PHYSICAL_DEVICE_MAPPINGS\u003d(physical_device_mappings\u003d$PHYSICAL_DEVICE_MAPPINGS)"},{"line_number":125,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE sriov_nic pysical_device_mappings $PHYSICAL_DEVICE_MAPPINGS"},{"line_number":126,"context_line":"        else"},{"line_number":127,"context_line":"            die $LINENO \"Error: In order to enable SRIOV service you must to provide the parameter: PHYSICAL_DEVICE_MAPPINGS\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_85e65b42","line":124,"in_reply_to":"baa201ad_d8a77aa5","updated":"2014-10-20 09:16:14.000000000","message":"Fixed","commit_id":"ae845d061887df01bb81c528e00731fe30cebc9c"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"e428778879d6cf4a66f3d138dc39c13394177032","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            PHYSICAL_DEVICE_MAPPINGS\u003d(physical_device_mappings\u003d$PHYSICAL_DEVICE_MAPPINGS)"},{"line_number":125,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE sriov_nic pysical_device_mappings $PHYSICAL_DEVICE_MAPPINGS"},{"line_number":126,"context_line":"        else"},{"line_number":127,"context_line":"            die $LINENO \"Error: In order to enable SRIOV service you must to provide the parameter: PHYSICAL_DEVICE_MAPPINGS\""},{"line_number":128,"context_line":"        fi"},{"line_number":129,"context_line":"        AGENT_BINARY\u003d\"$NEUTRON_BIN_DIR/neutron-sriov-nic-agent\""},{"line_number":130,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE agent rpc True"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_3826c668","line":127,"updated":"2014-10-07 18:50:34.000000000","message":"typo \"must to\"\n\nAlso, do you need to mention the alternative way to configure it  in the message as well?","commit_id":"ae845d061887df01bb81c528e00731fe30cebc9c"},{"author":{"_account_id":12441,"name":"omri marcovitch","email":"omrim@mellanox.com","username":"omrim"},"change_message_id":"0c2f59918963e3145cf1bfaf22ab0f502721dcc3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            PHYSICAL_DEVICE_MAPPINGS\u003d(physical_device_mappings\u003d$PHYSICAL_DEVICE_MAPPINGS)"},{"line_number":125,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE sriov_nic pysical_device_mappings $PHYSICAL_DEVICE_MAPPINGS"},{"line_number":126,"context_line":"        else"},{"line_number":127,"context_line":"            die $LINENO \"Error: In order to enable SRIOV service you must to provide the parameter: PHYSICAL_DEVICE_MAPPINGS\""},{"line_number":128,"context_line":"        fi"},{"line_number":129,"context_line":"        AGENT_BINARY\u003d\"$NEUTRON_BIN_DIR/neutron-sriov-nic-agent\""},{"line_number":130,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE agent rpc True"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_25f68ff9","line":127,"in_reply_to":"baa201ad_3826c668","updated":"2014-10-20 09:16:14.000000000","message":"Fixed","commit_id":"ae845d061887df01bb81c528e00731fe30cebc9c"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"dddf2ab0266c1abfe70fa7e2675b84c33a754464","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    #   PHYSICAL_NETWORK (For Example: default) + PHYSICAL_INTERFACE (For Example: eth1 )"},{"line_number":115,"context_line":"    # - PCI_PASSTHROUGH_WHITELIST (For Example: \u0027{\"address\":\"*:02:00.*\",\"physical_network\":\"default\"}\u0027)"},{"line_number":116,"context_line":"    # For more information: https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking"},{"line_number":117,"context_line":"    if [[ $Q_ML2_PLUGIN_MECHANISM_DRIVERS \u003d\u003d *sriovnicswitch* ]]; then"},{"line_number":118,"context_line":"        if [[ -z \"$PHYSICAL_DEVICE_MAPPINGS\" ]] \u0026\u0026 \\"},{"line_number":119,"context_line":"            [[ -n \"$PHYSICAL_NETWORK\" ]] \u0026\u0026 \\"},{"line_number":120,"context_line":"            [[ -n \"$PHYSICAL_INTERFACE\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_19c5043d","line":117,"updated":"2014-10-13 13:42:07.000000000","message":"question: is this configuration required even if the agent is not required?","commit_id":"85c505ba694918cbc9818612cd1856de4c36ac7d"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"dddf2ab0266c1abfe70fa7e2675b84c33a754464","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            die $LINENO \"Error: In order to enable SRIOV service you should provide the parameter:"},{"line_number":127,"context_line":"                PHYSICAL_DEVICE_MAPPINGS in local.conf file\""},{"line_number":128,"context_line":"        fi"},{"line_number":129,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE agent rpc True"},{"line_number":130,"context_line":"        neutron_plugin_configure_sriov_nova_conf"},{"line_number":131,"context_line":"    fi"},{"line_number":132,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baa201ad_39f2c89a","line":129,"updated":"2014-10-13 13:42:07.000000000","message":"Not sure what this option is.","commit_id":"85c505ba694918cbc9818612cd1856de4c36ac7d"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"fc608627092cdc51239b99b2d1ce64dcf9b311b0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    # - PHYSICAL_DEVICE_MAPPINGS (For Example: default:eth1)"},{"line_number":103,"context_line":"    #    or"},{"line_number":104,"context_line":"    #   PHYSICAL_NETWORK (For Example: default) + PHYSICAL_INTERFACE (For Example: eth1 )"},{"line_number":105,"context_line":"    # - PCI_PASSTHROUGH_WHITELIST (For Example: \u0027{\"address\":\"*:02:00.*\",\"physical_network\":\"default\"}\u0027)"},{"line_number":106,"context_line":"    # For more information: https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking"},{"line_number":107,"context_line":"    if [[ $Q_ML2_PLUGIN_MECHANISM_DRIVERS \u003d\u003d *sriovnicswitch* ]]; then"},{"line_number":108,"context_line":"        if [[ -z \"$PHYSICAL_DEVICE_MAPPINGS\" ]] \u0026\u0026 \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"baa201ad_2c1f735c","line":105,"updated":"2014-10-16 18:42:33.000000000","message":"Not sure this comment belongs here since  PCI_PASSTHROUGH_WHITELIST is in nova.","commit_id":"cee2c707ef9fa0710ada3064745dca70d760d30c"},{"author":{"_account_id":12441,"name":"omri marcovitch","email":"omrim@mellanox.com","username":"omrim"},"change_message_id":"73d3c9b608dbd1e46ab8668ba739b1dba2099584","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    # - PHYSICAL_DEVICE_MAPPINGS (For Example: default:eth1)"},{"line_number":103,"context_line":"    #    or"},{"line_number":104,"context_line":"    #   PHYSICAL_NETWORK (For Example: default) + PHYSICAL_INTERFACE (For Example: eth1 )"},{"line_number":105,"context_line":"    # - PCI_PASSTHROUGH_WHITELIST (For Example: \u0027{\"address\":\"*:02:00.*\",\"physical_network\":\"default\"}\u0027)"},{"line_number":106,"context_line":"    # For more information: https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking"},{"line_number":107,"context_line":"    if [[ $Q_ML2_PLUGIN_MECHANISM_DRIVERS \u003d\u003d *sriovnicswitch* ]]; then"},{"line_number":108,"context_line":"        if [[ -z \"$PHYSICAL_DEVICE_MAPPINGS\" ]] \u0026\u0026 \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9aa7fdbe_412c34ac","line":105,"in_reply_to":"baa201ad_2c1f735c","updated":"2014-10-20 09:16:44.000000000","message":"Done","commit_id":"cee2c707ef9fa0710ada3064745dca70d760d30c"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"fc608627092cdc51239b99b2d1ce64dcf9b311b0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    #   PHYSICAL_NETWORK (For Example: default) + PHYSICAL_INTERFACE (For Example: eth1 )"},{"line_number":105,"context_line":"    # - PCI_PASSTHROUGH_WHITELIST (For Example: \u0027{\"address\":\"*:02:00.*\",\"physical_network\":\"default\"}\u0027)"},{"line_number":106,"context_line":"    # For more information: https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking"},{"line_number":107,"context_line":"    if [[ $Q_ML2_PLUGIN_MECHANISM_DRIVERS \u003d\u003d *sriovnicswitch* ]]; then"},{"line_number":108,"context_line":"        if [[ -z \"$PHYSICAL_DEVICE_MAPPINGS\" ]] \u0026\u0026 \\"},{"line_number":109,"context_line":"            [[ -n \"$PHYSICAL_NETWORK\" ]] \u0026\u0026 \\"},{"line_number":110,"context_line":"            [[ -n \"$PHYSICAL_INTERFACE\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"baa201ad_0137d8ff","line":107,"updated":"2014-10-16 18:42:33.000000000","message":"Maybe [[ $Q_ML2_PLUGIN_MECHANISM_DRIVERS \u003d~ \"sriovnicswitch\" ]]?","commit_id":"cee2c707ef9fa0710ada3064745dca70d760d30c"},{"author":{"_account_id":12441,"name":"omri marcovitch","email":"omrim@mellanox.com","username":"omrim"},"change_message_id":"73d3c9b608dbd1e46ab8668ba739b1dba2099584","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    #   PHYSICAL_NETWORK (For Example: default) + PHYSICAL_INTERFACE (For Example: eth1 )"},{"line_number":105,"context_line":"    # - PCI_PASSTHROUGH_WHITELIST (For Example: \u0027{\"address\":\"*:02:00.*\",\"physical_network\":\"default\"}\u0027)"},{"line_number":106,"context_line":"    # For more information: https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking"},{"line_number":107,"context_line":"    if [[ $Q_ML2_PLUGIN_MECHANISM_DRIVERS \u003d\u003d *sriovnicswitch* ]]; then"},{"line_number":108,"context_line":"        if [[ -z \"$PHYSICAL_DEVICE_MAPPINGS\" ]] \u0026\u0026 \\"},{"line_number":109,"context_line":"            [[ -n \"$PHYSICAL_NETWORK\" ]] \u0026\u0026 \\"},{"line_number":110,"context_line":"            [[ -n \"$PHYSICAL_INTERFACE\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9aa7fdbe_6426a6bc","line":107,"in_reply_to":"baa201ad_0137d8ff","updated":"2014-10-20 09:16:44.000000000","message":"In this case Regx sign and compassion sign give the same result.\nSo why to use regx sign? Do you think it\u0027s more readable?","commit_id":"cee2c707ef9fa0710ada3064745dca70d760d30c"}]}