)]}'
{"lib/ironic":[{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"26aad3d7efa6914c8ab1331823026e3c76a94d1a","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":90,"context_line":"# are \u0027pxe_ssh\u0027, \"pxe_ipmitool\u0027 and \u0027agent_ssh\u0027."},{"line_number":91,"context_line":"# The \u0027pxe_impitool\u0027 is only valid when IRONIC_HARDWARE set"},{"line_number":92,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ssh}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"#TODO(agordeev): replace \u0027ubuntu\u0027 with host distro name getting"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_e3e3d531","line":91,"updated":"2014-10-15 22:29:08.000000000","message":"typo ^","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"f1cae68347ea6b9ec87d21a8b10118fe79ba3d45","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":90,"context_line":"# are \u0027pxe_ssh\u0027, \"pxe_ipmitool\u0027 and \u0027agent_ssh\u0027."},{"line_number":91,"context_line":"# The \u0027pxe_impitool\u0027 is only valid when IRONIC_HARDWARE set"},{"line_number":92,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ssh}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"#TODO(agordeev): replace \u0027ubuntu\u0027 with host distro name getting"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_bf28b1e2","line":91,"in_reply_to":"9aa7fdbe_3c286699","updated":"2014-10-28 17:13:47.000000000","message":"Thanks, I didn\u0027t find this after checking carefully.","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"1ecc6eee4505fdb453224be803ad0a7ccd8326b0","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":90,"context_line":"# are \u0027pxe_ssh\u0027, \"pxe_ipmitool\u0027 and \u0027agent_ssh\u0027."},{"line_number":91,"context_line":"# The \u0027pxe_impitool\u0027 is only valid when IRONIC_HARDWARE set"},{"line_number":92,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ssh}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"#TODO(agordeev): replace \u0027ubuntu\u0027 with host distro name getting"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_3c286699","line":91,"in_reply_to":"9aa7fdbe_e7d4b4be","updated":"2014-10-28 00:15:39.000000000","message":"pxe_ipmitool","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"3ae1b76cf83883d86e085be76d071d79a14fb3df","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":90,"context_line":"# are \u0027pxe_ssh\u0027, \"pxe_ipmitool\u0027 and \u0027agent_ssh\u0027."},{"line_number":91,"context_line":"# The \u0027pxe_impitool\u0027 is only valid when IRONIC_HARDWARE set"},{"line_number":92,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ssh}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"#TODO(agordeev): replace \u0027ubuntu\u0027 with host distro name getting"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_e7d4b4be","line":91,"in_reply_to":"baa201ad_e3e3d531","updated":"2014-10-27 18:27:06.000000000","message":"Sorry, waht\u0027s the typo? Sorry didn\u0027t find it :(","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"26aad3d7efa6914c8ab1331823026e3c76a94d1a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"}"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"function is_ironic_hardware {"},{"line_number":145,"context_line":"    if [[ \"$ENABLED_SERVICES\" \u003d~ \u0027ironic\u0027 \u0026\u0026 \"$IRONIC_HARDWARE\" \u003d\u003d \u0027True\u0027 ]]; then"},{"line_number":146,"context_line":"        return 0"},{"line_number":147,"context_line":"    fi"},{"line_number":148,"context_line":"    return 1"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_4353c116","line":145,"updated":"2014-10-15 22:29:08.000000000","message":"using \u0027is_service_enabeld \"ironic\u0027 would be preferred as it can account for ironic being listed in ENABLED_SERVICES in other ways (ie, \u0027ir-cond,ir-api\u0027 )","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"3ae1b76cf83883d86e085be76d071d79a14fb3df","unresolved":false,"context_lines":[{"line_number":142,"context_line":"}"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"function is_ironic_hardware {"},{"line_number":145,"context_line":"    if [[ \"$ENABLED_SERVICES\" \u003d~ \u0027ironic\u0027 \u0026\u0026 \"$IRONIC_HARDWARE\" \u003d\u003d \u0027True\u0027 ]]; then"},{"line_number":146,"context_line":"        return 0"},{"line_number":147,"context_line":"    fi"},{"line_number":148,"context_line":"    return 1"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_27015c38","line":145,"in_reply_to":"baa201ad_4353c116","updated":"2014-10-27 18:27:06.000000000","message":"Good point, done.","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"26aad3d7efa6914c8ab1331823026e3c76a94d1a","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        IRONIC_NODE_CPU\u003d$IRONIC_HW_NODE_CPU"},{"line_number":501,"context_line":"        IRONIC_NODE_RAM\u003d$IRONIC_HW_NODE_RAM"},{"line_number":502,"context_line":"        IRONIC_NODE_DISK\u003d$IRONIC_HW_NODE_DISK"},{"line_number":503,"context_line":"        IRONIC_HWINFO_FILE\u003d${IRONIC_HWINFO_FILE:-$IRONIC_DATA_DIR/hardware_info}"},{"line_number":504,"context_line":"    fi"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    while read hardware_info; do"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_a3962d92","line":503,"updated":"2014-10-15 22:29:08.000000000","message":"These should be local\u0027ized and, ideally, lower cased to avoid confusion with the IRONIC_HW_NODE_* globals\n\nAlso,IRONIC_HWINFO_FILE could be declared at line 77 to keep it grouped with other user-configurable things.","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"3ae1b76cf83883d86e085be76d071d79a14fb3df","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        IRONIC_NODE_CPU\u003d$IRONIC_HW_NODE_CPU"},{"line_number":501,"context_line":"        IRONIC_NODE_RAM\u003d$IRONIC_HW_NODE_RAM"},{"line_number":502,"context_line":"        IRONIC_NODE_DISK\u003d$IRONIC_HW_NODE_DISK"},{"line_number":503,"context_line":"        IRONIC_HWINFO_FILE\u003d${IRONIC_HWINFO_FILE:-$IRONIC_DATA_DIR/hardware_info}"},{"line_number":504,"context_line":"    fi"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    while read hardware_info; do"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_e7b9147a","line":503,"in_reply_to":"baa201ad_a3962d92","updated":"2014-10-27 18:27:06.000000000","message":"Done","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"722e609e297bd74aa0ade86f82eedfb5c3c6a969","unresolved":false,"context_lines":[{"line_number":511,"context_line":"            local mac_address\u003d$(echo $hardware_info |awk \u0027{print $2}\u0027)"},{"line_number":512,"context_line":"            # Currently we require all hardware platform have same CPU/RAM/DISK info"},{"line_number":513,"context_line":"            # in future, this can be enhanced to support different type, and then"},{"line_number":514,"context_line":"            # we create the bare metal flavor with minum value"},{"line_number":515,"context_line":"            local node_options\u003d\"-i ipmi_address\u003d$ipmi_address -i ipmi_password\u003d$IRONIC_IPMI_PASSWD\\"},{"line_number":516,"context_line":"                -i ipmi_username\u003d$IRONIC_IPMI_USERNAME\""},{"line_number":517,"context_line":"        fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_127a5488","line":514,"updated":"2014-10-21 08:01:36.000000000","message":"nit: minimum \"minum\" spelling","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"3ae1b76cf83883d86e085be76d071d79a14fb3df","unresolved":false,"context_lines":[{"line_number":511,"context_line":"            local mac_address\u003d$(echo $hardware_info |awk \u0027{print $2}\u0027)"},{"line_number":512,"context_line":"            # Currently we require all hardware platform have same CPU/RAM/DISK info"},{"line_number":513,"context_line":"            # in future, this can be enhanced to support different type, and then"},{"line_number":514,"context_line":"            # we create the bare metal flavor with minum value"},{"line_number":515,"context_line":"            local node_options\u003d\"-i ipmi_address\u003d$ipmi_address -i ipmi_password\u003d$IRONIC_IPMI_PASSWD\\"},{"line_number":516,"context_line":"                -i ipmi_username\u003d$IRONIC_IPMI_USERNAME\""},{"line_number":517,"context_line":"        fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_8765a81f","line":514,"in_reply_to":"9aa7fdbe_127a5488","updated":"2014-10-27 18:27:06.000000000","message":"Done","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"26aad3d7efa6914c8ab1331823026e3c76a94d1a","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            # in future, this can be enhanced to support different type, and then"},{"line_number":514,"context_line":"            # we create the bare metal flavor with minum value"},{"line_number":515,"context_line":"            local node_options\u003d\"-i ipmi_address\u003d$ipmi_address -i ipmi_password\u003d$IRONIC_IPMI_PASSWD\\"},{"line_number":516,"context_line":"                -i ipmi_username\u003d$IRONIC_IPMI_USERNAME\""},{"line_number":517,"context_line":"        fi"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        local node_id\u003d$(ironic node-create --chassis_uuid $chassis_id \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_c348912f","line":516,"updated":"2014-10-15 22:29:08.000000000","message":"I don\u0027t see either IRONIC_IPMI_PASSWD or USERNAME referenced anywhere.  These values should probably be stored in the HWINFO_FILE along with the address and mac, no?","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"3ae1b76cf83883d86e085be76d071d79a14fb3df","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            # in future, this can be enhanced to support different type, and then"},{"line_number":514,"context_line":"            # we create the bare metal flavor with minum value"},{"line_number":515,"context_line":"            local node_options\u003d\"-i ipmi_address\u003d$ipmi_address -i ipmi_password\u003d$IRONIC_IPMI_PASSWD\\"},{"line_number":516,"context_line":"                -i ipmi_username\u003d$IRONIC_IPMI_USERNAME\""},{"line_number":517,"context_line":"        fi"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        local node_id\u003d$(ironic node-create --chassis_uuid $chassis_id \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_e77034de","line":516,"in_reply_to":"baa201ad_c348912f","updated":"2014-10-27 18:27:06.000000000","message":"Hmm, I use these macro because all my machine have same password and username, but you are right, it\u0027s better in the HWINFO_FILE. Will do that way.","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"722e609e297bd74aa0ade86f82eedfb5c3c6a969","unresolved":false,"context_lines":[{"line_number":514,"context_line":"            # we create the bare metal flavor with minum value"},{"line_number":515,"context_line":"            local node_options\u003d\"-i ipmi_address\u003d$ipmi_address -i ipmi_password\u003d$IRONIC_IPMI_PASSWD\\"},{"line_number":516,"context_line":"                -i ipmi_username\u003d$IRONIC_IPMI_USERNAME\""},{"line_number":517,"context_line":"        fi"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        local node_id\u003d$(ironic node-create --chassis_uuid $chassis_id \\"},{"line_number":520,"context_line":"            --driver $IRONIC_DEPLOY_DRIVER \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_d2528cdc","line":517,"updated":"2014-10-21 08:01:36.000000000","message":"While there is benefit to including the above IRONIC_IPMI_PASSWD and IRONIC_IPMI_USERNAME in the HWINFO_FILE \"sample file\", is it typical to provide such sensitive data values in a file? Might these be in a database? How are IPMI user name and password handled elsewhere in Ironic? Would the password and username for IPMI be the same across all the hardware in the datacenter?\n\nEven if not handled in this patch, good to add to a \"TODO\"","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"3ae1b76cf83883d86e085be76d071d79a14fb3df","unresolved":false,"context_lines":[{"line_number":514,"context_line":"            # we create the bare metal flavor with minum value"},{"line_number":515,"context_line":"            local node_options\u003d\"-i ipmi_address\u003d$ipmi_address -i ipmi_password\u003d$IRONIC_IPMI_PASSWD\\"},{"line_number":516,"context_line":"                -i ipmi_username\u003d$IRONIC_IPMI_USERNAME\""},{"line_number":517,"context_line":"        fi"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        local node_id\u003d$(ironic node-create --chassis_uuid $chassis_id \\"},{"line_number":520,"context_line":"            --driver $IRONIC_DEPLOY_DRIVER \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_0779b8c7","line":517,"in_reply_to":"9aa7fdbe_d2528cdc","updated":"2014-10-27 18:27:06.000000000","message":"I think this is for devstack, a developer\u0027s tools, so possibly should be ok? There should have no security concern for confuguration item in devstack?","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"015c09392bd120ae03db8596162592b40559eb27","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":92,"context_line":"# are \u0027pxe_ssh\u0027, \"pxe_ipmitool\u0027 and \u0027agent_ssh\u0027."},{"line_number":93,"context_line":"# The \u0027pxe_impitool\u0027 is only valid when IRONIC_HARDWARE set"},{"line_number":94,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ssh}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"#TODO(agordeev): replace \u0027ubuntu\u0027 with host distro name getting"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9aa7fdbe_87157a9d","line":93,"updated":"2014-10-28 07:06:19.000000000","message":"pxe_ipmitool  (spelling)","commit_id":"5cff9c527bd213518f361335e204898ed1d34bcc"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"0eb13545f9867f6ba3c4ad8379e772f28471babc","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":92,"context_line":"# are \u0027pxe_ssh\u0027, \"pxe_ipmitool\u0027 and \u0027agent_ssh\u0027."},{"line_number":93,"context_line":"# The \u0027pxe_impitool\u0027 is only valid when IRONIC_HARDWARE set"},{"line_number":94,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ssh}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"#TODO(agordeev): replace \u0027ubuntu\u0027 with host distro name getting"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9aa7fdbe_5fbc25bb","line":93,"in_reply_to":"9aa7fdbe_87157a9d","updated":"2014-10-28 17:13:55.000000000","message":"Aha, Adam told me a typo, and I didn\u0027t find this even after careful check :)","commit_id":"5cff9c527bd213518f361335e204898ed1d34bcc"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"b8ea63c8f03c074539b0fb77a2d0664ee32d66da","unresolved":false,"context_lines":[{"line_number":73,"context_line":"IRONIC_VM_LOG_CONSOLE\u003d${IRONIC_VM_LOG_CONSOLE:-True}"},{"line_number":74,"context_line":"IRONIC_VM_LOG_DIR\u003d${IRONIC_VM_LOG_DIR:-$IRONIC_DATA_DIR/logs/}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Deploy to hardware platform"},{"line_number":77,"context_line":"IRONIC_IPMIINFO_FILE\u003d${IRONIC_IPMIINFO_FILE:-$IRONIC_DATA_DIR/hardware_info}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# Use DIB to create deploy ramdisk and kernel."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7a8c0949_c9201d4c","line":76,"updated":"2014-11-03 14:18:56.000000000","message":"Can we please add some light documentation here just to describe what this file should contain with an example of a single line?","commit_id":"057a879b1e61489aa9eee8c71a3fbb8f84b12023"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"c63a0a229ee51cfe4242679ea4f6ec9c3d713460","unresolved":false,"context_lines":[{"line_number":73,"context_line":"IRONIC_VM_LOG_CONSOLE\u003d${IRONIC_VM_LOG_CONSOLE:-True}"},{"line_number":74,"context_line":"IRONIC_VM_LOG_DIR\u003d${IRONIC_VM_LOG_DIR:-$IRONIC_DATA_DIR/logs/}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Deploy to hardware platform"},{"line_number":77,"context_line":"IRONIC_IPMIINFO_FILE\u003d${IRONIC_IPMIINFO_FILE:-$IRONIC_DATA_DIR/hardware_info}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# Use DIB to create deploy ramdisk and kernel."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7a8c0949_154cf66f","line":76,"in_reply_to":"7a8c0949_c9201d4c","updated":"2014-11-05 00:04:54.000000000","message":"Although user can check the code to get the idea, but it\u0027s really a good suggestion to be more straightforward.","commit_id":"057a879b1e61489aa9eee8c71a3fbb8f84b12023"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"dc80ae63027ef93d7ad594512041938805431a9f","unresolved":false,"context_lines":[{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"function is_ironic_hardware {"},{"line_number":150,"context_line":"    is_ironic_enabled \u0026\u0026 [ -n \"${IRONIC_DEPLOY_DRIVER##*_ssh}\" ] \u0026\u0026 return 0"},{"line_number":151,"context_line":"    return 1"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"5a890539_cb9a836d","line":150,"updated":"2014-11-14 03:34:54.000000000","message":"please use [[ -- it\u0027s more compatible","commit_id":"968ad33b55fd5b87bdd93157af5f3a1f8b4d44d5"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"d84eb64b4efd06e41057701bc9e40e6a83b53276","unresolved":false,"context_lines":[{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"function is_ironic_hardware {"},{"line_number":150,"context_line":"    is_ironic_enabled \u0026\u0026 [ -n \"${IRONIC_DEPLOY_DRIVER##*_ssh}\" ] \u0026\u0026 return 0"},{"line_number":151,"context_line":"    return 1"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"5a890539_e3ef4daf","line":150,"in_reply_to":"5a890539_cb9a836d","updated":"2014-11-14 21:06:05.000000000","message":"Done","commit_id":"968ad33b55fd5b87bdd93157af5f3a1f8b4d44d5"}],"lib/neutron":[{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"26aad3d7efa6914c8ab1331823026e3c76a94d1a","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        die_if_not_set $LINENO PHYSICAL_NETWORK \"You must specify the PHYSICAL_NETWORK\""},{"line_number":506,"context_line":"        die_if_not_set $LINENO PROVIDER_NETWORK_TYPE \"You must specifiy the PROVIDER_NETWORK_TYPE\""},{"line_number":507,"context_line":"        NET_ID\u003d$(neutron net-create $PHYSICAL_NETWORK --tenant_id $TENANT_ID --provider:network_type $PROVIDER_NETWORK_TYPE --provider:physical_network \"$PHYSICAL_NETWORK\" ${SEGMENTATION_ID:+--provider:segmentation_id $SEGMENTATION_ID} --shared | grep \u0027 id \u0027 | get_field 2)"},{"line_number":508,"context_line":"        SUBNET_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 4 ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} --name $PROVIDER_SUBNET_NAME --gateway $NETWORK_GATEWAY $NET_ID $FIXED_RANGE | grep \u0027 id \u0027 | get_field 2)"},{"line_number":509,"context_line":"        SUBNET_V6_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 6 --ipv6-address-mode slaac --gateway $V6_NETWORK_GATEWAY --name $PROVIDER_SUBNET_NAME_V6 $NET_ID $FIXED_RANGE_V6 | grep \u0027id\u0027 | get_field 2)"},{"line_number":510,"context_line":"        sudo ip link set $OVS_PHYSICAL_BRIDGE up"},{"line_number":511,"context_line":"        sudo ip link set br-int up"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baa201ad_635525c1","line":508,"updated":"2014-10-15 22:29:08.000000000","message":"Is this addition needed only to support hardware deployments, will there be consequences for doing this for all other types of configurations?","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"3ae1b76cf83883d86e085be76d071d79a14fb3df","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        die_if_not_set $LINENO PHYSICAL_NETWORK \"You must specify the PHYSICAL_NETWORK\""},{"line_number":506,"context_line":"        die_if_not_set $LINENO PROVIDER_NETWORK_TYPE \"You must specifiy the PROVIDER_NETWORK_TYPE\""},{"line_number":507,"context_line":"        NET_ID\u003d$(neutron net-create $PHYSICAL_NETWORK --tenant_id $TENANT_ID --provider:network_type $PROVIDER_NETWORK_TYPE --provider:physical_network \"$PHYSICAL_NETWORK\" ${SEGMENTATION_ID:+--provider:segmentation_id $SEGMENTATION_ID} --shared | grep \u0027 id \u0027 | get_field 2)"},{"line_number":508,"context_line":"        SUBNET_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 4 ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} --name $PROVIDER_SUBNET_NAME --gateway $NETWORK_GATEWAY $NET_ID $FIXED_RANGE | grep \u0027 id \u0027 | get_field 2)"},{"line_number":509,"context_line":"        SUBNET_V6_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 6 --ipv6-address-mode slaac --gateway $V6_NETWORK_GATEWAY --name $PROVIDER_SUBNET_NAME_V6 $NET_ID $FIXED_RANGE_V6 | grep \u0027id\u0027 | get_field 2)"},{"line_number":510,"context_line":"        sudo ip link set $OVS_PHYSICAL_BRIDGE up"},{"line_number":511,"context_line":"        sudo ip link set br-int up"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa7fdbe_679a846f","line":508,"in_reply_to":"baa201ad_635525c1","updated":"2014-10-27 18:27:06.000000000","message":"In fact, the gateway option has been passed to all other configurations.","commit_id":"b08c01598e6b2baaebe39313f005cf646aa34645"}]}