)]}'
{"id":"openstack%2Fdevstack~127672","triplet_id":"openstack%2Fdevstack~master~I69452b86f1f4eec4cb169923f978cc1bd1ac45b3","project":"openstack/devstack","branch":"master","topic":"ironic-hw","hashtags":[],"change_id":"I69452b86f1f4eec4cb169923f978cc1bd1ac45b3","subject":"Support user images","status":"ABANDONED","created":"2014-10-10 22:49:57.000000000","updated":"2016-03-22 12:41:59.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"016dd0b1133ae239097ddf8336c72cecf6c1650b","_number":127672,"virtual_id_number":127672,"owner":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2014-10-14 03:21:31.000000000","_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":1,"date":"2014-10-11 00:06:08.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":-1,"date":"2014-11-12 17:59:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"date":"2014-10-24 23:16:48.000000000","_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},{"date":"2016-03-22 12:41:59.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-12-11 04:11:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":-1,"date":"2014-10-15 22:36:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":-1,"date":"2014-10-14 04:12:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-11 00:06:08.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-10-14 03:21:31.000000000","updated_by":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-10-14 04:12:04.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2014-10-15 22:36:04.000000000","updated_by":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"reviewer":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"state":"REVIEWER"},{"updated":"2014-11-12 17:59:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-12-11 04:11:22.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2016-03-22 12:41:59.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"5251a9f6143efe3982945614c12fa543cdca4909","author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"date":"2014-10-10 22:49:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"129aa6401b7f24c31c018671b5845dd59c1d90bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-10 23:45:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/72/127672/1/check/check-tempest-dsvm-full/4e1c009 : SUCCESS in 44m 20s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/72/127672/1/check/check-tempest-dsvm-postgres-full/e9c66b9 : SUCCESS in 55m 37s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/72/127672/1/check/check-tempest-dsvm-neutron-full/16c0bf8 : SUCCESS in 49m 45s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/72/127672/1/check/check-tempest-dsvm-neutron-heat-slow/868a561 : SUCCESS in 21m 41s\n- check-grenade-dsvm http://logs.openstack.org/72/127672/1/check/check-grenade-dsvm/f362a3c : SUCCESS in 50m 02s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/72/127672/1/check/gate-tempest-dsvm-large-ops/de24ee2 : SUCCESS in 18m 11s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/72/127672/1/check/gate-tempest-dsvm-neutron-large-ops/de82f15 : SUCCESS in 21m 46s\n- gate-devstack-bashate http://logs.openstack.org/72/127672/1/check/gate-devstack-bashate/94792bf : SUCCESS in 10s\n- check-devstack-dsvm-cells http://logs.openstack.org/72/127672/1/check/check-devstack-dsvm-cells/ca4b9f4 : SUCCESS in 13m 28s\n- check-grenade-dsvm-ironic-sideways-nv http://logs.openstack.org/72/127672/1/check/check-grenade-dsvm-ironic-sideways-nv/d2d975b : FAILURE in 20m 14s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/72/127672/1/check/check-grenade-dsvm-partial-ncpu/dba5936 : SUCCESS in 48m 48s\n- check-neutron-dsvm-functional http://logs.openstack.org/72/127672/1/check/check-neutron-dsvm-functional/b4d5015 : SUCCESS in 15m 56s\n- check-swift-dsvm-functional http://logs.openstack.org/72/127672/1/check/check-swift-dsvm-functional/37ceafd : SUCCESS in 19m 55s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/72/127672/1/check/check-tempest-dsvm-ironic-pxe_ssh-nv/245dab8 : SUCCESS in 31m 19s\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/72/127672/1/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/bad6bf9 : SUCCESS in 31m 00s\n- check-tempest-dsvm-f20 http://logs.openstack.org/72/127672/1/check/check-tempest-dsvm-f20/a3f181f : SUCCESS in 44m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ddddf976601e1d4886c94c7d2e1fb4522cbb5c26","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-10-11 00:06:08.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/72/127672/1/28235/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"05b50fee87b4c03dbef4f61b58a33a4e7b7140b3","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2014-10-11 03:19:19.000000000","message":"Patch Set 1:\n\nWe should support multiple user images here. Because we have different user images for different nodes and this will be orchestrated by Heat.","accounts_in_message":[],"_revision_number":1},{"id":"51bc5ea6247d408aa445509253c253a819badb44","author":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"date":"2014-10-14 03:21:31.000000000","message":"Patch Set 1:\n\nredhatci results for change 127672\n\nLogs at http://people.redhat.com/~iwienand/127672/\n\n* OSLAB_RHEL65 http://people.redhat.com/~iwienand/127672/20141014022613.OSLAB_RHEL65.1.log.gz : SUCCESS Patch Set 1 in 00:23\n* OSLAB_RHEL7 http://people.redhat.com/~iwienand/127672/20141014022735.OSLAB_RHEL7.1.log.gz : FAILURE Patch Set 1 in 00:06\n* OSLAB_FEDORA20 http://people.redhat.com/~iwienand/127672/20141014023420.OSLAB_FEDORA20.1.log.gz : SUCCESS Patch Set 1 in 00:35\n* OSLAB_CENTOS65 http://people.redhat.com/~iwienand/127672/20141014023613.OSLAB_CENTOS65.1.log.gz : SUCCESS Patch Set 1 in 00:40\n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/RedHat_CI\nend","accounts_in_message":[],"_revision_number":1},{"id":"b65739e335f630a1c2f8c9e89ea76b56c63a5eb2","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-10-14 04:12:04.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c590a9dda67d4a65924bd46ba81d5e7dc74f2837","author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"date":"2014-10-15 22:36:04.000000000","message":"Patch Set 1: Code-Review-1\n\nIt\u0027s kinda unclear to me why this is needed.  Presumably you\u0027re still using the deploy kernel and ramdisk that devstack is building and publishing, why wouldn\u0027t you also just be using the cirros image that devstack publishes as well (this is the \"user\" image)  Populating glance with your own custom images seems more like a post-deployment task that a user or administrator would take care of after running devstack, not something devstack should be responsible for.\n\nThat said, I could imagine devstack providing a way of specifying one or more custom user images that it would publish into glance in addition to the stuff it already uploads.. But I think that should be something that could be consumed more broadly and not only in the ironic case.","accounts_in_message":[],"_revision_number":1},{"id":"298e7d9dbd1e32031b4728a4ce7dbf7ad3ec30ae","author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"date":"2014-10-24 23:16:48.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nHi, Adam, thanks for your review. Yes, add support for user to provide custom images will be a good add-on. I will take that way.\n\nBTW, it\u0027s not good to use cirros because cirros most possibly not working on the custom ironic.","accounts_in_message":[],"_revision_number":1},{"id":"1b2ae31da67e926f1936e0fec92e85035e5f698b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-12 17:59:11.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"89ed0b6c6e0b0e0a5fea628a47faa1c9a740f2f6","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-12-11 04:11:22.000000000","message":"Patch Set 1: Code-Review-1\n\nWe\u0027re in the middle of moving ironic\u0027s devstack code to a plugin in ironic\u0027s tree. Could you please re-propose this patch there? https://review.openstack.org/#/c/255879/","accounts_in_message":[],"_revision_number":1},{"id":"d63093a19bf29b7a1d5ec0e37842d2b3c9271205","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-03-22 12:41:59.000000000","message":"Patch Set 1:\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1},{"id":"fa2b0128021c85b644dcbff902aa14caa7ed2be7","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-03-22 12:41:59.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a7571b82ea539096f40c7d327b95b2d2f9d0f832","revisions":{"a7571b82ea539096f40c7d327b95b2d2f9d0f832":{"kind":"REWORK","_number":1,"created":"2014-10-10 22:49:57.000000000","uploader":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"ref":"refs/changes/72/127672/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/72/127672/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/127672/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/127672/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/72/127672/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/72/127672/1"}}},"commit":{"parents":[{"commit":"b08c01598e6b2baaebe39313f005cf646aa34645","subject":"Add Ironic hardware deployment support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b08c01598e6b2baaebe39313f005cf646aa34645"}]}],"author":{"name":"yunhong jiang","email":"yunhong.jiang@intel.com","date":"2014-10-10 14:57:28.000000000","tz":-420},"committer":{"name":"yunhong jiang","email":"yunhong.jiang@intel.com","date":"2014-10-10 14:57:28.000000000","tz":-420},"subject":"Support user images","message":"Support user images\n\nWhen deploy ironic in the baremetal system, we need provide user kernel,\nramdisk and images. This patch add support to this, so that when\nIRNOC_HARDWARE is true, these user disks will be uploaded to glance.\n\nChange-Id: I69452b86f1f4eec4cb169923f978cc1bd1ac45b3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a7571b82ea539096f40c7d327b95b2d2f9d0f832"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a7571b82ea539096f40c7d327b95b2d2f9d0f832"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}