)]}'
{"id":"openstack%2Fdevstack~128343","triplet_id":"openstack%2Fdevstack~master~If0d468d3edcdfd95f44cf8554032c29f0c23aa8d","project":"openstack/devstack","branch":"master","topic":"cd/var-test-cleanup","hashtags":[],"change_id":"If0d468d3edcdfd95f44cf8554032c29f0c23aa8d","subject":"Use the preferred form of testing for variable","status":"ABANDONED","created":"2014-10-14 16:08:50.000000000","updated":"2014-10-22 14:11:01.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dd1dbe2c65b23dc13bc8c36e76440f8cdc2a93f4","_number":128343,"virtual_id_number":128343,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2014-10-14 17:21:32.000000000","_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":1,"date":"2014-10-14 17:17:23.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2014-10-15 11:22:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"date":"2014-10-15 14:56:59.000000000","_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"date":"2014-10-15 10:28:37.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"disliked":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-10-15 07:57:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":-1,"date":"2014-10-15 16:22:26.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-14 17:17:23.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-10-14 17:21:32.000000000","updated_by":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-10-15 07:57:29.000000000","updated_by":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"reviewer":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"state":"REVIEWER"},{"updated":"2014-10-15 11:22:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-10-15 14:56:59.000000000","updated_by":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"reviewer":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"state":"REVIEWER"},{"updated":"2014-10-15 16:22:26.000000000","updated_by":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"reviewer":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"state":"REVIEWER"}],"messages":[{"id":"5d7aa965ec75a787e4cc660ebc27f0073796c278","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-14 16:08:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7601e32d69a1811d555c8009e47f71cb1716af50","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-10-14 17:17:23.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/43/128343/1/28549/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"dd04b3f76d1661e5e99dadf5ce10d8fca432b4b7","author":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"date":"2014-10-14 17:21:32.000000000","message":"Patch Set 1:\n\nredhatci results for change 128343\n\nLogs at http://people.redhat.com/~iwienand/128343/\n\n* OSLAB_RHEL65 http://people.redhat.com/~iwienand/128343/20141014162232.OSLAB_RHEL65.1.log.gz : SUCCESS Patch Set 1 in 00:24\n* OSLAB_RHEL7 http://people.redhat.com/~iwienand/128343/20141014162635.OSLAB_RHEL7.1.log.gz : FAILURE Patch Set 1 in 00:06\n* OSLAB_FEDORA20 http://people.redhat.com/~iwienand/128343/20141014163154.OSLAB_FEDORA20.1.log.gz : SUCCESS Patch Set 1 in 00:45\n* OSLAB_CENTOS65 http://people.redhat.com/~iwienand/128343/20141014163201.OSLAB_CENTOS65.1.log.gz : SUCCESS Patch Set 1 in 00:35\n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/RedHat_CI\nend","accounts_in_message":[],"_revision_number":1},{"id":"5f3c151eaddfb5d843ba185ea55a48fdf865ee5e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-14 17:30:53.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-tempest-dsvm-full http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-full/fb0d84b : SUCCESS in 55m 32s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-postgres-full/f3c139f : SUCCESS in 54m 21s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-neutron-full/600622c : SUCCESS in 57m 29s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-neutron-heat-slow/bf05bf6 : SUCCESS in 21m 44s\n- check-grenade-dsvm http://logs.openstack.org/43/128343/1/check/check-grenade-dsvm/39d7283 : SUCCESS in 45m 47s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/43/128343/1/check/gate-tempest-dsvm-large-ops/9c949da : SUCCESS in 19m 16s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/43/128343/1/check/gate-tempest-dsvm-neutron-large-ops/b2224d3 : SUCCESS in 18m 50s\n- gate-devstack-bashate http://logs.openstack.org/43/128343/1/check/gate-devstack-bashate/41b92ed : SUCCESS in 16s\n- check-devstack-dsvm-cells http://logs.openstack.org/43/128343/1/check/check-devstack-dsvm-cells/387a49f : SUCCESS in 13m 26s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/43/128343/1/check/check-grenade-dsvm-partial-ncpu/6fbcc53 : SUCCESS in 45m 28s\n- check-neutron-dsvm-functional http://logs.openstack.org/43/128343/1/check/check-neutron-dsvm-functional/fa4a7e2 : FAILURE in 12m 57s\n- check-swift-dsvm-functional http://logs.openstack.org/43/128343/1/check/check-swift-dsvm-functional/dda2dcf : SUCCESS in 20m 12s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-ironic-pxe_ssh-nv/6dc8fdc : SUCCESS in 30m 11s\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/7b94abc : SUCCESS in 34m 36s\n- check-tempest-dsvm-f20 http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-f20/6aa12ea : SUCCESS in 44m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"bfd023c00565ad4e2a0b51e662b61f04692ee048","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2014-10-15 07:57:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"778322ee055a6ee2bccc6928a3df6e95d78178ad","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-15 10:28:37.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"77832a58530d88c061756b3614402b1e575a5501","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-15 11:22:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-full/5a16157 : SUCCESS in 46m 36s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-postgres-full/0e4c3a7 : SUCCESS in 53m 50s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-neutron-full/e8aad6c : SUCCESS in 47m 26s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-neutron-heat-slow/6fdd3ce : SUCCESS in 18m 16s\n- check-grenade-dsvm http://logs.openstack.org/43/128343/1/check/check-grenade-dsvm/491f9f7 : SUCCESS in 48m 24s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/43/128343/1/check/gate-tempest-dsvm-large-ops/4130b26 : SUCCESS in 19m 09s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/43/128343/1/check/gate-tempest-dsvm-neutron-large-ops/bfc1472 : SUCCESS in 22m 29s\n- gate-devstack-bashate http://logs.openstack.org/43/128343/1/check/gate-devstack-bashate/e344a01 : SUCCESS in 14s\n- check-devstack-dsvm-cells http://logs.openstack.org/43/128343/1/check/check-devstack-dsvm-cells/369387b : SUCCESS in 15m 46s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/43/128343/1/check/check-grenade-dsvm-partial-ncpu/b7297d9 : SUCCESS in 49m 34s\n- check-neutron-dsvm-functional http://logs.openstack.org/43/128343/1/check/check-neutron-dsvm-functional/0c8a4e9 : SUCCESS in 14m 00s\n- check-swift-dsvm-functional http://logs.openstack.org/43/128343/1/check/check-swift-dsvm-functional/9cef92e : SUCCESS in 19m 07s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-ironic-pxe_ssh-nv/8801edc : SUCCESS in 34m 53s\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/e75c5aa : SUCCESS in 36m 11s\n- check-tempest-dsvm-f20 http://logs.openstack.org/43/128343/1/check/check-tempest-dsvm-f20/c899962 : SUCCESS in 43m 12s (non-voting)\n- gate-devstack-publish-docs http://logs.openstack.org/43/128343/1/check/gate-devstack-publish-docs/be2afa2 : NOT_REGISTERED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"40b4cd14075a0c76aea5fa2315ea1b1d4c05ee78","author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"date":"2014-10-15 14:56:59.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI\u0027d like to know/clarify the objective of this patch.","accounts_in_message":[],"_revision_number":1},{"id":"a828aced28b9acdf42e2b9b95236c2c33a5c1a72","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-15 15:08:48.000000000","message":"Patch Set 1:\n\nThese changes are based on a comment that dtroyer made on another review:\n\n   https://review.openstack.org/#/c/126921/2/lib/ceilometer,cm\n\nThe general idea is that the [[ -n version is more explicit and in addition uses bash keyword.","accounts_in_message":[],"_revision_number":1},{"id":"92b3bd16e363ddd038ac1009669dc3c91a987e92","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2014-10-15 16:22:26.000000000","message":"Patch Set 1: Code-Review-1\n\nTwo occurrences of the same pattern in ./lib/baremetal\n\nIf you make a commit-style change like this one (which is good), I\u0027d rather you try to do it on every files.\n\nOr even better, add a bash8 test.","accounts_in_message":[],"_revision_number":1},{"id":"851e9a299541cc8101ca9cf00997f7eccff1063f","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-15 16:25:47.000000000","message":"Patch Set 1:\n\nI\u0027ll abandon this one in favor a fix throughout.\n\nRe bash8, as far as I can tell it isn\u0027t working as desired unless you install it from github. The versions available on pypi are doing nothing.","accounts_in_message":[],"_revision_number":1},{"id":"918434fac112ff8e3c26ea5f73d6cece932819d4","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-22 14:11:01.000000000","message":"Abandoned\n\nWill come back to this idea after bashate is healthy again (soon).","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7cd3425209bd72173f4a8961b13acfce593f0a4c","revisions":{"7cd3425209bd72173f4a8961b13acfce593f0a4c":{"kind":"REWORK","_number":1,"created":"2014-10-14 16:08:50.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/43/128343/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/43/128343/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/43/128343/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/43/128343/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/43/128343/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/43/128343/1"}}},"commit":{"parents":[{"commit":"a6478982753e73526abffa6573748e27a63fc494","subject":"Merge \"Allow multi-line config items in meta-section of local.conf\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a6478982753e73526abffa6573748e27a63fc494"}]}],"author":{"name":"Chris Dent","email":"chdent@redhat.com","date":"2014-10-14 16:07:53.000000000","tz":60},"committer":{"name":"Chris Dent","email":"chdent@redhat.com","date":"2014-10-14 16:07:53.000000000","tz":60},"subject":"Use the preferred form of testing for variable","message":"Use the preferred form of testing for variable\n\n[[ -n \"$something\" ]] is the preference over [ \"$something\"]\n\nChange-Id: If0d468d3edcdfd95f44cf8554032c29f0c23aa8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7cd3425209bd72173f4a8961b13acfce593f0a4c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7cd3425209bd72173f4a8961b13acfce593f0a4c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}