)]}'
{"id":"openstack%2Fdevstack~130006","triplet_id":"openstack%2Fdevstack~master~I99c0d356758d767f5a4cd02107deaa4d51de1e74","project":"openstack/devstack","branch":"master","topic":"bug/1383843","hashtags":[],"change_id":"I99c0d356758d767f5a4cd02107deaa4d51de1e74","subject":"Make sure iniset replaces commented out options","status":"ABANDONED","created":"2014-10-21 18:55:30.000000000","updated":"2014-10-23 00:23:14.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3115fda8035a005532ec35b23c2e0bd2dbbbdfaf","_number":130006,"virtual_id_number":130006,"owner":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-10-21 20:02:21.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"date":"2014-10-21 19:56:50.000000000","_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":1,"date":"2014-10-22 01:40:41.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-10-23 00:23:00.000000000","_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":-1,"date":"2014-10-22 03:20:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2014-10-22 10:04:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":-1,"date":"2014-10-21 19:09:32.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-21 19:09:32.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2014-10-21 19:56:50.000000000","updated_by":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-10-21 20:02:21.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-10-22 01:40:41.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-10-22 03:20:25.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-10-22 10:04:07.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"}],"messages":[{"id":"c79eb26d3e9d47b402cc9e70b3808b45bf74f9d2","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2014-10-21 18:55:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"80dac2c9687849890467b61698036dca6c45d832","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-10-21 19:09:32.000000000","message":"Patch Set 1: Code-Review-1\n\nI\u0027m quite negative on this ... it\u0027s very counter-intuitive IMO; I would not expect commented things to change","accounts_in_message":[],"_revision_number":1},{"id":"464516d062c9146a74614e40ebc50131589d569a","author":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"date":"2014-10-21 19:56:50.000000000","message":"Patch Set 1:\n\nredhatci results for change 130006\n\nLogs at http://people.redhat.com/~iwienand/130006/\n\n* OSLAB_RHEL7 http://people.redhat.com/~iwienand/130006/20141021190721.OSLAB_RHEL7.1.log.gz : FAILURE Patch Set 1 in 00:06\n* OSLAB_RHEL65 http://people.redhat.com/~iwienand/130006/20141021190721.OSLAB_RHEL65.1.log.gz : FAILURE Patch Set 1 in 00:18\n* OSLAB_FEDORA20 http://people.redhat.com/~iwienand/130006/20141021190721.OSLAB_FEDORA20.1.log.gz : FAILURE Patch Set 1 in 00:34\n* OSLAB_CENTOS65 http://people.redhat.com/~iwienand/130006/20141021190721.OSLAB_CENTOS65.1.log.gz : FAILURE Patch Set 1 in 00:49\n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/RedHat_CI\nend","accounts_in_message":[],"_revision_number":1},{"id":"85ff4cf8d3c3cb71b5bbab8b0e9ed29688a956da","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-10-21 20:02:21.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/06/130006/1/29475/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"8f312da13e7e692b92c1776d19914bc071d14259","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-22 01:40:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/06/130006/1/check/check-tempest-dsvm-full/c03b64e : SUCCESS in 1h 04m 53s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/06/130006/1/check/check-tempest-dsvm-postgres-full/3fcb4ff : SUCCESS in 53m 33s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/06/130006/1/check/check-tempest-dsvm-neutron-full/e3fceea : SUCCESS in 1h 13m 48s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/06/130006/1/check/check-tempest-dsvm-neutron-heat-slow/647f1c9 : SUCCESS in 24m 25s\n- check-grenade-dsvm http://logs.openstack.org/06/130006/1/check/check-grenade-dsvm/51e7e52 : SUCCESS in 51m 15s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/06/130006/1/check/gate-tempest-dsvm-large-ops/91119c7 : SUCCESS in 23m 36s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/06/130006/1/check/gate-tempest-dsvm-neutron-large-ops/0eb3b48 : SUCCESS in 23m 42s\n- gate-devstack-bashate http://logs.openstack.org/06/130006/1/check/gate-devstack-bashate/ea79e37 : SUCCESS in 14s\n- check-devstack-dsvm-cells http://logs.openstack.org/06/130006/1/check/check-devstack-dsvm-cells/f1c89f5 : SUCCESS in 17m 26s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/06/130006/1/check/check-grenade-dsvm-partial-ncpu/50ec8ed : SUCCESS in 52m 34s\n- check-neutron-dsvm-functional http://logs.openstack.org/06/130006/1/check/check-neutron-dsvm-functional/2bd2724 : SUCCESS in 17m 01s\n- check-swift-dsvm-functional http://logs.openstack.org/06/130006/1/check/check-swift-dsvm-functional/9fd7cca : SUCCESS in 22m 24s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/06/130006/1/check/check-tempest-dsvm-ironic-pxe_ssh-nv/0438f4a : SUCCESS in 34m 26s\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/06/130006/1/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/f9c3a1b : SUCCESS in 53m 44s\n- check-tempest-dsvm-f20 http://logs.openstack.org/06/130006/1/check/check-tempest-dsvm-f20/a5c6868 : SUCCESS in 49m 52s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/06/130006/1/check/check-tempest-dsvm-centos7/7b4cd46 : FAILURE in 6m 21s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/06/130006/1/check/gate-devstack-publish-docs/0b6bdec/doc/build/html/ : SUCCESS in 1m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"981a62ddc7d8f628b57018545c03e076ea259063","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-22 03:20:25.000000000","message":"Patch Set 1: Code-Review-1\n\nAgreed, I don\u0027t think the added complexity is work an unintuitive effect.  If you must have this effect, iniuncomment() followed by iniset() will accomplish that.","accounts_in_message":[],"_revision_number":1},{"id":"5876b908c5c73335ab84e6938e8de9522815a96d","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-10-22 10:04:07.000000000","message":"Patch Set 1: Code-Review-1\n\nI agree with the others. I\u0027m not sure this is the behavior most people would expect. The commented line is not an ini settings, it\u0027s annotation, potentially left behind for some purpose.","accounts_in_message":[],"_revision_number":1},{"id":"cf17e51fee8ebd316a9182beffadb834eb91be4b","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2014-10-23 00:23:00.000000000","message":"Patch Set 1:\n\n@Dean: oh, I did not know about iniuncomment, thanks!\n\n@all: yeah, I see how this might be counter-intuitive, I\u0027ll just abandon the patch.","accounts_in_message":[],"_revision_number":1},{"id":"53620292f142f30aed4335fa60bc601be07d02b1","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2014-10-23 00:23:14.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ff227aa0463e034f43b6cbede071376ee2c37c93","revisions":{"ff227aa0463e034f43b6cbede071376ee2c37c93":{"kind":"REWORK","_number":1,"created":"2014-10-21 18:55:30.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/06/130006/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/06/130006/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/130006/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/130006/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/130006/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/06/130006/1"}}},"commit":{"parents":[{"commit":"572a4c4c3c5553beea01f519dbdcadfb9c6f78b7","subject":"Merge \"Allow use of ceilometer agent coordination\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/572a4c4c3c5553beea01f519dbdcadfb9c6f78b7"}]}],"author":{"name":"Cyril Roelandt","email":"cyril.roelandt@enovance.com","date":"2014-10-21 18:45:20.000000000","tz":120},"committer":{"name":"Cyril Roelandt","email":"cyril.roelandt@enovance.com","date":"2014-10-21 18:55:13.000000000","tz":120},"subject":"Make sure iniset replaces commented out options","message":"Make sure iniset replaces commented out options\n\nIf the option passed to iniset already exists but is commented out, it will be\nuncommented and its value will be changed.\n\nChange-Id: I99c0d356758d767f5a4cd02107deaa4d51de1e74\nCloses-Bug: #1383843\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ff227aa0463e034f43b6cbede071376ee2c37c93"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ff227aa0463e034f43b6cbede071376ee2c37c93"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}