)]}'
{"lib/ceph":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"73e28c31d88d2b9b0dc20486515db58094f01d50","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# ------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"function ceph_version {"},{"line_number":75,"context_line":"    ceph_version_major\u003d$(sudo ceph daemon mon.$(hostname) version | cut -d \u0027\"\u0027 -f 4 | cut -d \u0027.\u0027 -f 1)"},{"line_number":76,"context_line":"    ceph_version_minor\u003d$(sudo ceph daemon mon.$(hostname) version | cut -d \u0027\"\u0027 -f 4 | cut -d \u0027.\u0027 -f 2)"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a8c0949_009bdd18","line":75,"updated":"2014-11-03 00:11:43.000000000","message":"setting globals as a side-effect is pretty out of style\n\nrather keep this like lib/apache for consistency, call it \"get_ceph_version\" and extract major/minor into locals with ${foo%.} and ${foo##*.} or use regex checks with [[","commit_id":"61098e2ef12792ca277d3f469383910d6bdee60e"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4177f56d6db461bd9dab498bc1c6d9102c3f0b66","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    done"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # pools data and metadata were removed in the Giant release so depending on the version we apply different commands"},{"line_number":163,"context_line":"    ceph_version"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # change pool replica size according to the CEPH_REPLICAS set by the user"},{"line_number":166,"context_line":"    local ceph_version\u003d$(get_ceph_version)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a890539_333150a3","line":163,"updated":"2014-11-07 20:54:32.000000000","message":"Perhaps it is post summit fatigue, but I\u0027m not sure what this does here as ceph_version isn\u0027t defined until line 166 below...","commit_id":"941d603da162165612c40547ad243b9e72a2c50a"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"b6077315955b467798e014bb2705b409708c5ffc","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    done"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # pools data and metadata were removed in the Giant release so depending on the version we apply different commands"},{"line_number":163,"context_line":"    ceph_version"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # change pool replica size according to the CEPH_REPLICAS set by the user"},{"line_number":166,"context_line":"    local ceph_version\u003d$(get_ceph_version)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a890539_bc218db6","line":163,"in_reply_to":"5a890539_333150a3","updated":"2014-11-08 14:58:28.000000000","message":"leftover, thanks!","commit_id":"941d603da162165612c40547ad243b9e72a2c50a"}]}