)]}'
{"lib/ironic":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"490672ee71494e58f63b7aa5c8308204da4ca81a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"IRONIC_SCRIPTS_DIR\u003d${IRONIC_SCRIPTS_DIR:-$TOP_DIR/tools/ironic/scripts}"},{"line_number":56,"context_line":"IRONIC_TEMPLATES_DIR\u003d${IRONIC_TEMPLATES_DIR:-$TOP_DIR/tools/ironic/templates}"},{"line_number":57,"context_line":"IRONIC_BAREMETAL_BASIC_OPS\u003d$(trueorfalse False $IRONIC_BAREMETAL_BASIC_OPS)"},{"line_number":58,"context_line":"IRONIC_ENABLED_DRIVERS\u003d${IRONIC_ENABLED_DRIVERS:-fake,pxe_ssh,pxe_ipmitool,agent_ipmitool}"},{"line_number":59,"context_line":"IRONIC_SSH_USERNAME\u003d${IRONIC_SSH_USERNAME:-`whoami`}"},{"line_number":60,"context_line":"IRONIC_SSH_KEY_DIR\u003d${IRONIC_SSH_KEY_DIR:-$IRONIC_DATA_DIR/ssh_keys}"},{"line_number":61,"context_line":"IRONIC_SSH_KEY_FILENAME\u003d${IRONIC_SSH_KEY_FILENAME:-ironic_key}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a890539_be486e5c","line":58,"updated":"2014-11-11 19:39:08.000000000","message":"There is no need to add agent_ipmitool to the list of drivers which devstack enables by default -- any user can override this in their localrc easily (and in fact, devstack-gate already does this for the agent tests)","commit_id":"5f6671aa3518976d413aaf87052f36cff73304b9"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"b192f6ec80a3026216c08d588d7410411d4ecc65","unresolved":false,"context_lines":[{"line_number":55,"context_line":"IRONIC_SCRIPTS_DIR\u003d${IRONIC_SCRIPTS_DIR:-$TOP_DIR/tools/ironic/scripts}"},{"line_number":56,"context_line":"IRONIC_TEMPLATES_DIR\u003d${IRONIC_TEMPLATES_DIR:-$TOP_DIR/tools/ironic/templates}"},{"line_number":57,"context_line":"IRONIC_BAREMETAL_BASIC_OPS\u003d$(trueorfalse False $IRONIC_BAREMETAL_BASIC_OPS)"},{"line_number":58,"context_line":"IRONIC_ENABLED_DRIVERS\u003d${IRONIC_ENABLED_DRIVERS:-fake,pxe_ssh,pxe_ipmitool,agent_ipmitool}"},{"line_number":59,"context_line":"IRONIC_SSH_USERNAME\u003d${IRONIC_SSH_USERNAME:-`whoami`}"},{"line_number":60,"context_line":"IRONIC_SSH_KEY_DIR\u003d${IRONIC_SSH_KEY_DIR:-$IRONIC_DATA_DIR/ssh_keys}"},{"line_number":61,"context_line":"IRONIC_SSH_KEY_FILENAME\u003d${IRONIC_SSH_KEY_FILENAME:-ironic_key}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a890539_096845f4","line":58,"in_reply_to":"5a890539_be486e5c","updated":"2014-11-12 23:39:35.000000000","message":"Done.\n\nThanks for the discussion in the IRC.","commit_id":"5f6671aa3518976d413aaf87052f36cff73304b9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"490672ee71494e58f63b7aa5c8308204da4ca81a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    if [[ \"$IRONIC_VM_LOG_CONSOLE\" \u003d\u003d \"True\" ]] ; then"},{"line_number":292,"context_line":"        iniset $IRONIC_CONF_FILE pxe pxe_append_params \"nofb nomodeset vga\u003dnormal console\u003dttyS0\""},{"line_number":293,"context_line":"    fi"},{"line_number":294,"context_line":"    if [[ \"$IRONIC_DEPLOY_DRIVER\" \u003d~ agent_[a-z] ]] ; then"},{"line_number":295,"context_line":"        if [[ \"$SWIFT_ENABLE_TEMPURLS\" \u003d\u003d \"True\" ]] ; then"},{"line_number":296,"context_line":"            iniset $IRONIC_CONF_FILE glance swift_temp_url_key $SWIFT_TEMPURL_KEY"},{"line_number":297,"context_line":"        else"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a890539_9e3492df","line":294,"updated":"2014-11-11 19:39:08.000000000","message":"I believe this would be better expressed in bash as:\n\n  if [ -z \"${IRONIC_DEPLOY_DRIVER%%agent*}\" ] ; then\n\nditto throughout this file","commit_id":"5f6671aa3518976d413aaf87052f36cff73304b9"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"b192f6ec80a3026216c08d588d7410411d4ecc65","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    if [[ \"$IRONIC_VM_LOG_CONSOLE\" \u003d\u003d \"True\" ]] ; then"},{"line_number":292,"context_line":"        iniset $IRONIC_CONF_FILE pxe pxe_append_params \"nofb nomodeset vga\u003dnormal console\u003dttyS0\""},{"line_number":293,"context_line":"    fi"},{"line_number":294,"context_line":"    if [[ \"$IRONIC_DEPLOY_DRIVER\" \u003d~ agent_[a-z] ]] ; then"},{"line_number":295,"context_line":"        if [[ \"$SWIFT_ENABLE_TEMPURLS\" \u003d\u003d \"True\" ]] ; then"},{"line_number":296,"context_line":"            iniset $IRONIC_CONF_FILE glance swift_temp_url_key $SWIFT_TEMPURL_KEY"},{"line_number":297,"context_line":"        else"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a890539_49724de6","line":294,"in_reply_to":"5a890539_9e3492df","updated":"2014-11-12 23:39:35.000000000","message":"Thanks! Done.","commit_id":"5f6671aa3518976d413aaf87052f36cff73304b9"}]}