)]}'
{"id":"openstack%2Fdevstack~135183","triplet_id":"openstack%2Fdevstack~master~Ida9eaa7950554bcd2f183dede7ad19522f9ca558","project":"openstack/devstack","branch":"master","topic":"bug/1393684","hashtags":[],"change_id":"Ida9eaa7950554bcd2f183dede7ad19522f9ca558","subject":"Fixed conditions to determine if current distribution is a Fedora based distribution","status":"MERGED","created":"2014-11-18 07:24:48.000000000","updated":"2014-11-19 08:53:07.000000000","submitted":"2014-11-19 05:28:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"eb2a64e193e605e03b0b08ae911f376714d1afbe","_number":135183,"virtual_id_number":135183,"owner":{"_account_id":12742,"name":"Oleg Gashev","email":"oleg@gashev.net","username":"gashev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2014-11-18 08:30:41.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"date":"2014-11-19 08:53:07.000000000","post_submit":true,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":2,"date":"2014-11-19 05:28:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-11-18 15:46:41.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2014-11-19 04:24:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2014-11-19 04:24:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-11-18 08:30:41.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-11-18 15:46:41.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-11-19 04:24:53.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2014-11-19 05:28:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-11-19 08:53:07.000000000","updated_by":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"27a3d3d87f466343cfb0feb0769bf6b29b4dfa9f","author":{"_account_id":12742,"name":"Oleg Gashev","email":"oleg@gashev.net","username":"gashev"},"date":"2014-11-18 07:24:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b4499efa75dd069a723df7ca29cc36480c04a1b5","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-11-18 08:30:41.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/83/135183/1/31974/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"d67bc833a5f802fc87aba363060c22ae669880ed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-18 08:34:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/83/135183/1/check/check-tempest-dsvm-full/dfd6fae : SUCCESS in 57m 26s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/83/135183/1/check/check-tempest-dsvm-postgres-full/06d5f00 : SUCCESS in 55m 42s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/83/135183/1/check/check-tempest-dsvm-neutron-full/f3d1a27 : SUCCESS in 1h 06m 50s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/83/135183/1/check/check-tempest-dsvm-neutron-heat-slow/149b67a : SUCCESS in 22m 22s\n- check-grenade-dsvm http://logs.openstack.org/83/135183/1/check/check-grenade-dsvm/2e549e6 : SUCCESS in 47m 53s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/83/135183/1/check/gate-tempest-dsvm-large-ops/b01574b : SUCCESS in 22m 20s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/83/135183/1/check/gate-tempest-dsvm-neutron-large-ops/88419eb : SUCCESS in 26m 48s\n- gate-devstack-bashate http://logs.openstack.org/83/135183/1/check/gate-devstack-bashate/87e01a1 : SUCCESS in 14s\n- check-devstack-dsvm-cells http://logs.openstack.org/83/135183/1/check/check-devstack-dsvm-cells/ac84cef : SUCCESS in 15m 29s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/83/135183/1/check/check-grenade-dsvm-partial-ncpu/43e35bd : SUCCESS in 45m 56s\n- check-neutron-dsvm-functional http://logs.openstack.org/83/135183/1/check/check-neutron-dsvm-functional/782fe7e : SUCCESS in 16m 22s\n- check-swift-dsvm-functional http://logs.openstack.org/83/135183/1/check/check-swift-dsvm-functional/b17a064 : SUCCESS in 18m 01s\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/83/135183/1/check/check-tempest-dsvm-ironic-pxe_ssh-nv/66a2f56 : SUCCESS in 31m 52s\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/83/135183/1/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/83a3028 : SUCCESS in 28m 59s\n- check-tempest-dsvm-f20 http://logs.openstack.org/83/135183/1/check/check-tempest-dsvm-f20/bb4e40f : SUCCESS in 39m 22s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/83/135183/1/check/check-tempest-dsvm-centos7/d230864 : SUCCESS in 1h 00m 42s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/83/135183/1/check/gate-devstack-publish-docs/42b0f46/doc/build/html/ : SUCCESS in 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b34236ce53133902b86363128320b5694f5db9f6","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-11-18 15:46:41.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"762c3858d3efec532ef4b8447f81ba7c719cff64","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-19 04:24:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"78e8e5e2113707d3175056413ae55c25d06aeb21","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-11-19 04:24:53.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"77955572dfdca2a9dc9ebe1bc949f20b74bdc590","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-19 05:28:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/83/135183/1/gate/gate-tempest-dsvm-full/d81f018 : SUCCESS in 56m 24s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/83/135183/1/gate/gate-tempest-dsvm-postgres-full/d4cdf77 : SUCCESS in 58m 42s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/83/135183/1/gate/gate-tempest-dsvm-neutron-full/43dc691 : SUCCESS in 58m 47s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/83/135183/1/gate/gate-tempest-dsvm-neutron-heat-slow/27a5114 : SUCCESS in 18m 51s\n- gate-grenade-dsvm http://logs.openstack.org/83/135183/1/gate/gate-grenade-dsvm/0ef5643 : SUCCESS in 46m 37s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/83/135183/1/gate/gate-tempest-dsvm-large-ops/a051cc6 : SUCCESS in 24m 17s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/83/135183/1/gate/gate-tempest-dsvm-neutron-large-ops/05984f5 : SUCCESS in 18m 33s\n- gate-devstack-bashate http://logs.openstack.org/83/135183/1/gate/gate-devstack-bashate/bc8c9d5 : SUCCESS in 14s\n- gate-devstack-dsvm-cells http://logs.openstack.org/83/135183/1/gate/gate-devstack-dsvm-cells/3076e16 : SUCCESS in 19m 51s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/83/135183/1/gate/gate-grenade-dsvm-partial-ncpu/bfec3db : SUCCESS in 45m 37s\n- gate-neutron-dsvm-functional http://logs.openstack.org/83/135183/1/gate/gate-neutron-dsvm-functional/7895f5c : SUCCESS in 15m 51s\n- gate-swift-dsvm-functional http://logs.openstack.org/83/135183/1/gate/gate-swift-dsvm-functional/893dca8 : SUCCESS in 20m 12s","accounts_in_message":[],"_revision_number":1},{"id":"5764eb9e3bd068a6bce54c4941f7422a632a2d33","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-19 05:28:36.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"627e8edd69911f4619fe6c2dbf96de90d9906964","author":{"_account_id":9009,"name":"Red Hat CI","email":"redhatci@redhat.com","username":"redhatci","tags":["SERVICE_USER"]},"date":"2014-11-19 08:53:07.000000000","message":"Patch Set 1:\n\nredhatci results for change 135183\n\nLogs at http://people.redhat.com/~iwienand/135183/\n\n* OSLAB_RHEL7 http://people.redhat.com/~iwienand/135183/20141119075054.OSLAB_RHEL7.1.log.gz : SUCCESS Patch Set 1 in 00:33\n* OSLAB_FEDORA20 http://people.redhat.com/~iwienand/135183/20141119075613.OSLAB_FEDORA20.1.log.gz : SUCCESS Patch Set 1 in 00:50\n* OSLAB_CENTOS65 http://people.redhat.com/~iwienand/135183/20141119075911.OSLAB_CENTOS65.1.log.gz : SUCCESS Patch Set 1 in 00:43\n* OSLAB_RHEL66 http://people.redhat.com/~iwienand/135183/20141119080328.OSLAB_RHEL66.1.log.gz : FAILURE Patch Set 1 in 00:20\n* OSLAB_FEDORA21 http://people.redhat.com/~iwienand/135183/20141119080951.OSLAB_FEDORA21.1.log.gz : SUCCESS Patch Set 1 in 00:41\n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/RedHat_CI\nend","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1f26c0ef61e4e37bacac68014d993df108f70296","revisions":{"1f26c0ef61e4e37bacac68014d993df108f70296":{"kind":"REWORK","_number":1,"created":"2014-11-18 07:24:48.000000000","uploader":{"_account_id":12742,"name":"Oleg Gashev","email":"oleg@gashev.net","username":"gashev"},"ref":"refs/changes/83/135183/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/83/135183/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/83/135183/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/83/135183/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/83/135183/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/83/135183/1"}}},"commit":{"parents":[{"commit":"e883ad228ca73dfcd91a62f8cad5186904a5e379","subject":"Merge \"lib/dstat: Fix a comment\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e883ad228ca73dfcd91a62f8cad5186904a5e379"}]}],"author":{"name":"Oleg Gashev","email":"oleg@gashev.net","date":"2014-11-18 07:16:01.000000000","tz":-300},"committer":{"name":"Oleg Gashev","email":"oleg@gashev.net","date":"2014-11-18 07:16:01.000000000","tz":-300},"subject":"Fixed conditions to determine if current distribution is a Fedora based distribution","message":"Fixed conditions to determine if current distribution is a Fedora based distribution\n\nstack.sh line 223:\nif [[ is_fedora \u0026\u0026 $DISTRO \u003d\u003d \"rhel6\" ]]; then\n\nstack.sh line 234:\nif [[ is_fedora \u0026\u0026 ( $DISTRO \u003d\u003d \"rhel6\" || $DISTRO \u003d\u003d \"rhel7\" ) ]]; then\n\nstack.sh line 358:\nif [[ is_fedora \u0026\u0026 $DISTRO \u003d\u003d \"rhel6\" ]]; then\n\nCondition [[ is_fedora \u0026\u0026 $DISTRO \u003d\u003d \"rhel6\" ]] return wrong result.\nThis condition is equivalent to the\n[[ -n is_fedora \u0026\u0026 $DISTRO \u003d\u003d \"rhel6\" ]]. First expression -n is_fedora\nalways not null, therefore this condition the same is\n[[ $DISTRO \u003d \"rhel6\" ]].\n\nChange-Id: Ida9eaa7950554bcd2f183dede7ad19522f9ca558\nCloses-Bug: #1393684\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1f26c0ef61e4e37bacac68014d993df108f70296"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1f26c0ef61e4e37bacac68014d993df108f70296"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}