)]}'
{"lib/ceilometer":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f69ea546c04abcda0d59b28bd9cbdfd093d396a2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    :"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"function add_config_opt {"},{"line_number":48,"context_line":"    echo \"$1\" \u003e\u003e $2"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAALH%2F%2FQ%2F0%3D","line":47,"updated":"2012-09-27 16:33:07.000000000","message":"Why a new function?  see below...","commit_id":"b1f7c48737cbb8fa81fe4590ed7360b657eb67c1"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"cfaece13300bf745de78e130429291ee92aa75ff","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    :"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"function add_config_opt {"},{"line_number":48,"context_line":"    echo \"$1\" \u003e\u003e $2"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAALH%2F%2FQ9c%3D","line":47,"in_reply_to":"AAAALH%2F%2FQ%2F0%3D","updated":"2012-09-27 17:04:34.000000000","message":"Now using iniset","commit_id":"b1f7c48737cbb8fa81fe4590ed7360b657eb67c1"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f69ea546c04abcda0d59b28bd9cbdfd093d396a2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # ceilometer confs are copy of /etc/nova/nova.conf which must exist first"},{"line_number":62,"context_line":"    grep -v format_string $NOVA_CONF_DIR/$NOVA_CONF \u003e $CEILOMETER_AGENT_CONF"},{"line_number":63,"context_line":"    grep -v format_string $NOVA_CONF_DIR/$NOVA_CONF \u003e $CEILOMETER_COLLECTOR_CONF"},{"line_number":64,"context_line":"    add_config_opt \"notification_topics\u003dnotifications,glance_notifications\" $CEILOMETER_COLLECTOR_CONF"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# install_ceilometer() - Collect source and prepare"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAALH%2F%2FRAM%3D","line":64,"updated":"2012-09-27 16:33:07.000000000","message":"I don\u0027t see the value-add in using a function here, especially a new one that isn\u0027t used anywhere else.  Either use iniset or just append it directly to the config file.","commit_id":"b1f7c48737cbb8fa81fe4590ed7360b657eb67c1"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"cfaece13300bf745de78e130429291ee92aa75ff","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # ceilometer confs are copy of /etc/nova/nova.conf which must exist first"},{"line_number":62,"context_line":"    grep -v format_string $NOVA_CONF_DIR/$NOVA_CONF \u003e $CEILOMETER_AGENT_CONF"},{"line_number":63,"context_line":"    grep -v format_string $NOVA_CONF_DIR/$NOVA_CONF \u003e $CEILOMETER_COLLECTOR_CONF"},{"line_number":64,"context_line":"    add_config_opt \"notification_topics\u003dnotifications,glance_notifications\" $CEILOMETER_COLLECTOR_CONF"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# install_ceilometer() - Collect source and prepare"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAALH%2F%2FQ9Y%3D","line":64,"in_reply_to":"AAAALH%2F%2FRAM%3D","updated":"2012-09-27 17:04:34.000000000","message":"Fair enough, now using iniset.","commit_id":"b1f7c48737cbb8fa81fe4590ed7360b657eb67c1"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f69ea546c04abcda0d59b28bd9cbdfd093d396a2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# start_ceilometer() - Start running processes, including screen"},{"line_number":73,"context_line":"function start_ceilometer() {"},{"line_number":74,"context_line":"    screen_it ceilometer-acompute \"cd $CEILOMETER_DIR \u0026\u0026 $CEILOMETER_BIN_DIR/ceilometer-agent-compute --config-file $CEILOMETER_AGENT_CONF\""},{"line_number":75,"context_line":"    screen_it ceilometer-acentral \"export OS_USERNAME\u003d$OS_USERNAME OS_PASSWORD\u003d$OS_PASSWORD OS_TENANT_NAME\u003d$OS_TENANT_NAME OS_AUTH_URL\u003d$OS_AUTH_URL \u0026\u0026 cd $CEILOMETER_DIR \u0026\u0026 $CEILOMETER_BIN_DIR/ceilometer-agent-central --config-file $CEILOMETER_AGENT_CONF\""},{"line_number":76,"context_line":"    screen_it ceilometer-collector \"cd $CEILOMETER_DIR \u0026\u0026 $CEILOMETER_BIN_DIR/ceilometer-collector --config-file $CEILOMETER_COLLECTOR_CONF\""},{"line_number":77,"context_line":"    screen_it ceilometer-api \"cd $CEILOMETER_DIR \u0026\u0026 $CEILOMETER_BIN_DIR/ceilometer-api -d -v --log-dir\u003d$CEILOMETER_API_LOG_DIR\""},{"line_number":78,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAALH%2F%2FQ%2F4%3D","line":75,"updated":"2012-09-27 16:33:07.000000000","message":"The use of these OS_ env vars needs to be added to the list at the top of the file, plus maybe the assumption that they\u0027re set to admin credentials.\n\nHmmm...there\u0027s no list at all there.  DEST, NOVA_CONF_DIR, NOVA_CONF all need to be listed.","commit_id":"b1f7c48737cbb8fa81fe4590ed7360b657eb67c1"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"cfaece13300bf745de78e130429291ee92aa75ff","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# start_ceilometer() - Start running processes, including screen"},{"line_number":73,"context_line":"function start_ceilometer() {"},{"line_number":74,"context_line":"    screen_it ceilometer-acompute \"cd $CEILOMETER_DIR \u0026\u0026 $CEILOMETER_BIN_DIR/ceilometer-agent-compute --config-file $CEILOMETER_AGENT_CONF\""},{"line_number":75,"context_line":"    screen_it ceilometer-acentral \"export OS_USERNAME\u003d$OS_USERNAME OS_PASSWORD\u003d$OS_PASSWORD OS_TENANT_NAME\u003d$OS_TENANT_NAME OS_AUTH_URL\u003d$OS_AUTH_URL \u0026\u0026 cd $CEILOMETER_DIR \u0026\u0026 $CEILOMETER_BIN_DIR/ceilometer-agent-central --config-file $CEILOMETER_AGENT_CONF\""},{"line_number":76,"context_line":"    screen_it ceilometer-collector \"cd $CEILOMETER_DIR \u0026\u0026 $CEILOMETER_BIN_DIR/ceilometer-collector --config-file $CEILOMETER_COLLECTOR_CONF\""},{"line_number":77,"context_line":"    screen_it ceilometer-api \"cd $CEILOMETER_DIR \u0026\u0026 $CEILOMETER_BIN_DIR/ceilometer-api -d -v --log-dir\u003d$CEILOMETER_API_LOG_DIR\""},{"line_number":78,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAALH%2F%2FQ9Q%3D","line":75,"in_reply_to":"AAAALH%2F%2FQ%2F4%3D","updated":"2012-09-27 17:04:34.000000000","message":"Good shout, addressed in the latest patch set.","commit_id":"b1f7c48737cbb8fa81fe4590ed7360b657eb67c1"}],"lib/glance":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f69ea546c04abcda0d59b28bd9cbdfd093d396a2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    iniset $GLANCE_API_CONF keystone_authtoken admin_tenant_name $SERVICE_TENANT_NAME"},{"line_number":108,"context_line":"    iniset $GLANCE_API_CONF keystone_authtoken admin_user glance"},{"line_number":109,"context_line":"    iniset $GLANCE_API_CONF keystone_authtoken admin_password $SERVICE_PASSWORD"},{"line_number":110,"context_line":"    if is_service_enabled qpid; then"},{"line_number":111,"context_line":"        iniset $GLANCE_API_CONF DEFAULT notifier_strategy qpid"},{"line_number":112,"context_line":"    elif [ -n \"$RABBIT_HOST\" ] \u0026\u0026  [ -n \"$RABBIT_PASSWORD\" ]; then"},{"line_number":113,"context_line":"        iniset $GLANCE_API_CONF DEFAULT notifier_strategy rabbit"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAALH%2F%2FQ%2Fg%3D","line":110,"updated":"2012-09-27 16:33:07.000000000","message":"zeromq support is present and documented (if not complete); if it isn\u0027t supported here it should note a config error and exit.","commit_id":"b1f7c48737cbb8fa81fe4590ed7360b657eb67c1"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"cfaece13300bf745de78e130429291ee92aa75ff","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    iniset $GLANCE_API_CONF keystone_authtoken admin_tenant_name $SERVICE_TENANT_NAME"},{"line_number":108,"context_line":"    iniset $GLANCE_API_CONF keystone_authtoken admin_user glance"},{"line_number":109,"context_line":"    iniset $GLANCE_API_CONF keystone_authtoken admin_password $SERVICE_PASSWORD"},{"line_number":110,"context_line":"    if is_service_enabled qpid; then"},{"line_number":111,"context_line":"        iniset $GLANCE_API_CONF DEFAULT notifier_strategy qpid"},{"line_number":112,"context_line":"    elif [ -n \"$RABBIT_HOST\" ] \u0026\u0026  [ -n \"$RABBIT_PASSWORD\" ]; then"},{"line_number":113,"context_line":"        iniset $GLANCE_API_CONF DEFAULT notifier_strategy rabbit"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAALH%2F%2FQ%2BI%3D","line":110,"in_reply_to":"AAAALH%2F%2FQ%2Fg%3D","updated":"2012-09-27 17:04:34.000000000","message":"ZeroMQ is indeed supported by the openstack-common RPC layer, which is used by nova etc. But glance has its own set of notifier strategies, effectively qpid, rabbit, logging or no-op.\n\nI\u0027m thinking if ZeroMQ is selected as the AMQP provider in devstack, then it would be better for glance notification to just fallback to the default no-op, instead of failing out of stack.sh. My reasoning here is that AMQP is used by glance for notifications *only*, whereas nova uses it for RPC also - so glance can function fine without AMQP.","commit_id":"b1f7c48737cbb8fa81fe4590ed7360b657eb67c1"}]}