)]}'
{"lib/neutron":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a94734d4f4d52d2c4d309790528d49658b96164a","unresolved":false,"context_lines":[{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    if [[ \"$Q_PLUGIN\" \u003d\u003d \u0027cisco\u0027 ]]; then"},{"line_number":533,"context_line":"      neutron cisco-network-profile-create default_network_profile vlan --segment_range 1-3000 --physical_network \"$PHYSICAL_NETWORK\""},{"line_number":534,"context_line":"    fi"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    # Create a small network"},{"line_number":537,"context_line":"    # Since neutron command is executed in admin context at this point,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a890539_6123f0aa","line":534,"updated":"2014-12-05 13:48:02.000000000","message":"Can you put this logic in a function in lib/neutron_plugins/cisco and call it from here? I am not a bash expert but you should be able to conditionally call the function if it exists, something like this:\n\n  if type -p neutron_plugin_create_initial_network \u003e /dev/null; then\n      neutron_plugin_create_initial_network $PHYSICAL_NETWORK\n  fi","commit_id":"3b81bcadcdb189b72b7bb8410bdae75898bbd8be"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"da779f5e52826e163fe96441a2fb6111f8134779","unresolved":false,"context_lines":[{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    if [[ \"$Q_PLUGIN\" \u003d\u003d \u0027cisco\u0027 ]]; then"},{"line_number":533,"context_line":"      neutron cisco-network-profile-create default_network_profile vlan --segment_range 1-3000 --physical_network \"$PHYSICAL_NETWORK\""},{"line_number":534,"context_line":"    fi"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    # Create a small network"},{"line_number":537,"context_line":"    # Since neutron command is executed in admin context at this point,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a961159_c5dd8b44","line":534,"in_reply_to":"5a890539_6123f0aa","updated":"2014-12-08 12:09:02.000000000","message":"Done","commit_id":"3b81bcadcdb189b72b7bb8410bdae75898bbd8be"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"117d411b205d905f40574ee50584d4d7ee31455c","unresolved":false,"context_lines":[{"line_number":529,"context_line":"    TENANT_ID\u003d$(openstack project list | grep \" demo \" | get_field 1)"},{"line_number":530,"context_line":"    die_if_not_set $LINENO TENANT_ID \"Failure retrieving TENANT_ID for demo\""},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    # When using Cisco N1k, create a default Network Profile"},{"line_number":533,"context_line":"    if type neutron_plugin_create_initial_network_profile \u003e /dev/null; then"},{"line_number":534,"context_line":"        neutron_plugin_create_initial_network_profile $PHYSICAL_NETWORK"},{"line_number":535,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a961159_abee7e89","line":532,"updated":"2014-12-08 21:34:25.000000000","message":"I would prefer this comment to also be generic. How about:\n\n  # Allow drivers that need to create an initial network to do so here","commit_id":"736f328d4952d3e62c7a056115a6b9b8c2c0ddee"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"17ee964de285a458f12c0b5a658201b217ad45b8","unresolved":false,"context_lines":[{"line_number":529,"context_line":"    TENANT_ID\u003d$(openstack project list | grep \" demo \" | get_field 1)"},{"line_number":530,"context_line":"    die_if_not_set $LINENO TENANT_ID \"Failure retrieving TENANT_ID for demo\""},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    # When using Cisco N1k, create a default Network Profile"},{"line_number":533,"context_line":"    if type neutron_plugin_create_initial_network_profile \u003e /dev/null; then"},{"line_number":534,"context_line":"        neutron_plugin_create_initial_network_profile $PHYSICAL_NETWORK"},{"line_number":535,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a961159_b3c18130","line":532,"in_reply_to":"3a961159_abee7e89","updated":"2014-12-09 09:52:45.000000000","message":"Done","commit_id":"736f328d4952d3e62c7a056115a6b9b8c2c0ddee"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"117d411b205d905f40574ee50584d4d7ee31455c","unresolved":false,"context_lines":[{"line_number":530,"context_line":"    die_if_not_set $LINENO TENANT_ID \"Failure retrieving TENANT_ID for demo\""},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    # When using Cisco N1k, create a default Network Profile"},{"line_number":533,"context_line":"    if type neutron_plugin_create_initial_network_profile \u003e /dev/null; then"},{"line_number":534,"context_line":"        neutron_plugin_create_initial_network_profile $PHYSICAL_NETWORK"},{"line_number":535,"context_line":"    fi"},{"line_number":536,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a961159_cb366a03","line":533,"updated":"2014-12-08 21:34:25.000000000","message":"I think you need to use the -p option for type or you will get an error message if the function is not defined. See:\n\nhttp://logs.openstack.org/20/139620/3/check/check-tempest-dsvm-neutron-full/79a8e41/logs/devstacklog.txt.gz#_2014-12-08_12_30_34_227","commit_id":"736f328d4952d3e62c7a056115a6b9b8c2c0ddee"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"17ee964de285a458f12c0b5a658201b217ad45b8","unresolved":false,"context_lines":[{"line_number":530,"context_line":"    die_if_not_set $LINENO TENANT_ID \"Failure retrieving TENANT_ID for demo\""},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    # When using Cisco N1k, create a default Network Profile"},{"line_number":533,"context_line":"    if type neutron_plugin_create_initial_network_profile \u003e /dev/null; then"},{"line_number":534,"context_line":"        neutron_plugin_create_initial_network_profile $PHYSICAL_NETWORK"},{"line_number":535,"context_line":"    fi"},{"line_number":536,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a961159_f3094996","line":533,"in_reply_to":"3a961159_cb366a03","updated":"2014-12-09 09:52:45.000000000","message":"Ah, good spot. I\u0027d tested with and without the plugin and it appeared to work as intended, so hadn\u0027t dived into the logs any further. Thanks for the feedback.","commit_id":"736f328d4952d3e62c7a056115a6b9b8c2c0ddee"}]}