)]}'
{"lib/sahara":[{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"db39e0b8d5c85d95d736e3c8c529c9545a6ee292","unresolved":false,"context_lines":[{"line_number":164,"context_line":"}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# register_images() - Registers images in sahara image registry"},{"line_number":167,"context_line":"function register_images {"},{"line_number":168,"context_line":"    if is_service_enabled heat; then"},{"line_number":169,"context_line":"        # Register heat image for Fake plugin"},{"line_number":170,"context_line":"        if [[ ! -z \"$HEAT_CFN_IMAGE_URL\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a961159_edf325e5","line":167,"updated":"2014-12-17 10:06:29.000000000","message":"It should be named sahara_register_images to avoid intersections in naming between different files of devstack.","commit_id":"66a07c4778f7f490052d7999756f71d593a123d8"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"4e625c6f64dc43d576b20dab031a7cea0a2b5c6f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# register_images() - Registers images in sahara image registry"},{"line_number":167,"context_line":"function register_images {"},{"line_number":168,"context_line":"    if is_service_enabled heat; then"},{"line_number":169,"context_line":"        # Register heat image for Fake plugin"},{"line_number":170,"context_line":"        if [[ ! -z \"$HEAT_CFN_IMAGE_URL\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a961159_a0eaeda9","line":167,"in_reply_to":"3a961159_edf325e5","updated":"2014-12-18 00:40:58.000000000","message":"Done","commit_id":"66a07c4778f7f490052d7999756f71d593a123d8"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"db39e0b8d5c85d95d736e3c8c529c9545a6ee292","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            TOKEN\u003d$(keystone token-get | grep \u0027 id \u0027 | get_field 2)"},{"line_number":172,"context_line":"            die_if_not_set $LINENO TOKEN \"Keystone fail to get token\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            SAHARA_FAKE_PLUGIN_PROPERTIES\u003d\"--property _sahara_tag_0.1\u003dTrue --property _sahara_tag_fake\u003dTrue --property _sahara_username\u003dfedora\""},{"line_number":175,"context_line":"            openstack --os-token $TOKEN --os-url $GLANCE_SERVICE_PROTOCOL://$GLANCE_HOSTPORT image set $(basename \"$HEAT_CFN_IMAGE_URL\" \".qcow2\") $SAHARA_FAKE_PLUGIN_PROPERTIES"},{"line_number":176,"context_line":"        fi"},{"line_number":177,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a961159_8d262167","line":174,"updated":"2014-12-17 10:06:29.000000000","message":"Please, split it to three lines to make more readable, like\n\nSAHARA_FAKE_PLUGIN_PROPERTIES\u003d...\nSAHARA_FAKE_PLUGIN_PROPERTIES+\u003d...\nSAHARA_FAKE_PLUGIN_PROPERTIES+\u003d...","commit_id":"66a07c4778f7f490052d7999756f71d593a123d8"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"4e625c6f64dc43d576b20dab031a7cea0a2b5c6f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            TOKEN\u003d$(keystone token-get | grep \u0027 id \u0027 | get_field 2)"},{"line_number":172,"context_line":"            die_if_not_set $LINENO TOKEN \"Keystone fail to get token\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            SAHARA_FAKE_PLUGIN_PROPERTIES\u003d\"--property _sahara_tag_0.1\u003dTrue --property _sahara_tag_fake\u003dTrue --property _sahara_username\u003dfedora\""},{"line_number":175,"context_line":"            openstack --os-token $TOKEN --os-url $GLANCE_SERVICE_PROTOCOL://$GLANCE_HOSTPORT image set $(basename \"$HEAT_CFN_IMAGE_URL\" \".qcow2\") $SAHARA_FAKE_PLUGIN_PROPERTIES"},{"line_number":176,"context_line":"        fi"},{"line_number":177,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a961159_119a316e","line":174,"in_reply_to":"3a961159_8d262167","updated":"2014-12-18 00:40:58.000000000","message":"Done","commit_id":"66a07c4778f7f490052d7999756f71d593a123d8"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2722c8bc046115ba0766f1819941989323a856c5","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    if is_service_enabled heat; then"},{"line_number":169,"context_line":"        # Register heat image for Fake plugin"},{"line_number":170,"context_line":"        if [[ ! -z \"$HEAT_CFN_IMAGE_URL\" ]]; then"},{"line_number":171,"context_line":"            TOKEN\u003d$(keystone token-get | grep \u0027 id \u0027 | get_field 2)"},{"line_number":172,"context_line":"            die_if_not_set $LINENO TOKEN \"Keystone fail to get token\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            SAHARA_FAKE_PLUGIN_PROPERTIES\u003d\"--property _sahara_tag_0.1\u003dTrue\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a961159_cb2f1587","line":171,"updated":"2014-12-18 03:02:35.000000000","message":"can we make this a local (lower case to)\n\nalso could save a level of indent with an \u0026\u0026?","commit_id":"4888460c86d012ce5f491833822914ebb482369c"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"e8b3f4da97fce6f4c9ad95bd4c8101ef5bb52a3c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    if is_service_enabled heat; then"},{"line_number":169,"context_line":"        # Register heat image for Fake plugin"},{"line_number":170,"context_line":"        if [[ ! -z \"$HEAT_CFN_IMAGE_URL\" ]]; then"},{"line_number":171,"context_line":"            TOKEN\u003d$(keystone token-get | grep \u0027 id \u0027 | get_field 2)"},{"line_number":172,"context_line":"            die_if_not_set $LINENO TOKEN \"Keystone fail to get token\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            SAHARA_FAKE_PLUGIN_PROPERTIES\u003d\"--property _sahara_tag_0.1\u003dTrue\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a961159_b075b099","line":171,"in_reply_to":"3a961159_cb2f1587","updated":"2014-12-18 22:17:29.000000000","message":"Done","commit_id":"4888460c86d012ce5f491833822914ebb482369c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2722c8bc046115ba0766f1819941989323a856c5","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            TOKEN\u003d$(keystone token-get | grep \u0027 id \u0027 | get_field 2)"},{"line_number":172,"context_line":"            die_if_not_set $LINENO TOKEN \"Keystone fail to get token\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            SAHARA_FAKE_PLUGIN_PROPERTIES\u003d\"--property _sahara_tag_0.1\u003dTrue\""},{"line_number":175,"context_line":"            SAHARA_FAKE_PLUGIN_PROPERTIES+\u003d\" --property _sahara_tag_fake\u003dTrue\""},{"line_number":176,"context_line":"            SAHARA_FAKE_PLUGIN_PROPERTIES+\u003d\" --property _sahara_username\u003dfedora\""},{"line_number":177,"context_line":"            openstack --os-token $TOKEN --os-url $GLANCE_SERVICE_PROTOCOL://$GLANCE_HOSTPORT image set $(basename \"$HEAT_CFN_IMAGE_URL\" \".qcow2\") $SAHARA_FAKE_PLUGIN_PROPERTIES"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a961159_2b589931","line":174,"updated":"2014-12-18 03:02:35.000000000","message":"can also be a local?","commit_id":"4888460c86d012ce5f491833822914ebb482369c"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"e8b3f4da97fce6f4c9ad95bd4c8101ef5bb52a3c","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            TOKEN\u003d$(keystone token-get | grep \u0027 id \u0027 | get_field 2)"},{"line_number":172,"context_line":"            die_if_not_set $LINENO TOKEN \"Keystone fail to get token\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"            SAHARA_FAKE_PLUGIN_PROPERTIES\u003d\"--property _sahara_tag_0.1\u003dTrue\""},{"line_number":175,"context_line":"            SAHARA_FAKE_PLUGIN_PROPERTIES+\u003d\" --property _sahara_tag_fake\u003dTrue\""},{"line_number":176,"context_line":"            SAHARA_FAKE_PLUGIN_PROPERTIES+\u003d\" --property _sahara_username\u003dfedora\""},{"line_number":177,"context_line":"            openstack --os-token $TOKEN --os-url $GLANCE_SERVICE_PROTOCOL://$GLANCE_HOSTPORT image set $(basename \"$HEAT_CFN_IMAGE_URL\" \".qcow2\") $SAHARA_FAKE_PLUGIN_PROPERTIES"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a961159_d07a3c87","line":174,"in_reply_to":"3a961159_2b589931","updated":"2014-12-18 22:17:29.000000000","message":"Done","commit_id":"4888460c86d012ce5f491833822914ebb482369c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1147e2bc2a790b8c7d0b4aec8e24ba4aa76fb341","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        local fake_plugin_properties\u003d\"--property _sahara_tag_0.1\u003dTrue\""},{"line_number":174,"context_line":"        fake_plugin_properties+\u003d\" --property _sahara_tag_fake\u003dTrue\""},{"line_number":175,"context_line":"        fake_plugin_properties+\u003d\" --property _sahara_username\u003dfedora\""},{"line_number":176,"context_line":"        openstack --os-token $token --os-url $GLANCE_SERVICE_PROTOCOL://$GLANCE_HOSTPORT image set $(basename \"$HEAT_CFN_IMAGE_URL\" \".qcow2\") $fake_plugin_properties"},{"line_number":177,"context_line":"    fi"},{"line_number":178,"context_line":"}"},{"line_number":179,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a961159_34db2d50","line":176,"updated":"2015-01-07 20:24:07.000000000","message":"Why do you get a token above to use here?  OSC should work with the pre-set auth environment variables.","commit_id":"eb5e547bdbd772206d6aa81cdc64a766dd50966b"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"e0a688ea6f36a300c8b1d000b5895fe7a02913e6","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        local fake_plugin_properties\u003d\"--property _sahara_tag_0.1\u003dTrue\""},{"line_number":174,"context_line":"        fake_plugin_properties+\u003d\" --property _sahara_tag_fake\u003dTrue\""},{"line_number":175,"context_line":"        fake_plugin_properties+\u003d\" --property _sahara_username\u003dfedora\""},{"line_number":176,"context_line":"        openstack --os-token $token --os-url $GLANCE_SERVICE_PROTOCOL://$GLANCE_HOSTPORT image set $(basename \"$HEAT_CFN_IMAGE_URL\" \".qcow2\") $fake_plugin_properties"},{"line_number":177,"context_line":"    fi"},{"line_number":178,"context_line":"}"},{"line_number":179,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a961159_a0f517cc","line":176,"in_reply_to":"3a961159_34db2d50","updated":"2015-01-07 22:28:32.000000000","message":"copy-pasted from \"upload_image\", will try without token","commit_id":"eb5e547bdbd772206d6aa81cdc64a766dd50966b"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"b1c5eb95d3c0793691336c330d4494408ecbbabd","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        local fake_plugin_properties\u003d\"--property _sahara_tag_0.1\u003dTrue\""},{"line_number":174,"context_line":"        fake_plugin_properties+\u003d\" --property _sahara_tag_fake\u003dTrue\""},{"line_number":175,"context_line":"        fake_plugin_properties+\u003d\" --property _sahara_username\u003dfedora\""},{"line_number":176,"context_line":"        openstack --os-token $token --os-url $GLANCE_SERVICE_PROTOCOL://$GLANCE_HOSTPORT image set $(basename \"$HEAT_CFN_IMAGE_URL\" \".qcow2\") $fake_plugin_properties"},{"line_number":177,"context_line":"    fi"},{"line_number":178,"context_line":"}"},{"line_number":179,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a961159_2c3488ab","line":176,"in_reply_to":"3a961159_a0f517cc","updated":"2015-01-09 20:08:03.000000000","message":"Tried without getting token. It works. Updated patch.","commit_id":"eb5e547bdbd772206d6aa81cdc64a766dd50966b"}]}
