)]}'
{"lib/neutron":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"8a78de31df9b2beef046874b216c195bd5d72972","unresolved":false,"context_lines":[{"line_number":74,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d${PUBLIC_NETWORK_GATEWAY:-172.24.4.1}"},{"line_number":75,"context_line":"PRIVATE_SUBNET_NAME\u003d${PRIVATE_SUBNET_NAME:-\"private-subnet\"}"},{"line_number":76,"context_line":"PUBLIC_SUBNET_NAME\u003d${PUBLIC_SUBNET_NAME:-\"public-subnet\"}"},{"line_number":77,"context_line":"PUBLIC_NETWORK_TYPE\u003d${PUBLIC_NETWORK_TYPE:-\"flat\"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"if is_ssl_enabled_service \"neutron\" || is_service_enabled tls-proxy; then"},{"line_number":80,"context_line":"    Q_PROTOCOL\u003d\"https\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a961159_381ac9c6","line":77,"updated":"2014-12-30 18:26:09.000000000","message":"This change in this file should be pulled out to another patchset","commit_id":"6bc79a29e19801fe11051d29497f3e42e7cba33e"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"6650498092e1ea36361ef2d904922b74e9491480","unresolved":false,"context_lines":[{"line_number":74,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d${PUBLIC_NETWORK_GATEWAY:-172.24.4.1}"},{"line_number":75,"context_line":"PRIVATE_SUBNET_NAME\u003d${PRIVATE_SUBNET_NAME:-\"private-subnet\"}"},{"line_number":76,"context_line":"PUBLIC_SUBNET_NAME\u003d${PUBLIC_SUBNET_NAME:-\"public-subnet\"}"},{"line_number":77,"context_line":"PUBLIC_NETWORK_TYPE\u003d${PUBLIC_NETWORK_TYPE:-\"flat\"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"if is_ssl_enabled_service \"neutron\" || is_service_enabled tls-proxy; then"},{"line_number":80,"context_line":"    Q_PROTOCOL\u003d\"https\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a961159_95eb7b11","line":77,"in_reply_to":"3a961159_381ac9c6","updated":"2014-12-31 07:36:30.000000000","message":"Done","commit_id":"6bc79a29e19801fe11051d29497f3e42e7cba33e"}],"lib/neutron_plugins/vmware_nsx":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"f2712d0ac3fb9abb204c779997aeae0cba35c14c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"function has_neutron_plugin_security_group {"},{"line_number":8,"context_line":"    # 0 means True here"},{"line_number":9,"context_line":"    return 0"},{"line_number":10,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"ba7be1f8_bf67a424","line":10,"updated":"2015-02-27 15:31:52.000000000","message":"this should stay unfortunately (see comment above)","commit_id":"8d9c93a8e2369232f4b328e057a89ce890165a23"}],"lib/neutron_plugins/vmware_nsx_v":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"725d49f9e8a37099ac6f2056dd78f4907d56684a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Neutron VMware NSXv plugin"},{"line_number":2,"context_line":"# --------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Save trace setting"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da86d52c_eea86579","line":1,"updated":"2015-02-03 04:07:20.000000000","message":"there\u0027s nothing wrong with the approach you chose here, per se. But you could achieve greater flexibility if you alternatively chose local.conf or extra.d hooks to externalize all of the plumbing you\u0027ve done here and put there somewhere else, for instance in the vmware-nsx repo. This way, you don\u0027t have to touch/depend on the DevStack repo at all.","commit_id":"56e58783c2cc1dac4c05f989b5c277f00a7434fa"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"725d49f9e8a37099ac6f2056dd78f4907d56684a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"function neutron_plugin_configure_service {"},{"line_number":61,"context_line":"    _nsxv_ini_set password \"$NSXV_PASSWORD\""},{"line_number":62,"context_line":"    _nsxv_ini_set user \"$NSXV_USER\""},{"line_number":63,"context_line":"    _nsxv_ini_set vdn_scope_id \"$NSXV_VDN_SCOPE_ID\""},{"line_number":64,"context_line":"    _nsxv_ini_set dvs_id \"$NSXV_DVS_ID\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da86d52c_4eac11a1","line":61,"updated":"2015-02-03 04:07:20.000000000","message":"all of these can be tuned with local.conf; you could add this section to local.conf:\n\n  [[post-config|/$Q_PLUGIN_CONF_FILE]]\n\n  [nsxv]\n  password\u003d$NSXV_PASSWORD\n  user\u003d$NSXV_USER\n  ....","commit_id":"56e58783c2cc1dac4c05f989b5c277f00a7434fa"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"72a57700d5fa29a52e4bf2acfe50c13baaf60190","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"function neutron_plugin_configure_service {"},{"line_number":61,"context_line":"    _nsxv_ini_set password \"$NSXV_PASSWORD\""},{"line_number":62,"context_line":"    _nsxv_ini_set user \"$NSXV_USER\""},{"line_number":63,"context_line":"    _nsxv_ini_set vdn_scope_id \"$NSXV_VDN_SCOPE_ID\""},{"line_number":64,"context_line":"    _nsxv_ini_set dvs_id \"$NSXV_DVS_ID\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da86d52c_82c22b32","line":61,"in_reply_to":"da86d52c_28b51031","updated":"2015-02-04 01:58:31.000000000","message":"Agreed, pass through variables should be in local.conf. Unless a variable triggers something more than a pass through, it shouldn\u0027t be here.","commit_id":"56e58783c2cc1dac4c05f989b5c277f00a7434fa"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"5c64fa864d1051a0ea0b1da249583206706c323e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"function neutron_plugin_configure_service {"},{"line_number":61,"context_line":"    _nsxv_ini_set password \"$NSXV_PASSWORD\""},{"line_number":62,"context_line":"    _nsxv_ini_set user \"$NSXV_USER\""},{"line_number":63,"context_line":"    _nsxv_ini_set vdn_scope_id \"$NSXV_VDN_SCOPE_ID\""},{"line_number":64,"context_line":"    _nsxv_ini_set dvs_id \"$NSXV_DVS_ID\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da86d52c_59b5f82f","line":61,"in_reply_to":"da86d52c_28b51031","updated":"2015-02-09 09:09:13.000000000","message":"Right (its not a documenting tool), but I see no reason it shouldn\u0027t be self-documenting.\nwhat is the harm by having these here?\nwhat do we gain by tuning these variables in local.conf that we can\u0027t get by tuning them here?\n\nI don\u0027t believe I\u0027ve done anything uniq here, I used `lib/neutron_plugins/*`\nas a point of reference.","commit_id":"56e58783c2cc1dac4c05f989b5c277f00a7434fa"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"28eb0a04c862fe155773529b9015d01f770dbe32","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"function neutron_plugin_configure_service {"},{"line_number":61,"context_line":"    _nsxv_ini_set password \"$NSXV_PASSWORD\""},{"line_number":62,"context_line":"    _nsxv_ini_set user \"$NSXV_USER\""},{"line_number":63,"context_line":"    _nsxv_ini_set vdn_scope_id \"$NSXV_VDN_SCOPE_ID\""},{"line_number":64,"context_line":"    _nsxv_ini_set dvs_id \"$NSXV_DVS_ID\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da86d52c_f4ed98b8","line":61,"in_reply_to":"da86d52c_4eac11a1","updated":"2015-02-03 05:59:00.000000000","message":"Sure though, I\u0027d rather have all of this here to look up all the variables one would need to set.","commit_id":"56e58783c2cc1dac4c05f989b5c277f00a7434fa"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ee93c12ff2ccdde929e3f83ec71e15c0256fe10b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"function neutron_plugin_configure_service {"},{"line_number":61,"context_line":"    _nsxv_ini_set password \"$NSXV_PASSWORD\""},{"line_number":62,"context_line":"    _nsxv_ini_set user \"$NSXV_USER\""},{"line_number":63,"context_line":"    _nsxv_ini_set vdn_scope_id \"$NSXV_VDN_SCOPE_ID\""},{"line_number":64,"context_line":"    _nsxv_ini_set dvs_id \"$NSXV_DVS_ID\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da86d52c_28b51031","line":61,"in_reply_to":"da86d52c_f4ed98b8","updated":"2015-02-03 06:23:24.000000000","message":"why? DevStack is not a documentation tool, just put these into a localrc and add it somewhere else if you really need to.","commit_id":"56e58783c2cc1dac4c05f989b5c277f00a7434fa"}],"lib/neutron_thirdparty/vmware_nsx":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f5641e4cf7305f51ef7f33a86110353c409cab79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# REVISIT(roeyc): this file left empty so that \u0027enable_plugin vmware_nsx\u0027"},{"line_number":2,"context_line":"# continues to work."}],"source_content_type":"application/octet-stream","patch_set":17,"id":"ba7be1f8_b3ef78b0","line":1,"range":{"start_line":1,"start_character":48,"end_line":1,"end_character":61},"updated":"2015-03-03 05:42:13.000000000","message":"you mean enable_service?","commit_id":"c9c0cf6125720d46e5082efea6096ca12c197b9b"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"f14360a0b6576206f4000bd22999822b3c246e19","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# REVISIT(roeyc): this file left empty so that \u0027enable_plugin vmware_nsx\u0027"},{"line_number":2,"context_line":"# continues to work."}],"source_content_type":"application/octet-stream","patch_set":17,"id":"ba7be1f8_45e66bb1","line":1,"in_reply_to":"ba7be1f8_b3ef78b0","updated":"2015-03-03 10:03:48.000000000","message":"Thats correct, thanks.","commit_id":"c9c0cf6125720d46e5082efea6096ca12c197b9b"}],"lib/neutron_thirdparty/vmware_nsx_v":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"53c824f1d8527d6fafc63885c4ddc9b83c2b542a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set +o xtrace"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NSX_REPO\u003d\"git://git.openstack.org/stackforge/vmware-nsx\""},{"line_number":10,"context_line":"NSX_DIR\u003d$DEST/vmware-nsx"},{"line_number":11,"context_line":"NSX_BRANCH\u003d${NSX_BRANCH:-master}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3a961159_b007c980","line":9,"updated":"2014-12-29 15:30:28.000000000","message":"This should be in https://github.com/openstack-dev/devstack/blob/master/stackrc\n\nWe would want to be able to just update that file for stable versions\n\nMore specifically - https://github.com/openstack-dev/devstack/blob/master/stackrc#L434","commit_id":"a51ce45f0867a5c28eace4c5f1ed2788f3b9e1c9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5a02e908d0895d57288e8135b6978accc9f19958","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    NSX_DIR\u003d$DEST/vmware-nsx"},{"line_number":20,"context_line":"    git_clone $NSX_REPO $NSX_DIR $NSX_BRANCH"},{"line_number":21,"context_line":"    echo \"Installing VMware NSX plugin\""},{"line_number":22,"context_line":"    setup_develop $NSX_DIR"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"function start_vmware_nsx_v {"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3a961159_0eebd978","line":22,"updated":"2015-01-05 10:48:21.000000000","message":"By the end of the release cycle this will be a requirement for all vmware plugins, not just nsx-v. I think it\u0027s better to add this snippet to lib/neutron_third_party/vmware_nsx (no issue will arise from the fact that you clone vmware-nsx before we move out the code from openstack/neutron).\n\nIf this will create weird import situation we can create a lib/neutron_thirdparty/vmware module with common functions which will be imported by vmware_nsx and vmware_nsx_v","commit_id":"ff226a4b4ea1606e47a9e410d15c921fe8704eca"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"eb3dc08a50f6713c0f2f75eeeae4873a3163e97d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    NSX_DIR\u003d$DEST/vmware-nsx"},{"line_number":20,"context_line":"    git_clone $NSX_REPO $NSX_DIR $NSX_BRANCH"},{"line_number":21,"context_line":"    echo \"Installing VMware NSX plugin\""},{"line_number":22,"context_line":"    setup_develop $NSX_DIR"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"function start_vmware_nsx_v {"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3a961159_0332bd5d","line":22,"in_reply_to":"3a961159_0eebd978","updated":"2015-01-05 22:47:51.000000000","message":"Done","commit_id":"ff226a4b4ea1606e47a9e410d15c921fe8704eca"}],"stackrc":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"725d49f9e8a37099ac6f2056dd78f4907d56684a","unresolved":false,"context_lines":[{"line_number":470,"context_line":"NOVNC_REPO\u003d${NOVNC_REPO:-https://github.com/kanaka/noVNC.git}"},{"line_number":471,"context_line":"NOVNC_BRANCH\u003d${NOVNC_BRANCH:-master}"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"# vmware-nsx"},{"line_number":474,"context_line":"VMWARE_NSX_REPO\u003d${VMWARE_NSX_REPO:-${GIT_BASE}/stackforge/vmware-nsx.git}"},{"line_number":475,"context_line":"VMWARE_NSX_BRANCH\u003d${VMWARE_NSX_BRANCH:-master}"},{"line_number":476,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"da86d52c_aec58d3e","line":473,"updated":"2015-02-03 04:07:20.000000000","message":"I don\u0027t think it\u0027s necessary adding these init here. They can leave in your local.conf\u0027s localrc section.","commit_id":"56e58783c2cc1dac4c05f989b5c277f00a7434fa"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ee93c12ff2ccdde929e3f83ec71e15c0256fe10b","unresolved":false,"context_lines":[{"line_number":470,"context_line":"NOVNC_REPO\u003d${NOVNC_REPO:-https://github.com/kanaka/noVNC.git}"},{"line_number":471,"context_line":"NOVNC_BRANCH\u003d${NOVNC_BRANCH:-master}"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"# vmware-nsx"},{"line_number":474,"context_line":"VMWARE_NSX_REPO\u003d${VMWARE_NSX_REPO:-${GIT_BASE}/stackforge/vmware-nsx.git}"},{"line_number":475,"context_line":"VMWARE_NSX_BRANCH\u003d${VMWARE_NSX_BRANCH:-master}"},{"line_number":476,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"da86d52c_683b889c","line":473,"in_reply_to":"da86d52c_54366453","updated":"2015-02-03 06:23:24.000000000","message":"Besides well known ones, there\u0027s no stackforge project specified in here. I don\u0027t think we want to crowd this file with definitions that are not really necessary","commit_id":"56e58783c2cc1dac4c05f989b5c277f00a7434fa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6dad280e22b5fcecd7910435db27d58f509e5e7a","unresolved":false,"context_lines":[{"line_number":470,"context_line":"NOVNC_REPO\u003d${NOVNC_REPO:-https://github.com/kanaka/noVNC.git}"},{"line_number":471,"context_line":"NOVNC_BRANCH\u003d${NOVNC_BRANCH:-master}"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"# vmware-nsx"},{"line_number":474,"context_line":"VMWARE_NSX_REPO\u003d${VMWARE_NSX_REPO:-${GIT_BASE}/stackforge/vmware-nsx.git}"},{"line_number":475,"context_line":"VMWARE_NSX_BRANCH\u003d${VMWARE_NSX_BRANCH:-master}"},{"line_number":476,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"da86d52c_2f92b2f6","line":473,"in_reply_to":"da86d52c_683b889c","updated":"2015-02-08 17:43:41.000000000","message":"I am not sure that I agree here. The fact that the is a 1:1 relationship between neutron and the external stack forge projects entails that when we cut a devstack project for a stable version we will need to make the updates in different places. this will break things. why not have everything in one place - that is here in the stackrc file?","commit_id":"56e58783c2cc1dac4c05f989b5c277f00a7434fa"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"28eb0a04c862fe155773529b9015d01f770dbe32","unresolved":false,"context_lines":[{"line_number":470,"context_line":"NOVNC_REPO\u003d${NOVNC_REPO:-https://github.com/kanaka/noVNC.git}"},{"line_number":471,"context_line":"NOVNC_BRANCH\u003d${NOVNC_BRANCH:-master}"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"# vmware-nsx"},{"line_number":474,"context_line":"VMWARE_NSX_REPO\u003d${VMWARE_NSX_REPO:-${GIT_BASE}/stackforge/vmware-nsx.git}"},{"line_number":475,"context_line":"VMWARE_NSX_BRANCH\u003d${VMWARE_NSX_BRANCH:-master}"},{"line_number":476,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"da86d52c_54366453","line":473,"in_reply_to":"da86d52c_aec58d3e","updated":"2015-02-03 05:59:00.000000000","message":"ditto.","commit_id":"56e58783c2cc1dac4c05f989b5c277f00a7434fa"}]}