)]}'
{"tools/fixup_stuff.sh":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"809beb9af9dbdca941dcb663094e8b1bf28f6b95","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    FORCE_FIREWALLD\u003d$(trueorfalse False $FORCE_FIREWALLD)"},{"line_number":114,"context_line":"    if [[ ${DISTRO} \u003d~ (f19|f20) \u0026\u0026 $FORCE_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":115,"context_line":"        # On Fedora 19 and 20 firewalld interacts badly with libvirt and"},{"line_number":116,"context_line":"        # slows things down significantly.  However, for those cases"},{"line_number":117,"context_line":"        # where that combination is desired, allow this fix to be skipped."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a961159_68c9c759","side":"PARENT","line":115,"updated":"2015-01-02 17:55:23.000000000","message":"Perhaps update the comment here too, either to remove 19 or replace with 21 (depending on whether 21 has the same problem).","commit_id":"27f0339f8634df3f4b540e30df8667a42372482d"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"92e5016758edee9aa6355430f6bb0571617343f8","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    FORCE_FIREWALLD\u003d$(trueorfalse False $FORCE_FIREWALLD)"},{"line_number":114,"context_line":"    if [[ ${DISTRO} \u003d~ (f19|f20) \u0026\u0026 $FORCE_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":115,"context_line":"        # On Fedora 19 and 20 firewalld interacts badly with libvirt and"},{"line_number":116,"context_line":"        # slows things down significantly.  However, for those cases"},{"line_number":117,"context_line":"        # where that combination is desired, allow this fix to be skipped."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a961159_686c6737","side":"PARENT","line":115,"in_reply_to":"3a961159_68c9c759","updated":"2015-01-02 18:10:58.000000000","message":"I actually did briefly pause before making this change wondering whether to elide f19 - I\u0027ll do that for now. The said bug below doesn\u0027t mention Fedora 21  and there\u0027s no testing info about it yet.","commit_id":"27f0339f8634df3f4b540e30df8667a42372482d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"327297fd6181b9244253658b03f6c68ebb717c93","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    fi"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    FORCE_FIREWALLD\u003d$(trueorfalse False $FORCE_FIREWALLD)"},{"line_number":114,"context_line":"    if [[ ${DISTRO} \u003d~ (f20) \u0026\u0026 $FORCE_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":115,"context_line":"        # On Fedora 20 firewalld interacts badly with libvirt and"},{"line_number":116,"context_line":"        # slows things down significantly.  However, for those cases"},{"line_number":117,"context_line":"        # where that combination is desired, allow this fix to be skipped."}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_9ccc1c37","line":114,"updated":"2015-01-07 10:14:10.000000000","message":"Are we sure the issue is not relevant for Fedora 21?","commit_id":"7c9df1017cb249afd329e915aab8a04b04940bc2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1826b903623e6ebdc71dbcce19d8dc0f36ef329b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    fi"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    FORCE_FIREWALLD\u003d$(trueorfalse False $FORCE_FIREWALLD)"},{"line_number":114,"context_line":"    if [[ ${DISTRO} \u003d~ (f20) \u0026\u0026 $FORCE_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":115,"context_line":"        # On Fedora 20 firewalld interacts badly with libvirt and"},{"line_number":116,"context_line":"        # slows things down significantly.  However, for those cases"},{"line_number":117,"context_line":"        # where that combination is desired, allow this fix to be skipped."}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_19a2934b","line":114,"in_reply_to":"3a961159_05dfdd0d","updated":"2015-01-12 10:05:52.000000000","message":"How are those interactions fixed in f21? where\u0027s the fix?\n\nAre we sure making changes in the firewall policies over firewalld is not going to screw up the security group iptables or other iptables by neutron-openvswitch-agent?.","commit_id":"7c9df1017cb249afd329e915aab8a04b04940bc2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4d7cecabb1cf4798b9569c5bfac8429c8816f428","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    fi"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    FORCE_FIREWALLD\u003d$(trueorfalse False $FORCE_FIREWALLD)"},{"line_number":114,"context_line":"    if [[ ${DISTRO} \u003d~ (f20) \u0026\u0026 $FORCE_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":115,"context_line":"        # On Fedora 20 firewalld interacts badly with libvirt and"},{"line_number":116,"context_line":"        # slows things down significantly.  However, for those cases"},{"line_number":117,"context_line":"        # where that combination is desired, allow this fix to be skipped."}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_92bb23c3","line":114,"in_reply_to":"3a961159_2f2bec95","updated":"2015-01-07 11:12:05.000000000","message":"It depends on whether the impact of distro specific hack is enormous. If by removing the hack we\u0027re making some distros unusable, then we should probably leave the hack intact.\n\nI don\u0027t have any clue on what\u0027s the impact of the hack is, that\u0027s why I\u0027m asking.","commit_id":"7c9df1017cb249afd329e915aab8a04b04940bc2"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"5c282ac0c89a73f83b0ab7827a03d271c6110874","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    fi"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    FORCE_FIREWALLD\u003d$(trueorfalse False $FORCE_FIREWALLD)"},{"line_number":114,"context_line":"    if [[ ${DISTRO} \u003d~ (f20) \u0026\u0026 $FORCE_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":115,"context_line":"        # On Fedora 20 firewalld interacts badly with libvirt and"},{"line_number":116,"context_line":"        # slows things down significantly.  However, for those cases"},{"line_number":117,"context_line":"        # where that combination is desired, allow this fix to be skipped."}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_f708d292","line":114,"in_reply_to":"3a961159_92bb23c3","updated":"2015-01-07 14:42:02.000000000","message":"FWIW, with this patch, I\u0027ve tested DevStack on F21 successfully multiple times with Neutron without any glaring performance issues. So, it\u0027s not \"ununsable\" for sure.","commit_id":"7c9df1017cb249afd329e915aab8a04b04940bc2"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"d06ea25901c9daaf0c683d0ba44e85e8edb365c1","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    fi"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    FORCE_FIREWALLD\u003d$(trueorfalse False $FORCE_FIREWALLD)"},{"line_number":114,"context_line":"    if [[ ${DISTRO} \u003d~ (f20) \u0026\u0026 $FORCE_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":115,"context_line":"        # On Fedora 20 firewalld interacts badly with libvirt and"},{"line_number":116,"context_line":"        # slows things down significantly.  However, for those cases"},{"line_number":117,"context_line":"        # where that combination is desired, allow this fix to be skipped."}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_2f2bec95","line":114,"in_reply_to":"3a961159_9ccc1c37","updated":"2015-01-07 10:54:55.000000000","message":"AIUI, the rationale here is the said issue should not be fixed in DevStack, it should be handled elsewhere (firewalld, polkit, libvirt or wherever the root cause lies). Also, from what I see, avoiding distribution-specific workarounds is strongly preferred[1]\n\n[1] https://review.openstack.org/#/c/99047/1","commit_id":"7c9df1017cb249afd329e915aab8a04b04940bc2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5f18bc36f248fe1087bbdbde02822e6e0c09ed64","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    fi"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    FORCE_FIREWALLD\u003d$(trueorfalse False $FORCE_FIREWALLD)"},{"line_number":114,"context_line":"    if [[ ${DISTRO} \u003d~ (f20) \u0026\u0026 $FORCE_FIREWALLD \u003d\u003d \"False\" ]]; then"},{"line_number":115,"context_line":"        # On Fedora 20 firewalld interacts badly with libvirt and"},{"line_number":116,"context_line":"        # slows things down significantly.  However, for those cases"},{"line_number":117,"context_line":"        # where that combination is desired, allow this fix to be skipped."}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_05dfdd0d","line":114,"in_reply_to":"3a961159_f708d292","updated":"2015-01-07 22:03:23.000000000","message":"this issue was related to bad interactions between firewalld and libvirt and only existed on f19/f20.  the issue is fixed in f21","commit_id":"7c9df1017cb249afd329e915aab8a04b04940bc2"}]}