)]}'
{"id":"openstack%2Fdevstack~146223","triplet_id":"openstack%2Fdevstack~master~I01cec39dae8c6a99620d43471c9a7d34b84da846","project":"openstack/devstack","branch":"master","topic":"fix_remove_dis_extensions","hashtags":[],"change_id":"I01cec39dae8c6a99620d43471c9a7d34b84da846","subject":"Ensure also last extension in the list can be removed","status":"ABANDONED","created":"2015-01-09 23:22:20.000000000","updated":"2015-05-26 19:12:25.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9608b19d5b45efa279a029c132010ff0330b4e4f","_number":146223,"virtual_id_number":146223,"owner":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-01-10 00:20:03.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":-1,"date":"2015-05-26 12:36:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-01-13 10:53:42.000000000","_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":-1,"date":"2015-01-12 03:08:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-10 00:20:03.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-01-12 03:08:56.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-05-26 12:36:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3c85f818968d348670a8b18d84f80a8825d4cf9b","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2015-01-09 23:22:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b6a7e1d0f8c857a94339214b7b5ac0474591e124","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-01-10 00:20:03.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/23/146223/1/4612/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"a296281b97050fb7bb53dd436e1aca6682878cda","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-10 00:35:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/23/146223/1/check/check-tempest-dsvm-full/8d21c89/ : SUCCESS in 31m 21s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/23/146223/1/check/check-tempest-dsvm-postgres-full/6493b36/ : SUCCESS in 38m 26s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/23/146223/1/check/check-tempest-dsvm-neutron-full/a14933a/ : SUCCESS in 1h 10m 15s\n- check-grenade-dsvm http://logs.openstack.org/23/146223/1/check/check-grenade-dsvm/8b5ce8e/ : SUCCESS in 42m 33s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/23/146223/1/check/gate-tempest-dsvm-large-ops/eb0f825/ : SUCCESS in 28m 44s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/23/146223/1/check/gate-tempest-dsvm-neutron-large-ops/0ef3839/ : SUCCESS in 25m 51s\n- gate-devstack-bashate http://logs.openstack.org/23/146223/1/check/gate-devstack-bashate/3921f86/ : SUCCESS in 18s\n- gate-devstack-unit-tests http://logs.openstack.org/23/146223/1/check/gate-devstack-unit-tests/f265558/ : SUCCESS in 22s\n- check-devstack-dsvm-cells http://logs.openstack.org/23/146223/1/check/check-devstack-dsvm-cells/4730955/ : SUCCESS in 13m 43s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/23/146223/1/check/check-grenade-dsvm-partial-ncpu/2156489/ : SUCCESS in 28m 26s\n- check-neutron-dsvm-functional http://logs.openstack.org/23/146223/1/check/check-neutron-dsvm-functional/8bfb7f2/ : SUCCESS in 18m 14s\n- check-swift-dsvm-functional http://logs.openstack.org/23/146223/1/check/check-swift-dsvm-functional/16ad0fe/ : SUCCESS in 21m 44s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/23/146223/1/check/check-tempest-dsvm-ironic-pxe_ssh/802ec54/ : SUCCESS in 32m 12s\n- check-tempest-dsvm-f20 http://logs.openstack.org/23/146223/1/check/check-tempest-dsvm-f20/36f3390/ : SUCCESS in 36m 56s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/23/146223/1/check/check-tempest-dsvm-centos7/7e32a96/ : SUCCESS in 50m 54s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/23/146223/1/check/gate-devstack-publish-docs/b686cc4//doc/build/html/ : SUCCESS in 1m 18s","accounts_in_message":[],"_revision_number":1},{"id":"6e6eac4c1ff7a5bae4408b6cfe6388d120ab4554","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-01-12 03:08:56.000000000","message":"Patch Set 1: Code-Review-1\n\nI had to think about this for a bit, but it seems like this function is suspect general -- consider this little snippet\n\nhttps://gist.github.com/ianw/7fbb8ab9272ee3a6ec4d\n\nThe matching, particularly with substrings, isn\u0027t what you\u0027d expect.\n\nI feel like a generic function that takes a comma-separated list and another comma separated list of items to remove is a fair addition here so we don\u0027t have to re-discover solutions","accounts_in_message":[],"_revision_number":1},{"id":"2c2cf4dfaa9c02ac67558a5e6bb322f754562423","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2015-01-13 10:53:42.000000000","message":"Patch Set 1:\n\nthanks I did not think about that corner case.\nmostly because I tend to think bash actually treats stuff as array and not strings.\n\nI will use the function you proposed and move it into the common functions module (if there\u0027s anything that can be called a module in bash)","accounts_in_message":[],"_revision_number":1},{"id":"7f420623103ea1b73c3ea098eb88f21dae45d4cd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-26 12:36:18.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"7d2a04ec99cbe2e04cc23170e9760f23fa686a29","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-05-26 19:12:25.000000000","message":"Abandoned\n\nI194b483de797697ba06b320cf33f1bac67fc0cc7 merged which should fix this","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7669e0e4f88c228f8a90ea1bbebb4548848e549b","revisions":{"7669e0e4f88c228f8a90ea1bbebb4548848e549b":{"kind":"REWORK","_number":1,"created":"2015-01-09 23:22:20.000000000","uploader":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"ref":"refs/changes/23/146223/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/23/146223/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/146223/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/146223/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/146223/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/23/146223/1"}}},"commit":{"parents":[{"commit":"441ff07b97b4d44a25479912ff2878be3fa6e9a9","subject":"Fixing the problem in loading plugins","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/441ff07b97b4d44a25479912ff2878be3fa6e9a9"}]}],"author":{"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","date":"2015-01-09 23:18:39.000000000","tz":-480},"committer":{"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","date":"2015-01-09 23:22:16.000000000","tz":-480},"subject":"Ensure also last extension in the list can be removed","message":"Ensure also last extension in the list can be removed\n\nThe algorithm for removing disabled extensions from the list which\nwill be supplied to tempest assumes that an extension name is\nfollowed by a comma. This is not true for the last element in the\nlist; the current algorithm cannot therefore remove it.\n\nThis patch fixes this issue by adding a comma at the end of the\nextension list string. The additional comma is removed immediately\nbefore returning the string.\n\nChange-Id: I01cec39dae8c6a99620d43471c9a7d34b84da846\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7669e0e4f88c228f8a90ea1bbebb4548848e549b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7669e0e4f88c228f8a90ea1bbebb4548848e549b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}