)]}'
{"lib/heat":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f199ff6200a2b44e9214b5eb279c3e3f42e842b9","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    else"},{"line_number":309,"context_line":"        echo \"Error, HEAT_CREATE_TEST_IMAGE\u003dTrue requires dib\" \u003e\u00262"},{"line_number":310,"context_line":"        echo \"Add \\\"enable_service dib\\\" to your localrc\" \u003e\u00262"},{"line_number":311,"context_line":"        exit 1"},{"line_number":312,"context_line":"    fi"},{"line_number":313,"context_line":"}"},{"line_number":314,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1a930d6b_a8e427ac","line":311,"updated":"2015-01-27 01:32:10.000000000","message":"Maybe it\u0027s better to use function die.","commit_id":"1f3f4b0a69a70bb5fce0707a517d67c896c3cf2c"}],"stack.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c5f71b3fce32474382045060514ebc9f8e930093","unresolved":false,"context_lines":[{"line_number":568,"context_line":"source $TOP_DIR/lib/heat"},{"line_number":569,"context_line":"source $TOP_DIR/lib/neutron"},{"line_number":570,"context_line":"source $TOP_DIR/lib/ldap"},{"line_number":571,"context_line":"source $TOP_DIR/lib/dstat"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"# Clone all external plugins"},{"line_number":574,"context_line":"fetch_plugins"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a961159_c4018908","line":571,"updated":"2015-01-15 05:01:57.000000000","message":"why not just put it here with everything else?","commit_id":"568a8497fe5031aa6837ac23315c5cdf57422a09"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"eae2a2ae71a4cce39d1024d0aca8f5d1035cb612","unresolved":false,"context_lines":[{"line_number":568,"context_line":"source $TOP_DIR/lib/heat"},{"line_number":569,"context_line":"source $TOP_DIR/lib/neutron"},{"line_number":570,"context_line":"source $TOP_DIR/lib/ldap"},{"line_number":571,"context_line":"source $TOP_DIR/lib/dstat"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"# Clone all external plugins"},{"line_number":574,"context_line":"fetch_plugins"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a961159_0f01e506","line":571,"in_reply_to":"3a961159_c4018908","updated":"2015-01-15 10:03:14.000000000","message":"I wasn\u0027t sure that would be acceptable, given that diskimage-builder isn\u0027t needed for many/most configurations.\n\nI can move it though! :)","commit_id":"568a8497fe5031aa6837ac23315c5cdf57422a09"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"3acdbb4ebf02c3203a79cab4cdd8fc05c0b512ca","unresolved":false,"context_lines":[{"line_number":569,"context_line":"source $TOP_DIR/lib/neutron"},{"line_number":570,"context_line":"source $TOP_DIR/lib/ldap"},{"line_number":571,"context_line":"source $TOP_DIR/lib/dstat"},{"line_number":572,"context_line":"source $TOP_DIR/lib/dib"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# Clone all external plugins"},{"line_number":575,"context_line":"fetch_plugins"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a961159_0c3ff325","line":572,"updated":"2015-01-16 19:40:57.000000000","message":"dib is a plugin in extras.d, and will be sourced below in line 580, long before HEAT_CREATE_TEST_IMAGE is referenced.\n\nIt looks like you might not have \u0027dib\u0027 in ENABLED_SERVICES so the source isn\u0027t happening in extras.d/40-dib.sh.  If so, and that is the correct configuration, the fix is to move the source outside the is_service_enabled dib conditional there.","commit_id":"1f4841b75c8a3906315c569f052a454c9ab70ef6"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"fe8c8fd5d569a127dfd3ea4de39f0cad0a02a695","unresolved":false,"context_lines":[{"line_number":569,"context_line":"source $TOP_DIR/lib/neutron"},{"line_number":570,"context_line":"source $TOP_DIR/lib/ldap"},{"line_number":571,"context_line":"source $TOP_DIR/lib/dstat"},{"line_number":572,"context_line":"source $TOP_DIR/lib/dib"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# Clone all external plugins"},{"line_number":575,"context_line":"fetch_plugins"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a961159_ac65e34a","line":572,"in_reply_to":"3a961159_0c3ff325","updated":"2015-01-19 09:54:02.000000000","message":"Hmm, looks like you\u0027re right.  \n\nPerhaps we should add a test inside lib/heat which displays an error if HEAT_CREATE_TEST_IMAGE is set and dib isn\u0027t enabled, given that there\u0027s no automatic way to specify the dependency between them, and if you forget (or in my case didn\u0027t know) that you need to add dib to ENABLED_SERVICES, the error output isn\u0027t the most obvious.","commit_id":"1f4841b75c8a3906315c569f052a454c9ab70ef6"}]}