)]}'
{"id":"openstack%2Fdevstack~148612","triplet_id":"openstack%2Fdevstack~master~I412eb9ca218ee5daa5bbf08ae6f937227202914b","project":"openstack/devstack","branch":"master","hashtags":[],"change_id":"I412eb9ca218ee5daa5bbf08ae6f937227202914b","subject":"Stop using `local` outside a function","status":"ABANDONED","created":"2015-01-20 16:07:09.000000000","updated":"2015-01-20 17:08:38.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"60387e7af65b992a325b9342fb02eac3895d287d","_number":148612,"virtual_id_number":148612,"owner":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"actions":{},"labels":{"Verified":{"all":[{"date":"2015-01-20 17:08:38.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"date":"2015-01-20 16:32:58.000000000","_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},{"value":-1,"date":"2015-01-20 16:28:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-20 16:28:03.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-01-20 17:08:38.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2cd0cf90fb01036f97fce6b05c6f575c0990a01e","author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"date":"2015-01-20 16:07:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3bf2a3f0e1526b930e89f66695bae75a11114abe","author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"date":"2015-01-20 16:09:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b5f43fdd8f364ccb0f5682c9cc94e01163ba40c9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-01-20 16:28:03.000000000","message":"Patch Set 2: Code-Review-1\n\nDupe of https://review.openstack.org/148598","accounts_in_message":[],"_revision_number":2},{"id":"413f918d26d279acebd45965576e082f4bb11932","author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"date":"2015-01-20 16:32:58.000000000","message":"Patch Set 2:\n\nAh, didn\u0027t see that review.","accounts_in_message":[],"_revision_number":2},{"id":"54becb6eaea470050bb1315f3269a79a1f49092c","author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"date":"2015-01-20 16:33:13.000000000","message":"Abandoned\n\nDuplicate.","accounts_in_message":[],"_revision_number":2},{"id":"60387e7af65b992a325b9342fb02eac3895d287d","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-01-20 17:08:38.000000000","message":"Patch Set 2:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/12/148612/2/5757/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"70f87d884d21f40ab9329732b5115395f29220ff","revisions":{"7885fa7fb6594587eeb02a5a243e897ae7d62ee7":{"kind":"REWORK","_number":1,"created":"2015-01-20 16:07:09.000000000","uploader":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"ref":"refs/changes/12/148612/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/12/148612/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/148612/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/148612/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/148612/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/12/148612/1"}}},"commit":{"parents":[{"commit":"d4a81a895ebd505b82ada0278d7b388924577ff0","subject":"Merge \"Gracefully add provider network port\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d4a81a895ebd505b82ada0278d7b388924577ff0"}]}],"author":{"name":"Ryan S. Brown","email":"rybrown@redhat.com","date":"2015-01-20 16:03:51.000000000","tz":-300},"committer":{"name":"Ryan S. Brown","email":"rybrown@redhat.com","date":"2015-01-20 16:07:04.000000000","tz":-300},"subject":"Stop using `local` outside a function","message":"Stop using `local` outside a function\n\nUsing `local logfile_...` would raise errors, as below\n\n    ./stack.sh: line 384: local: can only be used in a function\n    ./stack.sh: line 385: local: can only be used in a function\n\nAs a side effect, logs wouldn\u0027t be saved because no arguments would be\ngiven to mkdir.\n\nChange-Id: I412eb9ca218ee5daa5bbf08ae6f937227202914b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7885fa7fb6594587eeb02a5a243e897ae7d62ee7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7885fa7fb6594587eeb02a5a243e897ae7d62ee7"}]},"branch":"refs/heads/master"},"70f87d884d21f40ab9329732b5115395f29220ff":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-01-20 16:09:03.000000000","uploader":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"ref":"refs/changes/12/148612/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/12/148612/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/148612/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/148612/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/148612/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/12/148612/2"}}},"commit":{"parents":[{"commit":"d4a81a895ebd505b82ada0278d7b388924577ff0","subject":"Merge \"Gracefully add provider network port\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d4a81a895ebd505b82ada0278d7b388924577ff0"}]}],"author":{"name":"Ryan S. Brown","email":"rybrown@redhat.com","date":"2015-01-20 16:03:51.000000000","tz":-300},"committer":{"name":"Ryan S. Brown","email":"rybrown@redhat.com","date":"2015-01-20 16:08:22.000000000","tz":-300},"subject":"Stop using `local` outside a function","message":"Stop using `local` outside a function\n\nUsing `local logfile_...` would raise errors, as below\n\n    ./stack.sh: line 384: local: can only be used in a function\n    ./stack.sh: line 385: local: can only be used in a function\n\nAs a side effect, logs wouldn\u0027t be saved because no arguments would be\ngiven to mkdir.\n\nIntroduced in https://review.openstack.org/148612\n\nChange-Id: I412eb9ca218ee5daa5bbf08ae6f937227202914b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/70f87d884d21f40ab9329732b5115395f29220ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/70f87d884d21f40ab9329732b5115395f29220ff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
