)]}'
{"id":"openstack%2Fdevstack~148651","triplet_id":"openstack%2Fdevstack~master~I76d358f8ebf5145cd3c65f9a470c83d4af67fd32","project":"openstack/devstack","branch":"master","hashtags":[],"change_id":"I76d358f8ebf5145cd3c65f9a470c83d4af67fd32","subject":"Remove locals that were not inside functions","status":"MERGED","created":"2015-01-20 17:11:48.000000000","updated":"2015-01-20 21:21:35.000000000","submitted":"2015-01-20 21:21:34.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bccd55ae185f44673cb48ba2454514170243f73e","_number":148651,"virtual_id_number":148651,"owner":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2015-01-20 18:04:14.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":2,"date":"2015-01-20 21:21:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},{"value":0,"_account_id":4220,"name":"patrick-crews","email":"gleebix@gmail.com","username":"patrick-crews"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"recommended":{"_account_id":4220,"name":"patrick-crews","email":"gleebix@gmail.com","username":"patrick-crews"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-01-20 20:07:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},{"value":1,"date":"2015-01-20 17:44:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4220,"name":"patrick-crews","email":"gleebix@gmail.com","username":"patrick-crews"},{"value":2,"date":"2015-01-20 20:10:08.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},{"value":0,"_account_id":4220,"name":"patrick-crews","email":"gleebix@gmail.com","username":"patrick-crews"},{"value":1,"date":"2015-01-20 20:11:48.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},{"value":0,"_account_id":4220,"name":"patrick-crews","email":"gleebix@gmail.com","username":"patrick-crews"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4220,"name":"patrick-crews","email":"gleebix@gmail.com","username":"patrick-crews"},{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-20 17:44:24.000000000","updated_by":{"_account_id":4220,"name":"patrick-crews","email":"gleebix@gmail.com","username":"patrick-crews"},"reviewer":{"_account_id":4220,"name":"patrick-crews","email":"gleebix@gmail.com","username":"patrick-crews"},"state":"REVIEWER"},{"updated":"2015-01-20 18:04:14.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-01-20 20:07:07.000000000","updated_by":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"reviewer":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"state":"REVIEWER"},{"updated":"2015-01-20 20:11:48.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-01-20 21:21:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7da5f4f8357682c3985d24eaaa68f946757cdfbc","author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"date":"2015-01-20 17:11:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f18749dab2276623b630d9265b862962927fc16","author":{"_account_id":4220,"name":"patrick-crews","email":"gleebix@gmail.com","username":"patrick-crews"},"date":"2015-01-20 17:44:24.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"18ee6dccbc5a4d849bbb733739e02dfa58b1f841","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-01-20 18:04:14.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/51/148651/1/5774/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"1eb5edee9e5c69b22bec3b0e507150cdde01c6c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-20 18:29:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/51/148651/1/check/check-tempest-dsvm-full/80d53f0/ : SUCCESS in 45m 38s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/51/148651/1/check/check-tempest-dsvm-postgres-full/6ab8517/ : SUCCESS in 38m 22s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/51/148651/1/check/check-tempest-dsvm-neutron-full/4c14061/ : SUCCESS in 57m 49s\n- check-grenade-dsvm http://logs.openstack.org/51/148651/1/check/check-grenade-dsvm/b308b71/ : SUCCESS in 38m 41s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/51/148651/1/check/gate-tempest-dsvm-large-ops/33beba0/ : SUCCESS in 22m 08s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/51/148651/1/check/gate-tempest-dsvm-neutron-large-ops/f539140/ : SUCCESS in 19m 46s\n- gate-devstack-bashate http://logs.openstack.org/51/148651/1/check/gate-devstack-bashate/2bd599b/ : SUCCESS in 16s\n- gate-devstack-unit-tests http://logs.openstack.org/51/148651/1/check/gate-devstack-unit-tests/a3db32f/ : SUCCESS in 11s\n- check-devstack-dsvm-cells http://logs.openstack.org/51/148651/1/check/check-devstack-dsvm-cells/c37bc6b/ : SUCCESS in 18m 01s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/51/148651/1/check/check-grenade-dsvm-partial-ncpu/c9144d9/ : SUCCESS in 38m 16s\n- check-neutron-dsvm-functional http://logs.openstack.org/51/148651/1/check/check-neutron-dsvm-functional/a9e5eb1/ : SUCCESS in 20m 32s\n- check-swift-dsvm-functional http://logs.openstack.org/51/148651/1/check/check-swift-dsvm-functional/035450a/ : SUCCESS in 22m 16s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/51/148651/1/check/check-tempest-dsvm-ironic-pxe_ssh/3129156/ : SUCCESS in 32m 20s\n- check-tempest-dsvm-f21 http://logs.openstack.org/51/148651/1/check/check-tempest-dsvm-f21/eb166aa/ : FAILURE in 40m 06s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/51/148651/1/check/check-tempest-dsvm-centos7/93f34da/ : SUCCESS in 53m 23s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/51/148651/1/check/gate-devstack-publish-docs/35815d1//doc/build/html/ : SUCCESS in 1m 34s","accounts_in_message":[],"_revision_number":1},{"id":"0adf5d1d459e1132e38806221c76caa14a18303c","author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"date":"2015-01-20 20:07:07.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"39454e77f217bc19a2759988718fac4332ee077b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-01-20 20:10:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9b2d68d473ce0e691dd19eaa73217fb1b64c69c0","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-01-20 20:11:48.000000000","message":"Patch Set 1: Workflow+1\n\nclearly wrong, fixing","accounts_in_message":[],"_revision_number":1},{"id":"3e2d4dfcf99bb1fe63471e49393f3263e5e0b1e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-20 20:11:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"8c7830da33ead85980d6f614b5152baf5bfd2cbd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-20 21:21:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/51/148651/1/gate/gate-tempest-dsvm-full/b7a498a/ : SUCCESS in 38m 11s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/51/148651/1/gate/gate-tempest-dsvm-postgres-full/5a66d2e/ : SUCCESS in 45m 10s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/51/148651/1/gate/gate-tempest-dsvm-neutron-full/6fea7a6/ : SUCCESS in 58m 36s\n- gate-grenade-dsvm http://logs.openstack.org/51/148651/1/gate/gate-grenade-dsvm/d0f332b/ : SUCCESS in 35m 18s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/51/148651/1/gate/gate-tempest-dsvm-large-ops/d1dcfa9/ : SUCCESS in 16m 56s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/51/148651/1/gate/gate-tempest-dsvm-neutron-large-ops/c1d21f6/ : SUCCESS in 20m 21s\n- gate-devstack-bashate http://logs.openstack.org/51/148651/1/gate/gate-devstack-bashate/327a2ee/ : SUCCESS in 15s\n- gate-devstack-dsvm-cells http://logs.openstack.org/51/148651/1/gate/gate-devstack-dsvm-cells/1dfcbbf/ : SUCCESS in 17m 23s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/51/148651/1/gate/gate-grenade-dsvm-partial-ncpu/b1c9bbe/ : SUCCESS in 39m 52s\n- gate-neutron-dsvm-functional http://logs.openstack.org/51/148651/1/gate/gate-neutron-dsvm-functional/c35b9a1/ : SUCCESS in 17m 09s\n- gate-swift-dsvm-functional http://logs.openstack.org/51/148651/1/gate/gate-swift-dsvm-functional/2119495/ : SUCCESS in 22m 21s","accounts_in_message":[],"_revision_number":1},{"id":"bccd55ae185f44673cb48ba2454514170243f73e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-20 21:21:35.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fc9cc96514bf582d644029f114441891a087d665","revisions":{"fc9cc96514bf582d644029f114441891a087d665":{"kind":"REWORK","_number":1,"created":"2015-01-20 17:11:48.000000000","uploader":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"ref":"refs/changes/51/148651/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/51/148651/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/51/148651/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/51/148651/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/51/148651/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/51/148651/1"}}},"commit":{"parents":[{"commit":"46d4769f8c81dbf4d82025f383dbdf38d5eadbc5","subject":"Merge \"Use `os role list` instead of `os user role list`\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/46d4769f8c81dbf4d82025f383dbdf38d5eadbc5"}]}],"author":{"name":"Mikhail S Medvedev","email":"mmedvede@us.ibm.com","date":"2015-01-20 17:04:48.000000000","tz":-360},"committer":{"name":"Mikhail S Medvedev","email":"mmedvede@us.ibm.com","date":"2015-01-20 17:11:05.000000000","tz":-360},"subject":"Remove locals that were not inside functions","message":"Remove locals that were not inside functions\n\nUsing \u0027local\u0027 keyword outside a function is invalid.\n\nAlso uppercase the variables to adhere to the style.\n\nRelated: I02aba9ca82c117a1186dafc1d3c07aa04ecd1dde\nChange-Id: I76d358f8ebf5145cd3c65f9a470c83d4af67fd32\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fc9cc96514bf582d644029f114441891a087d665"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fc9cc96514bf582d644029f114441891a087d665"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}