)]}'
{"id":"openstack%2Fdevstack~148777","triplet_id":"openstack%2Fdevstack~master~I5b6c8cfedcdd36efb4cbc91831501ee5c9c3b1d1","project":"openstack/devstack","branch":"master","topic":"zsh","hashtags":[],"change_id":"I5b6c8cfedcdd36efb4cbc91831501ee5c9c3b1d1","subject":"Some portability improvements for zsh","status":"ABANDONED","created":"2015-01-21 02:10:07.000000000","updated":"2015-02-09 02:13:55.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a451915a217d60c7a05b0878d7c0123952402c0d","_number":148777,"virtual_id_number":148777,"owner":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-01-21 03:00:47.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"date":"2015-02-04 18:55:20.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":-1,"date":"2015-02-04 03:05:20.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-01-25 14:10:58.000000000","_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"date":"2015-01-21 03:16:08.000000000","_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"date":"2015-01-25 18:10:32.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":-1,"date":"2015-02-03 08:55:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2015-01-22 13:38:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":1,"date":"2015-01-21 07:51:56.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":-1,"date":"2015-02-03 03:51:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-21 03:00:47.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-01-21 07:51:56.000000000","updated_by":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"reviewer":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"state":"REVIEWER"},{"updated":"2015-01-22 13:38:48.000000000","updated_by":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"reviewer":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"state":"REVIEWER"},{"updated":"2015-01-25 14:10:58.000000000","updated_by":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"reviewer":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"state":"REVIEWER"},{"updated":"2015-01-25 18:10:32.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-02-03 03:51:04.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-02-04 03:05:20.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-02-04 18:55:20.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"}],"messages":[{"id":"9d609ac8a9edc294ace18bee7790db151a517351","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-01-21 02:10:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c2ac3190e5f5b90117cc554d7dd183e93f51fa84","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-01-21 03:00:47.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/77/148777/1/5818/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"67b28337219bdec5a8516fcc12547a82e8e3c290","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-21 03:07:39.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- check-tempest-dsvm-full http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-full/df4ff1d/ : SUCCESS in 34m 12s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-postgres-full/616a2ef/ : SUCCESS in 42m 10s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-neutron-full/e983cab/ : FAILURE in 48m 47s\n- check-grenade-dsvm http://logs.openstack.org/77/148777/1/check/check-grenade-dsvm/34bae19/ : SUCCESS in 30m 24s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/77/148777/1/check/gate-tempest-dsvm-large-ops/0dd1738/ : SUCCESS in 16m 39s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/77/148777/1/check/gate-tempest-dsvm-neutron-large-ops/e8aebae/ : SUCCESS in 15m 35s\n- gate-devstack-bashate http://logs.openstack.org/77/148777/1/check/gate-devstack-bashate/037fd1b/ : SUCCESS in 17s\n- gate-devstack-unit-tests http://logs.openstack.org/77/148777/1/check/gate-devstack-unit-tests/fef83c3/ : SUCCESS in 7s\n- check-devstack-dsvm-cells http://logs.openstack.org/77/148777/1/check/check-devstack-dsvm-cells/756265f/ : SUCCESS in 14m 14s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/77/148777/1/check/check-grenade-dsvm-partial-ncpu/569d4c2/ : SUCCESS in 40m 23s\n- check-neutron-dsvm-functional http://logs.openstack.org/77/148777/1/check/check-neutron-dsvm-functional/ec5f198/ : SUCCESS in 19m 07s\n- check-swift-dsvm-functional http://logs.openstack.org/77/148777/1/check/check-swift-dsvm-functional/1a353b4/ : SUCCESS in 23m 08s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-ironic-pxe_ssh/96d9a40/ : SUCCESS in 32m 51s\n- check-tempest-dsvm-f21 http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-f21/416d49f/ : SUCCESS in 34m 11s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-centos7/8b457cc/ : SUCCESS in 57m 27s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/77/148777/1/check/gate-devstack-publish-docs/87f697e//doc/build/html/ : SUCCESS in 1m 30s","accounts_in_message":[],"_revision_number":1},{"id":"06fc7217e219d16af577928fed29ccf87784ff8b","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-01-21 03:16:08.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"6043dcebcb54c8d362ef27dd16b41a2e5a35c7bb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-21 04:18:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-full/cb43b31/ : SUCCESS in 43m 17s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-postgres-full/18279cf/ : SUCCESS in 35m 30s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-neutron-full/6ce6a9e/ : SUCCESS in 1h 02m 15s\n- check-grenade-dsvm http://logs.openstack.org/77/148777/1/check/check-grenade-dsvm/59eff2e/ : SUCCESS in 35m 16s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/77/148777/1/check/gate-tempest-dsvm-large-ops/894d0ff/ : SUCCESS in 16m 22s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/77/148777/1/check/gate-tempest-dsvm-neutron-large-ops/d8294b9/ : SUCCESS in 15m 31s\n- gate-devstack-bashate http://logs.openstack.org/77/148777/1/check/gate-devstack-bashate/ca81f3c/ : SUCCESS in 23s\n- gate-devstack-unit-tests http://logs.openstack.org/77/148777/1/check/gate-devstack-unit-tests/bb4fa2d/ : SUCCESS in 7s\n- check-devstack-dsvm-cells http://logs.openstack.org/77/148777/1/check/check-devstack-dsvm-cells/17d5b7e/ : SUCCESS in 17m 42s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/77/148777/1/check/check-grenade-dsvm-partial-ncpu/1fdf474/ : SUCCESS in 38m 29s\n- check-neutron-dsvm-functional http://logs.openstack.org/77/148777/1/check/check-neutron-dsvm-functional/ed6b66b/ : SUCCESS in 15m 31s\n- check-swift-dsvm-functional http://logs.openstack.org/77/148777/1/check/check-swift-dsvm-functional/88032c5/ : SUCCESS in 22m 51s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-ironic-pxe_ssh/a945dff/ : SUCCESS in 33m 07s\n- check-tempest-dsvm-f21 http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-f21/a96debb/ : SUCCESS in 40m 26s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/77/148777/1/check/check-tempest-dsvm-centos7/57c94a5/ : SUCCESS in 54m 33s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/77/148777/1/check/gate-devstack-publish-docs/d991da4//doc/build/html/ : SUCCESS in 59s","accounts_in_message":[],"_revision_number":1},{"id":"e5853f0058fe7529a34f357cfdd6bfc15a628b79","author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"date":"2015-01-21 07:51:56.000000000","message":"Patch Set 1: Code-Review+1\n\nHow about adding documents on shell portability?\nunder doc/?","accounts_in_message":[],"_revision_number":1},{"id":"76faa8918cb7d21d7802582e672fa33c19029329","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2015-01-22 13:38:48.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5dd7c1061869fc089332be576ce65876cc68616a","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2015-01-25 14:10:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1f53d857062dbeb2756ae4751e7a24c76ff8a21b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-01-25 18:10:32.000000000","message":"Patch Set 1:\n\nI\u0027m not going to -1 this (yet) but FWIW I am not a fan of reverting to eval like this just for compatibility with something we\u0027ve never claimed to support.","accounts_in_message":[],"_revision_number":1},{"id":"f24c9bec3cefbd113f9c0e0d6153e8ca1051d1ba","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-01-28 01:36:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dad5d624d5c1d3d0c6beb4a07a4784bbeae8177d","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-02-03 03:51:04.000000000","message":"Patch Set 1: Code-Review-1\n\nI\u0027m -1.5\n\nIf it\u0027s things like \"\u003d\" v \"\u003d\u003d\" well ok, but that eval stuff is *worse* code.  you may not know what ${! does straight away, but at least you can look it up in the man page instead of having to figure out tricks.","accounts_in_message":[],"_revision_number":1},{"id":"59c1f43ed202bfa31a30815f22b4063809baebaa","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-02-03 06:36:53.000000000","message":"Patch Set 1:\n\nIan,\nin my opinion, a convenience for non-bash users outweigh this small amount of ugly code.","accounts_in_message":[],"_revision_number":1},{"id":"695a2c79c31c6bd779aad0aa0457106b51435492","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-02-03 08:55:42.000000000","message":"Patch Set 1: Code-Review-1\n\nDevStack explicitly uses Bash.  It always has.   It has always been documented that way.","accounts_in_message":[],"_revision_number":1},{"id":"dea3c7da4570671c491fcff504364cb716c78d5b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-04 03:05:20.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"32fa85fc478a8844256e607ff25e8956cdb568a3","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-02-04 03:57:59.000000000","message":"Patch Set 1:\n\nDean,\nwhere is it documented?","accounts_in_message":[],"_revision_number":1},{"id":"87719b341d2574c0d3895c42136e483d4b51ba6a","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2015-02-04 09:09:39.000000000","message":"Patch Set 1:\n\nHacking.rst : \"DevStack is written in UNIX shell script.  It uses a number of bash-isms\nand so is limited to Bash (version 3 and up) and compatible shells.\"","accounts_in_message":[],"_revision_number":1},{"id":"465943b3fb0a29045d5b31a32ed59612a304cf92","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-02-04 18:23:48.000000000","message":"Patch Set 1:\n\nAnd I need to update that to \"Bash 4 and up\"","accounts_in_message":[],"_revision_number":1},{"id":"5ca14ee04b41c35d4f0a5c42dff798426ce13075","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-02-04 18:28:34.000000000","message":"Patch Set 1:\n\nAnd just because I\u0027m turning in to a grouchy old man, here\u0027s the very first commit to stack.sh.  Always bash: http://git.openstack.org/cgit/openstack-dev/devstack/tree/stack.sh?id\u003dba23cc730f2a9483792524e3759bd78f36621dcc#n1","accounts_in_message":[],"_revision_number":1},{"id":"99f1d763ed17ffa362f150435273fca769046b5b","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2015-02-04 18:55:20.000000000","message":"Patch Set 1:\n\nas a zsh user, I think there is a difference between sourcing openrc from zsh (or xshell) which and writing devstack in an another shell than bash. \n\nHaving said that i have been using this hack successfully under zsh to source openrc :\n\n function sourceopenrc {\n   pushd ~/devstack \u003e/dev/null\n   eval $(bash -c \". openrc $1 $2;env|sed -n \u0027/OS_/ { s/^/export /;p}\u0027\")\n   popd \u003e/dev/null\n }\n\nwhich should work properly and not having those \"fix for zsh\" patch that we see every now and then.\n\nI should probably send a patch to update documentation if other find this useful.","accounts_in_message":[],"_revision_number":1},{"id":"cb6f9af969aa42ef8ca228201497496c18bf581f","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-02-05 03:05:03.000000000","message":"Patch Set 1:\n\nDean,\nthank you for updating the doc.\nhowever, it seems talking only about the implementation of devstack, not about user\u0027s login shell.","accounts_in_message":[],"_revision_number":1},{"id":"d18e2a7ab88c8347dd2ffe832649d8f2941ccc94","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-02-05 03:07:05.000000000","message":"Patch Set 1:\n\nChmouel,\nthank you for the recipe.  looks useful to me.","accounts_in_message":[],"_revision_number":1},{"id":"6774de42e2f8fa377b9caa9a9eafaf1c9f4e8736","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-02-09 02:13:55.000000000","message":"Abandoned\n\nChmouel\u0027s alternative looks less controversial.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f5049de20a46a0246c0b25cf874bc55109dfdd6c","revisions":{"f5049de20a46a0246c0b25cf874bc55109dfdd6c":{"kind":"REWORK","_number":1,"created":"2015-01-21 02:10:07.000000000","uploader":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"ref":"refs/changes/77/148777/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/77/148777/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/148777/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/148777/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/77/148777/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/77/148777/1"}}},"commit":{"parents":[{"commit":"9e84d095f2fc5549186097f00c678f916941bf69","subject":"Merge \"Remove locals that were not inside functions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9e84d095f2fc5549186097f00c678f916941bf69"}]}],"author":{"name":"YAMAMOTO Takashi","email":"yamamoto@valinux.co.jp","date":"2015-01-21 01:59:32.000000000","tz":540},"committer":{"name":"YAMAMOTO Takashi","email":"yamamoto@valinux.co.jp","date":"2015-01-21 02:09:17.000000000","tz":540},"subject":"Some portability improvements for zsh","message":"Some portability improvements for zsh\n\nSome of recent changes broke \"source ./openrc\" for zsh.\nThis commit restores it.\n\nWhile bash specific constructs are ok in general as\ndevstack is a bash-project, it\u0027s convenient for zsh users\nlike me to be able to do \"source ./openrc\".\n\nChange-Id: I5b6c8cfedcdd36efb4cbc91831501ee5c9c3b1d1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f5049de20a46a0246c0b25cf874bc55109dfdd6c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f5049de20a46a0246c0b25cf874bc55109dfdd6c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
