)]}'
{"lib/cinder_backends/lvm":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f1f6a60c9dde63311de38c63c7c5538747912db1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    local filter_suffix\u003d\u0027\"r/.*/\" ]\u0027"},{"line_number":72,"context_line":"    local filter_string\u003d\"filter \u003d [ \""},{"line_number":73,"context_line":"    local conf_entries\u003d$(grep volume_group /etc/cinder/cinder.conf | sed \"s/ //g\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    for pv_info in $(sudo pvs --noheadings -o name,vg_name --separator \u0027;\u0027); do"},{"line_number":76,"context_line":"        IFS\u003d\u0027;\u0027 read pv vg \u003c\u003c\u003c $pv_info"},{"line_number":77,"context_line":"        for line in ${conf_entries}; do"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a930d6b_eaff94ff","line":74,"updated":"2015-01-22 06:35:30.000000000","message":"In the below block, pv_info, line, group and new should be declared local","commit_id":"e473428221a172076b48c072269557a4f483a5e9"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d7621ec23a7fffe67352a7b4d0d59fb4177ea5e0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    local filter_suffix\u003d\u0027\"r/.*/\" ]\u0027"},{"line_number":72,"context_line":"    local filter_string\u003d\"filter \u003d [ \""},{"line_number":73,"context_line":"    local conf_entries\u003d$(grep volume_group /etc/cinder/cinder.conf | sed \"s/ //g\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    for pv_info in $(sudo pvs --noheadings -o name,vg_name --separator \u0027;\u0027); do"},{"line_number":76,"context_line":"        IFS\u003d\u0027;\u0027 read pv vg \u003c\u003c\u003c $pv_info"},{"line_number":77,"context_line":"        for line in ${conf_entries}; do"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a930d6b_f16853bc","line":74,"in_reply_to":"1a930d6b_eaff94ff","updated":"2015-01-22 17:13:47.000000000","message":"Oh... yeah, nice catch.  Assuming declaring them all above ala C-Style is ok","commit_id":"e473428221a172076b48c072269557a4f483a5e9"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f1f6a60c9dde63311de38c63c7c5538747912db1","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    # FIXME(jdg): Possible odd case that the lvm.conf file has been modified"},{"line_number":89,"context_line":"    # and doesn\u0027t have a filter entry to search/replace.  For devstack don\u0027t"},{"line_number":90,"context_line":"    # know that we care, but could consider adding a check and add"},{"line_number":91,"context_line":"    sudo sed -i \"s#^[ \\t]*filter.*#    $filter_string#g\" /etc/cinder/lvm.conf"},{"line_number":92,"context_line":"    echo \"set LVM filter_strings: $filter_string\""},{"line_number":93,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a930d6b_4a5d0821","line":90,"updated":"2015-01-22 06:35:30.000000000","message":"I don\u0027t recall seeing an lvm.conf with no filter so this should be safe...having the note here is a good reminder for when it happens.","commit_id":"e473428221a172076b48c072269557a4f483a5e9"}]}