)]}'
{"lib/dib":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4c58c5fe5b65b1f138641eaa719bb088e440e808","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    DIB_APT_SOURCES\u003d$DIB_APT_SOURCES \\"},{"line_number":129,"context_line":"    DIB_OFFLINE\u003d$DIB_BUILD_OFFLINE \\"},{"line_number":130,"context_line":"    PYPI_MIRROR_URL\u003d$pypi_mirror_url \\"},{"line_number":131,"context_line":"    PYPI_MIRROR_URL_1\u003d$pypi_mirror_url_1 \\"},{"line_number":132,"context_line":"    disk-image-create -a amd64 $image_elements $EXTRA_ELEMENTS \\"},{"line_number":133,"context_line":"        --image-cache $DIB_IMAGE_CACHE \\"},{"line_number":134,"context_line":"        -o $image_path"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a930d6b_f631400c","line":131,"updated":"2015-01-22 06:21:18.000000000","message":"I prefer ${EXTRA_ELEMENTS:-} to above EXTRA_ELEMENTS\u003d\"\".","commit_id":"fde72876237f7b5c3ca7fdaf2ab426fac4dad9cb"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d77f85c679dd8e7790edd674520311cc9a64058d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    DIB_APT_SOURCES\u003d$DIB_APT_SOURCES \\"},{"line_number":129,"context_line":"    DIB_OFFLINE\u003d$DIB_BUILD_OFFLINE \\"},{"line_number":130,"context_line":"    PYPI_MIRROR_URL\u003d$pypi_mirror_url \\"},{"line_number":131,"context_line":"    PYPI_MIRROR_URL_1\u003d$pypi_mirror_url_1 \\"},{"line_number":132,"context_line":"    disk-image-create -a amd64 $image_elements $EXTRA_ELEMENTS \\"},{"line_number":133,"context_line":"        --image-cache $DIB_IMAGE_CACHE \\"},{"line_number":134,"context_line":"        -o $image_path"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a930d6b_6af9e4c7","line":131,"in_reply_to":"1a930d6b_f631400c","updated":"2015-01-22 06:43:55.000000000","message":"I would agree if EXTRA_ELEMENTS were not a global var.  If this function is the only place it is used the declaration could be moved inside the function and it made local, then ${extra_elements:-} below would be fine in place of the above change\n\nAnd actually, if it remains global I would like to see it have a qualifier of some sort, such as DIB_EXTRA_ELEMENTS..","commit_id":"fde72876237f7b5c3ca7fdaf2ab426fac4dad9cb"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c7a7b50506e035831fb9dc9f9fe69da146dfe5d6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if [ ! -e \"$DIB_APT_SOURCES\" ]; then"},{"line_number":104,"context_line":"            die $LINENO \"DIB_APT_SOURCES set but not found at $DIB_APT_SOURCES\""},{"line_number":105,"context_line":"        fi"},{"line_number":106,"context_line":"        local extra_elements\u003d\"apt-sources\""},{"line_number":107,"context_line":"    fi"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    # Set the local pip repo as the primary index mirror so the"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a930d6b_533d3cc3","line":106,"updated":"2015-01-26 21:35:09.000000000","message":"If you re-do this review, the local declaration should be outside the if block, but this should still work with nounset enabled.","commit_id":"8874115668427b9d60bb65cbe3670d01d3f7eb14"}]}