)]}'
{"id":"openstack%2Fdevstack~149288","triplet_id":"openstack%2Fdevstack~master~Ibd86bfcb5d4a3b90a1ee7a5bd637b01124e3a6ba","project":"openstack/devstack","branch":"master","topic":"rpc-config-error","hashtags":[],"change_id":"Ibd86bfcb5d4a3b90a1ee7a5bd637b01124e3a6ba","subject":"Exit when printing error about database config","status":"MERGED","created":"2015-01-22 14:38:44.000000000","updated":"2015-02-11 18:03:58.000000000","submitted":"2015-01-24 17:37:39.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"94d641bc608c28a62236ccf047d5627ba06716c9","_number":149288,"virtual_id_number":149288,"owner":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2015-01-22 16:11:54.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":2,"date":"2015-01-24 17:37:39.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"recommended":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2015-01-23 00:12:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-01-24 16:39:55.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":2,"date":"2015-01-22 16:08:47.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-01-24 16:39:55.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-22 16:08:47.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-01-22 16:11:54.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-01-23 00:12:48.000000000","updated_by":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"reviewer":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"state":"REVIEWER"},{"updated":"2015-01-24 16:39:55.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2015-01-24 17:37:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"928e8684340dcf37de44f0347f31e1ccc345690e","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2015-01-22 14:38:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e4e98f52fc44e612b5fa64ee755661811c64f24c","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2015-01-22 15:11:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a7e6f27791dcd24d6e181f78b050e1f61d34e20a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-22 16:04:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/88/149288/2/check/check-tempest-dsvm-full/dffc1df/ : SUCCESS in 35m 11s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/88/149288/2/check/check-tempest-dsvm-postgres-full/8d3d742/ : SUCCESS in 37m 15s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/88/149288/2/check/check-tempest-dsvm-neutron-full/a6d7644/ : SUCCESS in 44m 36s\n- check-grenade-dsvm http://logs.openstack.org/88/149288/2/check/check-grenade-dsvm/9870f04/ : SUCCESS in 35m 19s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/88/149288/2/check/gate-tempest-dsvm-large-ops/fdb85c2/ : SUCCESS in 18m 53s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/88/149288/2/check/gate-tempest-dsvm-neutron-large-ops/a48585f/ : SUCCESS in 18m 44s\n- gate-devstack-bashate http://logs.openstack.org/88/149288/2/check/gate-devstack-bashate/f7acb35/ : SUCCESS in 10s\n- gate-devstack-unit-tests http://logs.openstack.org/88/149288/2/check/gate-devstack-unit-tests/bdde85b/ : SUCCESS in 34s\n- check-devstack-dsvm-cells http://logs.openstack.org/88/149288/2/check/check-devstack-dsvm-cells/5970fb7/ : SUCCESS in 13m 20s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/88/149288/2/check/check-grenade-dsvm-partial-ncpu/cf63d9b/ : SUCCESS in 34m 41s\n- check-neutron-dsvm-functional http://logs.openstack.org/88/149288/2/check/check-neutron-dsvm-functional/070bba0/ : SUCCESS in 17m 55s\n- check-swift-dsvm-functional http://logs.openstack.org/88/149288/2/check/check-swift-dsvm-functional/11ff9c6/ : SUCCESS in 24m 46s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/88/149288/2/check/check-tempest-dsvm-ironic-pxe_ssh/336f642/ : SUCCESS in 29m 44s\n- check-tempest-dsvm-f21 http://logs.openstack.org/88/149288/2/check/check-tempest-dsvm-f21/029b8b2/ : FAILURE in 39m 33s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/88/149288/2/check/check-tempest-dsvm-centos7/0c58a65/ : SUCCESS in 53m 05s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/88/149288/2/check/gate-devstack-publish-docs/83edf46//doc/build/html/ : SUCCESS in 1m 35s","accounts_in_message":[],"_revision_number":2},{"id":"4abf3fafc57a312064b03c10c6bfefb574230c20","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-01-22 16:08:47.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e0b4d1f0ba9b4f5c2e976538cdc42ce590ca426b","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-01-22 16:11:54.000000000","message":"Patch Set 2: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/88/149288/2/6141/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2},{"id":"9ff1a8dc228cb7497582cd07070815fd6641a848","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-01-23 00:12:48.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e078f079d78f1c88bce64ae60ae2bc46f978a628","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2015-01-24 16:39:55.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"514bd1936b6cb019f44d2d9486d54979f6f1f1ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-24 16:40:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"cf21768c87b778b9d6d162ff967548daf9553be7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-24 17:37:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/88/149288/2/gate/gate-tempest-dsvm-full/b5fce8c/ : SUCCESS in 36m 03s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/88/149288/2/gate/gate-tempest-dsvm-postgres-full/10ec427/ : SUCCESS in 36m 04s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/88/149288/2/gate/gate-tempest-dsvm-neutron-full/8cfb566/ : SUCCESS in 45m 04s\n- gate-grenade-dsvm http://logs.openstack.org/88/149288/2/gate/gate-grenade-dsvm/d7baa5e/ : SUCCESS in 37m 40s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/88/149288/2/gate/gate-tempest-dsvm-large-ops/9d61b71/ : SUCCESS in 21m 34s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/88/149288/2/gate/gate-tempest-dsvm-neutron-large-ops/91df886/ : SUCCESS in 19m 02s\n- gate-devstack-bashate http://logs.openstack.org/88/149288/2/gate/gate-devstack-bashate/7c6fb25/ : SUCCESS in 29s\n- gate-devstack-dsvm-cells http://logs.openstack.org/88/149288/2/gate/gate-devstack-dsvm-cells/cebe645/ : SUCCESS in 13m 37s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/88/149288/2/gate/gate-grenade-dsvm-partial-ncpu/d098e46/ : SUCCESS in 36m 08s\n- gate-neutron-dsvm-functional http://logs.openstack.org/88/149288/2/gate/gate-neutron-dsvm-functional/4ddf4a4/ : SUCCESS in 19m 59s\n- gate-swift-dsvm-functional http://logs.openstack.org/88/149288/2/gate/gate-swift-dsvm-functional/fe70b6d/ : SUCCESS in 37m 41s","accounts_in_message":[],"_revision_number":2},{"id":"1dbc2ef0402076ee753b76cbd80f5ed01f135785","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-24 17:37:40.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"c3c5563f2c3661d829d8755183790763092c11d9","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-02-11 18:03:58.000000000","message":"Patch Set 2: Reverted\n\nThis patchset was reverted in change: Ie178aa1e5d5877c199fee0ac9d23600323c27cef","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2d7c346f0c8cefe622edc8fed47cc2782aeb9a9b","revisions":{"190ce4cf6c02e34507b6e642977c69770ba33f48":{"kind":"REWORK","_number":1,"created":"2015-01-22 14:38:44.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/88/149288/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/88/149288/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/88/149288/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/88/149288/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/88/149288/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/88/149288/1"}}},"commit":{"parents":[{"commit":"3951fd04c719cce56ba9ff9397d316dec6d29f8f","subject":"Exit after printing error about RPC config","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3951fd04c719cce56ba9ff9397d316dec6d29f8f"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2015-01-22 14:37:04.000000000","tz":0},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2015-01-22 14:37:04.000000000","tz":0},"subject":"Exit when printing error about database config","message":"Exit when printing error about database config\n\nWhen finding no configured database, devstack prints\na suitable error in the logs\n\n   \"No database enabled\"\n\nbut then just carries on running, as a result the developer\nis very unlikely to ever see the original error message.\nChange the \u0027echo\u0027 to a \u0027die\u0027 so that it stop immediately\nmaking the error message clearly visible.\n\nChange-Id: Ibd86bfcb5d4a3b90a1ee7a5bd637b01124e3a6ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/190ce4cf6c02e34507b6e642977c69770ba33f48"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/190ce4cf6c02e34507b6e642977c69770ba33f48"}]},"branch":"refs/heads/master"},"2d7c346f0c8cefe622edc8fed47cc2782aeb9a9b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-01-22 15:11:34.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/88/149288/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/88/149288/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/88/149288/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/88/149288/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/88/149288/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/88/149288/2"}}},"commit":{"parents":[{"commit":"c1dbf10562796c7006fd0a66c6cb39a1b990c8c1","subject":"Exit after printing error about RPC config","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c1dbf10562796c7006fd0a66c6cb39a1b990c8c1"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2015-01-22 14:37:04.000000000","tz":0},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2015-01-22 15:11:18.000000000","tz":0},"subject":"Exit when printing error about database config","message":"Exit when printing error about database config\n\nWhen finding no configured database, devstack prints\na suitable error in the logs\n\n   \"No database enabled\"\n\nbut then just carries on running, as a result the developer\nis very unlikely to ever see the original error message.\nChange the \u0027echo\u0027 to a \u0027die\u0027 so that it stop immediately\nmaking the error message clearly visible.\n\nChange-Id: Ibd86bfcb5d4a3b90a1ee7a5bd637b01124e3a6ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2d7c346f0c8cefe622edc8fed47cc2782aeb9a9b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2d7c346f0c8cefe622edc8fed47cc2782aeb9a9b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}