)]}'
{"extras.d/80-opendaylight.sh":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6505fe7f200c72905f4d1852f76793b87bd7ae4d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        if [ \"$OFFLINE\" !\u003d \"True\"]; then"},{"line_number":14,"context_line":"            install_opendaylight"},{"line_number":15,"context_line":"        elif"},{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        fi"},{"line_number":18,"context_line":"        configure_opendaylight"},{"line_number":19,"context_line":"        init_opendaylight"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa81d914_e91a2316","line":16,"updated":"2015-01-29 04:57:09.000000000","message":"Do we need this message?","commit_id":"b735fb4c89ee11e0b6d7fbdf2f7c36a160ce3657"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"10da2843af4fc3c0238797517f0933f2957b9e3a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        if [ \"$OFFLINE\" !\u003d \"True\"]; then"},{"line_number":14,"context_line":"            install_opendaylight"},{"line_number":15,"context_line":"        elif"},{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        fi"},{"line_number":18,"context_line":"        configure_opendaylight"},{"line_number":19,"context_line":"        init_opendaylight"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da86d52c_43527a14","line":16,"in_reply_to":"fa81d914_e91a2316","updated":"2015-01-30 22:43:46.000000000","message":"This is to be on par with other messages that are logged in offline mode.","commit_id":"b735fb4c89ee11e0b6d7fbdf2f7c36a160ce3657"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"34b6a2ea132dd5e72b618e361e8863ce7292fab0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        # no-op"},{"line_number":11,"context_line":"        :"},{"line_number":12,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":13,"context_line":"        if [ \"$OFFLINE\" !\u003d \"True\"]; then"},{"line_number":14,"context_line":"            install_opendaylight"},{"line_number":15,"context_line":"        elif"},{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"da86d52c_68901f96","line":13,"updated":"2015-02-02 05:56:19.000000000","message":"put a space between \"True\" and ]","commit_id":"3fe6f0d3f21d2395cdea2a32222e37427014b962"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"34b6a2ea132dd5e72b618e361e8863ce7292fab0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":13,"context_line":"        if [ \"$OFFLINE\" !\u003d \"True\"]; then"},{"line_number":14,"context_line":"            install_opendaylight"},{"line_number":15,"context_line":"        elif"},{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        fi"},{"line_number":18,"context_line":"        configure_opendaylight"}],"source_content_type":"text/x-sh","patch_set":3,"id":"da86d52c_28dd4771","line":15,"updated":"2015-02-02 05:56:19.000000000","message":"else","commit_id":"3fe6f0d3f21d2395cdea2a32222e37427014b962"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"0deed8e952516a1d480294600e781ef3617f164f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":14,"context_line":"            install_opendaylight"},{"line_number":15,"context_line":"        else"},{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        configure_opendaylight"},{"line_number":18,"context_line":"        init_opendaylight"},{"line_number":19,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-config\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"da86d52c_e8187986","line":16,"updated":"2015-02-02 15:42:52.000000000","message":"Need a \"fi\" on the line below the echo.","commit_id":"6c434638ea73431e7e7c1d3725947dc0dafe0e68"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"f98f73e20b67a081c6f75b9a8cf3e670d5afbbf5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        configure_opendaylight"},{"line_number":18,"context_line":"        init_opendaylight"},{"line_number":19,"context_line":"        fi"},{"line_number":20,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-config\" ]]; then"},{"line_number":21,"context_line":"        configure_ml2_odl"},{"line_number":22,"context_line":"        # This has to start before Neutron"}],"source_content_type":"text/x-sh","patch_set":5,"id":"da86d52c_111b341c","line":19,"updated":"2015-02-02 17:42:44.000000000","message":"I think you want the \"fi\" after the echo statement directly, otherwise \"configure_opendaylight\" and \"init_opendaylight\" won\u0027t run when in OFFLINE mode.","commit_id":"a5f8fa9c15cf3e76963c45de121da1b318252b97"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"fb074bf0499e6021e9fd8f5d2e912a14eddcd7ae","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        configure_opendaylight"},{"line_number":18,"context_line":"        init_opendaylight"},{"line_number":19,"context_line":"        fi"},{"line_number":20,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-config\" ]]; then"},{"line_number":21,"context_line":"        configure_ml2_odl"},{"line_number":22,"context_line":"        # This has to start before Neutron"}],"source_content_type":"text/x-sh","patch_set":5,"id":"da86d52c_94ac72a2","line":19,"in_reply_to":"da86d52c_111b341c","updated":"2015-02-02 17:59:34.000000000","message":"I was too quick to push the code.","commit_id":"a5f8fa9c15cf3e76963c45de121da1b318252b97"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9b307d00babe05c2f0b0d6d83bce33395b9d313b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":14,"context_line":"            install_opendaylight"},{"line_number":15,"context_line":"        else"},{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        fi"},{"line_number":18,"context_line":"        configure_opendaylight"},{"line_number":19,"context_line":"        init_opendaylight"}],"source_content_type":"text/x-sh","patch_set":6,"id":"da86d52c_a8af45e2","line":16,"updated":"2015-02-03 02:17:31.000000000","message":"This doesn\u0027t make much sense?  Should this ay \"distro not available\"?","commit_id":"0b6053ebbd54a1f2ff0eb2fcb5c8aa36dc15fbe1"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3970096449262bbf38def0557773e66f4d306fb7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":14,"context_line":"            install_opendaylight"},{"line_number":15,"context_line":"        else"},{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        fi"},{"line_number":18,"context_line":"        configure_opendaylight"},{"line_number":19,"context_line":"        init_opendaylight"}],"source_content_type":"text/x-sh","patch_set":6,"id":"da86d52c_ca644d4b","line":16,"in_reply_to":"da86d52c_1c45eeb2","updated":"2015-02-03 17:19:33.000000000","message":"Devstack reports the message \"Running in offline mode\" when \"git_clone\" function is called.\nIn this case, it is not calling \"git_clone\" but there is a \"wget\" that is occuring.\nSo I wanted to explicitly state that it is \"Running in offline mode\" to be in sync with what the \"git_clone\" is doing.\n\nLet me know if this is wrong?","commit_id":"0b6053ebbd54a1f2ff0eb2fcb5c8aa36dc15fbe1"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6b0e70a16a2435dfc89ae97b24b09228844eb461","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":14,"context_line":"            install_opendaylight"},{"line_number":15,"context_line":"        else"},{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        fi"},{"line_number":18,"context_line":"        configure_opendaylight"},{"line_number":19,"context_line":"        init_opendaylight"}],"source_content_type":"text/x-sh","patch_set":6,"id":"da86d52c_b93cf9c0","line":16,"in_reply_to":"da86d52c_a8af45e2","updated":"2015-02-03 04:24:17.000000000","message":"This is correct. Since in offline mode, you don\u0027t reclone and the distribution is already available in your directory.","commit_id":"0b6053ebbd54a1f2ff0eb2fcb5c8aa36dc15fbe1"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"e64d2955601734c5ac3365f48b379fd3aaee92d9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":14,"context_line":"            install_opendaylight"},{"line_number":15,"context_line":"        else"},{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        fi"},{"line_number":18,"context_line":"        configure_opendaylight"},{"line_number":19,"context_line":"        init_opendaylight"}],"source_content_type":"text/x-sh","patch_set":6,"id":"da86d52c_9cfa8341","line":16,"in_reply_to":"da86d52c_b93cf9c0","updated":"2015-02-04 12:27:43.000000000","message":"How does is know that the distro is already available in your directory? I\u0027m thinking of a pathological case where devstack ran with odl_server disabled before; and then with it enabled AND offline.","commit_id":"0b6053ebbd54a1f2ff0eb2fcb5c8aa36dc15fbe1"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e05b3d7261e4496dc310422ad23d053250a783e5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":14,"context_line":"            install_opendaylight"},{"line_number":15,"context_line":"        else"},{"line_number":16,"context_line":"            echo \"Running in offline mode, opendaylight distro available\""},{"line_number":17,"context_line":"        fi"},{"line_number":18,"context_line":"        configure_opendaylight"},{"line_number":19,"context_line":"        init_opendaylight"}],"source_content_type":"text/x-sh","patch_set":6,"id":"da86d52c_1c45eeb2","line":16,"in_reply_to":"da86d52c_b93cf9c0","updated":"2015-02-03 09:08:21.000000000","message":"The message is not needed.  We don\u0027t report every little thing that is not an indication of potential errors.","commit_id":"0b6053ebbd54a1f2ff0eb2fcb5c8aa36dc15fbe1"}],"lib/opendaylight":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"240d0166cf274567a16163b17b7738662ac2bbeb","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":143,"context_line":"        wget -N $ODL_URL/$ODL_PKG"},{"line_number":144,"context_line":"        unzip -u $ODL_PKG"},{"line_number":145,"context_line":"    fi"},{"line_number":146,"context_line":"}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# install_opendaylight-compute - Make sure OVS is installed"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa81d914_8f1c5279","line":145,"updated":"2015-01-29 00:40:28.000000000","message":"This fix is unnecessary. If OFFLINE is True, install_opendaylight isn\u0027t call in 80-opendaylight.sh.","commit_id":"442873b332c06c5638d9223279bd223039a8d065"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"ad61f75af0b127c5844d2cf9401417ec6025e8cb","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":143,"context_line":"        wget -N $ODL_URL/$ODL_PKG"},{"line_number":144,"context_line":"        unzip -u $ODL_PKG"},{"line_number":145,"context_line":"    fi"},{"line_number":146,"context_line":"}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# install_opendaylight-compute - Make sure OVS is installed"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa81d914_062be494","line":145,"in_reply_to":"fa81d914_8f1c5279","updated":"2015-01-29 04:38:54.000000000","message":"Got it. Fixed.","commit_id":"442873b332c06c5638d9223279bd223039a8d065"}]}