)]}'
{"lib/cinder":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4757145086a7b99ed0e4f395e8a3746bd61a4017","unresolved":false,"context_lines":[{"line_number":421,"context_line":"# install_cinderclient() - Collect source and prepare"},{"line_number":422,"context_line":"function install_cinderclient {"},{"line_number":423,"context_line":"    if use_library_from_git \"python-cinderclient\"; then"},{"line_number":424,"context_line":"        activate_venv $CLIENT_VENV_PATH"},{"line_number":425,"context_line":"        git_clone_by_name \"python-cinderclient\""},{"line_number":426,"context_line":"        setup_dev_lib \"python-cinderclient\""},{"line_number":427,"context_line":"        sudo install -D -m 0644 -o $STACK_USER {${GITDIR[\"python-cinderclient\"]}/tools/,/etc/bash_completion.d/}cinder.bash_completion"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da86d52c_52b8d810","line":424,"updated":"2015-02-11 20:50:13.000000000","message":"activate is used here due to the chain of functions started by setup_dev_lib().  I am reluctant to set multiple magic side-effect variables to control pip_install() from here.","commit_id":"a43bbdfb269051ee457b9b5479b5511d1d427cfd"}],"lib/stack":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"782d39ecbd14283917ee0f84b6c591b6a31e5113","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    local service\u003d$1"},{"line_number":18,"context_line":"    if type install_${service} \u003e/dev/null 2\u003e\u00261; then"},{"line_number":19,"context_line":"        if [[ -n ${PROJECT_VENV[$service]:-} ]]; then"},{"line_number":20,"context_line":"            rm -rf ${PROJECT_VENV[$service]}"},{"line_number":21,"context_line":"            source tools/build_venv.sh ${PROJECT_VENV[$service]}"},{"line_number":22,"context_line":"            export PIP_VIRTUAL_ENV\u003d${PROJECT_VENV[$service]:-}"},{"line_number":23,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"da86d52c_e77d63e8","line":20,"updated":"2015-02-19 16:37:16.000000000","message":"so on every run for a service we recreate the venv?","commit_id":"8c2ce6ea724c9123b8cc5660c6ad52aa8ebf9865"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b2e02df18972b654ed68ba9c680dd534d0eb7fbb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    local service\u003d$1"},{"line_number":18,"context_line":"    if type install_${service} \u003e/dev/null 2\u003e\u00261; then"},{"line_number":19,"context_line":"        if [[ -n ${PROJECT_VENV[$service]:-} ]]; then"},{"line_number":20,"context_line":"            rm -rf ${PROJECT_VENV[$service]}"},{"line_number":21,"context_line":"            source tools/build_venv.sh ${PROJECT_VENV[$service]}"},{"line_number":22,"context_line":"            export PIP_VIRTUAL_ENV\u003d${PROJECT_VENV[$service]:-}"},{"line_number":23,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"da86d52c_92277eb5","line":20,"in_reply_to":"da86d52c_e77d63e8","updated":"2015-02-19 19:38:12.000000000","message":"yes, but the bulky bits to re-install come from the wheel cache so the time hit should be low","commit_id":"8c2ce6ea724c9123b8cc5660c6ad52aa8ebf9865"}],"stack.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"99c9a9a6cbccc46c52a467f7c73167fe88201cda","unresolved":false,"context_lines":[{"line_number":750,"context_line":"else"},{"line_number":751,"context_line":"    pip_install \u0027python-openstackclient\u003e\u003d1.0.2\u0027"},{"line_number":752,"context_line":"fi"},{"line_number":753,"context_line":"OSC_CMD\u003d\"${CLIENT_PATH}openstack\""},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"unset PIP_VIRTUAL_ENV"},{"line_number":756,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"da86d52c_136c0f9d","line":753,"updated":"2015-02-16 14:10:02.000000000","message":"As can be seen in the tempest setup for grenade, I think we need to actually export global PATH here instead of locking down. Because we need to handle the grenade case.","commit_id":"64c2643829fc91ab35e175de8c1d9d18d078dcf5"}],"tools/build_venv.sh":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"782d39ecbd14283917ee0f84b6c591b6a31e5113","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    local r\u003d$?"},{"line_number":44,"context_line":"    set +o xtrace"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    rm -rf $TMP_VENV_PATH"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    exit $r"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":14,"id":"da86d52c_e7672323","line":46,"updated":"2015-02-19 16:37:16.000000000","message":"Where is this coming from?","commit_id":"8c2ce6ea724c9123b8cc5660c6ad52aa8ebf9865"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b2e02df18972b654ed68ba9c680dd534d0eb7fbb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    local r\u003d$?"},{"line_number":44,"context_line":"    set +o xtrace"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    rm -rf $TMP_VENV_PATH"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    exit $r"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":14,"id":"da86d52c_722cca93","line":46,"in_reply_to":"da86d52c_e7672323","updated":"2015-02-19 19:38:12.000000000","message":"ugh, another leftover, I\u0027ll add it to the wheel cleanup review coming soon","commit_id":"8c2ce6ea724c9123b8cc5660c6ad52aa8ebf9865"}]}