)]}'
{"id":"openstack%2Fdevstack~151810","triplet_id":"openstack%2Fdevstack~master~I4c465819c311604e97d24e081389ff531f8a42fa","project":"openstack/devstack","branch":"master","topic":"venv-stack","hashtags":[],"change_id":"I4c465819c311604e97d24e081389ff531f8a42fa","subject":"Fix unbound literal in trueorfalse()","status":"MERGED","created":"2015-01-30 22:56:54.000000000","updated":"2015-02-04 03:05:00.000000000","submitted":"2015-02-04 03:04:58.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2a8977bc06f3b38c08e1a7b1dc2a2b9681e5b93e","_number":151810,"virtual_id_number":151810,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-02-04 03:04:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"date":"2015-01-31 14:03:53.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"disliked":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-02-02 06:16:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":1,"date":"2015-01-30 23:25:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2015-02-01 09:32:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":2,"date":"2015-02-03 03:20:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":2,"date":"2015-02-04 02:01:34.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2015-02-04 02:01:34.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-30 23:25:13.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2015-02-01 09:32:48.000000000","updated_by":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"reviewer":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"state":"REVIEWER"},{"updated":"2015-02-02 06:16:00.000000000","updated_by":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"reviewer":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"state":"REVIEWER"},{"updated":"2015-02-03 03:20:29.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-02-04 02:01:34.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-02-04 03:04:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9731db923fd3f6ff7fc1d9d994aefe354b8a1865","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-01-30 22:56:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1864b648d0146b78e6e8d15a8f913a6e50d8e0ea","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-01-30 23:25:13.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d3a190e7d416df21034107dc530c426a08982254","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-01-31 14:03:53.000000000","message":"Patch Set 1:\n\nrecheck - job appears to have been lost?","accounts_in_message":[],"_revision_number":1},{"id":"b97f87598e0aec726d73fab45c0a038388a17646","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-31 14:56:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/10/151810/1/check/check-tempest-dsvm-full/6bea375/ : SUCCESS in 37m 31s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/10/151810/1/check/check-tempest-dsvm-postgres-full/8cf5ded/ : SUCCESS in 46m 46s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/10/151810/1/check/check-tempest-dsvm-neutron-full/8cbaab9/ : SUCCESS in 52m 20s\n- check-grenade-dsvm http://logs.openstack.org/10/151810/1/check/check-grenade-dsvm/e1ec2f0/ : SUCCESS in 36m 28s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/10/151810/1/check/gate-tempest-dsvm-large-ops/b5fb8e6/ : SUCCESS in 24m 53s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/10/151810/1/check/gate-tempest-dsvm-neutron-large-ops/f5c7a50/ : SUCCESS in 20m 24s\n- gate-devstack-bashate http://logs.openstack.org/10/151810/1/check/gate-devstack-bashate/a5397d1/ : SUCCESS in 14s\n- gate-devstack-unit-tests http://logs.openstack.org/10/151810/1/check/gate-devstack-unit-tests/8629e37/ : SUCCESS in 18s\n- check-devstack-dsvm-cells http://logs.openstack.org/10/151810/1/check/check-devstack-dsvm-cells/9365c41/ : SUCCESS in 14m 17s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/10/151810/1/check/check-grenade-dsvm-partial-ncpu/40653eb/ : SUCCESS in 36m 19s\n- check-neutron-dsvm-functional http://logs.openstack.org/10/151810/1/check/check-neutron-dsvm-functional/824ac91/ : SUCCESS in 21m 28s\n- check-swift-dsvm-functional http://logs.openstack.org/10/151810/1/check/check-swift-dsvm-functional/ac118eb/ : SUCCESS in 20m 53s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/10/151810/1/check/check-tempest-dsvm-ironic-pxe_ssh/5329a1a/ : SUCCESS in 30m 22s\n- check-tempest-dsvm-f21 http://logs.openstack.org/10/151810/1/check/check-tempest-dsvm-f21/d43cd54/ : FAILURE in 10m 36s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/10/151810/1/check/check-tempest-dsvm-centos7/59aeed5/ : FAILURE in 11m 34s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/10/151810/1/check/gate-devstack-publish-docs/2f82660//doc/build/html/ : SUCCESS in 1m 08s","accounts_in_message":[],"_revision_number":1},{"id":"1d10d2853c48bae8c11bcae93480dc756993e4a9","author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"date":"2015-02-01 09:32:48.000000000","message":"Patch Set 1: Code-Review-1\n\nCan we have a bug to describe it? without bug, it is not easy to tell it is necessary?","accounts_in_message":[],"_revision_number":1},{"id":"7a9aa8f5b1f54c0fd31e3ec7f62deff9d61ee40a","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-02-02 06:16:00.000000000","message":"Patch Set 1: Code-Review-1\n\n+1 gongysh\n\nit isn\u0027t clear to me what you are trying to fix.","accounts_in_message":[],"_revision_number":1},{"id":"e2e9307a1ed491a1110173cd58dd15882f39a3ea","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-02-03 03:20:29.000000000","message":"Patch Set 1: Code-Review+2\n\nThere\u0027s no need to file a bug for every little thing, but I would agree that it doesn\u0027t cost much to add a description and often helps reviewers.\n\nIf $2 (the argument assigned to \"literal\") isn\u0027t set, then the next line uses an unbound variable which fails with -u","accounts_in_message":[],"_revision_number":1},{"id":"c49cd8694b81fb6ee9e94bdcc602fad702b519da","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-02-03 09:03:53.000000000","message":"Patch Set 1:\n\nThis is required to support enabling nounset.  In a few places unset variables may be passed as $2 causing the error.  You may have noticed it is part of a series of patches that lay the basis for putting various things into virtual environments.","accounts_in_message":[],"_revision_number":1},{"id":"6e6b98c75d3d1f98a4bbafb1e6072ec5fb087f68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-04 02:01:34.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"db15d595d86cbe926f230eb44034e5fac27486dc","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-02-04 02:01:34.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3f468bb30556097d450116b3543f85060cb1052c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-04 03:04:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/10/151810/1/gate/gate-tempest-dsvm-full/7f7e934/ : SUCCESS in 36m 15s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/10/151810/1/gate/gate-tempest-dsvm-postgres-full/379fc3b/ : SUCCESS in 35m 07s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/10/151810/1/gate/gate-tempest-dsvm-neutron-full/aec3176/ : SUCCESS in 1h 03m 17s\n- gate-grenade-dsvm http://logs.openstack.org/10/151810/1/gate/gate-grenade-dsvm/cdaf3dd/ : SUCCESS in 36m 17s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/10/151810/1/gate/gate-tempest-dsvm-large-ops/57c47dc/ : SUCCESS in 18m 54s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/10/151810/1/gate/gate-tempest-dsvm-neutron-large-ops/4bc8a7a/ : SUCCESS in 34m 15s\n- gate-devstack-bashate http://logs.openstack.org/10/151810/1/gate/gate-devstack-bashate/8864d68/ : SUCCESS in 17s\n- gate-devstack-dsvm-cells http://logs.openstack.org/10/151810/1/gate/gate-devstack-dsvm-cells/5e3fcb1/ : SUCCESS in 17m 56s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/10/151810/1/gate/gate-grenade-dsvm-partial-ncpu/e83eec7/ : SUCCESS in 34m 27s\n- gate-neutron-dsvm-functional http://logs.openstack.org/10/151810/1/gate/gate-neutron-dsvm-functional/ce716f4/ : SUCCESS in 43m 44s\n- gate-swift-dsvm-functional http://logs.openstack.org/10/151810/1/gate/gate-swift-dsvm-functional/c68c696/ : SUCCESS in 23m 18s","accounts_in_message":[],"_revision_number":1},{"id":"6d16c81ec85c22c37409f8ab2ce34d592ffbf851","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-04 03:05:00.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a1b82cc1b5a7172c3fdf17d2c3f0725660911ad7","revisions":{"a1b82cc1b5a7172c3fdf17d2c3f0725660911ad7":{"kind":"REWORK","_number":1,"created":"2015-01-30 22:56:54.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/10/151810/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/10/151810/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/10/151810/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/10/151810/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/10/151810/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/10/151810/1"}}},"commit":{"parents":[{"commit":"b9a7d3b5e4f01d932709633f2b5b9461ecdbd0cb","subject":"Merge \"Revert \"Exit after printing error about RPC config\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b9a7d3b5e4f01d932709633f2b5b9461ecdbd0cb"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2015-01-30 19:54:40.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2015-01-30 20:59:40.000000000","tz":-360},"subject":"Fix unbound literal in trueorfalse()","message":"Fix unbound literal in trueorfalse()\n\nChange-Id: I4c465819c311604e97d24e081389ff531f8a42fa\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a1b82cc1b5a7172c3fdf17d2c3f0725660911ad7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a1b82cc1b5a7172c3fdf17d2c3f0725660911ad7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}