)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"ff3a5cf913e9e5be26741d0114d0931ff9a08d9b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Devstack LBaaS support is being migrated to the external"},{"line_number":10,"context_line":"plugin facility.  This change will update LBaaS check"},{"line_number":11,"context_line":"in the midonet code to support LBaaS V1/V2, but that will"},{"line_number":12,"context_line":"be the only LBaaS-specific code left in devstack."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I592f64407ccf1e722b8d9788917879d0236acf0b"},{"line_number":15,"context_line":"Depends-On: I64a94aeeabe6357b5ea7796e34c9306c55c9ae67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba7be1f8_43cfd5b3","line":12,"updated":"2015-02-27 00:21:12.000000000","message":"With your q-lbaas backwards-compatibility tweak, this commit message is slightly wrong.","commit_id":"ec4da2d2350b0cd1afa42b118f6eebf3ab321381"}],"doc/source/guides/neutron.rst":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"736d08c67db69b918ec1dee21bc337456eac1893","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        disable_service n-net"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # Neutron"},{"line_number":189,"context_line":"        ENABLED_SERVICES+\u003d,q-svc,q-dhcp,q-meta,q-agt,q-lbaas"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        ## Neutron Networking options used to create Neutron Subnets"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"da86d52c_a6e368d7","line":189,"updated":"2015-02-05 23:47:35.000000000","message":"I don\u0027t think we should put that on this line, as the other entries here are for core neutron.  Perhaps add a block:\n\n# LBaaS with Neutron\nENABLED_SERVICES+\u003dq-lbaas","commit_id":"928b94ee6592d057fa37de142bfed94863ee1ae7"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"c6debc114b1fec8c874a4d2007cd7d5d19d868ba","unresolved":false,"context_lines":[{"line_number":226,"context_line":"For example, with the above  configuration, a bridge is"},{"line_number":227,"context_line":"created, named `br-ex` which is managed by Open vSwitch, and the"},{"line_number":228,"context_line":"second interface on the compute node, `eth1` is attached to the"},{"line_number":229,"context_line":"bridge, to forward traffic sent by guest vms."},{"line_number":230,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"da86d52c_329332a4","line":229,"updated":"2015-02-12 18:51:12.000000000","message":"I\u0027ll remove this extra line on the next commit","commit_id":"411d8ddd9ea96873e79970e077c7ba742d359458"}],"functions-common":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b2c512a388d529c670e07b56a10fe78bbe62d275","unresolved":false,"context_lines":[{"line_number":1613,"context_line":"        return $enabled"},{"line_number":1614,"context_line":"    fi"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"    [[ ${DEVSTACK_PLUGINS}, \u003d~ ,${my_plugin}, ]] \u0026\u0026 enabled\u003d0"},{"line_number":1617,"context_line":""},{"line_number":1618,"context_line":"    return $enabled"},{"line_number":1619,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"ba7be1f8_99e1239d","line":1616,"updated":"2015-02-27 14:00:15.000000000","message":"A comma is missing before ${DEVSTACK_PLUGINS}; as written this will fail if the checked plugin is first in the list.","commit_id":"707311c76d1601213d5828d646b53faf8bf7df4c"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"5dd0ff0e0e9cfdf8be4fb80ee6818196e9146b11","unresolved":false,"context_lines":[{"line_number":1613,"context_line":"        return $enabled"},{"line_number":1614,"context_line":"    fi"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"    [[ ${DEVSTACK_PLUGINS}, \u003d~ ,${my_plugin}, ]] \u0026\u0026 enabled\u003d0"},{"line_number":1617,"context_line":""},{"line_number":1618,"context_line":"    return $enabled"},{"line_number":1619,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"ba7be1f8_da43866a","line":1616,"in_reply_to":"ba7be1f8_99e1239d","updated":"2015-02-27 15:50:33.000000000","message":"OK, good thought.","commit_id":"707311c76d1601213d5828d646b53faf8bf7df4c"}],"lib/neutron":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"ff3a5cf913e9e5be26741d0114d0931ff9a08d9b","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"if is_service_enabled q-lbaas; then"},{"line_number":358,"context_line":"    if ! is_plugin_enabled neutron-lbaas; then"},{"line_number":359,"context_line":"        enable_plugin \"neutron-lbaas\" \"${GIT_BASE}/openstack/neutron-lbaas.git\" \"master\""},{"line_number":360,"context_line":"    fi"},{"line_number":361,"context_line":"fi"},{"line_number":362,"context_line":"# Save trace setting"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ba7be1f8_e3bfe9fa","line":359,"updated":"2015-02-27 00:21:12.000000000","message":"Hmm, once stable/kilo is cut, the hard-coded master will be wrong.  Is that in an env var somewhere?","commit_id":"ec4da2d2350b0cd1afa42b118f6eebf3ab321381"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"a07242a37759f978c8759643405cc14866f03d2c","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"if is_service_enabled q-lbaas; then"},{"line_number":358,"context_line":"    if ! is_plugin_enabled neutron-lbaas; then"},{"line_number":359,"context_line":"        enable_plugin \"neutron-lbaas\" \"${GIT_BASE}/openstack/neutron-lbaas.git\" \"master\""},{"line_number":360,"context_line":"    fi"},{"line_number":361,"context_line":"fi"},{"line_number":362,"context_line":"# Save trace setting"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ba7be1f8_6335b9f6","line":359,"in_reply_to":"ba7be1f8_e3bfe9fa","updated":"2015-02-27 00:44:49.000000000","message":"Ah, thanks.  I will check into this and come up with a suggestion.  If unspecified, the underlying code will default to \"master\"","commit_id":"ec4da2d2350b0cd1afa42b118f6eebf3ab321381"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b2c512a388d529c670e07b56a10fe78bbe62d275","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"# For backward compatibility, if q-lbaas service is enabled, make sure to load the"},{"line_number":355,"context_line":"# neutron-lbaas plugin"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"if is_service_enabled q-lbaas; then"},{"line_number":358,"context_line":"    if ! is_plugin_enabled neutron-lbaas; then"},{"line_number":359,"context_line":"        enable_plugin \"neutron-lbaas\" \"${GIT_BASE}/openstack/neutron-lbaas.git\""}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"ba7be1f8_998cc381","line":356,"updated":"2015-02-27 14:00:15.000000000","message":"There should be a note about how long this will remain, I think it could go during the Liberty cycle.\n\nAlso add something like this inside the inner if block:\n\n  DEPRECATED_TEXT+\u003d\"External plugin neutron-lbaas has been automatically activated, please add the appropriate enable_plugin to your local.conf.  This will be removed in the Liberty cycle.\"","commit_id":"707311c76d1601213d5828d646b53faf8bf7df4c"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"5dd0ff0e0e9cfdf8be4fb80ee6818196e9146b11","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"# For backward compatibility, if q-lbaas service is enabled, make sure to load the"},{"line_number":355,"context_line":"# neutron-lbaas plugin"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"if is_service_enabled q-lbaas; then"},{"line_number":358,"context_line":"    if ! is_plugin_enabled neutron-lbaas; then"},{"line_number":359,"context_line":"        enable_plugin \"neutron-lbaas\" \"${GIT_BASE}/openstack/neutron-lbaas.git\""}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"ba7be1f8_7aa61a55","line":356,"in_reply_to":"ba7be1f8_998cc381","updated":"2015-02-27 15:50:33.000000000","message":"OK","commit_id":"707311c76d1601213d5828d646b53faf8bf7df4c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b2c512a388d529c670e07b56a10fe78bbe62d275","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"if is_service_enabled q-lbaas; then"},{"line_number":358,"context_line":"    if ! is_plugin_enabled neutron-lbaas; then"},{"line_number":359,"context_line":"        enable_plugin \"neutron-lbaas\" \"${GIT_BASE}/openstack/neutron-lbaas.git\""},{"line_number":360,"context_line":"    fi"},{"line_number":361,"context_line":"fi"},{"line_number":362,"context_line":"# Save trace setting"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"ba7be1f8_191453f4","line":359,"updated":"2015-02-27 14:00:15.000000000","message":"Continue to use the value from lib/neutron as long as this is here so the user can override the repo.","commit_id":"707311c76d1601213d5828d646b53faf8bf7df4c"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"5dd0ff0e0e9cfdf8be4fb80ee6818196e9146b11","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"if is_service_enabled q-lbaas; then"},{"line_number":358,"context_line":"    if ! is_plugin_enabled neutron-lbaas; then"},{"line_number":359,"context_line":"        enable_plugin \"neutron-lbaas\" \"${GIT_BASE}/openstack/neutron-lbaas.git\""},{"line_number":360,"context_line":"    fi"},{"line_number":361,"context_line":"fi"},{"line_number":362,"context_line":"# Save trace setting"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"ba7be1f8_da6c660b","line":359,"in_reply_to":"ba7be1f8_191453f4","updated":"2015-02-27 15:50:33.000000000","message":"OK","commit_id":"707311c76d1601213d5828d646b53faf8bf7df4c"}],"lib/neutron_plugins/services/loadbalancer":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"cb479c08d4deab7d3fc0551d12c459cc406b1cbc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    elif is_service_enabled $LBAAS_V2; then"},{"line_number":36,"context_line":"        _neutron_service_plugin_class_add $LBAASV2_PLUGIN"},{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    _neutron_deploy_rootwrap_filters $NEUTRON_LBAAS_DIR"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"da86d52c_b1df2dd5","line":38,"updated":"2015-02-05 19:52:53.000000000","message":"nothing in here is related to the agent, so either this function is poorly named, or this isn\u0027t the right spot.","commit_id":"c313c93c8f9c04a2c896024a064f8b98a3a72e37"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"98a5c55833ebe3b01eaa5ef8d2c71791a0b44414","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    elif is_service_enabled $LBAAS_V2; then"},{"line_number":36,"context_line":"        _neutron_service_plugin_class_add $LBAASV2_PLUGIN"},{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    _neutron_deploy_rootwrap_filters $NEUTRON_LBAAS_DIR"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"da86d52c_f137e5fc","line":38,"in_reply_to":"da86d52c_b1df2dd5","updated":"2015-02-05 20:11:07.000000000","message":"OK, good comment.   I will rename the function to neutron_lbaas_configure_common().","commit_id":"c313c93c8f9c04a2c896024a064f8b98a3a72e37"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"dc00826f1554812d4d0bac6de982148f0454b48e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"da86d52c_a669dafa","updated":"2015-02-11 19:16:38.000000000","message":"Not sure where this comment belongs, but when we have an haproxy agent running, we\u0027ll need to include a \"q-lbaasv2\" service running in the screen.  (similar to currently lbaas v1)","commit_id":"f298f256fb25fe84e64e01034cc34ce41f88698b"}],"stackrc":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b2c512a388d529c670e07b56a10fe78bbe62d275","unresolved":false,"context_lines":[{"line_number":197,"context_line":"NEUTRON_FWAAS_REPO\u003d${NEUTRON_FWAAS_REPO:-${GIT_BASE}/openstack/neutron-fwaas.git}"},{"line_number":198,"context_line":"NEUTRON_FWAAS_BRANCH\u003d${NEUTRON_FWAAS_BRANCH:-master}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# neutron lbaas service"},{"line_number":201,"context_line":"NEUTRON_LBAAS_REPO\u003d${NEUTRON_LBAAS_REPO:-${GIT_BASE}/openstack/neutron-lbaas.git}"},{"line_number":202,"context_line":"NEUTRON_LBAAS_BRANCH\u003d${NEUTRON_LBAAS_BRANCH:-master}"},{"line_number":203,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"ba7be1f8_f9577fc8","side":"PARENT","line":200,"updated":"2015-02-27 14:00:15.000000000","message":"Leave these here as long as the compat bit is present in lib/neutron","commit_id":"36373c06558d86f87554dccb038a9adcb5fe97ab"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"5dd0ff0e0e9cfdf8be4fb80ee6818196e9146b11","unresolved":false,"context_lines":[{"line_number":197,"context_line":"NEUTRON_FWAAS_REPO\u003d${NEUTRON_FWAAS_REPO:-${GIT_BASE}/openstack/neutron-fwaas.git}"},{"line_number":198,"context_line":"NEUTRON_FWAAS_BRANCH\u003d${NEUTRON_FWAAS_BRANCH:-master}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# neutron lbaas service"},{"line_number":201,"context_line":"NEUTRON_LBAAS_REPO\u003d${NEUTRON_LBAAS_REPO:-${GIT_BASE}/openstack/neutron-lbaas.git}"},{"line_number":202,"context_line":"NEUTRON_LBAAS_BRANCH\u003d${NEUTRON_LBAAS_BRANCH:-master}"},{"line_number":203,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"ba7be1f8_da9e2607","side":"PARENT","line":200,"in_reply_to":"ba7be1f8_f9577fc8","updated":"2015-02-27 15:50:33.000000000","message":"OK, I will put them back along with a comment marking them as deprecated.","commit_id":"36373c06558d86f87554dccb038a9adcb5fe97ab"}]}