)]}'
{"id":"openstack%2Fdevstack~153121","triplet_id":"openstack%2Fdevstack~master~Ifed9c1b52f3e4dead599f21227da1ed07de3ff07","project":"openstack/devstack","branch":"master","topic":"neutron-entry-points","hashtags":[],"change_id":"Ifed9c1b52f3e4dead599f21227da1ed07de3ff07","subject":"lib/neutron: Inline create_neutron_cache_dir","status":"ABANDONED","created":"2015-02-05 02:56:51.000000000","updated":"2015-02-16 01:56:03.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b1523df6ac994c1aea38b094bbcb4b7ae087e7bc","_number":153121,"virtual_id_number":153121,"owner":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2015-02-05 03:55:58.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2015-02-05 03:51:53.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"date":"2015-02-06 01:52:44.000000000","_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-02-06 09:19:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":-2,"date":"2015-02-06 13:26:17.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-05 03:51:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-02-05 03:55:58.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-02-06 09:19:55.000000000","updated_by":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"reviewer":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"state":"REVIEWER"},{"updated":"2015-02-06 13:26:17.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"88469bf7d1dcf65eef4be84409d722c2c36c26ae","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-02-05 02:56:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ee1e5b1b5376e2a1c3c2f32a6342902a687c1a65","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-05 03:51:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/21/153121/1/check/check-tempest-dsvm-full/685d850/ : SUCCESS in 37m 30s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/21/153121/1/check/check-tempest-dsvm-postgres-full/1c9d45c/ : SUCCESS in 44m 32s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/21/153121/1/check/check-tempest-dsvm-neutron-full/b40d11e/ : SUCCESS in 51m 22s\n- check-grenade-dsvm http://logs.openstack.org/21/153121/1/check/check-grenade-dsvm/eee10b8/ : SUCCESS in 34m 05s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/21/153121/1/check/gate-tempest-dsvm-large-ops/d0ec260/ : SUCCESS in 23m 38s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/21/153121/1/check/gate-tempest-dsvm-neutron-large-ops/d90101d/ : SUCCESS in 18m 36s\n- gate-devstack-bashate http://logs.openstack.org/21/153121/1/check/gate-devstack-bashate/cb23545/ : SUCCESS in 29s\n- gate-devstack-unit-tests http://logs.openstack.org/21/153121/1/check/gate-devstack-unit-tests/275fb76/ : SUCCESS in 32s\n- check-devstack-dsvm-cells http://logs.openstack.org/21/153121/1/check/check-devstack-dsvm-cells/215eac7/ : SUCCESS in 15m 16s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/21/153121/1/check/check-grenade-dsvm-partial-ncpu/6ff04c1/ : SUCCESS in 41m 57s\n- check-neutron-dsvm-functional http://logs.openstack.org/21/153121/1/check/check-neutron-dsvm-functional/ec18eef/ : SUCCESS in 19m 37s\n- check-swift-dsvm-functional http://logs.openstack.org/21/153121/1/check/check-swift-dsvm-functional/172be03/ : SUCCESS in 23m 49s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/21/153121/1/check/check-tempest-dsvm-ironic-pxe_ssh/d9f9f2b/ : SUCCESS in 29m 17s\n- check-devstack-dsvm-updown http://logs.openstack.org/21/153121/1/check/check-devstack-dsvm-updown/228c300/ : SUCCESS in 15m 26s (non-voting)\n- check-tempest-dsvm-f21 http://logs.openstack.org/21/153121/1/check/check-tempest-dsvm-f21/cd981eb/ : SUCCESS in 36m 18s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/21/153121/1/check/check-tempest-dsvm-centos7/c4aae70/ : SUCCESS in 50m 07s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/21/153121/1/check/gate-devstack-publish-docs/6add6a4//doc/build/html/ : SUCCESS in 1m 24s","accounts_in_message":[],"_revision_number":1},{"id":"373fe196c4a5a1e2f17bfb20dabb87543207ad10","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-02-05 03:55:58.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/21/153121/1/7947/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"035371077631ec25028134ddc40b551518e64748","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2015-02-05 16:27:24.000000000","message":"Patch Set 1: Code-Review-1\n\nYou should squash these 2 changes together.","accounts_in_message":[],"_revision_number":1},{"id":"0288338e7760696309d893789f3524f17ed66415","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-02-06 01:52:44.000000000","message":"Patch Set 1:\n\nJordan,\nwhy? these are logically separate.","accounts_in_message":[],"_revision_number":1},{"id":"8a860e91c67eebbba315c8ebf69d35920ffc31ce","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2015-02-06 09:19:55.000000000","message":"Patch Set 1: -Code-Review\n\nIn Iefb8057f71d4a3589cb3f0b18375779dd3896916 you remove the function named \"create_neutron_cache_dir\" from the code comment (so called \u0027entry points\u0027) but *this* is the actual patch that remove the function.\n\nI am not going to argue. Two patchs (including one that just move/remove code comments) for a small change seems one too many.","accounts_in_message":[],"_revision_number":1},{"id":"6217710a79189670a39ee08471bd1ce194054fb9","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-02-06 13:26:17.000000000","message":"Patch Set 1: Code-Review-2\n\nit\u0027s more descriptive pulled out, we should leave it that way","accounts_in_message":[],"_revision_number":1},{"id":"c09e9412a67ab9b9526625282cd0272bbcbe66ea","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-02-11 07:07:45.000000000","message":"Patch Set 1:\n\nSean,\ni tend to agree.\nbut this change followed Dean Troyer\u0027s suggestion in https://review.openstack.org/#/c/150648/ PS5.","accounts_in_message":[],"_revision_number":1},{"id":"74fd7054c0ec0844bc8dc39b5fd01f046fc65403","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-02-16 01:56:03.000000000","message":"Abandoned\n\ntwo of core reviewers (Dean and Sean) disagree on what to do.  probably it isn\u0027t worth to do anything on this.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"579109920055cd4a25c9deba21e23afae061f4f4","revisions":{"579109920055cd4a25c9deba21e23afae061f4f4":{"kind":"REWORK","_number":1,"created":"2015-02-05 02:56:51.000000000","uploader":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"ref":"refs/changes/21/153121/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/21/153121/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/153121/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/153121/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/153121/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/21/153121/1"}}},"commit":{"parents":[{"commit":"1a669dce052e45b0e7de74e1613c06f41b6be1ce","subject":"lib/neutron: Update comments about entry points","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1a669dce052e45b0e7de74e1613c06f41b6be1ce"}]}],"author":{"name":"YAMAMOTO Takashi","email":"yamamoto@valinux.co.jp","date":"2015-02-05 02:55:28.000000000","tz":540},"committer":{"name":"YAMAMOTO Takashi","email":"yamamoto@valinux.co.jp","date":"2015-02-05 02:55:28.000000000","tz":540},"subject":"lib/neutron: Inline create_neutron_cache_dir","message":"lib/neutron: Inline create_neutron_cache_dir\n\nInline create_neutron_cache_dir as it\u0027s only called once.\n\nChange-Id: Ifed9c1b52f3e4dead599f21227da1ed07de3ff07\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/579109920055cd4a25c9deba21e23afae061f4f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/579109920055cd4a25c9deba21e23afae061f4f4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}