)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"00616116d9a72f0560f51b39fc8d9ef4d046da3a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After https://review.openstack.org/#/c/72974 nova (somehow?)"},{"line_number":10,"context_line":"uses ssl/cert_file to connect to glance. Analysis of such"},{"line_number":11,"context_line":"behavior reasons is out of scope of this CR."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change fixes configuration parameters according to"},{"line_number":14,"context_line":"current nova behavior."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_df38b63f","line":11,"updated":"2015-02-09 23:02:54.000000000","message":"This indicates we don\u0027t have all the information.  Let\u0027s get the details right before we commit code","commit_id":"31de892b8b8d2859a09ad07b12c9afe1f40a6312"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2330d7a56a9f783700ab8d41e518892db6d74a49","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change fixes configuration parameters according to"},{"line_number":14,"context_line":"current nova behavior."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib78878af37484f3e176c9b5d27d188aa35a79924"},{"line_number":17,"context_line":"Closes-Bug: #1405484"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_c5865665","line":15,"updated":"2015-02-08 22:54:28.000000000","message":"Sorry but this isn\u0027t convincing; especially as I have little context on this\n\nAre you saying nova is broken and this works around it, or this is the correct fix for all time?  I understand we want things to work, and work-around are ok, but I\u0027d like them to be identified as such.","commit_id":"31de892b8b8d2859a09ad07b12c9afe1f40a6312"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"6052ac3067d8637071d95c0b3427ffc1334b16d2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change fixes configuration parameters according to"},{"line_number":14,"context_line":"current nova behavior."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib78878af37484f3e176c9b5d27d188aa35a79924"},{"line_number":17,"context_line":"Closes-Bug: #1405484"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_449f9b5f","line":15,"in_reply_to":"da86d52c_241b871d","updated":"2015-02-09 22:32:12.000000000","message":"BTW, don\u0027t we want to add CI job to test USE_SSL\u003dTrue use case? This could prevent such synchronization issues.","commit_id":"31de892b8b8d2859a09ad07b12c9afe1f40a6312"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"00616116d9a72f0560f51b39fc8d9ef4d046da3a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change fixes configuration parameters according to"},{"line_number":14,"context_line":"current nova behavior."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib78878af37484f3e176c9b5d27d188aa35a79924"},{"line_number":17,"context_line":"Closes-Bug: #1405484"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_7fa18aa8","line":15,"in_reply_to":"da86d52c_241b871d","updated":"2015-02-09 23:02:54.000000000","message":"This is *a* fix, I would agree, but I\u0027d like to be convinced it is correct and change this commit message to a real explaination.  If you don\u0027t have the context probably some nova people should weigh in\n\nAs mentioned in my other comment, to me it looks like the ca_file setup might have just been forgotten should just go with the other bits as a generic","commit_id":"31de892b8b8d2859a09ad07b12c9afe1f40a6312"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"d0b86a88502c9e08b9a2485cb21f2ccfc95a4010","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change fixes configuration parameters according to"},{"line_number":14,"context_line":"current nova behavior."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib78878af37484f3e176c9b5d27d188aa35a79924"},{"line_number":17,"context_line":"Closes-Bug: #1405484"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_ff173943","line":15,"in_reply_to":"da86d52c_7fa18aa8","updated":"2015-02-09 23:09:37.000000000","message":"I agree, input from nova guy would be helpful here. I\u0027ll write email to openstack-dev.","commit_id":"31de892b8b8d2859a09ad07b12c9afe1f40a6312"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"be72f84af4756d5d4515f22ced90784f4fee5e0d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change fixes configuration parameters according to"},{"line_number":14,"context_line":"current nova behavior."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib78878af37484f3e176c9b5d27d188aa35a79924"},{"line_number":17,"context_line":"Closes-Bug: #1405484"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_241b871d","line":15,"in_reply_to":"da86d52c_c5865665","updated":"2015-02-09 22:29:11.000000000","message":"This is correct fix for the current nova behavior with secured glance. I don\u0027t know details about nova plans for clients configuration. For now each client except glance has own configuration section. But glance uses parameters from [ssl] section which also contains settings for nova server SSL configuration. This looks strange for me, but it could be a part of some plan (nova cores approved https://review.openstack.org/#/c/72974 and it was merged).\n\nI expect that devstack is a reflection of the current state of openstack. If user sets USE_SSL\u003dTrue, I expect devstack installing openstack services working with each other. Once behavior of nova changes, devstack should be changed too. For now devstack wasn\u0027t updated after https://review.openstack.org/#/c/72974 and this CR is to address that.","commit_id":"31de892b8b8d2859a09ad07b12c9afe1f40a6312"}],"lib/nova":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"00616116d9a72f0560f51b39fc8d9ef4d046da3a","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        ensure_certificates NOVA"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        iniset $NOVA_CONF DEFAULT ssl_cert_file \"$NOVA_SSL_CERT\""},{"line_number":565,"context_line":"        iniset $NOVA_CONF DEFAULT ssl_key_file \"$NOVA_SSL_KEY\""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        iniset $NOVA_CONF DEFAULT enabled_ssl_apis \"$NOVA_ENABLED_APIS\""},{"line_number":568,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da86d52c_1f9ece54","line":565,"updated":"2015-02-09 23:02:54.000000000","message":"or maybe here?","commit_id":"31de892b8b8d2859a09ad07b12c9afe1f40a6312"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"d0b86a88502c9e08b9a2485cb21f2ccfc95a4010","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        ensure_certificates NOVA"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        iniset $NOVA_CONF DEFAULT ssl_cert_file \"$NOVA_SSL_CERT\""},{"line_number":565,"context_line":"        iniset $NOVA_CONF DEFAULT ssl_key_file \"$NOVA_SSL_KEY\""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        iniset $NOVA_CONF DEFAULT enabled_ssl_apis \"$NOVA_ENABLED_APIS\""},{"line_number":568,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da86d52c_bf6dc206","line":565,"in_reply_to":"da86d52c_1f9ece54","updated":"2015-02-09 23:09:37.000000000","message":"Adding it here will not work for the case when glance is secured, but nova is not.","commit_id":"31de892b8b8d2859a09ad07b12c9afe1f40a6312"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"00616116d9a72f0560f51b39fc8d9ef4d046da3a","unresolved":false,"context_lines":[{"line_number":568,"context_line":"    fi"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":571,"context_line":"        iniset $NOVA_CONF DEFAULT ec2_listen_port $EC2_SERVICE_PORT_INT"},{"line_number":572,"context_line":"    fi"},{"line_number":573,"context_line":"}"},{"line_number":574,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da86d52c_7f8fca23","line":571,"updated":"2015-02-09 23:02:54.000000000","message":"wouldn\u0027t the ca_file setup more generically belong here?","commit_id":"31de892b8b8d2859a09ad07b12c9afe1f40a6312"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"d0b86a88502c9e08b9a2485cb21f2ccfc95a4010","unresolved":false,"context_lines":[{"line_number":568,"context_line":"    fi"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":571,"context_line":"        iniset $NOVA_CONF DEFAULT ec2_listen_port $EC2_SERVICE_PORT_INT"},{"line_number":572,"context_line":"    fi"},{"line_number":573,"context_line":"}"},{"line_number":574,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da86d52c_5f53e638","line":571,"in_reply_to":"da86d52c_7f8fca23","updated":"2015-02-09 23:09:37.000000000","message":"for me, this is also not the right place","commit_id":"31de892b8b8d2859a09ad07b12c9afe1f40a6312"}]}