)]}'
{"functions-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5a7058207cf494753b7fd00c092ce238e680eea1","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"}"},{"line_number":1589,"context_line":""},{"line_number":1590,"context_line":""},{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":"# Plugin Functions"},{"line_number":1593,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1594,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da86d52c_cebc4fbe","line":1591,"updated":"2015-02-10 23:33:16.000000000","message":"not needed","commit_id":"318a933ddc799e65506e976babb9322c2a8b361e"}],"inc/python":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5a7058207cf494753b7fd00c092ce238e680eea1","unresolved":false,"context_lines":[{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# Install python package and get version from global requirements"},{"line_number":99,"context_line":"function pip_install_version_from_global_requirments {"},{"line_number":100,"context_line":"    pip_install `grep -h $@ $REQUIREMENTS_DIR/global-requirements.txt | cut -d\\# -f1`"},{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da86d52c_6ec1a32e","line":99,"updated":"2015-02-10 23:33:16.000000000","message":"spelling (requirments) here\n\nbut this is really a very long function name\n\ni feel like a \"get_from_global_requirements\" function that returns the line would be better, and use it in conjunction with the existing pip_install\n\n pip_install $(get_from_global_requirements foobar)","commit_id":"318a933ddc799e65506e976babb9322c2a8b361e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"68a7b816ed282c1705ffbe575c4678f3289bd588","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# get version from global requirements"},{"line_number":99,"context_line":"function get_from_global_requirements {"},{"line_number":100,"context_line":"    echo grep -h $@ $REQUIREMENTS_DIR/global-requirements.txt | cut -d\\# -f1"},{"line_number":101,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_42f9137f","line":98,"updated":"2015-02-11 00:15:36.000000000","message":"i think make this a bit more robust by just matching $1, document fn (we don\u0027t always do that well) and check we got a result\n\n # get version of a package from global requirements file\n # get_from_global_requirements \u003cpackage\u003e","commit_id":"795173e75cb0352a041ce45124c367e811af9a35"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"68a7b816ed282c1705ffbe575c4678f3289bd588","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# get version from global requirements"},{"line_number":99,"context_line":"function get_from_global_requirements {"},{"line_number":100,"context_line":"    echo grep -h $@ $REQUIREMENTS_DIR/global-requirements.txt | cut -d\\# -f1"},{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# should we use this library from their git repo, or should we let it"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_821dcbc0","line":100,"updated":"2015-02-11 00:15:36.000000000","message":"that\u0027s going to echo the command\n\nmaybe something like\n\n local package\u003d$1\n local required_pkg\u003d$(grep $package ...)\n if [[ required_pkg \u003d\u003d \"\" ]]; then\n   die \"Can\u0027t find package $package in requirements\"\n fi\n echo $required_package\n\nI don\u0027t think we need the -h as it\u0027s only one file","commit_id":"795173e75cb0352a041ce45124c367e811af9a35"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"28959b4778b0af12afbee9f335a315c8914a188b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"# get_from_global_requirements \u003cpackage\u003e"},{"line_number":100,"context_line":"function get_from_global_requirements {"},{"line_number":101,"context_line":"    local package\u003d$1"},{"line_number":102,"context_line":"    local required_pkg\u003d$(grep -h $@ $REQUIREMENTS_DIR/global-requirements.txt | cut -d\\# -f1)"},{"line_number":103,"context_line":"    if [[ required_pkg \u003d\u003d \"\"  ]]; then"},{"line_number":104,"context_line":"        die \"Can\u0027t find package $package in requirements\""},{"line_number":105,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da86d52c_f13701e1","line":102,"updated":"2015-02-12 01:13:37.000000000","message":"${package} rather than $@","commit_id":"44547ef4afb842755acf26c1de64e0d68e30f0b5"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"28959b4778b0af12afbee9f335a315c8914a188b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    local package\u003d$1"},{"line_number":102,"context_line":"    local required_pkg\u003d$(grep -h $@ $REQUIREMENTS_DIR/global-requirements.txt | cut -d\\# -f1)"},{"line_number":103,"context_line":"    if [[ required_pkg \u003d\u003d \"\"  ]]; then"},{"line_number":104,"context_line":"        die \"Can\u0027t find package $package in requirements\""},{"line_number":105,"context_line":"    fi"},{"line_number":106,"context_line":"    echo $required_pkg"},{"line_number":107,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da86d52c_b1590937","line":104,"updated":"2015-02-12 01:13:37.000000000","message":"die $LINENO ...","commit_id":"44547ef4afb842755acf26c1de64e0d68e30f0b5"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8576850f0c8f2b6cd4117edc6b3229f49d4a2ede","unresolved":false,"context_lines":[{"line_number":100,"context_line":"function get_from_global_requirements {"},{"line_number":101,"context_line":"    local package\u003d$1"},{"line_number":102,"context_line":"    local required_pkg\u003d$(grep -h ${package} $REQUIREMENTS_DIR/global-requirements.txt | cut -d\\# -f1)"},{"line_number":103,"context_line":"    if [[ required_pkg \u003d\u003d \"\"  ]]; then"},{"line_number":104,"context_line":"        die $LINENO \"Can\u0027t find package $package in requirements\""},{"line_number":105,"context_line":"    fi"},{"line_number":106,"context_line":"    echo $required_pkg"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da86d52c_38dde7e0","line":103,"updated":"2015-02-12 13:17:41.000000000","message":"you are missing a $, this condition will never be true.","commit_id":"4b98d8d772742176b415bbce6cec48e07c50cff3"}],"lib/horizon":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"68a7b816ed282c1705ffbe575c4678f3289bd588","unresolved":false,"context_lines":[{"line_number":182,"context_line":"# NOTE: It can be moved to common functions, but it is only used by compilation"},{"line_number":183,"context_line":"# of django_openstack_auth catalogs at the moment."},{"line_number":184,"context_line":"function _prepare_message_catalog_compilation {"},{"line_number":185,"context_line":"    pip_install $(get_from_global_requirements babel_package)"},{"line_number":186,"context_line":"}"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_e295a733","line":185,"updated":"2015-02-11 00:15:36.000000000","message":"I think this wants to be \"Babel\"","commit_id":"795173e75cb0352a041ce45124c367e811af9a35"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c8cbbbfca8661312cf020938cc5a6966f80a87d2","unresolved":false,"context_lines":[{"line_number":182,"context_line":"# NOTE: It can be moved to common functions, but it is only used by compilation"},{"line_number":183,"context_line":"# of django_openstack_auth catalogs at the moment."},{"line_number":184,"context_line":"function _prepare_message_catalog_compilation {"},{"line_number":185,"context_line":"    pip_install $(get_from_global_requirements babel_package)"},{"line_number":186,"context_line":"}"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"da86d52c_ffb70783","line":185,"updated":"2015-02-17 19:46:54.000000000","message":"babel_package isn\u0027t a thing, should be \"Babel\"","commit_id":"4efbf446978f1875dba30625cd002e65667958d3"}]}