)]}'
{"lib/tempest":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6f9a55dd38b7310231fc6444882b03c3650d8362","unresolved":false,"context_lines":[{"line_number":73,"context_line":"TEMPEST_DEFAULT_STORAGE_PROTOCOL\u003d\"iSCSI\""},{"line_number":74,"context_line":"TEMPEST_STORAGE_PROTOCOL\u003d${TEMPEST_STORAGE_PROTOCOL:-$TEMPEST_DEFAULT_STORAGE_PROTOCOL}"},{"line_number":75,"context_line":"TEMPEST_DEFAULT_VOLUME_SIZE\u003d1"},{"line_number":76,"context_line":"TEMPEST_VOLUME_VOLUME_SIZE\u003d${TEMPEST_VOLUME_VOLUME_SIZE:-$TEMPEST_DEFAULT_VOLUME_SIZE}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Neutron/Network variables"},{"line_number":79,"context_line":"IPV6_ENABLED\u003d$(trueorfalse True IPV6_ENABLED)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_7759a58d","line":76,"updated":"2015-02-16 21:58:34.000000000","message":"Why do you divide two parameters? It seems that definition of TEMPEST_DEFAULT_VOLUME_SIZE is useless.","commit_id":"1fa995a7555b9b25ec2f04e63cbcabdb3247b533"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e80efa2fbb6c1b4e8251cd42b8e863d78beaf424","unresolved":false,"context_lines":[{"line_number":73,"context_line":"TEMPEST_DEFAULT_STORAGE_PROTOCOL\u003d\"iSCSI\""},{"line_number":74,"context_line":"TEMPEST_STORAGE_PROTOCOL\u003d${TEMPEST_STORAGE_PROTOCOL:-$TEMPEST_DEFAULT_STORAGE_PROTOCOL}"},{"line_number":75,"context_line":"TEMPEST_DEFAULT_VOLUME_SIZE\u003d1"},{"line_number":76,"context_line":"TEMPEST_VOLUME_VOLUME_SIZE\u003d${TEMPEST_VOLUME_VOLUME_SIZE:-$TEMPEST_DEFAULT_VOLUME_SIZE}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Neutron/Network variables"},{"line_number":79,"context_line":"IPV6_ENABLED\u003d$(trueorfalse True IPV6_ENABLED)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_f059048f","line":76,"in_reply_to":"da86d52c_39eb9679","updated":"2015-02-17 15:40:09.000000000","message":"I understand your logic but it seems volume size parameter don\u0027t need the logic. IMO, \"default\" of DRIVER is closely related to VENDOR and PROTOCOL but SIZE is not.","commit_id":"1fa995a7555b9b25ec2f04e63cbcabdb3247b533"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ebc7d01fcd93a131f67a487272436eb4f9936fa8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"TEMPEST_DEFAULT_STORAGE_PROTOCOL\u003d\"iSCSI\""},{"line_number":74,"context_line":"TEMPEST_STORAGE_PROTOCOL\u003d${TEMPEST_STORAGE_PROTOCOL:-$TEMPEST_DEFAULT_STORAGE_PROTOCOL}"},{"line_number":75,"context_line":"TEMPEST_DEFAULT_VOLUME_SIZE\u003d1"},{"line_number":76,"context_line":"TEMPEST_VOLUME_VOLUME_SIZE\u003d${TEMPEST_VOLUME_VOLUME_SIZE:-$TEMPEST_DEFAULT_VOLUME_SIZE}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Neutron/Network variables"},{"line_number":79,"context_line":"IPV6_ENABLED\u003d$(trueorfalse True IPV6_ENABLED)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_39eb9679","line":76,"in_reply_to":"da86d52c_7759a58d","updated":"2015-02-17 09:16:46.000000000","message":"The variable \"TEMPEST_DEFAULT_VOLUME_SIZE\" is used again on line 451 to check if the configuration has to be set. Initially I wanted to use the approach to check if \"TEMPEST_VOLUME_VOLUME_SIZE\" was set or not but then I changed it to be consistent with the other cinder/volume related variables.","commit_id":"1fa995a7555b9b25ec2f04e63cbcabdb3247b533"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"833849e4e98e9edf3850c41252bed728a49d5e40","unresolved":false,"context_lines":[{"line_number":73,"context_line":"TEMPEST_DEFAULT_STORAGE_PROTOCOL\u003d\"iSCSI\""},{"line_number":74,"context_line":"TEMPEST_STORAGE_PROTOCOL\u003d${TEMPEST_STORAGE_PROTOCOL:-$TEMPEST_DEFAULT_STORAGE_PROTOCOL}"},{"line_number":75,"context_line":"TEMPEST_DEFAULT_VOLUME_SIZE\u003d1"},{"line_number":76,"context_line":"TEMPEST_VOLUME_VOLUME_SIZE\u003d${TEMPEST_VOLUME_VOLUME_SIZE:-$TEMPEST_DEFAULT_VOLUME_SIZE}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Neutron/Network variables"},{"line_number":79,"context_line":"IPV6_ENABLED\u003d$(trueorfalse True IPV6_ENABLED)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_678f1776","line":76,"in_reply_to":"da86d52c_f059048f","updated":"2015-02-17 16:10:01.000000000","message":"Ah, okay, I think I see your point now. I\u0027ll upload a new patch set.","commit_id":"1fa995a7555b9b25ec2f04e63cbcabdb3247b533"}]}