)]}'
{"id":"openstack%2Fdevstack~156420","triplet_id":"openstack%2Fdevstack~master~I8e8b40f1d0d1ad7be0f9abf210ab1ea52c7468a3","project":"openstack/devstack","branch":"master","topic":"bug/1422532","hashtags":[],"change_id":"I8e8b40f1d0d1ad7be0f9abf210ab1ea52c7468a3","subject":"Don\u0027t create stack-volume-default in lib/cinder","status":"ABANDONED","created":"2015-02-16 23:57:15.000000000","updated":"2015-02-20 15:34:38.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"da2db84d3301f172465dd32c6153f76a99671a2d","_number":156420,"virtual_id_number":156420,"owner":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2015-02-17 01:03:20.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"date":"2015-02-17 00:13:00.000000000","_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"date":"2015-02-17 16:45:53.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":1,"date":"2015-02-17 01:05:24.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-02-17 20:20:19.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-02-18 21:38:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-17 00:13:00.000000000","updated_by":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"reviewer":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"state":"REVIEWER"},{"updated":"2015-02-17 01:03:20.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-02-17 01:05:24.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-02-17 20:20:19.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"}],"messages":[{"id":"6778eb720b42e2222fecff19ddce38928f139187","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-02-16 23:57:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c741c3ca26314d97ba3cc8c08a276405763842a7","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-02-16 23:58:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"36cf2553daf8de554d6a041fc6045cdefec2b006","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2015-02-17 00:13:00.000000000","message":"Patch Set 2:\n\nWhat is the impact on nova?\n\nIf init_default_lvm_volume_group is no longer the correct thing to do should we update lib/nova to call the correct thing and remove init_default_lvm_volume_group altogether?\n\nnote: I\u0027m happy to make the appropriate nova change.","accounts_in_message":[],"_revision_number":2},{"id":"7c2c6a8928a3bc2e6f4960fadc34b5b21e772c62","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-02-17 01:03:20.000000000","message":"Patch Set 2: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/20/156420/2/9535/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2},{"id":"4575d29ea20aff76dfce3f82aba14063b5e5e18a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-17 01:05:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/20/156420/2/check/check-tempest-dsvm-full/58ddf07/ : SUCCESS in 36m 45s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/20/156420/2/check/check-tempest-dsvm-postgres-full/e706529/ : SUCCESS in 48m 41s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/20/156420/2/check/check-tempest-dsvm-neutron-full/461132b/ : SUCCESS in 1h 06m 42s\n- check-grenade-dsvm http://logs.openstack.org/20/156420/2/check/check-grenade-dsvm/165ddf7/ : SUCCESS in 40m 52s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/20/156420/2/check/gate-tempest-dsvm-large-ops/ea7ed58/ : SUCCESS in 21m 09s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/20/156420/2/check/gate-tempest-dsvm-neutron-large-ops/6ea6e06/ : SUCCESS in 23m 42s\n- gate-devstack-bashate http://logs.openstack.org/20/156420/2/check/gate-devstack-bashate/1f06a67/ : SUCCESS in 16s\n- gate-devstack-unit-tests http://logs.openstack.org/20/156420/2/check/gate-devstack-unit-tests/9e58f3b/ : SUCCESS in 14s\n- check-devstack-dsvm-cells http://logs.openstack.org/20/156420/2/check/check-devstack-dsvm-cells/672da5a/ : SUCCESS in 18m 04s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/20/156420/2/check/check-grenade-dsvm-partial-ncpu/b248738/ : SUCCESS in 41m 16s\n- check-swift-dsvm-functional http://logs.openstack.org/20/156420/2/check/check-swift-dsvm-functional/0686d02/ : SUCCESS in 24m 09s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/20/156420/2/check/check-tempest-dsvm-ironic-pxe_ssh/c86942e/ : SUCCESS in 39m 42s\n- check-devstack-dsvm-updown http://logs.openstack.org/20/156420/2/check/check-devstack-dsvm-updown/a31b717/ : SUCCESS in 15m 34s\n- check-tempest-dsvm-f21 http://logs.openstack.org/20/156420/2/check/check-tempest-dsvm-f21/0b4be60/ : FAILURE in 41m 43s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/20/156420/2/check/check-tempest-dsvm-centos7/dc1e2c1/ : SUCCESS in 52m 27s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/20/156420/2/check/gate-devstack-publish-docs/efe81ce//doc/build/html/ : SUCCESS in 1m 35s","accounts_in_message":[],"_revision_number":2},{"id":"06bf8e35f27c8c0630cceb8167b9ce43b99aa702","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-02-17 16:45:53.000000000","message":"Patch Set 2:\n\n@Tony,\nNot exactly sure what case you have in mind, sure I\u0027m missing something that Nova does here maybe.  \n\nI don\u0027t think there are any projects (Nova included) that use init_default_lvm_volume any longer.  Yes, it\u0027s probably safe to remove it, although it also doesn\u0027t hurt to leave it in place as far as I can tell.","accounts_in_message":[],"_revision_number":2},{"id":"ae19adbe01be299dc8f70af623cb4e66977674c3","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-02-17 20:20:19.000000000","message":"Patch Set 2:\n\n\u003e I don\u0027t think there are any projects (Nova included) that use init_default_lvm_volume any longer\n\nlib/nova has \n\n if [[ \"$NOVA_BACKEND\" \u003d\u003d \"LVM\" ]]; then\n    init_default_lvm_volume_group\n fi\n\nso i\u0027d just like to clarify if this is right or not.  if its not needed, we should remove the whole lot","accounts_in_message":[],"_revision_number":2},{"id":"8ca2e3dc011b1f823aec5a87e1f0ee2f02a817e0","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-02-17 20:20:37.000000000","message":"Patch Set 2: Code-Review-1","accounts_in_message":[],"_revision_number":2},{"id":"498c7240f3612399550d77208d1d80ecda69cfd9","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-02-18 20:54:09.000000000","message":"Patch Set 2:\n\n@Ian\nSuppose that\u0027s fine but quite frankly I don\u0027t know why that should be a part of this patch.  This patch is explicitly to remove the call to the create in cinder setup.  Frankly I don\u0027t care if there\u0027s an unused method left behind, but think it\u0027s fine to pull that out as a separate patch.\n\nIf this is really important for some reason I can amend this change to remove it entirely but personally that doesn\u0027t seem like the right thing.","accounts_in_message":[],"_revision_number":2},{"id":"58a620237ee618f2b480f1589503a47975ccef18","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-02-18 20:56:02.000000000","message":"Patch Set 2:\n\n@Ian,\nOk, prevous comment made no sense.  As you pointed out, YES nova still uses that; so NO it should not be removed entirely.\n\nMy proposed patch is to remove it only from Cinder init which sets a group name based on be_name.  \n\nSorry for any confusion.","accounts_in_message":[],"_revision_number":2},{"id":"ad44ab241a464f003b8e6f2c489ca6db07003c74","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-02-18 21:37:43.000000000","message":"Patch Set 2: Code-Review+2\n\nok, so to further clarify lib/lvm and especially the comments around init_default_lvm_volume_group all talk about cinder \u0026 nova sharing the volume group; comments which I guess are now actually incorrect since cinder is using the be_* volumes.  so while we don\u0027t need to re-write the world, we should just clean up lib/lvm\u0027s comments to reflect the reality","accounts_in_message":[],"_revision_number":2},{"id":"c5cf53c7f35cba2d38061955ec534c8eed5bec74","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-02-18 21:38:27.000000000","message":"Patch Set 2: Code-Review-1\n\nsorry, see above","accounts_in_message":[],"_revision_number":2},{"id":"5b22fa454c938c47e5f5a4bcd40b6837467a4176","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-02-19 02:13:19.000000000","message":"Patch Set 2:\n\n@Ian\nSo turns out Dean had some insight that the \"shared nova/cinder\" add was fairly recent to try and reduce the disk usage on test instances.  Problem is that the way the Cinder lib is right now it actually has the opposite effect and creates a VG that is never used.\n\nThere is work that needs to be done here to clean all of this up and sort it out a bit better, however from the perspective of this change it really is unrelated IMO.  I\u0027m perfectly fine if this doesn\u0027t merge, it doesn\u0027t hurt anything as it is now but it does cause some confusion and is creating a VG that is never used (at least by the gate).","accounts_in_message":[],"_revision_number":2},{"id":"71cc2697fb968f21a5a97d833caca6a2558ad5b1","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-02-20 15:34:38.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1ee7ea3e3bec3c38f80a5e6a83eb65996e16d061","revisions":{"018ecd9d0678422e7f90ea59fcfba34a8b54b20a":{"kind":"REWORK","_number":1,"created":"2015-02-16 23:57:15.000000000","uploader":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"ref":"refs/changes/20/156420/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/20/156420/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/156420/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/156420/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/156420/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/20/156420/1"}}},"commit":{"parents":[{"commit":"9f362d3ab6e73f814b2b4c685a4eab5891fc226f","subject":"Merge \"XenAPI: Move where os-vpx is set\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9f362d3ab6e73f814b2b4c685a4eab5891fc226f"}]}],"author":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2015-02-16 23:53:52.000000000","tz":-420},"committer":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2015-02-16 23:56:31.000000000","tz":-420},"subject":"Don\u0027t create stack-volume-default in lib/cinder","message":"Don\u0027t create stack-volume-default in lib/cinder\n\nIn the past lib/cinder would always call\ninit_default_lvm_volume_group which would use the\n/lib/lvm default VG name of stack-volumes-default.\nWe switched over to using the be_type and be_name\nto create and use stack-volume-lvmdriver-X, but we\nnow have both calls in place.\n\nThe result is that we have two VG\u0027s, one on the loop\ndevice named stack-volumes-default which actually\nisn\u0027t used by the Cinder tests, and another on\n/dev/vdX that\u0027s actually the intended Cinder VG.\n\nTo reiterate, the current gate tests are in fact only\nusing the stack-volumes-lvmdrver-X VG.\n\nCloses-Bug: #1422532\n\nThis may be in order to preserve compat for Grenade tests, but we should probably do something a bit better to keep from having an unused VG in the standard dsvm full run to eliminate some confusion.\n\nChange-Id: I8e8b40f1d0d1ad7be0f9abf210ab1ea52c7468a3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/018ecd9d0678422e7f90ea59fcfba34a8b54b20a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/018ecd9d0678422e7f90ea59fcfba34a8b54b20a"}]},"branch":"refs/heads/master"},"1ee7ea3e3bec3c38f80a5e6a83eb65996e16d061":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-02-16 23:58:34.000000000","uploader":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"ref":"refs/changes/20/156420/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/20/156420/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/156420/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/156420/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/156420/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/20/156420/2"}}},"commit":{"parents":[{"commit":"9f362d3ab6e73f814b2b4c685a4eab5891fc226f","subject":"Merge \"XenAPI: Move where os-vpx is set\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9f362d3ab6e73f814b2b4c685a4eab5891fc226f"}]}],"author":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2015-02-16 23:53:52.000000000","tz":-420},"committer":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2015-02-16 23:57:23.000000000","tz":-420},"subject":"Don\u0027t create stack-volume-default in lib/cinder","message":"Don\u0027t create stack-volume-default in lib/cinder\n\nIn the past lib/cinder would always call\ninit_default_lvm_volume_group which would use the\n/lib/lvm default VG name of stack-volumes-default.\nWe switched over to using the be_type and be_name\nto create and use stack-volume-lvmdriver-X, but we\nnow have both calls in place.\n\nThe result is that we have two VG\u0027s, one on the loop\ndevice named stack-volumes-default which actually\nisn\u0027t used by the Cinder tests, and another on\n/dev/vdX that\u0027s actually the intended Cinder VG.\n\nTo reiterate, the current gate tests are in fact only\nusing the stack-volumes-lvmdrver-X VG.\n\nCloses-Bug: #1422532\n\nChange-Id: I8e8b40f1d0d1ad7be0f9abf210ab1ea52c7468a3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1ee7ea3e3bec3c38f80a5e6a83eb65996e16d061"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1ee7ea3e3bec3c38f80a5e6a83eb65996e16d061"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}