)]}'
{"lib/keystone":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"2bf72873909f84f7d97aa70917b75cb91314063a","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        git_clone_by_name \"keystonemiddleware\""},{"line_number":517,"context_line":"        setup_dev_lib \"keystonemiddleware\""},{"line_number":518,"context_line":"    else"},{"line_number":519,"context_line":"        pip_install keystonemiddleware"},{"line_number":520,"context_line":"    fi"},{"line_number":521,"context_line":"}"},{"line_number":522,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_bde3a5d6","line":519,"updated":"2015-02-18 19:54:10.000000000","message":"why do we need to install keystonemiddleware outside of it getting pulled in as a dependency?","commit_id":"d3e573bd7764da7b4ebc052e6d7a62f9d3f4f55b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"699b48860031ffcd6f7d73043f900e8154363cd1","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        git_clone_by_name \"keystonemiddleware\""},{"line_number":517,"context_line":"        setup_dev_lib \"keystonemiddleware\""},{"line_number":518,"context_line":"    else"},{"line_number":519,"context_line":"        pip_install keystonemiddleware"},{"line_number":520,"context_line":"    fi"},{"line_number":521,"context_line":"}"},{"line_number":522,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_dd6e99ff","line":519,"in_reply_to":"da86d52c_bde3a5d6","updated":"2015-02-18 20:06:45.000000000","message":"This may be left over from an earlier pass and may not be necessary now","commit_id":"d3e573bd7764da7b4ebc052e6d7a62f9d3f4f55b"}],"lib/stack":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"2bf72873909f84f7d97aa70917b75cb91314063a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            export PIP_VIRTUAL_ENV\u003d${PROJECT_VENV[$service]:-}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"            # Install packages not in project requirements files"},{"line_number":25,"context_line":"            ${PROJECT_VENV[$service]}/bin/pip install MySQL-python psycopg2"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"            # Install other OpenStack prereqs that might come from source repos"},{"line_number":28,"context_line":"            install_oslo"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_9d7ee1e2","line":25,"updated":"2015-02-18 19:54:10.000000000","message":"Should we have a DATABASE_DRIVERS list? And enabled databases add their item to the list, then we install here. That also lets us use different mysql drivers depending.","commit_id":"d3e573bd7764da7b4ebc052e6d7a62f9d3f4f55b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"699b48860031ffcd6f7d73043f900e8154363cd1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            export PIP_VIRTUAL_ENV\u003d${PROJECT_VENV[$service]:-}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"            # Install packages not in project requirements files"},{"line_number":25,"context_line":"            ${PROJECT_VENV[$service]}/bin/pip install MySQL-python psycopg2"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"            # Install other OpenStack prereqs that might come from source repos"},{"line_number":28,"context_line":"            install_oslo"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_dd45b96f","line":25,"in_reply_to":"da86d52c_9d7ee1e2","updated":"2015-02-18 20:06:45.000000000","message":"This needs to be sorted yet, yes.  But I also want to ditch the only-one-db-can-be-supprted bits too.  For now we can install them all and let the project use what it wants, I don\u0027t think any of them conflict?","commit_id":"d3e573bd7764da7b4ebc052e6d7a62f9d3f4f55b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"2bf72873909f84f7d97aa70917b75cb91314063a","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"            # Install other OpenStack prereqs that might come from source repos"},{"line_number":28,"context_line":"            install_oslo"},{"line_number":29,"context_line":"            install_keystonemiddleware"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        install_${service}"},{"line_number":32,"context_line":"        if [[ -n ${PROJECT_VENV[$service]:-} ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_bd7f25de","line":29,"updated":"2015-02-18 19:54:10.000000000","message":"so... long term I think we\u0027re going to have to iterate LIBS_FROM_GIT and do installation of the list.\n\nFor this patch, I\u0027m ok with this, but it is kind of fragile.","commit_id":"d3e573bd7764da7b4ebc052e6d7a62f9d3f4f55b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"699b48860031ffcd6f7d73043f900e8154363cd1","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"            # Install other OpenStack prereqs that might come from source repos"},{"line_number":28,"context_line":"            install_oslo"},{"line_number":29,"context_line":"            install_keystonemiddleware"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        install_${service}"},{"line_number":32,"context_line":"        if [[ -n ${PROJECT_VENV[$service]:-} ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da86d52c_d842270e","line":29,"in_reply_to":"da86d52c_bd7f25de","updated":"2015-02-18 20:06:45.000000000","message":"It is fragile.  I wasn\u0027t sure the right thing to do here, it will need to be re-visited","commit_id":"d3e573bd7764da7b4ebc052e6d7a62f9d3f4f55b"}],"stack.sh":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3923fea61dde04006321cccb951992962cf24784","unresolved":false,"context_lines":[{"line_number":757,"context_line":"        install_keystone"},{"line_number":758,"context_line":"        configure_keystone"},{"line_number":759,"context_line":"    fi"},{"line_number":760,"context_line":"    unset PIP_VEIRTUAL_ENV"},{"line_number":761,"context_line":"fi"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"if is_service_enabled s-proxy; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da86d52c_e4ea01d7","line":760,"updated":"2015-02-18 10:24:40.000000000","message":"extra E","commit_id":"a90766019eb5ae0a6654c05bd1f733612d424786"}]}